D27669: [kstyle] Tools area

2020-04-25 Thread Noah Davis
ndavis added a comment. The only remaining problem I can find is this one with certain kinds of menu buttons: F8260819: vokoscreenNG-2020-04-26_00-43-00.mp4 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack,

KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.14 - Build # 25 - Still Failing!

2020-04-25 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/25/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 26 Apr 2020 04:19:33 + Build duration: 1 min 3 sec and counting CONSOLE OUTPUT

D28888: Fix navigation regressions

2020-04-25 Thread Carson Black
cblack updated this revision to Diff 81214. cblack added a comment. Rebase REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2?vs=81132=81214 BRANCH cblack/better-navigation (branched from master) REVISION DETAIL

D28888: Fix navigation regressions

2020-04-25 Thread Noah Davis
ndavis added a comment. This needs to be rebased REPOSITORY R1014 Kirigami Gallery REVISION DETAIL https://phabricator.kde.org/D2 To: cblack, #vdg, #kirigami Cc: mart, ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D28057: Fix/Allow folderview popup mode icon and list icon size

2020-04-25 Thread Alexandre Pereira
pereira.alex added a comment. In D28057#657036 , @ngraham wrote: > Re-reviewing this is on my to-do list. Sorry for the delay! oh no worries, i know you are a busy man :) and really this isn't an important bug. I was just doubtfull if

D29142: Add footer support to systray

2020-04-25 Thread Niccolò Venerandi
niccolove added a comment. Should work now REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29142 To: niccolove, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf,

D29142: Add footer support to systray

2020-04-25 Thread Niccolò Venerandi
niccolove updated this revision to Diff 81184. niccolove added a comment. Set height correctly code and more concise code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29142?vs=81183=81184 BRANCH master REVISION DETAIL

D29142: Add footer support to systray

2020-04-25 Thread Niccolò Venerandi
niccolove updated this revision to Diff 81183. niccolove edited the summary of this revision. niccolove added a comment. Fix bars not disappearing when switching to a component without page REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29140: Fix POTD in lock screen (partly)

2020-04-25 Thread Yunhe Guo
guoyunhe added a comment. Anyway, this patch just focus on fixing the cache issue. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D29140 To: guoyunhe, #plasma Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D12459: [Icon KCM] Port to new design

2020-04-25 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > main.cpp:393 > +for (int i = 0; i < KIconLoader::LastGroup; i++) { > +KIconLoader::emitChange(KIconLoader::Group(i)); > + Is KIconLoader::emitChange also for kde4 apps only? Asking as KIconLoader of KIconThemes seems to have

D29176: [GTK Subpage] Hide Breeze Dark for GTK3

2020-04-25 Thread Mikhail Zolotukhin
This revision was automatically updated to reflect the committed changes. Closed by commit R119:fd6f3bacc91e: [GTK Subpage] Hide Breeze Dark for GTK3 (authored by gikari). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29176?vs=81166=81178 REVISION

D29176: [GTK Subpage] Hide Breeze Dark for GTK3

2020-04-25 Thread Carson Black
cblack added a comment. I'd probably like to introduce a custom "should show theme variant" attribute to theme indexes, but this will be fine for now. REPOSITORY R119 Plasma Desktop BRANCH hide-breeze-gtk-dark (branched from master) REVISION DETAIL https://phabricator.kde.org/D29176

D29176: [GTK Subpage] Hide Breeze Dark for GTK3

2020-04-25 Thread Nathaniel Graham
ngraham added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29176 To: gikari, cblack Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed,

D28057: Fix/Allow folderview popup mode icon and list icon size

2020-04-25 Thread Nathaniel Graham
ngraham added a comment. Re-reviewing this is on my to-do list. Sorry for the delay! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28057 To: pereira.alex, #plasma, #vdg, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D29154: Use QWindow overload of QIcon::pixmap

2020-04-25 Thread Aleix Pol Gonzalez
apol added a comment. Yeah, I guess that phabricator scaled the pictures to take less space. My impression was that the patch improved things. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29154 To: davidre, apol, broulik, ndavis, #breeze, davidedmundson,

D28057: Fix/Allow folderview popup mode icon and list icon size

2020-04-25 Thread Alexandre Pereira
pereira.alex added a comment. @ngraham did I do something wrong ? If i did it was not intentional. I am hoping that at least the bug fix can get included in 5.19. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28057 To: pereira.alex, #plasma, #vdg,

D29176: [GTK Subpage] Hide Breeze Dark for GTK3

2020-04-25 Thread Mikhail Zolotukhin
gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Given, that Breeze GTK grabs its colors from color scheme and Breeze Dark doesn't do that creating by that confusion within the

D29165: [System Monitor] Fix update interval setting

2020-04-25 Thread Konstantinos Smanis
ksmanis updated this revision to Diff 81160. ksmanis added a comment. - Make update interval spinbox locale-aware REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29165?vs=81139=81160 BRANCH master REVISION DETAIL

D29140: Fix POTD in lock screen (partly)

2020-04-25 Thread David Redondo
davidre added a comment. In D29140#656817 , @guoyunhe wrote: > To totally solve the issue, there are several solutions I can find: > > 1. POTD need to have a daemon process that can always access network. The lock screen send request to the

D29154: Use QWindow overload of QIcon::pixmap

2020-04-25 Thread David Redondo
davidre added a comment. Actually everything in the sidebad is very blurry at 2x REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29154 To: davidre, apol, broulik, ndavis, #breeze, davidedmundson, cblack Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D29154: Use QWindow overload of QIcon::pixmap

2020-04-25 Thread David Redondo
davidre added a comment. In D29154#656690 , @apol wrote: > This is what it looks like for me with the patch applied. > > scale 1x: F8258193: Screenshot_20200424_203628.png > scale 2x: F8258201:

D29140: Fix POTD in lock screen (partly)

2020-04-25 Thread Yunhe Guo
guoyunhe added a comment. To totally solve the issue, there are several solutions I can find: 1. POTD need to have a daemon process that can always access network. The lock screen send request to the daemon through DBus or other protocol. 2. Create an invisible lock screen widget in