Re: Information regarding upcoming Gitlab Migration

Hi Olivier, On Mon, Apr 27, 2020 at 10:49:46PM +0200, Olivier Churlaud wrote: > >Because in order to search for something, you need to know it exists. > > > >If you are just casually browsing, then the search can't help you. > > I don't think people casually browse our repos. What use case is

Re: Information regarding upcoming Gitlab Migration

Hi Ingo, On Mon, Apr 27, 2020 at 03:46:13PM +0200, Ingo Klöcker wrote: > > > I'm sorry, but I don't think that this is solved by your proposal for the > > > KDE PIM projects because not everything related to KDE PIM (e.g. relevant > > > frameworks like kcontacts, kholidays, kpeople and soon kdav)

Re: Information regarding upcoming Gitlab Migration

Hi Nate, On Mon, Apr 27, 2020 at 07:45:23AM -0600, Nate Graham wrote: > Trying to categorize everything into a single group cannot succeed because > many projects could logically belong to multiple groups (e.g > plasma-framework is a framework that's a part of Plasma; Discover is an app > that's

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81389. niccolove added a comment. Fix close button not clickable REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81372=81389 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove added inline comments. INLINE COMMENTS > broulik wrote in NotificationItem.qml:125 > Please use one of the `State` below for `inGroup` state I originally did this but I had a problem. It displays and works just as good, but it will throw a "you are using anchors in layouts" error in

D29226: [ksmserver] Use CommandLauncherJob for restoring applications

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > server.cpp:134 > +for ( int i=1; i < n; i++) > + argList.append( command[i]); > +auto *job = new KIO::CommandLauncherJob(app, argList);

D29157: force systemsettings for kcms

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Looks like this also needs to invoke kinfocenter mode when needed. If I search for "energy" from KRunner now, it opens Systemsettings with the home page visible, not the Energy

Re: Information regarding upcoming Gitlab Migration

El dilluns, 27 d’abril de 2020, a les 3:40:01 CEST, Bhushan Shah va escriure: > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > replies] > > Hello Community members, > > In view of upcoming Gitlab migration, we sysadmin team wants to share > the recommended structuring for

Re: Information regarding upcoming Gitlab Migration

Le 27 avril 2020 22:33:12 GMT+02:00, Ben Cooksley a écrit : >On Tue, Apr 28, 2020 at 8:31 AM Albert Astals Cid >wrote: >> >> El dilluns, 27 d’abril de 2020, a les 13:19:07 CEST, Ben Cooksley va >escriure: >> > On Mon, Apr 27, 2020 at 11:12 PM Olivier Churlaud > wrote: >> > > >> > > Hi, >> > >

D29238: Use Standard "Show/Hide Hidden files" shortcuts in directory chooser dialog

ngraham created this revision. ngraham added reviewers: Plasma, Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY New standard shortcuts were added in D28802 and

Re: Information regarding upcoming Gitlab Migration

On Tue, Apr 28, 2020 at 8:31 AM Albert Astals Cid wrote: > > El dilluns, 27 d’abril de 2020, a les 13:19:07 CEST, Ben Cooksley va escriure: > > On Mon, Apr 27, 2020 at 11:12 PM Olivier Churlaud > > wrote: > > > > > > Hi, > > > > > > Le lundi 27 avril 2020, 12:38:42 CEST Aleix Pol a écrit : > >

Re: Information regarding upcoming Gitlab Migration

El dilluns, 27 d’abril de 2020, a les 13:19:07 CEST, Ben Cooksley va escriure: > On Mon, Apr 27, 2020 at 11:12 PM Olivier Churlaud > wrote: > > > > Hi, > > > > Le lundi 27 avril 2020, 12:38:42 CEST Aleix Pol a écrit : > > > On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > > > > > > >

Re: Information regarding upcoming Gitlab Migration

El dilluns, 27 d’abril de 2020, a les 13:58:02 CEST, Bhushan Shah va escriure: > In part I am mostly re-iterating what Ben already mentioned in different > messages. > > On Mon, Apr 27, 2020 at 12:38:42PM +0200, Aleix Pol wrote: > > Does this mean that to clone it we'll have to go "git clone > >

D29234: Fix various bugs introduced with heading

broulik requested changes to this revision. broulik added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > FullRepresentation.qml:454 > elementId: "vertical-line" > -svg:

Re: Information regarding upcoming Gitlab Migration

On Tue, Apr 28, 2020 at 1:46 AM Nate Graham wrote: > > > > On 4/27/20 4:38 AM, Aleix Pol wrote: > > Does this mean that to clone it we'll have to go "git clone > > kde:games/knetwalk" or something along the lines? > > > > If that's the case I'd much prefer if we didn't do this, at the moment > >

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81372. niccolove added a comment. Fix spacing REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81368=81372 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove planned changes to this revision. niccolove added a comment. Ahh, this adds top margin in history. Let me fix. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29234 To: niccolove, #plasma, broulik Cc: ngraham, plasma-devel, Orage, LeGast00n,

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81368. niccolove added a comment. Missing space REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81367=81368 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

ngraham added inline comments. INLINE COMMENTS > NotificationItem.qml:441 > when: notificationItem.inGroup > + > PropertyChanges { unrelated change > NotificationItem.qml:140 > + > +MouseArea{ > +anchors.fill: parent missing space before the curly

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81367. niccolove added a comment. unrelated pt3 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81366=81367 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81366. niccolove added a comment. Unrelated pt2 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81365=81366 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81365. niccolove added a comment. Remove unrelated REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81364=81365 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY This fixes: - Indented notifications line (it's back) - Heading being non-clickable - Buttons not being right-aligned

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.14 - Build # 50 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.14/50/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 27 Apr 2020 15:23:01 + Build duration: 5 min 19 sec and counting CONSOLE OUTPUT [...truncated 3243

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.14 - Build # 57 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.14/57/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 27 Apr 2020 15:23:26 + Build duration: 4 min 12 sec and counting CONSOLE OUTPUT

D29056: [libtaskmanager] add stacking order data for wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c46446e65b98: [libtaskmanager] add stacking order data for wayland (authored by bport). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28744: Rewrite of the global shortcuts kcm

ngraham accepted this revision. ngraham added a comment. UI approved :) REPOSITORY R119 Plasma Desktop BRANCH kcmkeys2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28744 To: davidre, #vdg, #plasma, ngraham Cc: GB_2, broulik, davidedmundson, nicolasfella,

D29224: [Task Manager] Avoid crash with QStringBuilder

apol added a comment. Good catch :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29224 To: broulik, #plasma, fvogt, anthonyfieroni, davidedmundson Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen,

D26111: Runner: make recentdocument use KActivityStats data

broulik added a comment. +1 INLINE COMMENTS > CMakeLists.txt:85 >) > +find_package(KF5ActivitiesStats ${KF5_MIN_VERSION}) > +set_package_properties(KF5ActivitiesStats PROPERTIES DESCRIPTION " querying > of activity history" Do we not have this dep in p-w these days

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol updated this revision to Diff 81343. apol added a comment. Explicitly request zkde_screencast_unstable_v1 REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28884?vs=81115=81343 BRANCH master REVISION DETAIL

Re: Information regarding upcoming Gitlab Migration

On 4/27/20 7:52 AM, Nate Graham wrote: On 4/27/20 7:46 AM, Ingo Klöcker wrote: On Montag, 27. April 2020 14:10:55 CEST Bhushan Shah wrote: This is something which can be easily solved by Gitlab, Gitlab offers a solution where project can be shared with another group. So e.g. sharing

Re: Information regarding upcoming Gitlab Migration

On 4/27/20 7:46 AM, Ingo Klöcker wrote: On Montag, 27. April 2020 14:10:55 CEST Bhushan Shah wrote: This is something which can be easily solved by Gitlab, Gitlab offers a solution where project can be shared with another group. So e.g. sharing kcontacts with kdepim should be possible, then

D26111: Runner: make recentdocument use KActivityStats data

meven added inline comments. INLINE COMMENTS > alex wrote in recentdocuments.cpp:98 > You could use KShell:: tildeCollapse here :-) Indeed, the irony is that I created `KShell::titdeCollapes`, but this diff is older than KF that introduced it... Thanks REPOSITORY R120 Plasma Workspace

Re: Information regarding upcoming Gitlab Migration

On Montag, 27. April 2020 14:10:55 CEST Bhushan Shah wrote: > [adding sysad...@kde.org in CC, please make sure you keep it in CC] > > On Mon, Apr 27, 2020 at 02:03:48PM +0200, Ingo Klöcker wrote: > > On Montag, 27. April 2020 13:19:07 CEST Ben Cooksley wrote: > > > That requires that you know it

D26111: Runner: make recentdocument use KActivityStats data

alex added inline comments. INLINE COMMENTS > recentdocuments.cpp:98 > +QString destUrlString = url.adjusted(QUrl::RemoveFilename).path(); > +if (destUrlString.startsWith(homePath)) { > +destUrlString = QLatin1String("~") + > destUrlString.mid(homePath.length());

Re: Information regarding upcoming Gitlab Migration

On 4/27/20 4:38 AM, Aleix Pol wrote: Does this mean that to clone it we'll have to go "git clone kde:games/knetwalk" or something along the lines? If that's the case I'd much prefer if we didn't do this, at the moment it's already uncomfortable for me to remember the URL for some of the

D26111: Runner: make recentdocument use KActivityStats data

meven added a comment. ping whoever... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26111 To: meven, #plasma, ivan, ngraham, broulik Cc: alex, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen,

D29226: [ksmserver] Use CommandLauncherJob for restoring applications

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Rather than calling into `KLauncher` directly. TEST PLAN Compiles, session restore apps are

D29224: [Task Manager] Avoid crash with QStringBuilder

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0eba5453b9d4: [Task Manager] Avoid crash with QStringBuilder (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29224?vs=81333=81335

Re: Information regarding upcoming Gitlab Migration

In part I am mostly re-iterating what Ben already mentioned in different messages. On Mon, Apr 27, 2020 at 12:38:42PM +0200, Aleix Pol wrote: > Does this mean that to clone it we'll have to go "git clone > kde:games/knetwalk" or something along the lines? Yes [Rest of message is with sysadmin

Re: Information regarding upcoming Gitlab Migration

Le lundi 27 avril 2020, 13:19:07 CEST Ben Cooksley a écrit : > On Mon, Apr 27, 2020 at 11:12 PM Olivier Churlaud > wrote: > > > > Hi, > > > > Le lundi 27 avril 2020, 12:38:42 CEST Aleix Pol a écrit : > > > On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > > > > > > > [Please keep

D29224: [Task Manager] Avoid crash with QStringBuilder

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The lambda returns a `QStringBuilder` which contains dangling references, see also

Re: Information regarding upcoming Gitlab Migration

On Mon, Apr 27, 2020 at 11:12 PM Olivier Churlaud wrote: > > Hi, > > Le lundi 27 avril 2020, 12:38:42 CEST Aleix Pol a écrit : > > On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > > > > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > > > replies] > > > > > > Hello

Re: Information regarding upcoming Gitlab Migration

On Mon, Apr 27, 2020 at 12:55 PM Ben Cooksley wrote: > > On Mon, Apr 27, 2020 at 10:39 PM Aleix Pol wrote: > > > > On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > > > > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > > > replies] > > > > > > Hello Community

Re: Information regarding upcoming Gitlab Migration

Hi, Le lundi 27 avril 2020, 12:38:42 CEST Aleix Pol a écrit : > On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > > replies] > > > > Hello Community members, > > > > In view of upcoming Gitlab migration, we sysadmin

Re: Information regarding upcoming Gitlab Migration

On Mon, Apr 27, 2020 at 10:50 PM Piyush Aggarwal wrote: > > > > On Mon, 27 Apr, 2020, 4:09 pm Aleix Pol, wrote: >> >> On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: >> > >> > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for >> > replies] >> > >> > Hello Community members,

monday meeting notes for 27/04/2020

Bhushan: * Gitlab migration coming! * https://mail.kde.org/pipermail/kde-community/2020q2/006194.html * and that's it I suppose from my side, not much of direct plasma stuff this week Kai Uwe: plasma-browser-integration: * Supports Brave browser now * Technically supports any Chromium but now

Re: Information regarding upcoming Gitlab Migration

On Mon, Apr 27, 2020 at 10:39 PM Aleix Pol wrote: > > On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > > replies] > > > > Hello Community members, > > > > In view of upcoming Gitlab migration, we sysadmin team wants

Re: Information regarding upcoming Gitlab Migration

On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > replies] > > Hello Community members, > > In view of upcoming Gitlab migration, we sysadmin team wants to share > the recommended structuring for the repositories on Gitlab.

D29157: force systemsettings for kcms

mart updated this revision to Diff 81320. mart added a comment. - comments++ REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29157?vs=81116=81320 BRANCH phab/systemsettings REVISION DETAIL https://phabricator.kde.org/D29157 AFFECTED FILES

D29157: force systemsettings for kcms

mart added a comment. In D29157#656640 , @ngraham wrote: > Heh, clever! > > However if System Settings is already open and you use KRunner to open a KCM, it switches focus to that existing System Settings window but doesn't show you the

D29064: Support module commandline paramenter

mart updated this revision to Diff 81319. mart added a comment. - load a new module when a new instance is invoked REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29064?vs=80913=81319 BRANCH phab/startupModule REVISION DETAIL

Re: Information regarding upcoming Gitlab Migration

On Mon, Apr 27, 2020 at 7:26 PM Ilya Bizyaev wrote: > > Hello Bhushan! > > Thank you for you work on the Gitlab migration! > > The lists look good! Here are some ideas that I have, in case you think they > can be considered before we transition: > • The "applications" category is somewhat

D28744: Rewrite of the global shortcuts kcm

davidre updated this revision to Diff 81305. davidre added a comment. rebasae REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=81304=81305 BRANCH kcmkeys2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28744

D28744: Rewrite of the global shortcuts kcm

davidre updated this revision to Diff 81304. davidre added a comment. - Use model.* properties - Use placeholder message - Still don't know why model properties are undefined when switching components REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D29157: force systemsettings for kcms

broulik added a comment. +1 INLINE COMMENTS > servicerunner.cpp:461 > if (actionName.isEmpty()) { > +if (service->serviceTypes().contains(QLatin1String("KCModule"))) { > +service->setExec(QStringLiteral("systemsettings5 ") + > service->desktopEntryName()); A

Re: Type=FSDevice desktop files

Hi, > Would it be OK if we dropped support for desktop files that represent devices? > This was a KDE1/KDE2/KDE3? feature, you'd write/ship a desktop file with Type=FSDevice and Dev=/dev/sdc and this would give you Mount and Unmount in the context menu. I believe macOS to this day

D29214: [Notifications] Fix typo

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ed0a51886150: [Notifications] Fix typo (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29214?vs=81283=81301 REVISION DETAIL

Re: Information regarding upcoming Gitlab Migration

On Mon, Apr 27, 2020 at 6:33 PM Rolf Eike Beer wrote: > > Bhushan Shah wrote: > > > I've worked on draft "move" of the current set of the repositories in > > their respective subgroups at the repo-metadata project's branch [1]. > > You can browse the directory structure to get idea of how final

Re: Information regarding upcoming Gitlab Migration

Bhushan Shah wrote: I've worked on draft "move" of the current set of the repositories in their respective subgroups at the repo-metadata project's branch [1]. You can browse the directory structure to get idea of how final structure on Gitlab would look like. No objection, just a request for