D28744: Rewrite of the global shortcuts kcm

ngraham added a comment. I find that I'm not able to set shortcuts involving the space key. The key sequence get repeated twice in the button and the Apply button ever becomes enabled. Can you reproduce? REPOSITORY R119 Plasma Desktop BRANCH kcmkeys2 (branched from master) REVISION

D27960: Make it possible to scroll through the padding

apol added a comment. @ngraham can you test again? it works well for me (admittedly better than when I first submitted it). Maybe something else got fixed too in the meantime. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27960 To: apol, #kirigami, mart,

D27960: Make it possible to scroll through the padding

apol updated this revision to Diff 81481. apol added a comment. Rebase and improve test REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27960?vs=77323=81481 BRANCH arcpatch-D27960 REVISION DETAIL https://phabricator.kde.org/D27960 AFFECTED FILES

D29150: Address Connections syntax warnings on the systray plasmoid

apol added a comment. Ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29150 To: apol, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed,

D29268: [WIP] Add Date/Time dialog

nicolasfella updated this revision to Diff 81471. nicolasfella added a comment. - fix REPOSITORY R1047 Kirigami Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29268?vs=81470=81471 BRANCH work REVISION DETAIL https://phabricator.kde.org/D29268 AFFECTED FILES

D29268: [WIP] Add Date/Time dialog

nicolasfella created this revision. nicolasfella added reviewers: davidedmundson, vkrause, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Import the date/time picker used in KTrip. It wraps the

D29262: Less segfaulty PageRouterAttached

This revision was automatically updated to reflect the committed changes. Closed by commit R169:e0107f5854dc: Less segfaulty PageRouterAttached (authored by cblack). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29262?vs=81466=81468 REVISION DETAIL

D29262: Less segfaulty PageRouterAttached

cblack updated this revision to Diff 81466. cblack added a comment. Parent climbing REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29262?vs=81449=81466 BRANCH cblack/less-segfaulty-pagerouter (branched from master) REVISION DETAIL

D29264: New tabs for Breeze

abstractdevelop updated this revision to Diff 81461. abstractdevelop marked 2 inline comments as done. abstractdevelop added a comment. Fixed all messages. Sorry for all the emails. :/ REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29264?vs=81460=81461

D29264: New tabs for Breeze

abstractdevelop marked 5 inline comments as done. abstractdevelop added a comment. If we want to do that, then the line will have to go on the bottom. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29264 To: abstractdevelop, #vdg, #breeze Cc: filipf, ngraham, cblack,

D29264: New tabs for Breeze

filipf added a comment. I think we still want to have the edges rounded if it's possible? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29264 To: abstractdevelop, #vdg, #breeze Cc: filipf, ngraham, cblack, plasma-devel, dmenig, manueljlin, Orage, LeGast00n,

D29264: New tabs for Breeze

abstractdevelop updated this revision to Diff 81460. abstractdevelop added a comment. Oof silly me. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29264?vs=81459=81460 REVISION DETAIL https://phabricator.kde.org/D29264 AFFECTED FILES

D29264: New tabs for Breeze

abstractdevelop updated this revision to Diff 81459. abstractdevelop added a comment. Address comments. (Those were just some things I was playing around with, but everybody was right and they weren't necessary) REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE

D29264: New tabs for Breeze

ngraham added inline comments. INLINE COMMENTS > cblack wrote in breezestyle.cpp:5608 > mmm, not sure how I feel about this Yeah we shouldn't be overriding this. `documentMode` is something that the widget itself can have set depending on the context. AFAIK the plan is to use `documentMode`

D29264: New tabs for Breeze

abstractdevelop created this revision. abstractdevelop added reviewers: ngraham, niccolove. abstractdevelop added projects: Breeze, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. abstractdevelop requested review of this revision. REVISION SUMMARY This is a new tab

D29264: New tabs for Breeze

cblack added inline comments. INLINE COMMENTS > breezehelper.cpp:1276 > QRectF frameRect( rect ); > -qreal radius( frameRadius( PenWidth::NoPen, -1 ) ); > +qreal radius( 0 ); //frameRadius( PenWidth::NoPen, -1 ) ); > You should remove code rather than commenting it

D20569: RFC: Use more compact OSD

ngraham added a comment. Yeah, I'm in favor of revisiting this. Sorry I helped kill it with bikeshedding earlier. :( Personally I appreciate the conceptual elegance of re-using the notification pop-ups, and this gains configurability with respect to location on screen, but code-wise

D20569: RFC: Use more compact OSD

achauvel added a comment. Several options were discussed here, and I have a few questions: Do we want to keep the current design? -- I don’t really understand why the OSD has to be so huge, because it contains so few information compared to a

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.14 - Build # 51 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.14/51/ Project: kf5-qt5 SUSEQt5.14 Date of build: Tue, 28 Apr 2020 18:00:27 + Build duration: 26 min and counting JUnit Tests Name: (root) Failed: 0

D29262: Less segfaulty PageRouterAttached

cblack created this revision. cblack added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY - PageRouterAttached will have its router set when the PageRouter creates an object for a route

D29260: Clean up desktop config window size code and set a better default size

ngraham updated this revision to Diff 81446. ngraham added a comment. Restore minimum size, but make it sensible (previous minimum size made the window unusably small) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29260?vs=81445=81446 BRANCH

D29260: Clean up desktop config window size code and set a better default size

ngraham added a comment. Keep in mind that this patch doesn't impose a larger minimum size, just a larger //default// size. Which reminds me, I shouldn't have removed the minimum size. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29260 To: ngraham,

D29260: Clean up desktop config window size code and set a better default size

ngraham added a comment. I don't think it makes sense to make the thumbnails smaller. They're already quite small IMO and I often find myself wishing they were bigger! In the end, a low-resolution screen is always gonna be a low-resolution screen. REPOSITORY R119 Plasma Desktop

D29260: Clean up desktop config window size code and set a better default size

trmdi added a comment. In D29260#659172 , @ngraham wrote: > `GridUnit * 40` works out to be 720 px high with the default 10pt Noto Sans font, which is enough space to not interfere with the default 36px bottom panel. > > But there's no way

D29260: Clean up desktop config window size code and set a better default size

ngraham added a comment. `GridUnit * 40` works out to be 720 px high with the default 10pt Noto Sans font, which is enough space to not interfere with the default 36px bottom panel. But there's no way around the fact that this window greatly benefits from more space. On such a small

D29260: Clean up desktop config window size code and set a better default size

trmdi added a comment. Please keep in mind that not everyone uses a high res screen. 1366x768 is a very popular one, please don't make it too big on those screens. :( REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29260 To: ngraham, #vdg, #plasma Cc: trmdi,

D29260: Clean up desktop config window size code and set a better default size

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The desktop config window's sizing code is currently set in three different places and the

D29203: kirigami.pri: Add missing includes

patrickelectric closed this revision. patrickelectric added a comment. Merged. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29203 To: patrickelectric, apol, mart, cblack, ognarb Cc: ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol,

D20569: RFC: Use more compact OSD

kori added a comment. Why was this abandoned? The arguments in favor of not changing are mostly on a personal level ignoring the complaints that the current big square behaviour affects usability (I went more in detail about this in another comment

D29203: kirigami.pri: Add missing includes

ognarb accepted this revision. ognarb added a comment. +1 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29203 To: patrickelectric, apol, mart, cblack, ognarb Cc: ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra,

D29135: PageRouter: find parents of items better

This revision was automatically updated to reflect the committed changes. Closed by commit R169:9b21a37d44e2: PageRouter: find parents of items better (authored by cblack). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29135?vs=81443=81444 REVISION DETAIL

D29135: PageRouter: find parents of items better

cblack updated this revision to Diff 81443. cblack added a comment. Coding style REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29135?vs=81018=81443 BRANCH cblack/better-router-parent-finding (branched from master) REVISION DETAIL

D29135: PageRouter: find parents of items better

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > pagerouter.cpp:342 > +auto casted = qobject_cast(pointer); > +if (casted != nullptr) return casted; > +pointer = pointer->parent(); as

D14949: Add option for whether to show the volume change OSD

ngraham commandeered this revision. ngraham added a reviewer: anonym. ngraham added a comment. In fact an option to hide the volume OSD was added in 5.19 already. Sadly I think we all forgot about this patch (sorry about that) but at least it's done now. Further visual improvements to

D14949: Add option for whether to show the volume change OSD

kori added a comment. Any news on this OSD behaviour? The default notifications is incredibly obnoxious and it just seems like a horrible design decision to use an icon that covers about 20% of screen width/height and blocks whatever was below it right at the center of the screen, which

D28744: Rewrite of the global shortcuts kcm

davidre updated this revision to Diff 81441. davidre added a comment. - Reinstate the pointingHand mouseAreas - Make delegate automatically expand if it's the only one REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=81435=81441 BRANCH

D26111: Runner: make recentdocument use KActivityStats data

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > CMakeLists.txt:13 > KF5::I18n > +KF5::Activities > +KF5::ActivitiesStats Where's this being used? I only see stats > recentdocuments.cpp:78 > > -

D29156: [kcms/fonts] When adjusting all fonts, keep Small font size smaller

ahmadsamir accepted this revision. ahmadsamir added a comment. This revision is now accepted and ready to land. The change makes sense; but please wait for @bport review too. REPOSITORY R119 Plasma Desktop BRANCH make-small-font-smaller-when-changing-all-font-sizes (branched from master)

D29156: [kcms/fonts] When adjusting all fonts, keep Small font size smaller

ngraham updated this revision to Diff 81438. ngraham marked an inline comment as done. ngraham added a comment. Store it in a variable REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29156?vs=81437=81438 BRANCH

D29156: [kcms/fonts] When adjusting all fonts, keep Small font size smaller

ahmadsamir added inline comments. INLINE COMMENTS > fonts.cpp:271 > +// tiny, they want a tiny font everywhere. > +if (font.pointSize() > 8) { > +smallestFont.setPointSize(font.pointSize() - 2); Nit-pick: I'd store font.pointSize() in a const int, and use that

D29156: [kcms/fonts] When adjusting all fonts, keep Small font size smaller

ngraham updated this revision to Diff 81437. ngraham marked an inline comment as done. ngraham added a comment. Only do it when the general font is 9pt or larger REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29156?vs=81112=81437 BRANCH

D29234: Fix various bugs introduced with heading

broulik added inline comments. INLINE COMMENTS > niccolove wrote in NotificationItem.qml:125 > I originally did this but I had a problem. It displays and works just as > good, but it will throw a "you are using anchors in layouts" error in the > console. Even though I disable the anchors in

D29156: [kcms/fonts] When adjusting all fonts, keep Small font size smaller

ahmadsamir added inline comments. INLINE COMMENTS > fonts.cpp:267 > +QFont smallerSmallestFont = font; > +smallerSmallestFont.setPointSize(font.pointSize() - 2); > + > m_settings->setSmallestReadableFont(applyFontDiff(m_settings->smallestReadableFont(), >

D28941: startplasma: Sort environment scripts prior to sourcing

ngraham added a comment. Thanks for the ping, @cfeck. And thanks for the patch @auxym! May it be the first of many. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28941 To: auxym, #plasma, davidedmundson, apol Cc: ngraham, cfeck, plasma-devel, Orage,

D28941: startplasma: Sort environment scripts prior to sourcing

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ed09a3baf3e0: startplasma: Sort environment scripts prior to sourcing (authored by auxym, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28744: Rewrite of the global shortcuts kcm

davidre updated this revision to Diff 81435. davidre added a comment. - Make the delegate use states REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=81305=81435 BRANCH kcmkeys2 (branched from master) REVISION DETAIL

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.14 - Build # 58 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.14/58/ Project: kf5-qt5 SUSEQt5.14 Date of build: Tue, 28 Apr 2020 13:28:53 + Build duration: 8 min 20 sec and counting BUILD ARTIFACTS

D28926: Signal player gone in "pagehide" not "beforeunload"

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Didn't test myself, but apparently you did, so LGTM. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28926 To: broulik, #plasma, fvogt, ognarb

D28926: Signal player gone in "pagehide" not "beforeunload"

broulik updated this revision to Diff 81430. broulik retitled this revision from "Signal player gone in "unload" not "beforeunload"" to "Signal player gone in "pagehide" not "beforeunload"". broulik edited the summary of this revision. REPOSITORY R856 Plasma Browser Integration CHANGES SINCE

D29154: Use QWindow overload of QIcon::pixmap

davidre added a comment. I did some digging and think that things should be repainted when they change screen https://code.woboq.org/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp.html#_ZN13QWidgetWindow18handleScreenChangeEv REPOSITORY R31 Breeze REVISION DETAIL

Re: Information regarding upcoming Gitlab Migration

Hi Adriaan, On Tue, Apr 28, 2020 at 01:08:33PM +0200, Adriaan de Groot wrote: > A tool-like actor that I don't think has been mentioned so far is "existing > checkouts". I have a src/kde with all the bits I've looked at "recently". > There may even be some SVN checkouts there -- I'm willing to

Re: Information regarding upcoming Gitlab Migration

On Tue, Apr 28, 2020 at 11:09 PM Adriaan de Groot wrote: > > There are a whole bunch of considerations and use-cases being discussed at > once in this thread, and Leinir's post made me think a bit about different > actors can interact with "the collection of repositories". > > One actor is

KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.14 - Build # 26 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/26/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 28 Apr 2020 11:30:08 + Build duration: 1 min 7 sec and counting

D29071: FileChooser portal: add support for opening directories

This revision was automatically updated to reflect the committed changes. Closed by commit R838:976d0c5fade9: FileChooser portal: add support for opening directories (authored by jgrulich). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D29071: FileChooser portal: add support for opening directories

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH filechooser-directory REVISION DETAIL https://phabricator.kde.org/D29071 To: jgrulich, apol,

D29226: [ksmserver] Use CommandLauncherJob for restoring applications

broulik updated this revision to Diff 81419. broulik added a comment. - Simplify - Remove pointless return REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29226?vs=81336=81419 REVISION DETAIL https://phabricator.kde.org/D29226 AFFECTED FILES

D26111: Runner: make recentdocument use KActivityStats data

meven updated this revision to Diff 81413. meven marked 3 inline comments as done. meven added a comment. Clean CMakeLists, use KShell::tildeCollapse, avoid stating in RecentDocuments::actionsForMatch REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28941: startplasma: Sort environment scripts prior to sourcing

cfeck added a comment. It looks like the submitter doesn't have commit rights. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28941 To: auxym, #plasma, davidedmundson, apol Cc: cfeck, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,