D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files.

dkorth added a comment. The original version I wrote a few months back as a quick fix to reduce CPU usage. I do agree that the magic numbers shouldn't be hard-coded, since that's not easily maintained, though I'm not sure of the best approach. constexpr strlen() seems like it'd work, or

D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files.

jpalecek added a comment. In D29808#673157 , @sandsmark wrote: > > It's all C code whereas the rest of the helper is C++. It also relies very heavily on magic numbers now. > > > > > I think a much simpler implementation would be to

D29726: BookmarksRunner: Change caching databases

alex closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29726 To: alex, #plasma, ngraham, meven, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf,

D20569: Use more compact OSD

achauvel added a comment. I’m so happy that it has finally been merged! I wish I could express more often how glad I am of the work being done on KDE, but it would be quite annoying to spam every patch/bug report I care about. ^^ I hope my contribution to the discussion was valuable

D29807: Change Chrome API design

alex updated this revision to Diff 83131. alex added a comment. Use iterator, remove unused include REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29807?vs=83118=83131 BRANCH api_inconsistencies (branched from master) REVISION DETAIL

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 106 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/106/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 23 May 2020 14:41:39 + Build duration: 25 min and counting CONSOLE OUTPUT

D29807: Change Chrome API design

meven accepted this revision as: meven. meven added a comment. This revision is now accepted and ready to land. Two smalls things. Seems good to me otherwise. Give some times to other to have a final say before merging. INLINE COMMENTS > chromeprofile.cpp:33 > +const

D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

kkoma added a comment. In D29798#672261 , @ngraham wrote: > You're probably right. This was a pretty lazy patch. > > The inherent challenge here is that desktop wallpapers are per-containment ("Containment" means a screen or activity), while

D29827: Give users the ability to disable the microphone indicator

meven added a comment. In D29827#673611 , @davidedmundson wrote: > It's an SNI, I thought the systemtray could already filter SNIs in the enties tab of the system tray? Currently it appears in the systray config only when the

D29827: Give users the ability to disable the microphone indicator

davidedmundson added a comment. It's an SNI, I thought the systemtray could already filter SNIs in the enties tab of the system tray? > I made different attempts to achieve this. The class was imagined like a singleton, but it's not really a singleton, anyway it's initialized

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 105 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/105/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 23 May 2020 10:52:03 + Build duration: 4 min 0 sec and counting CONSOLE OUTPUT

D29827: Give users the ability to disable the microphone indicator

meven added a comment. In D29827#673569 , @kurmikon wrote: > In D29827#673551 , @ngraham wrote: > > > The name needs to be your full name ("Firstname Lastname"). This was a pre-existing

D29827: Give users the ability to disable the microphone indicator

kurmikon added a comment. In D29827#673551 , @ngraham wrote: > The name needs to be your full name ("Firstname Lastname"). This was a pre-existing requirement, it's just now enforced before patch submission, rather than afterwards. I

Re: KEmoticons, emoticons kcm

On Saturday, 23 May 2020 02:49:57 CEST Aleix Pol wrote: > I was looking through some Plasma code and I saw that we have some > fairly old emoticons KCM using KF5Emoticons. > > Now while I know why this exists, it feels like it's more of a thing > of the past from when people wrote :) instead of