Re: Old versions of our software in Bugzilla

2022-09-06 Thread Ömer Fadıl USTA
are they using. Also a good Bug reporting tool in KDE Gears with a good GUI will be perfect [ other than drkonqi ] which can help newbie users to bug reporting more comfortable Ömer Fadıl Usta PGP key : 0xfd11561976b1690b about.me/omerusta Nate Graham , 7 Eyl 2022 Çar, 00:41 tarihinde şunu yazdı

Re: Can we remove or quiet down the commit bot in the chatrooms

2021-05-19 Thread Ömer Fadıl USTA
or we can move those bots to some other channels like #xyz-commits (e.g. #plasma-commits ) Ömer Fadıl Usta PGP key : 0xfd11561976b1690b about.me/omerusta Aleix Pol , 20 May 2021 Per, 02:56 tarihinde şunu yazdı: > On Wed, May 19, 2021 at 8:38 PM Nate Graham wrote: > > > > I

D29847: Fixes compile problem for freebsd because of missing crypt.h

2020-06-07 Thread Ömer Fadıl Usta
usta added a comment. In D29847#674807 , @adridg wrote: > https://invent.kde.org/adridg/plasma-desktop/-/tree/normalize-includes > > There's already a CMake-time check for ``, it's just not used. (`HAVE_CRYPT_H`) @adridg having or

D29847: Fixes compile problem for freebsd because of missing crypt.h

2020-06-07 Thread Ömer Fadıl Usta
usta added a comment. or if this is just for linux think we can make it just directly if defined(Q_OS_LINUX) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29847 To: usta, #plasma, bcooksley, ngraham, adridg, #freebsd Cc: tcberner, adridg, plasma-devel,

D29847: Fixes compile problem for freebsd because of missing crypt.h

2020-06-07 Thread Ömer Fadıl Usta
usta updated this revision to Diff 83237. usta added a project: FreeBSD. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29847?vs=83235=83237 REVISION DETAIL https://phabricator.kde.org/D29847 AFFECTED FILES kcms/users/src/user.cpp To: usta,

D29847: Fixes compile problem for freebsd because of missing crypt.h

2020-06-07 Thread Ömer Fadıl Usta
usta added a comment. Sorry i have written one of them twice , so is this aproach wrong ? #if !defined(Q_OS_UNIX) && !defined(Q_OS_BSD4) && !defined(Q_OS_FREEBSD) && !defined(Q_OS_NETBSD) && !defined(Q_OS_OPENBSD) REPOSITORY R119 Plasma Desktop REVISION DETAIL

D29847: Fixes compile problem for freebsd because of missing crypt.h

2020-06-07 Thread Ömer Fadıl Usta
usta added inline comments. INLINE COMMENTS > tcberner wrote in user.cpp:23 > wouldn't it be a bit more portable to check for the header file in cmake? > (OpenBSD also has the same issue, I would assume from [1]) > > [1] >

D29847: Fixes compile problem for freebsd because of missing crypt.h

2020-06-06 Thread Ömer Fadıl Usta
usta created this revision. usta added reviewers: Plasma, bcooksley. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. usta requested review of this revision. REVISION SUMMARY Freebsd compile is not working last 17 days because of missing crypt.h crypt method is in

Re: KDE CI: Administration » Dependency Build Plasma kf5-qt5 SUSEQt5.12 - Build # 95 - Failure!

2020-03-24 Thread Ömer Fadıl USTA
Ben Cooksley , 25 Mar 2020 Çar, 07:48 tarihinde şunu yazdı: > The Dependency Build says plasma-desktop is broken. > > Ideas anyone? > > Hello ben, It looks like this will solve that problem : https://phabricator.kde.org/D28232 Could you apply that patch and try if it fixes the problem? And the

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

2020-03-23 Thread Ömer Fadıl Usta
usta added a comment. Not just include problem but also got a problem about new Qt version : [ 64%] Linking CXX shared module ../../bin/kcm_notifications.so /home/usta/kde/src/plasma-desktop/kcms/spellchecking/spellchecking.cpp: In member function ‘void

D27661: wireguard: Trim IP list before submitting to NM

2020-02-25 Thread Ömer Fadıl Usta
usta added inline comments. INLINE COMMENTS > wireguardpeerwidget.cpp:197 > + > +for (QString : rawIPList) { > +ipList.append(ip.trimmed()); const REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27661 To: hexchain, jgrulich Cc:

D27611: Invert logic of shouldShowMountPoint -> ignoreMountPoint

2020-02-23 Thread Ömer Fadıl Usta
usta added a comment. 2 Question : 1- isnt that method should be const'ified ? 2- also its name will be much better isIgnoreableMountPoint (or something can be more understandable that it will just return true or false ) becase right now it looks like "ignore that mount point"

D27412: Port away from deprecated API on Qt 5.15.0

2020-02-14 Thread Ömer Fadıl Usta
usta added a comment. isnt this also needs #include REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D27412 To: apol, #frameworks, davidedmundson, sitter Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

Re: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 SUSEQt5.12 - Build # 46 - Still Failing!

2019-08-10 Thread Ömer Fadıl USTA
https://phabricator.kde.org/D22976 On Fri, Aug 9, 2019, 23:21 Ben Cooksley wrote: > Hi folks, > > Could someone please look into the below QMutex include problem within > plasma-workspace? > > Thanks, > Ben > > -- Forwarded message - > From: CI System > Date: Sat, Aug 10, 2019

D22976: Fix compilation

2019-08-10 Thread Ömer Fadıl Usta
usta added a comment. In D22976#509675 , @aacid wrote: > And what are you or ben waiting for? You've both got commit access :) @aacid: ;) in here we are in sacrifice feast , and i dont have my laptop with me ( sorry about that )

D22976: Fix compilation

2019-08-09 Thread Ömer Fadıl Usta
usta added a comment. ben mentioned that this also needs to be cherrypicked to stable branch too. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22976 To: ngraham, #plasma, aacid Cc: usta, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen,

[Differential] [Commented On] D3046: Pass color scheme hint to Wayland compositor using window property

2016-10-16 Thread Ömer Fadıl Usta
usta added inline comments. INLINE COMMENTS > graesslin wrote in kwaylandintegration.cpp:57 > this is completely unrelated code not touched in this change. #include removed and #include https://phabricator.kde.org/D3046 EMAIL PREFERENCES

[Differential] [Commented On] D3046: Pass color scheme hint to Wayland compositor using window property

2016-10-16 Thread Ömer Fadıl Usta
usta added a comment. In line 57 QCoreApplication -> QGuiApplication INLINE COMMENTS > kwaylandintegration.cpp:57 > qputenv("QT_WAYLAND_DISABLE_WINDOWDECORATION", "1"); > QCoreApplication::instance()->installEventFilter(this); > }

Re: [kde-promo] Plasma 5.1.1 announcement

2014-11-25 Thread Ömer Fadıl USTA
Link has a typo. Plasma 5.1 http://kde.org/announcements/plasma5.1/index.php link is showing to : http://kde.org/announcements/plasma5.1/index.php on the other hand it must be : http://kde.org/announcements/plasma-5.1/index.php (The - is missing between plasma and 5.1 ) [image: Ömer Fadıl Usta

Re: Baloo - Not Indexing everything by default

2014-10-16 Thread Ömer Fadıl USTA
Couldnt we add a .baloo file to specify for attributes for current directory, file or subdirectories about not indexing ? For example of a .baloo file skip_all skip_if_greater 1m skip_if_smaller 50k skip_ext txt jpg With --subdirs flag like Skip_ext --subdirs txt jpg Skip_all --subdirs On Oct 16,

Re: Review Request 119352: missing fclose - Resource leaking

2014-07-21 Thread Ömer Fadıl Usta
--- Thanks, Ömer Fadıl Usta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119352: missing fclose - Resource leaking

2014-07-18 Thread Ömer Fadıl Usta
--- config resource already opened but forgotten to close Diffs - startkde/kstartupconfig/kstartupconfig.cpp f0b902a Diff: https://git.reviewboard.kde.org/r/119352/diff/ Testing --- Thanks, Ömer Fadıl Usta ___ Plasma-devel mailing

Re: Review Request 118351: [klipper] Port from KDialog to QDialog

2014-05-27 Thread Ömer Fadıl Usta
/#comment40781 is this a forgotten KDialog or on purpose ? - Ömer Fadıl Usta On May 27, 2014, 7:48 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: [kde-artists] New start sound - Discussion.

2013-05-31 Thread Ömer Fadıl USTA
I might be not so active about active development, I believe it is nice to hear a login notification sound. But i also accept there will be some problems while it is logging in process. my idea is adding these sounds to kdm so before starting login process we can use our sound effects then start