Re: Review Request 111553: Fix for the Revision 2f4ab1e6 and Subtitle feature extension in PMC to .sub file format as well.

2014-08-03 Thread Akshay Ratan
:) However, please test it once as still on my system , when a .sub subtitle should play , following is the debug console error output :: (plasma-mediacenter:12999): GStreamer-CRITICAL **: gst_pad_link_full: assertion `GST_IS_PAD (sinkpad)' failed .srt subtitle plays fine :) Thanks, Akshay

Re: Review Request 111770: Implemented search feature in Local Browsing.

2014-08-03 Thread Akshay Ratan
correctly. - Akshay --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111770/#review39798 --- On Sept. 10, 2013, 7:31 p.m., Akshay Ratan

Re: Review Request 111770: Implemented search feature in Local Browsing.

2014-07-30 Thread Akshay Ratan
://wstaw.org/m/2013/09/11/snapshot1.png (when searched for videos)http://wstaw.org/m/2013/09/11/snapshot2.png (when clicked on filterd search i.e on videos) Status? - Sinny On September 10th, 2013, 7:31 p.m. UTC, Akshay Ratan wrote: Review request for Plasma, Shantanu Tushar, Sinny Kumari

Re: cmake does not work

2014-07-10 Thread Akshay Ratan
Hello Devanshu, You followed the PMC build instructions from here : http://sinny.in/node/25 ? Let us know if you still need help in building the source code after following Sinny's blog post. Cheers, Akshay Ratan On Thu, Jul 10, 2014 at 12:34 PM, Devanshu Jain devanshu.jain...@gmail.com

Re: Ideas Critical to PMC

2014-02-25 Thread Akshay Ratan
some background which is very bright or something, our Plasma White coloured font, time stamp at bottom, and other texture features would not look nice. Shantanu and Sinny, whats your opinion regarding this ? Regards, Akshay Ratan On Tue, Feb 25, 2014 at 12:07 AM, R.Harish Navnit harishnav

Re: [PMC] Review of major refactoring around All Music mode

2013-09-28 Thread Akshay Ratan
Hi Shantanu, Great work! I will test out the branch soon and would let you know if I find something :) Cheers, Akshay On Sat, Sep 28, 2013 at 5:24 PM, Shantanu Tushar Jha shaan...@gmail.comwrote: Hey, Thanks for testing, really appreciate that. Also, unless somebody has any objection, I

Re: Getting started wiki for Plasma Media Center (PMC)

2013-09-18 Thread Akshay Ratan
Great work Sinny :) On Wed, Sep 18, 2013 at 8:50 PM, Shantanu Tushar Jha shaan...@gmail.comwrote: Awesome job, really appreciate it :) I made edits wherever I could fix small things, however the Building source section seems redundant, can't we just point people to read the instructions from

Re: Review Request 111863: Feature: Folder Preview in Local Pictures Browsing

2013-09-11 Thread Akshay Ratan
/localvideos/localvideothumbnailprovider.h d485b11 browsingbackends/localfiles/localvideos/localvideothumbnailprovider.cpp d666ac4 Diff: http://git.reviewboard.kde.org/r/111863/diff/ Testing --- Yes. Works fine. Thanks, Akshay Ratan ___ Plasma

Re: Review Request 111770: Implemented search feature in Local Browsing.

2013-09-10 Thread Akshay Ratan
/localfiles/localfilesabstractmodel.cpp ebfc602 mediaelements/mediabrowser/MediaBrowser.qml 6ae777f Diff: http://git.reviewboard.kde.org/r/111770/diff/ Testing --- Works as intended. Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel

Re: Review Request 111863: Feature: Folder Preview in Local Pictures Browsing

2013-08-08 Thread Akshay Ratan
--- Yes. Works fine. Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 111863: Feature: Folder Preview in Local Pictures Browsing

2013-08-08 Thread Akshay Ratan
/localfiles/localvideos/localvideothumbnailprovider.cpp d666ac4 Diff: http://git.reviewboard.kde.org/r/111863/diff/ Testing --- Yes. Works fine. Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Review Request 111863: Feature: Folder Preview in Local Pictures Browsing

2013-08-03 Thread Akshay Ratan
fine. Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 111801: Minor fix in Local Browsing Search

2013-07-30 Thread Akshay Ratan
of your commit earlier in mediaBrowser and please check if the issue you pointed earlier gets solved. Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 111770: Implemented search feature in Local Browsing.

2013-07-30 Thread Akshay Ratan
as intended. Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 111770: Implemented search feature in Local Browsing.

2013-07-28 Thread Akshay Ratan
browsingbackends/localfiles/localfilesabstractmodel.h 43f50b7 browsingbackends/localfiles/localfilesabstractmodel.cpp ebfc602 Diff: http://git.reviewboard.kde.org/r/111770/diff/ Testing --- Works as intended. Thanks, Akshay Ratan ___ Plasma-devel

QML Video Element Error Query

2013-07-23 Thread Akshay Ratan
/* It would be great if anybody could suggest something regarding this problem of QML Video Element in my code . Please suggest me a way as to how can I successfully get the frame Rate value from Video Element of QML. Best Regards, *Akshay Ratan* * * GSoC 2013 Student, KDE

Review Request 111614: Fix Key Navigation in Plasma Media Center

2013-07-20 Thread Akshay Ratan
: http://git.reviewboard.kde.org/r/111614/diff/ Testing --- The key navigation does not break now. Sinny : Please check once if the changes you intended from that patch are there. Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel

Review Request 111553: Fix for the Revision 2f4ab1e6 and Subtitle feature extension in PMC to .sub file format as well.

2013-07-17 Thread Akshay Ratan
error output :: (plasma-mediacenter:12999): GStreamer-CRITICAL **: gst_pad_link_full: assertion `GST_IS_PAD (sinkpad)' failed .srt subtitle plays fine :) Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Review Request 111553: Fix for the Revision 2f4ab1e6 and Subtitle feature extension in PMC to .sub file format as well.

2013-07-17 Thread Akshay Ratan
play , following is the debug console error output :: (plasma-mediacenter:12999): GStreamer-CRITICAL **: gst_pad_link_full: assertion `GST_IS_PAD (sinkpad)' failed .srt subtitle plays fine :) Thanks, Akshay Ratan ___ Plasma-devel mailing list

Re: Review Request 111337: Enhancements and optimization in navigation flow of Plasma Media Center

2013-07-03 Thread Akshay Ratan
all works as intended and NO application crashes were experienced. Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 111337: Enhancements and optimization in navigation flow of Plasma Media Center

2013-07-03 Thread Akshay Ratan
experienced. Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 111337: Enhancements and optimization in navigation flow of Plasma Media Center

2013-07-03 Thread Akshay Ratan
to BAR. 4) Now try pressing ESCAPE/BACK, ideally PLACES MODEL Screen should be shown , but you will notice, you have to press 2 escape/back keys to go there. Rest all works as intended and NO application crashes were experienced. Thanks, Akshay Ratan

Re: Review Request 111337: Enhancements and optimization in navigation flow of Plasma Media Center

2013-07-02 Thread Akshay Ratan
and NO application crashes were experienced. Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 111337: Enhancements and optimization in navigation flow of Plasma Media Center

2013-07-01 Thread Akshay Ratan
ESCAPE/BACK, ideally PLACES MODEL Screen should be shown , but you will notice, you have to press 2 escape/back keys to go there. Rest all works as intended and NO application crashes were experienced. Thanks, Akshay Ratan ___ Plasma-devel mailing

Re: Review Request 111337: Enhancements and optimization in navigation flow of Plasma Media Center

2013-07-01 Thread Akshay Ratan
be shown , but you will notice, you have to press 2 escape/back keys to go there. Rest all works as intended and NO application crashes were experienced. Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Review Request 111287: Fix of an issue in Escape Key functioning

2013-06-28 Thread Akshay Ratan
. Application does not crash now in the scenario mentioned :) Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 111263: Revamping the filesystem browser in the plasma-mediacenter

2013-06-27 Thread Akshay Ratan
, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 111263: Revamping the filesystem browser in the plasma-mediacenter

2013-06-27 Thread Akshay Ratan
be certain issues regarding the correct folder contents shown inside any folder in any particular directory. Further malformed url might appear on clicking certain drives. However this can be fixed later :) Thanks, Akshay Ratan ___ Plasma-devel

Review Request 111263: Revamping the filesystem browser in the plasma-mediacenter

2013-06-26 Thread Akshay Ratan
appear on clicking certain drives. However this can be fixed later :) Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 111263: Revamping the filesystem browser in the plasma-mediacenter

2013-06-26 Thread Akshay Ratan
fine , but there might be certain issues regarding the correct folder contents shown inside any folder in any particular directory. Further malformed url might appear on clicking certain drives. However this can be fixed later :) Thanks, Akshay Ratan

Re: Review Request 111187: Implement UI navigation using PageStack

2013-06-23 Thread Akshay Ratan
click thus will work to go back to the slideshow from the homescreen. - Akshay Ratan On June 23, 2013, 6:16 a.m., Shantanu Tushar wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r

Re: Review Request 111047: Handle edge cases when going back/escape

2013-06-16 Thread Akshay Ratan
. - Akshay Ratan On June 16, 2013, 7:36 a.m., Shantanu Tushar wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111047

Re: Review Request 111047: Handle edge cases when going back/escape

2013-06-16 Thread Akshay Ratan
takes us back to the PMC homescreen. There seems no way to go back one level now, in case someone just want to Browse folders. - Akshay Ratan On June 16, 2013, 2:33 p.m., Shantanu Tushar wrote: --- This is an automatically generated e

Re: Review Request 111017: Fix:Playlist Entries swap

2013-06-15 Thread Akshay Ratan
://git.reviewboard.kde.org/r/111017/diff/ Testing --- Yes Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110856: A minor fix to make the Back button on the Media Controller of the PMC work when the user clicks on the empty homescreen space to open up the slideshow again.

2013-06-15 Thread Akshay Ratan
with the back button on the controller. Nothing happened on clicking it. Diffs - shells/newshell/package/contents/ui/mediacenter.qml 9792607 Diff: http://git.reviewboard.kde.org/r/110856/diff/ Testing --- Yes Thanks, Akshay Ratan

Review Request 111017: Fix:Playlist Entries swap

2013-06-14 Thread Akshay Ratan
as the case should be with a media application. Besides, 2 lines have be removed as they were not really important. Diffs - mediaelements/playlist/PlaylistDelegate.qml a2b4fae Diff: http://git.reviewboard.kde.org/r/111017/diff/ Testing --- Yes Thanks, Akshay Ratan

Review Request 111006: Escape Key fix in the media player

2013-06-13 Thread Akshay Ratan
this ensuring Escape Key works as required in the media player. Diffs - shells/newshell/package/contents/ui/mediacenter.qml d56344d Diff: http://git.reviewboard.kde.org/r/111006/diff/ Testing --- Works as intended. Thanks, Akshay Ratan

Re: Review Request 110629: Feature: Dimming the image when it is not viewed directly

2013-06-12 Thread Akshay Ratan
. Diffs (updated) - shells/newshell/package/contents/ui/mediacenter.qml 1c6a3ed Diff: http://git.reviewboard.kde.org/r/110629/diff/ Testing --- Works as intended. Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 110776: Bug 317451 Fix : A way to return to media from main screen

2013-06-06 Thread Akshay Ratan
check for the Escape key navigation to see if it does not break the keyboard navigation flow somewhere. Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110856: A minor fix to make the Back button on the Media Controller of the PMC work when the user clicks on the empty homescreen space to open up the slideshow again.

2013-06-06 Thread Akshay Ratan
happened on clicking it. Diffs - shells/newshell/package/contents/ui/mediacenter.qml 9792607 Diff: http://git.reviewboard.kde.org/r/110856/diff/ Testing --- Yes Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 110776: Bug 317451 Fix : A way to return to media from main screen

2013-06-03 Thread Akshay Ratan
://git.reviewboard.kde.org/r/110776/diff/ Testing --- Yes, works as intended. Please check for the Escape key navigation to see if it does not break the keyboard navigation flow somewhere. Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 110776: Bug 317451 Fix : A way to return to media from main screen

2013-06-02 Thread Akshay Ratan
check for the Escape key navigation to see if it does not break the keyboard navigation flow somewhere. Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110776: Bug 317451 Fix : A way to return to media from main screen

2013-06-02 Thread Akshay Ratan
/mediacenter.qml b4a659a Diff: http://git.reviewboard.kde.org/r/110776/diff/ Testing --- Yes, works as intended. Please check for the Escape key navigation to see if it does not break the keyboard navigation flow somewhere. Thanks, Akshay Ratan

Re: Review Request 110776: Bug 317451 Fix : A way to return to media from main screen

2013-06-02 Thread Akshay Ratan
/#review33583 --- On June 2, 2013, 4:50 p.m., Akshay Ratan wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110776

Review Request 110776: Bug 317451 Fix : A way to return to media from main screen

2013-06-01 Thread Akshay Ratan
somewhere. Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

GSoC 2013 : Improvements and Enhancements for Plasma Media Center

2013-05-29 Thread Akshay Ratan
with a KDE Planet blog :) Looking forward for a codeful summer ! :) Thanks and Cheers, *Akshay Ratan* IRC: akshay_r , #kde-in , #kde-devel, #plasma , #kde-soc www.akshaycode.blogspot.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Review Request 110628: Feature: Press Escape Key to navigate back one level while viewing pictures in the slideshow in the Image Viewer of the Plasma Media Center.

2013-05-24 Thread Akshay Ratan
://git.reviewboard.kde.org/r/110628/diff/ Testing --- Testing Done: works as intended Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 110629: Feature: Dimming the image when it is not viewed directly

2013-05-24 Thread Akshay Ratan
--- Works as intended. Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110628: Feature: Press Escape Key to navigate back one level while viewing pictures in the slideshow in the Image Viewer of the Plasma Media Center.

2013-05-24 Thread Akshay Ratan
! Diffs - shells/newshell/package/contents/ui/mediacenter.qml ef71938 Diff: http://git.reviewboard.kde.org/r/110628/diff/ Testing --- Testing Done: works as intended Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 110488: Feature Request: Enter Key support to Login in Picasa in Plasma Media Center

2013-05-23 Thread Akshay Ratan
://git.reviewboard.kde.org/r/110488/diff/ Testing --- Yes. It works as intended. Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 110488: Feature Request: Enter Key support to Login in Picasa in Plasma Media Center

2013-05-18 Thread Akshay Ratan
, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110488: Feature Request: Enter Key support to Login in Picasa in Plasma Media Center

2013-05-18 Thread Akshay Ratan
://git.reviewboard.kde.org/r/110488/diff/ Testing --- Yes. It works as intended. Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 110512: Feature Review Request: Tab Control in Picasa Backend Login in Plasma Media Center.

2013-05-18 Thread Akshay Ratan
by the patch. Diffs - browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml 7ef9531 Diff: http://git.reviewboard.kde.org/r/110512/diff/ Testing --- Yes . Works as intended. Thanks, Akshay Ratan ___ Plasma-devel

Re: Review Request 110512: Feature Review Request: Tab Control in Picasa Backend Login in Plasma Media Center.

2013-05-18 Thread Akshay Ratan
to the UserID space as intended by the patch. Diffs - browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml 7ef9531 Diff: http://git.reviewboard.kde.org/r/110512/diff/ Testing --- Yes . Works as intended. Thanks, Akshay Ratan

Re: Review Request 110475: Fixed::Bug 319626 - Can't remove an another song from playlist without stopping the current media.

2013-05-17 Thread Akshay Ratan
Diffs - mediaelements/playlist/PlaylistDelegate.qml 449a0aa Diff: http://git.reviewboard.kde.org/r/110475/diff/ Testing --- Yes Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Review Request 110475: Fixed::Bug 319626 - Can't remove an another song from playlist without stopping the current media.

2013-05-16 Thread Akshay Ratan
://git.reviewboard.kde.org/r/110475/diff/ Testing --- Yes Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110475: Fixed::Bug 319626 - Can't remove an another song from playlist without stopping the current media.

2013-05-16 Thread Akshay Ratan
? Cheers, Akshay Ratan On Thu, May 16, 2013 at 10:45 PM, Shantanu Tushar shant...@kde.org wrote: This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110475/ Ship it! Looks good. Should I commit this for you? mediaelements/playlist

Re: Patch Review

2013-05-15 Thread Akshay Ratan
removing/deleting any other item in the playlist of the mediaplayer. Cheers, Akshay Ratan On Mon, May 13, 2013 at 11:58 PM, Akshay Ratan akshayra...@gmail.comwrote: Hi, Thanks for the review . I am sorry, i didnt really ask before implementing the tooltip, I believe I should have done

Re: [KDE] New public review on Improvements and enhancements for Plasma Media Center (Akshay Ratan)

2013-04-27 Thread Akshay Ratan
response :) Cheers *Akshay Ratan* (akshay_r #plasma #kde-in ) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: GSOC Project Proposal Draft :: Improvement and Enhancements for Plasma Media Center

2013-04-18 Thread Akshay Ratan
it if it concerns the project implementation plan so that I can understand the community ideas also better. What further changes do you suggest in the proposal ? Thanks in advance ! Cheers, Akshay Ratan On Wed, Apr 17, 2013 at 11:58 PM, Sinny Kumari ksi...@gmail.com wrote: Overall, draft proposal looks

Re: GSOC Project Proposal Draft :: Improvement and Enhancements for Plasma Media Center

2013-04-14 Thread Akshay Ratan
than that, please advice me as to how should I exactly frame every detail in my proposal for best results ? Any other suggestion would be more than welcome :) Best Regards, Akshay Ratan (IRC :: akshay_r) On Fri, Apr 12, 2013 at 11:28 PM, Sinny Kumari ksi...@gmail.com wrote: Doing CC to plasma