D17438: [folder] Initialise LabelGenerator::m_labelMode

apol added a comment. In D17438#373627 , @davidedmundson wrote: > That patch needs backporting to stable. > > I'll do that now. ^^' thanks REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17438 To: da

D17375: Don't automatically refresh if the user already asked apt to do so

apol abandoned this revision. apol added a comment. It's landed, phabricator doesn't let me just close it. https://commits.kde.org/discover/30de60f05d183e185724e614aad67b06aec987f3 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17375 To: apol, #kub

D17375: Don't automatically refresh if the user already asked apt to do so

apol added a comment. This is apt-specific code, so if apt distros are happy with it, then it's as good as it gets. It could make sense to do the same for other distros, but that's a different battle. I'll land on 5.14. REPOSITORY R134 Discover Software Store REVISION DETAIL http

D17375: Don't automatically refresh if the user already asked apt to do so

apol created this revision. apol added reviewers: Kubuntu, sitter, rikmills. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Just expect apt to do the right thing. BUG: 401810 REPOSITORY R134 Discover Softw

D17268: Fix warning

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY .../kirigami.2/templates/AbstractApplicationHeader.qml:113: TypeError: Cannot read property 'globalToo

D17263: DelegateRecycler: Don't create a new propertiesTracker for every delegate

apol closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D17263 To: apol, #kirigami, mart Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17263: DelegateRecycler: Don't create a new propertiesTracker for every delegate

apol updated this revision to Diff 46572. apol added a comment. Clean after destruction REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17263?vs=46571&id=46572 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17263 AFFECTED FILES src/dele

D17263: DelegateRecycler: Don't create a new propertiesTracker for every delegate

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It should make setSourceComponent a bit lighter REPOSITORY R169 Kirigami BRANCH master REVISION

D17177: Drop tab-based UI for the about page

This revision was automatically updated to reflect the committed changes. Closed by commit R134:50c69c2c069f: Drop tab-based UI for the about page (authored by apol). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17177?vs=46479&id=46480 REVIS

D17177: Drop tab-based UI for the about page

apol updated this revision to Diff 46479. apol added a comment. Adopt the AboutPage upstream in Kirigami REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17177?vs=46390&id=46479 BRANCH master REVISION DETAIL https://phabricator.kde.org/D

D17216: Move the about page from Discover to Kirigami

apol closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D17216 To: apol, #kirigami, mart, broulik Cc: leinir, nicolasfella, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17216: Move the about page from Discover to Kirigami

apol updated this revision to Diff 46476. apol added a comment. gravatar-- REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17216?vs=46417&id=46476 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17216 AFFECTED FILES kirigami.qrc src/co

D17216: Move the about page from Discover to Kirigami

apol updated this revision to Diff 46417. apol added a comment. ADd since REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17216?vs=46416&id=46417 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17216 AFFECTED FILES kirigami.qrc src/con

D17216: Move the about page from Discover to Kirigami

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > broulik wrote in AboutPage.qml:102 > Not a huge fan of this, privacy-wise, also QtQuick doesn't do any caching on > its own I do agree it can read a bit weird. It's generally done on public emails though, I'm n

D17216: Move the about page from Discover to Kirigami

apol updated this revision to Diff 46416. apol marked 5 inline comments as done. apol added a comment. Address Kai's comments REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17216?vs=46406&id=46416 BRANCH master REVISION DETAIL https://phabricator.kde

D17216: Move the about page from Discover to Kirigami

apol created this revision. apol added reviewers: Kirigami, mart, broulik. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Includes the AboutPage we're using in Discover for other Kirigami projects to use. It

D17177: Drop tab-based UI for the about page

apol added a comment. Yes, yes, on it... REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D17177 To: apol, #plasma, #vdg, leinir Cc: broulik, leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D17211: Port applet/containment configs to qqc2

apol added a comment. +1 cool! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17211 To: mart, #plasma, #vdg, broulik Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D17177: Drop tab-based UI for the about page

apol updated this revision to Diff 46390. apol added a comment. Move report action back to the contextual actions REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17177?vs=46328&id=46390 BRANCH master REVISION DETAIL https://phabricator.

D17177: Drop tab-based UI for the about page

apol added a comment. In D17177#366890 , @ngraham wrote: > Looks fantastic! > > Could we put the bug report button on the toolbar, maybe? It looks a bit odd just sitting in the content view like that. It was on the last version. I cou

D17177: Drop tab-based UI for the about page

apol added a comment. F6443951: discover-about4.png REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17177 To: apol, #plasma, #vdg, leinir Cc: leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesl

D17177: Drop tab-based UI for the about page

apol updated this revision to Diff 46328. apol added a comment. Remove the bug reporting weirdness REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17177?vs=46324&id=46328 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17177

D17177: Drop tab-based UI for the about page

apol added a comment. In D17177#366883 , @ngraham wrote: > Well then Discover is setting the wrong information :) > > Can we have an updated screenshot if the last code change resulted in any visual changes? Ah you're right. Let's try

D17177: Drop tab-based UI for the about page

apol added a comment. In D17177#366500 , @ngraham wrote: > Looks much better visually! But something about the bugDisplay looks wrong. Right now it's recommending that people send bugs via email. No it's not, it's recomending to go to bug

D17177: Drop tab-based UI for the about page

apol updated this revision to Diff 46324. apol added a comment. Address Dan's concern REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17177?vs=46280&id=46324 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17177 AFFECTED FIL

D17177: Drop tab-based UI for the about page

apol added a comment. F6442717: discover-scrollableabout.png REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17177 To: apol, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuter

D17177: Drop tab-based UI for the about page

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Integrates better with Kirigami. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETA

D17079: Provide a qqc2/kirigami-based about page

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:673981634266: Provide a qqc2/kirigami-based about page (authored by apol). REPOSITORY R134 Discover Software Store

D16860: touchscreen text controls

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH phab/textcontrols REVISION DETAIL https://phabricator.kde.org/D16860 To: mart, #plasma, apol Cc: apol, broulik, plasma-dev

D17105: Add a new lookandfeel runner

apol updated this revision to Diff 46028. apol added a comment. LnF themes don't really have an icon REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17105?vs=46027&id=46028 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17105 AFFECTE

D17105: Add a new lookandfeel runner

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY I was using my laptop in the dark and hoping I could tone my colors down, thought this could be convenient

D17064: datetime runner: Match timezones less restrictively

apol closed this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D17064 To: apol, #plasma, hein Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17080: Make it possible to fallback to a different icon

apol closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D17080 To: apol, #kirigami, mart Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17079: Provide a qqc2/kirigami-based about page

apol added a comment. In D17079#364163 , @ltoscano wrote: > In D17079#364157 , @mart wrote: > > > I think this ui should really go into KCoreAddons itself. Would it be accepted there? > > > kco

D16860: touchscreen text controls

apol added a comment. isn't this a bit too binary? Maybe it makes sense to have hover effects even if on tablet mode. isn't it a matter of whether it comes from a finger? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16860 To: mart, #pla

D17079: Provide a qqc2/kirigami-based about page

apol added a comment. In D17079#363906 , @ltoscano wrote: > That's a great idea! Would it be possible: > > - to also (optionally) support the translators' information, like in the current about box? (probably in a future patch, but maybe some

D17079: Provide a qqc2/kirigami-based about page

apol added a comment. WRT the gravatar bit, I'm not married to it, it's just a way to have this moving forward. I'll add some screenshots so you get an idea: F6435584: discover-about1.png F6435585: discover-about2.png

D17079: Provide a qqc2/kirigami-based about page

apol updated this revision to Diff 45968. apol added a comment. Don't show the gravatar logo when not there REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17079?vs=45965&id=45968 BRANCH master REVISION DETAIL https://phabricator.kde.or

D17080: Make it possible to fallback to a different icon

apol updated this revision to Diff 45967. apol added a comment. Unrelated change REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17080?vs=45966&id=45967 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17080 AFFECTED FILES src/desktopicon

D17080: Make it possible to fallback to a different icon

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY If we failed to download something, it could make sense to be in control of what icon is shown inste

D17079: Provide a qqc2/kirigami-based about page

apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Instead of using the one in xmlgui, create one that integrates properly in Kirigami/Discover.

D17064: datetime runner: Match timezones less restrictively

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Instead of just showing the first match, show all of the matches. So if Europe was the query, it will list

D17050: Allow clicking of links in app descriptions

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks good to me, maybe it would make sense to restrict it to http:? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17050 To: leinir, #discover_softwa

D17025: Perf: Do expensive regexp construction earlier

apol added inline comments. INLINE COMMENTS > systemtray.cpp:88 > qCDebug(SYSTEM_TRAY) << "ST Found DBus-able Applet: " << > info.pluginId() << dbusactivation; > -m_dbusActivatableTasks[info.pluginId()] = dbusactivation; > +QRegExp rx(dbusactivation); > +

D16900: Don't use an icon that is only supposed for plasmoids

apol closed this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D16900 To: apol, andreask, sitter, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16898: [kcm] Remove profiles code

apol added subscribers: dvratil, apol. apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. RIP I see that @dvratil removed it at some point, maybe he remembers why it's not necessary? REPOSITORY R104 KScreen BRANCH removeProfilesCode

D16900: Don't use an icon that is only supposed for plasmoids

apol created this revision. apol added reviewers: andreask, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REPOSITORY R134 Discover Software Store BRANCH Plasma/5.14 REVISION DETAIL https://phabricator.kde.org/D16900

D16889: Listen to KDE Connect device signals

apol added inline comments. INLINE COMMENTS > kdeconnectplugin.cpp:185 > +msg.setArguments({url}); > +QDBusConnection::sessionBus().call(msg, QDBus::NoBlock); > +} Never saw this kind of change, what's the difference? REPOSITORY R856 Plasma Browser Integration REVISION DE

D16889: Listen to KDE Connect device signals

apol added a comment. +1 LGTM the KDE Connect parts. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D16889 To: broulik, #plasma, davidedmundson, fvogt, nicolasfella Cc: apol, bruns, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, j

D16843: Add output and connected outputs config API

apol added a comment. Don't we already have a hash per config? INLINE COMMENTS > config.h:126 > + * @return sorted hash combination of all connected outputs > + * @since 5.X.0 > + */ X=53 :) REPOSITORY R110 KScreen Library BRANCH hashApi REVISION DETAIL https://phabricat

D16776: Better error handling in KNewStuff backend

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D16776 To: leinir, #discover_software_store, apol Cc: plasma-devel, masilva, ragreen, ixoos, Pit

D16828: Allow sharing clipboard items to kdeconnect

apol added a comment. Why? Isn't the clipboard shared by its own plugin? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16828 To: blaws Cc: apol, nicolasfella, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D16812: Avoid potential race condtion with QFutureWatcher in FWUPD backend

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Good catch! REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D16812 To: davidedmundson, #plasma, apol Cc: apol, plasma-devel, ragreen, P

D16811: Load KDE QtQuickSettings in Discover

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I wonder if this would make sense in Kirigami integration instead? REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D16811 To: davidedmu

D16771: Fix warning

apol closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16771 To: apol, #plasma, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16776: Better error handling in KNewStuff backend

apol added a comment. Where will the `All categories are missing` error fall right now? INLINE COMMENTS > KNSBackend.cpp:247 > +QString error = message; > +bool invalidFile = false; > +switch(errorCode) { Maybe at least qDebug() it? > KNSBackend.cpp:275 > +case KNSCore::

D16771: Fix warning

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Now if appIcon isn't defined, it will set the property as undefined. file:///home/apol/devel/kde5/share/

D16715: make global menu minimize state aware

apol added inline comments. INLINE COMMENTS > main.qml:107 > id: buttonRepeater > -model: appMenuModel > +model: !appMenuModel.menuHidden ? appMenuModel : 0 > use `null` REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D167

D16711: Make sure m_labelMode is initialised

This revision was automatically updated to reflect the committed changes. Closed by commit R119:98d38f9ffb60: Make sure m_labelMode is initialised (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16711?vs=44971&id=44996#toc REPOSITORY R119 Plasma Desktop CHANGES SINC

D16711: Make sure m_labelMode is initialised

apol created this revision. apol added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Fixes uninitialised warning on valgrind REPOSITORY R119 Plasma Desktop BRANCH master REVISION D

D16685: Fix issue where there's only one element on the menu

This revision was automatically updated to reflect the committed changes. Closed by commit R858:8fa114df0ad1: Fix issue where there's only one element on the menu (authored by apol). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D166

D16685: Fix issue where there's only one element on the menu

apol created this revision. apol added reviewers: Frameworks, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY This (random) height shows an odd padding on the menu when there's just the one element. C

D16658: Respect the display property of buttons

apol added a comment. I guess we can wait until we can bump to Qt 5.10 as a dependency? This looks a bit chaotic. Also the Under/Beside setting isn't taken into account yet. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16658 To: astip

D16659: Size according to specified icon width and height

apol added a comment. +1 overall INLINE COMMENTS > kquickstyleitem.cpp:193 > } > +int iconWidth = m_properties[QStringLiteral("iconWidth")].toInt(); > +int iconHeight = m_properties[QStringLiteral("iconHeight")].toInt(); Can we be a bit smarter here? If the size is p

D16651: Honor flat property of buttons

apol added a comment. Looks good overall. Maybe it would make sense to add a test in `tests/buttonIcons.qml`? INLINE COMMENTS > Button.qml:63 > +"iconColor": controlRoot.icon && controlRoot.icon.color.a > 0? > controlRoot.icon.color : Kirigami.Theme.textColor, > +

D16635: Add declarative plugin

apol added a comment. Who's the use-case for this? The plasmoid? REPOSITORY R994 Pulseaudio Qt Bindings REVISION DETAIL https://phabricator.kde.org/D16635 To: nicolasfella, drosca, broulik, apol Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D16277: [ksmserver] Split xsession logout and shutdown into separate classes

apol requested changes to this revision. apol added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > shutdown.cpp:31 > { > -if ( state != Idle ) > -return; > -sessionGroup = QStringLiteral( "Session: " ) + session; > -saveCurrentSession(); > +

D16231: [ksmserver] Rewrite Startup

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. +1 LGTM INLINE COMMENTS > startup.cpp:275 > QDBusPendingCallWatcher *watcher = new QDBusPendingCallWatcher(pending, > this); > -QObject::connect(watcher, &QDBusPendingCallWatcher::fin

D16375: fix warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R169:96aa15d1: fix warnings (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16375?vs=44077&id=44497 REVISION DETAIL https://phabricator.kde.org

D16066: [ksmserver] Launch logout greeter with DBus methods

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. This looks really good! REPOSITORY R120 Plasma Workspace BRANCH ksmserver_split REVISION DETAIL https://phabricator.kde.org/D16066 To: davidedmundson, #plasma, apol Cc: apol, plasma-dev

D16521: [cuttlefish] Bind StandardKey.Quit (Ctrl+Q) to exit the app

apol added a comment. I know it may not be what you are after, but make a lot of sense to port this to Kirigami, which already has this and a bunch of other stuff. (Other than that, the patch is okay +1). REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D16521

D16502: Use consistent text for the GHNS button

apol added a comment. If you could give consistency to it, that would be awesome. Do what you think is best and I'll approve :). REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D16502 To: ngraham, #plasma, #vdg Cc: apol, plasma-devel, ragreen, Pitel

D16502: Use consistent text for the GHNS button

apol added a comment. Are you sure it makes sense to mention gnome? The user who uses this will more likely use it to modify behavior of random GTK apps. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D16502 To: ngraham, #plasma, #vdg Cc: apol, pla

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

apol added a comment. What's the status of this? The longer we wait, the harder it will be to integrate. We just branched 5.14, maybe it's time to consider doing so? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14796 To: gpark, hein Cc: apol, plasma-devel,

D16375: fix warnings

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Don't call directly properties that may be undefined TEST PLAN Now discover still works without

D16374: Don't fetch the url if it's already being fetched

This revision was automatically updated to reflect the committed changes. Closed by commit R169:3a7782e0ba5c: Don't fetch the url if it's already being fetched (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16374?vs=44075&id=44076 REVISIO

D16374: Don't fetch the url if it's already being fetched

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It had weird behaviours and would sometimes overwrite the image when it's downloaded for real.

D16087: RFC: Store full URL as URI

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense, even the argument is URI REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D16087 To: broulik, #plasma, hein, ivan, apol Cc: apol, plasma-d

D15790: Follow the preferred mode if we're asked to (i.e. if under QXL)

This revision was automatically updated to reflect the committed changes. Closed by commit R104:fb19e12c3253: Follow the preferred mode if we're asked to (i.e. if under QXL) (authored by apol). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15790?vs=42406&id=4

D15789: Support QXL hotplug_mode_update

This revision was automatically updated to reflect the committed changes. Closed by commit R110:b237aebd00ba: Support QXL hotplug_mode_update (authored by apol). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15789?vs=42500&id=42681 REVISION DETAIL

D15776: Show the preferred resolution on the combo box

This revision was automatically updated to reflect the committed changes. Closed by commit R104:dfd178e6d093: Show the preferred resolution on the combo box (authored by Your Name , committed by apol). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kd

D15789: Support QXL hotplug_mode_update

apol updated this revision to Diff 42500. apol added a comment. Make sure we don't check the property twice on the same path REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15789?vs=42405&id=42500 BRANCH arcpatch-D15789_1 REVISION DETAIL https:

D15789: Support QXL hotplug_mode_update

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > davidedmundson wrote in xrandroutput.cpp:212 > why are we querying if the property exists rather than if the property is 1? Because it's poorly specified. In fact, it's always 0 as far as I can tell. REPOSITORY

D15807: Allow to disable installation of wallpapers with breeze

apol closed this revision. apol added a comment. https://commits.kde.org/breeze/b97dfaff25ca2eb18099128243f3e2b2d2b56230 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D15807 To: apol, ngraham Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreu

D15807: Allow to disable installation of wallpapers with breeze

apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Will make it possible to have breeze on the flatpak and snap backends without all of the wallpapers REPOSITORY R31 Breeze BRANCH m

D15790: Follow the preferred mode if we're asked to (i.e. if under QXL)

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY As described in D15789 , follow the preferred mode when the backend

D15789: Support QXL hotplug_mode_update

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY QXL is a driver used mainly in VMs. This driver, it creates a new preferred mode upon resize instead of j

D15767: Don't apply configs in a loop

This revision was automatically updated to reflect the committed changes. Closed by commit R104:05ebba6b6e6e: Don't apply configs in a loop (authored by apol). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15767?vs=42363&id=42382 REVISION DETAIL https://ph

D15770: Expose the preferredModesChanged property change

apol requested review of this revision. apol added a comment. Sorry for the noise, this doesn't work. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D15770 To: apol, #plasma, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D15768: Fix using kscreen with qxl, follow the preferred mode

apol abandoned this revision. apol added a comment. Sorry for the noise, this doesn't work. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D15768 To: apol, #plasma Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, s

D15776: Show the preferred resolution on the combo box

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Usually there's a preferred resoluton for a display, let the user know it TEST PLAN Used the kcm with it

D15770: Expose the preferredModesChanged property change

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY See D15768 REPOSITORY R110 KScreen Library BRANCH master REVISI

D15768: Fix using kscreen with qxl, follow the preferred mode

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY When using a the qxl driver (for virtual machines), we'll be getting resizes of the display by changes o

D15767: Don't apply configs in a loop

apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Loop through all the changed bits then apply at once. It should trigger less unnecessary visual changes. TEST PLAN Restarted kded5, r

D15613: [Hotplug Engine] Update actions at runtime and listen for added/removed

apol added a comment. +1 INLINE COMMENTS > broulik wrote in hotplugengine.cpp:152 > I don't think so, the icon and emblem don't depend on the predicate but the > device's state. > > Granted, we currently don't update them *at all* in this dataengine but > that's a separate issue. Device No

D15598: Sort icon and cursor themes case-insensitively

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM, not sure why sort() doesn't work though. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH sort-icon-and-cursor-themes-case-insensitively (branched from master) REVISION DETAIL http

D15613: [Hotplug Engine] Update actions at runtime and listen for added/removed

apol added a comment. Sorry, very naif review. INLINE COMMENTS > hotplugengine.cpp:152 > Plasma::DataEngine::Data data; > data.insert(QStringLiteral("predicateFiles"), predicates); > +data.insert(QStringLiteral("actions"), > actionsForPredica

D15245: Start looking for the context from the delegate itself

This revision was automatically updated to reflect the committed changes. Closed by commit R169:00e73ec1091c: Start looking for the context from the delegate itself (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15245?vs=40920&id=40985 RE

D15243: Remove some double look-ups

This revision was automatically updated to reflect the committed changes. Closed by commit R169:301af35592af: Remove some double look-ups (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15243?vs=40947&id=40984 REVISION DETAIL https://pha

D15263: Don't use older buggier versions of AppStream Qt

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b96651acdca4: Don't use older buggier versions of AppStream Qt (authored by apol). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15263?vs=40971&id=40983 RE

<    5   6   7   8   9   10   11   12   13   14   >