D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9848#190676, @romangg wrote: > In https://phabricator.kde.org/D9848#190644, @anemeth wrote: > > > .arcconfig is not needed here > > > Your current patch

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 6 inline comments as done. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25350. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Reverted the change of putting the blur strength configuration into a vector, because it resulted in some complications. Doing it with the huge switch

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 2 inline comments as done. anemeth added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > romangg wrote in blur.h:29 > Put this into the cpp. Why? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25305. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Moved pointer initialization to the header file. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9848?vs=25300=25305

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 8 inline comments as done. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9848#190515, @romangg wrote: > In https://phabricator.kde.org/D9848#190128, @anemeth wrote: > > > Removed .arcconfig

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25300. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Changed all references of NULL to nullptr REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9848?vs=25290=25300 BRANCH

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25290. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Fixed a bug where changing resolution would break the blur effect. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 6 inline comments as done. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham, plasma-devel,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25282. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Implementing the changes that were suggested by @zzag REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9848?vs=25267=25282

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > zzag wrote in blur.cpp:135 > Where did they come from? I came up with these numbers by testing different iteration and offset values. REPOSITORY R108 KWin REVISION DETAIL

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9848#190209, @davidedmundson wrote: > In general, I think it makes sense. Academically the change is sound[1] - and the results certainly look good. >

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > davidedmundson wrote in blur.cpp:186 > m_simpleTarget no longer gets updated on screen changes. What do you mean by this? m_simpleTarget works independently form the vector of

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 13 inline comments as done. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. These changes were implemented. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: anthonyfieroni,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25267. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Implemented the changes that were suggested by anthonyfieroni REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. And here it is in action: F5644329: a.mp4 REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth edited the summary of this revision. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin, graesslin Cc: plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, progwolff,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25253. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Removed .arcconfig and added a whitespace REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9848?vs=25252=25253 BRANCH

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25252. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Removed whitespaces and added blur config structure. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9848?vs=25249=25252

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added reviewers: Plasma, KWin, graesslin. Restricted Application edited projects, added Plasma; removed KWin. Restricted Application added a subscriber: plasma-devel. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin, graesslin Cc:

<    1   2