D26199: Remove unneeded shortcut for page naviagtion

alexeymin added a comment. Doesn't work for me, needs very fresh kirigami too? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D26199 To: nicolasfella, #discover_software_store Cc: alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D26069: Fix usage of deprecated QSet/QList methods

This revision was automatically updated to reflect the committed changes. Closed by commit R134:34d68d4ec5a5: Fix usage of deprecated QSet/QList methods (authored by alexeymin). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D26069: Fix usage of deprecated QSet/QList methods

alexeymin added a comment. Should be fine now? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D26069 To: alexeymin Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin,

D26069: Fix usage of deprecated QSet/QList methods

alexeymin updated this revision to Diff 71749. alexeymin added a comment. I feel sad doing such things REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26069?vs=71748=71749 BRANCH arcpatch-D26069 REVISION DETAIL

D26069: Fix usage of deprecated QSet/QList methods

alexeymin updated this revision to Diff 71748. alexeymin added a comment. Add QT_VERSION_CHECK checks REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26069?vs=71731=71748 BRANCH arcpatch-D26069 REVISION DETAIL

D26069: Fix usage of deprecated QSet/QList methods

alexeymin added a comment. No :( just checked, Qt 5.12's https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/tools/qset.h?h=v5.12.0 is missing `inline QSet(InputIterator first, InputIterator last)`, which appeared only in 5.14. I guess I need an `#ifdef` for QSet construction then.

D26069: Fix usage of deprecated QSet/QList methods

alexeymin created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alexeymin requested review of this revision. REVISION SUMMARY COmpiiling with Qt 5.14 produces the following warnings: .../libdiscover/resources/StandardBackendUpdater.cpp:70:43:

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

alexeymin added inline comments. INLINE COMMENTS > apol wrote in startplasma-wayland.cpp:91 > Please see > https://invent.kde.org/kde/plasma-phone-components/merge_requests/38 Indeed, I overlooked, probably lack of `{ }` around `for` loop confused me.. REPOSITORY R120 Plasma Workspace

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

alexeymin added inline comments. INLINE COMMENTS > apol wrote in startplasma-wayland.cpp:91 > This is not changing, --xwayland is already on by default. In fact it will be > possible to change the defaults by passing some arguments to > startplasma-wayland. Currently I can edit simple shell

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

alexeymin added inline comments. INLINE COMMENTS > startplasma-wayland.cpp:91 > +} else { > +args = QStringList { QStringLiteral("--xwayland"), > QStringLiteral("--libinput"), QStringLiteral("--exit-with-session=" > CMAKE_INSTALL_FULL_LIBEXECDIR "/startplasma-waylandsession") }; >

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

alexeymin added a comment. Good to see more flexibility! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25750 To: apol, #plasma, bshah Cc: alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D22418: WIP [wayland] make automatic backend selection truly automatic

alexeymin added a comment. > not convinced that removing the ifdef is the solution It is, because now availability and presence of command-line options is decided at KWin **compile** time, and it should be decided at **run** time based on the actual list of available plugins. Just

D22418: WIP [wayland] make automatic backend selection truly automatic

alexeymin updated this revision to Diff 69838. alexeymin added a comment. - remove unwanted change in translated string REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22418?vs=69837=69838 BRANCH alexeymin/rework-wayland-backends-plugin-system REVISION

D22418: WIP [wayland] make automatic backend selection truly automatic

alexeymin updated this revision to Diff 69837. alexeymin added a comment. - Link kwin_wayland with Wayland::Client - Platform: add canLoad() function and implement in all backends - Add autoLoadPriority to wayland backends plugins JSON metadata - main_wayland: sort loaded plugins by

D24363: Fix several build system errors

This revision was automatically updated to reflect the committed changes. Closed by commit R858:731b85008c21: Fix several build system errors (authored by alexeymin). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D24363: Fix several build system errors

alexeymin marked an inline comment as done. alexeymin added a comment. Right, so I was fooled by having qqc2-desktop-style listed as Tier 1 on our main documentation page https://api.kde.org/frameworks/index.html . If it is really Tier 3, then maybe it does not even make sense to make

D24363: Fix several build system errors

alexeymin updated this revision to Diff 67233. alexeymin added a comment. - Bring back missing KF5_DEP_VERSION REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24363?vs=67207=67233 BRANCH alexeymin/fix-cmake-errors REVISION

D24363: Fix several build system errors

alexeymin reopened this revision. alexeymin added a comment. Phabricator, you're drunk, it is not pushed to master REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D24363 To: alexeymin, mart, #plasma, dfaure Cc: kde-frameworks-devel,

D24363: Fix several builsystem errors

alexeymin added a comment. Second error is revealed after the first one is fixed: Scanning dependencies of target qqc2desktopstyleplugin [ 40%] Building CXX object plugin/CMakeFiles/qqc2desktopstyleplugin.dir/qqc2desktopstyleplugin_autogen/mocs_compilation.cpp.o [ 60%] Building

D24363: Fix several builsystem errors

alexeymin added a comment. First of all, if you try to build qqc2-desktop-style on a system with only Qt5 and other Tier 1 frameworks installed, you will get the following cmake configure log (https://paste.ubuntu.com/p/YRjSRWm9g6/): OS Kubuntu 18.04 LTS Custom-built Qt 5.14 in

D24363: qqc2-desktop-style: Fix several builsystem errors

alexeymin created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alexeymin requested review of this revision. TEST PLAN without this patch, try to build with only Qt5 and Tier 1 frameworks installed and see it fails REPOSITORY R858 Qt Quick Controls

D23350: Chaning default iconSize in systemtray

alexeymin added a comment. I can confirm the issue that tray icons are to small on 4k display REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23350 To: xshram, ngraham Cc: alexeymin, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D22418: wayland: make automatic backend selection truly automatic

alexeymin created this revision. alexeymin added reviewers: romangg, zzag. Herald added a project: KWin. Herald added a subscriber: kwin. alexeymin requested review of this revision. REVISION SUMMARY Choose backend automatically, based on actually available plugins at runtime, independently

D22014: Add a copy of FindKXB from kwin

alexeymin added a comment. typo in title :) REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D22014 To: lbeltrame, cgiboudeaux Cc: alexeymin, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D21273: Add support for newer linux kernel power_supply API. Keep backwardcompatibility with older procfs API.

alexeymin added a comment. Hm, looks ideologically similar to how it was done in SDL2... https://hg.libsdl.org/SDL/file/792c26401463/src/power/linux/SDL_syspower.c REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D21273 To: luc4, davidedmundson Cc: alexeymin,

D18802: Fix pragma once problem with process class

alexeymin added a comment. Is it because process.h exists somewhere else? REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18802 To: patrickelectric, davidedmundson, tcanabrava, ngraham Cc: alexeymin, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D18651: [Task Manager] Sort manually by default

alexeymin added a comment. In D18651#403466 , @broulik wrote: > +1 first thing I change on a fresh setup me too, along with single click to open to double click  REPOSITORY R119 Plasma Desktop BRANCH

D18621: Add again a button to manually scan for wireless networks

alexeymin added a comment. In D18621#402558 , @ngraham wrote: > In my opinion, this sort of thing is a "help the user feel in control" issue. +1, it would be cool to have a button to scan for wireless networks. Today I tried to connect

D16330: Add a vertical spacer item

alexeymin added a comment. 1. What if in the future another, horizontal spacer component will become needed? Will you add a HorizontalSpacer.qml then?  Maybe have just a Spacer with `horizontal` property? 2. Why `Rectangle`, it could be just `Item`, it does not cause rendering (Rectangle

D16073: openconnect: add missing dependency Qt5Xml

alexeymin accepted this revision. alexeymin added a comment. This revision is now accepted and ready to land. https://cgit.kde.org/plasma-nm.git/diff/vpn/openconnect/CMakeLists.txt?id=a44b7f38c548d756b6cb822c047ef71cf67645f5 Probably this commit could remove dependency on QtXml (I'm not

D15696: Fix qmake build

alexeymin added a comment. How can I reproduce broken build? Any test plan? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D15696 To: IlyaBizyaev, mart Cc: alexeymin, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D15696: Fix qmake build

alexeymin added a comment. Maybe add it to .pro file too then? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D15696 To: IlyaBizyaev, mart Cc: alexeymin, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D15233: Add a tooltip for the appentry in the kicker

alexeymin added a comment. Why isn't repository for this review set? Which repo it should be? REVISION DETAIL https://phabricator.kde.org/D15233 To: underwit, #plasma Cc: alexeymin, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

alexeymin added a comment. Don't know how much offtopic will be what I'm going to say, but I recently ran into an issue while packaging QQC2 application in flatpak with org.kde.Platform//5.9 runtime. My app was functioning perfectly fine in system, but under flatpak it failed to start with

D13919: [Fonts KCM] Generate font rendering previews only on X

alexeymin added a comment. This is probably for BUG: 396214 ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13919 To: broulik, #plasma, fvogt Cc: alexeymin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D13920: [Font Management KCM] Only show on xcb platform

alexeymin added a comment. BUG: 396214 or better BUG: 364746 ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13920 To: broulik, #plasma, fvogt Cc: alexeymin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D6096: Add Wayland RemoteAccess capabilities to KRfb

alexeymin added a comment. How exactly I can test if something works? And what are the requirements? PipeWire? Something else? REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson, graesslin, #plasma, #kde_applications Cc:

D12698: WIP: Show SNI to install browser-side extension

alexeymin added a comment. In D12698#259554 , @zzag wrote: > Also, there is Firefox Nightly, which has its own icon too. Nightly users shall suffer! Icon mismatch is not fatal error, at least nightly users should know what they have

D12476: kcm_opengl: Fix retrieval of DRI information

alexeymin accepted this revision. alexeymin added a comment. This revision is now accepted and ready to land. In D12476#258427 , @roberts wrote: > It will fail gracefully, it checks for the presence of these /proc or /sys files and only acts if

D12476: kcm_opengl: Fix retrieval of DRI information

alexeymin added a comment. I'm not completely sure that IsDirect should be manually set to true in wayland code path (it looks like a hack just to test). What happens if IsDirect is set to true, but software rendering is active? Will get_dri_device() fail gracefully or something horrible

D12679: Show SNI when software renderer is in use

alexeymin added a comment. In D12679#257717 , @davidedmundson wrote: > I give them a KCM where they can easily toggle it back. That's only really useful after they've fixed their real problem, but I don't think we can really help with that.

D12679: Show SNI when software renderer is in use

alexeymin added a comment. Should this notifier provide some tip for user on how to go back to hardware rendering? Or is it not relevant here? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12679 To: davidedmundson, #plasma Cc: alexeymin, broulik,

D12476: kcm_opengl: Fix retrieval of DRI information

alexeymin added a comment. I've tested this and it seems to work! F5821132: kinfocenter DRI info wayland.png But in wayland I had to add some changes: set `IsDirect = true;` before calling `print_screen_info()` in `get_gl_info_egl_qt()` line ~

D12003: Fix displaying OpenGL info on wayland: do not require OpenGL 3.2

This revision was automatically updated to reflect the committed changes. Closed by commit R102:702c7ca86e94: Fix displaying OpenGL info on wayland: do not require OpenGL 3.2 (authored by alexeymin). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D12003: Fix displaying OpenGL info on wayland: do not require OpenGL 3.2

alexeymin added a comment. On wayland, without this patch with OpenGL 3.2 version requested, it fails with error: F5796592: wayland before.png and outputs in terminal: Could not get requested OpenGL profile, requested

D12003: Fix displaying OpenGL info on wayland: do not require OpenGL 3.2

alexeymin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. alexeymin requested review of this revision. REVISION SUMMARY Removing the requirement of 3.2 version just fixes it for my AMD RX560 on amdgpu opensource

D6096: Add Wayland RemoteAccess capabilities to KRfb

alexeymin added a comment. While I'm here and still remember some things that I don't like here - naming: There is a class `EventsPlugin` and files `eventsplugin.{h,cpp}`, class `EventsManager` and files `eventsmanager.{h,cpp}` and this is fine. But there is also class `EventHandler`,

D10807: fileindexerconfig: Exclude Vaults by default

alexeymin added a comment. Maybe when a new vault is configured, it should add itself to baloo exceptions. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham, #plasma Cc: alexeymin, plasma-devel, ivan, nicolasfella,

D9804: Add BusyIndicator to the styled controls list

alexeymin added a comment. https://api.kde.org/frameworks/index.html says: > Tier 1 frameworks depend only on Qt (and possibly a small number of other third-party libraries), so can easily be used by any Qt-based project. Can tier 1 framework depend on other tier 1 framework?

D9542: Improve display of technical app info

alexeymin added a comment. I don't spot any obvious problems in QML any more. And I like newer version more than previous... REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9542 To: ngraham, apol, #vdg, #discover_software_store Cc: januz, alexeymin,

D9542: Improve display of technical app info

alexeymin added a comment. "After" definitely looks better :) INLINE COMMENTS > ApplicationPage.qml:153 > Layout.fillWidth: true > -text: appInfo.application.comment > +Text { > +text: appInfo.application.comment Why do you put a `Text`

D1231: Add Remote Access interface to KWayland

alexeymin added a comment. In https://phabricator.kde.org/D1231#39191, @Kanedias wrote: > ... > Besides, I didn't find any mentions of multi-screen capabilities in Krfb at all. It currently works like this: > > d->framebufferImage = XGetImage(QX11Info::display(), >

D6096: Add Wayland RemoteAccess capabilities to KRfb

alexeymin added a comment. There was a https://phabricator.kde.org/D5211, that added `xcb` framebuffer plugin; and after that `x11` framebuffer was removed from source tree ( https://phabricator.kde.org/R437:f131f7ddba584779144e7f737a98b24de430824c ), so this patch of needs to be slightly