D18101: Don't reset the moved display position

This revision was automatically updated to reflect the committed changes. Closed by commit R104:2c5af49d3de7: Dont reset the moved display position (authored by amantia). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18101?vs=50659=50660 REVISION DETAIL

D18101: Don't reset the moved display position

amantia updated this revision to Diff 50659. amantia added a comment. Rebased REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18101?vs=49003=50659 BRANCH fix_reset_output_pos REVISION DETAIL https://phabricator.kde.org/D18101 AFFECTED FILES

D18093: Calculate screen scaling dynamically, so it always fits to the page

amantia closed this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D18093 To: amantia, #plasma, dvratil Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18093: Calculate screen scaling dynamically, so it always fits to the page

amantia updated this revision to Diff 50657. amantia added a comment. Make it work with Qt 5.9 REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18093?vs=49002=50657 BRANCH dynamic_scale REVISION DETAIL https://phabricator.kde.org/D18093 AFFECTED FILES

D18091: Backport "Show unconnected displays at the right side of the main screen"https://phabricator.kde.org/D17682

amantia updated this revision to Diff 50656. amantia added a comment. Don't use QQuickItem size(), use width() directly, so it builds with Qt 5.9 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18091?vs=48951=50656 REVISION DETAIL https://phabricator.kde.org/D18091 AFFECTED FILES

D18121: Don't lose the widget layout after Default is pressed

amantia closed this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D18121 To: amantia, dvratil, #plasma, davidedmundson Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18121: Don't lose the widget layout after Default is pressed

amantia created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. amantia requested review of this revision. REVISION SUMMARY BUG: 400302 REPOSITORY R104 KScreen BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D18121 AFFECTED FILES

D18093: Calculate screen scaling dynamically, so it always fits to the page

amantia added a comment. It is a followup and extension of https://phabricator.kde.org/D17682 Basically it is possible that you have 3-4 monitors and only 2.5 or so are visible, because they don't fit in the dialog. This patch makes sure they are all visible. The previous patch just

D18093: Calculate screen scaling dynamically, so it always fits to the page

amantia updated this revision to Diff 49002. amantia added a comment. Restore REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18093?vs=48998=49002 BRANCH dynamic_scale REVISION DETAIL https://phabricator.kde.org/D18093 AFFECTED FILES

D18100: Calculate screen scaling dynamically, so it always fits to the page

amantia created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. amantia requested review of this revision. REVISION SUMMARY Don't reset the moved display position This fixes the problem that after moving a display, clicking on another one and

D18093: Calculate screen scaling dynamically, so it always fits to the page

amantia updated this revision to Diff 48998. amantia added a comment. - Don't reset the moved display position REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18093?vs=48953=48998 BRANCH fix_reset_output_pos REVISION DETAIL

D18092: Backport "Show unconnected displays at the right side of the main screen"

amantia created this revision. amantia added a project: Plasma. amantia requested review of this revision. REVISION SUMMARY https://phabricator.kde.org/D17682 REPOSITORY R104 KScreen BRANCH dynamic_scale REVISION DETAIL https://phabricator.kde.org/D18092 AFFECTED FILES

D18091: Backport "Show unconnected displays at the right side of the main screen"https://phabricator.kde.org/D17682

amantia created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. amantia requested review of this revision. REPOSITORY R104 KScreen BRANCH backport_screen_to_right REVISION DETAIL https://phabricator.kde.org/D18091 AFFECTED FILES

D17533: Make the button's purpose more clear

amantia added a comment. I understand that, of course. I think the question is: is this an improvement or not? I think it is (not perfect, has problems, but an improvement), but if considered to be not, I will just abandon it, no hard feelings. REPOSITORY R119 Plasma Desktop REVISION

D17533: Make the button's purpose more clear

amantia added a comment. Ping? I'll push this if there are no strong objections. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17533 To: amantia, #plasma_accessibility, davidedmundson, aacid, ngraham Cc: pino, gladhorn, ngraham, plasma-devel, kvanton,

D17682: Show unconnected displays at the right side of the main screen

amantia closed this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D17682 To: amantia, dvratil Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17658: Redraw the slider if modes have changed

amantia abandoned this revision. amantia added a comment. Abandoned in favor of https://phabricator.kde.org/D17686 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D17658 To: amantia, dvratil Cc: davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D17686: Redraw the slider if modes have changed

amantia closed this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D17686 To: amantia, #plasma, dvratil Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17685: Notify also if modes have changed

amantia closed this revision. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D17685 To: amantia, #plasma, dvratil Cc: davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17657: Notify also if modes have changed

amantia abandoned this revision. amantia added a comment. Will fix first in 5.12 and merge to master, as per https://phabricator.kde.org/D17685 REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D17657 To: amantia, dvratil Cc: davidedmundson, plasma-devel,

D17685: Notify also if modes have changed

amantia added a comment. I have on for master and one for Plasma 5.12, as we want this in 5.12 as well, if approved. Should I keep only one of them? REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D17685 To: amantia, #plasma, dvratil Cc: davidedmundson,

D17686: Redraw the slider if modes have changed

amantia created this revision. amantia added a project: Plasma. amantia requested review of this revision. REVISION SUMMARY This can happen if a monitor was not configured at all, the KCM is shown when it first plugged in and the user selects to not configure it. In the UI it will appear

D17685: Notify also if modes have changedBackport for D17657Depends on D17657

amantia created this revision. amantia added a project: Plasma. amantia requested review of this revision. REVISION SUMMARY Will be needed in the KCM to correctly update the UI REPOSITORY R110 KScreen Library BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D17685

D17658: Redraw the slider if modes have changed

amantia updated this revision to Diff 47831. amantia added a comment. Undo last change REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17658?vs=47830=47831 BRANCH fix_null_size REVISION DETAIL https://phabricator.kde.org/D17658 AFFECTED FILES

D17658: Redraw the slider if modes have changed

amantia updated this revision to Diff 47830. amantia added a comment. - Show unconnected displayed at the left REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17658?vs=47779=47830 BRANCH rework_qml_part REVISION DETAIL

D17657: Notify also if modes have changed

amantia updated this revision to Diff 47789. amantia added a comment. Simplify REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17657?vs=47778=47789 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17657 AFFECTED FILES

D17658: Redraw the slider if modes have changed

amantia added inline comments. INLINE COMMENTS > davidedmundson wrote in resolutionslider.cpp:144 > does this not cause the apply button to enable immediately when a user hasn't > changed anything? I don't see how it would do that. This is called either when an output is set up the first time

D17657: Notify also if modes have changed

amantia added inline comments. INLINE COMMENTS > davidedmundson wrote in output.cpp:583-585 > isn't that what this is doing? Good point, missed it. @dvratil any reason why it emits outputChanged and not modesChanged? Actually setModes emits both, so maybe indeed it is easier to just put

D17658: Redraw the slider if modes have changed

amantia created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. amantia requested review of this revision. REVISION SUMMARY This can happen if a monitor was not configured at all, the KCM is shown when it first plugged in and the user selects to not

D17657: Notify also if modes have changed

amantia created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. amantia requested review of this revision. REVISION SUMMARY Will be needed in the KCM to correctly update the UI REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL

D17533: Make the button's purpose more clear

amantia updated this revision to Diff 47714. amantia added a comment. Use title case REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17533?vs=47712=47714 BRANCH accesbility_dialog_improvement REVISION DETAIL https://phabricator.kde.org/D17533

D17533: Make the button's purpose more clear

amantia added a comment. I perfectly agree with Frederik. There is room for improvement, but my intention was not to completely change it, just to make it slightly more clear what this is about. The rest can be fixed in a separate commit, if anyone is interested to do it. :) INLINE

D17533: Make the button's purpose more clear

amantia updated this revision to Diff 47712. amantia added a comment. Change the individual texts REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17533?vs=47661=47712 BRANCH accesbility_dialog_improvement REVISION DETAIL

D17533: Make the button's purpose more clear

amantia abandoned this revision. amantia added inline comments. INLINE COMMENTS > ngraham wrote in kaccess.cpp:870 > Let's use `xi18nc()` for this: > > `xi18nc("@info", "%1", question)` That looks weird., as it creates a translatable string for no reason. Obviously best would be to update

D17533: Make the button's purpose more clear

amantia added a comment. Yes, most questions can be answered with Yes/No, and still I'd say it is better to use Yes/No, instead of OK/Cancel. OK/Cancel is rather useless, although widely used, I know... I made the question text bold now, and unfortunately as I said I don't want to spend

D17533: Make the button's purpose more clear

amantia updated this revision to Diff 47661. amantia added a comment. Make the question text bold REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17533?vs=47590=47661 BRANCH accesbility_dialog_improvement REVISION DETAIL

D17533: Make the button's purpose more clear

amantia added a comment. I'm not a native speaker, but I don't see how OK/Cancel is better. The dialog shows a question that can be answered with Yes or No. See also the HIG https://hig.kde.org/components/assistance/message.html > - Apply confirmation button labels when further

D17533: Make the button's purpose more clear

amantia updated this revision to Diff 47590. amantia added a comment. Improve dialog title as well REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17533?vs=47441=47590 BRANCH accesbility_dialog_improvement REVISION DETAIL

D17533: Make the button's purpose more clear

amantia added a comment. You can't change to Yes/No (that was my first try), as the question might be one of the following: - "Activate foo ?" - "Deactivate foo?" - "Activate foo and deactivate bar?" REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17533: Make the button's purprose more clear

amantia added a comment. How it looked before: F6476429: new_dialog.jpg How it looks now: F6476432: new_dialog.jpg REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17533 To:

D17536: Make accessibility warning dialog usable again and fix event handling

amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17536 To: amantia, #plasma_accessibility, #plasma, aacid, mart Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17557: Make accessibility warning dialog usable again

amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17557 To: amantia, #plasma_accessibility, #plasma, aacid, davidedmundson Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D17557: Make accessibility warning dialog usable again

amantia created this revision. amantia added reviewers: Plasma Accessibility, Plasma, aacid. amantia added a project: Plasma. amantia requested review of this revision. REVISION SUMMARY Layout was completely broken, resulting in an empty dialog. REPOSITORY R119 Plasma Desktop BRANCH

D17557: Make accessibility warning dialog usable again

amantia added a comment. Backport to 5.12 branch REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17557 To: amantia, #plasma_accessibility, #plasma, aacid Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D17533: Make the button's purprose more clear

amantia updated this revision to Diff 47441. amantia added a comment. Reworked, by reshuffling the dialog text, instead of renaming the buttons REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17533?vs=47434=47441 BRANCH

D17533: Make the button's purprose more clear

amantia planned changes to this revision. amantia added a comment. Will have to rework, I missed some cases(the dialog might as to activate. deactivate or "activate some, deactivate others"), it is not as simple as I thought. INLINE COMMENTS > davidedmundson wrote in kaccess.cpp:713 > can

D17536: Make accessibility warning dialog usable again and fix event handling

amantia added a comment. Accessibility bugfixes cherry picked from master REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17536 To: amantia, #plasma_accessibility, #plasma, aacid Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D17536: Make accessibility warning dialog usable again and fix event handling

amantia created this revision. amantia added reviewers: Plasma Accessibility, Plasma, aacid. amantia added a project: Plasma. amantia requested review of this revision. REVISION SUMMARY Layout was completely broken, resulting in an empty dialog. REPOSITORY R119 Plasma Desktop BRANCH

D17533: Make the button's purprose more clear

amantia created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. amantia requested review of this revision. REVISION SUMMARY BUG: 190369 REPOSITORY R119 Plasma Desktop BRANCH accesbility_dialog_improvement REVISION DETAIL

D17415: Fix event type checking

amantia closed this revision. amantia added a comment. Messed up a little and this got landed together with another patch https://cgit.kde.org/plasma-desktop.git/commit/?id=40b9e34ced6b421c8585f304d91a2da37f40c4d6 REVISION DETAIL https://phabricator.kde.org/D17415 To: amantia, #plasma,

D17408: Make accessibility warning dialog usable again

This revision was automatically updated to reflect the committed changes. Closed by commit R119:40b9e34ced6b: Make accessibility warning dialog usable again (authored by amantia). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17408?vs=47044=47374#toc REPOSITORY R119 Plasma Desktop

D17415: Fix event type checking

amantia updated this revision to Diff 47100. amantia added a comment. Added comment for workaround CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17415?vs=47065=47100 REVISION DETAIL https://phabricator.kde.org/D17415 AFFECTED FILES kaccess/kaccess.cpp To: amantia, #plasma,

D17415: Fix event type checking

amantia created this revision. amantia added reviewers: Plasma, Plasma Accessibility, aacid. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. amantia requested review of this revision. REVISION SUMMARY The ev->xkbType looks to be a value that is defined in xkb.xml

D17408: Make accessibility warning dialog usable again

amantia created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. amantia requested review of this revision. REVISION SUMMARY Layout was completely broken, resulting in an empty dialog. REPOSITORY R119 Plasma Desktop BRANCH accessbility-fixes

D10728: Improve multi-desktop folderview behavior

amantia closed this revision. REVISION DETAIL https://phabricator.kde.org/D10728 To: amantia, #plasma, hein Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10728: Improve multi-desktop folderview behavior

amantia updated this revision to Diff 28998. amantia added a comment. Moved to 5.12 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10728?vs=27733=28998 BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10728 AFFECTED FILES

D10728: Improve multi-desktop folderview behavior

amantia added a comment. I can't put to 5.12 as it seems https://phabricator.kde.org/D9325 didn't get into the 5.12 branch, and I don't want two versions of this patch. May I cherry-pick that commit to 5.12 and apply this patch? REPOSITORY R119 Plasma Desktop BRANCH master REVISION

D10729: Improve detecting D between two screen showing the same URL

amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10729 To: amantia, #plasma, hein, mwolff Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10728: Improve multi-desktop folderview behavior

amantia added a comment. Yes, I will push first to 5.12 both of them REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D10728 To: amantia, #plasma, hein Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10728: Improve multi-desktop folderview behavior

amantia added a comment. It adds a new entry, doesn't change an existing one. If that is not there, I see no problems, the ScreenMapper::readDisabledScreensMap() will not initialize the m_itemsOnDisabledScreensMap. That map was not saved previously, thus the folderview behaving differently

D10729: Improve detecting D between two screen showing the same URL

amantia added a comment. Ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10729 To: amantia, #plasma, hein, mwolff Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10728: Improve multi-desktop folderview behavior

amantia added a comment. Ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10728 To: amantia, #plasma, hein Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10728: Improve multi-desktop folderview behavior

amantia added reviewers: Plasma, hein. amantia set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D10729: Improve detecting D between two screen showing the same URL

amantia added reviewers: Plasma, hein, mwolff. amantia set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D10407: Disable positioning in popup folderviews

amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10407 To: amantia, hein Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10408: Add option to enable shared folderview content per desktop

amantia closed this revision. REVISION DETAIL https://phabricator.kde.org/D10408 To: amantia, #plasma, hein Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10407: Disable positioning in popup folderviews

amantia added a comment. Yes, I have commit access since some time. ;) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10407 To: amantia, hein Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10408: Add option to enable shared folderview content per desktop

amantia added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION DETAIL https://phabricator.kde.org/D10408 To: amantia, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10407: Disable positioning in popup folderviews

amantia added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10407 To: amantia, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10407: Disable positioning in popup folderviews

amantia created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. amantia requested review of this revision. REVISION SUMMARY We need to use the overriden sortMode, not the model's sort mode. The == -> === changes are just

D9325: Use QUrl in the ScreenMapper API

amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9325 To: amantia, #plasma, mwolff, broulik, hein Cc: ervin, mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9325: Use QUrl in the ScreenMapper API

amantia updated this revision to Diff 25933. amantia added a comment. Make the code more clear, by renaming a local variable. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9325?vs=25799=25933 BRANCH master REVISION DETAIL

D9325: Use QUrl in the ScreenMapper API

amantia edited reviewers, added: hein; removed: dakon. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9325 To: amantia, #plasma, mwolff, broulik, hein Cc: ervin, mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D9325: Use QUrl in the ScreenMapper API

amantia added inline comments. INLINE COMMENTS > mwolff wrote in foldermodel.cpp:1509 > not your change: why is m_url not an url :-/ > > also: introduce the helper function you have in the tests here, too - maybe > even move it into a static function in the ScreenMapper and then use it >

D9325: Use QUrl in the ScreenMapper API

amantia updated this revision to Diff 25799. amantia added a comment. Change code according to reviewer's requests REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9325?vs=23954=25799 BRANCH master REVISION DETAIL

D8922: Avoid jumping of items toward right/botton when dropping

amantia added a comment. Sorry about it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8922 To: amantia, #plasma, hein, mwolff Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9323: Use ScreenMapper everywhere as a singleton

amantia closed this revision. REVISION DETAIL https://phabricator.kde.org/D9323 To: amantia, #plasma, mwolff, hein Cc: mlaurent, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9300: Store screenMapping info only once

amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9300 To: amantia, #plasma, mwolff, hein, broulik, mlaurent, mart Cc: mart, mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9325: Use QUrl in the ScreenMapper API

amantia updated this revision to Diff 23954. amantia added a comment. Fixed issues pointed out by Laurent. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9325?vs=23898=23954 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9325 AFFECTED FILES

D9300: Store screenMapping info only once

amantia added a comment. I will merge this latest on Monday if there is no further objection REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D9300 To: amantia, #plasma, mwolff, hein, broulik, mlaurent, mart Cc: mart, mlaurent, plasma-devel,

D9313: Don't move back items to second screen if they were manually moved

amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9313 To: amantia, #plasma, hein, mwolff Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9300: Store screenMapping info only once

amantia added a comment. In https://phabricator.kde.org/D9300#179031, @broulik wrote: > Screen mapper is a singleton type, so it won't cause problems when one screen adds a mapping, it will propagate to the other containments automagically? Before we had `plasmoid.configuration` which

D9325: Use QUrl in the ScreenMapper API

amantia added reviewers: Plasma, mwolff, dakon, broulik. amantia set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D9323: Use ScreenMapper everywhere as a singleton

amantia updated this revision to Diff 23897. amantia added a comment. Connect to screenammper only if used as a containment CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9323?vs=23894=23897 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9323 AFFECTED FILES

D9323: Use ScreenMapper everywhere as a singleton

amantia added inline comments. INLINE COMMENTS > broulik wrote in foldermodel.cpp:124 > Why have this member then? For convenience > broulik wrote in foldermodel.cpp:194 > I think we shouldn't connect to the signals if we're not a containment? Yes, that makes sense, I will fix it REPOSITORY

D9323: Use ScreenMapper everywhere as a singleton

amantia added reviewers: Plasma, mwolff, hein. amantia set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D9313: Don't move back items to second screen if they were manually moved

amantia added reviewers: Plasma, hein, mwolff. amantia set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D9311: Create new items at the position where the context menu was invoked

amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9311 To: amantia, #plasma, broulik, hein, mwolff Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9307: Show newly created items on the right desktop

amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9307 To: amantia, #plasma, hein, mwolff, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9311: Create new items at the position where the context menu was invoked

amantia added reviewers: Plasma, broulik, hein, mwolff. amantia set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D9300: Store screenMapping info only once

amantia added a comment. I think it is better to store once, than 2-3 times (per desktop) as the data is the same. I'm not sure if the corona level is the best, although I don't see big problems with it. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D9307: Show newly created items on the right desktop

amantia added reviewers: Plasma, hein, mwolff, broulik. amantia set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D9300: Store screenMapping info only once

amantia updated this revision to Diff 23846. amantia added a comment. Add const REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9300?vs=23821=23846 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9300 AFFECTED FILES

D9300: Store screenMapping info only once

amantia added reviewers: Plasma, mwolff, hein, broulik. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9300 To: amantia, #plasma, mwolff, hein, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9300: Store screenMapping info only once

amantia created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Until now every FolderView applet stored exactly the same screenMapping info in the config file. Store it only once using the config

D8922: Avoid jumping of items toward right/botton when dropping

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c0f8856742a4: Avoid jumping of items toward right/botton when dropping (authored by amantia). Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.

D8915: Update the proxy to source and source to proxy mapping correctly

This revision was automatically updated to reflect the committed changes. Closed by commit R119:98d56d9135b1: Update the proxy to source and source to proxy mapping correctly (authored by amantia). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D8850: Support drag and drop between shared folder view containments

This revision was automatically updated to reflect the committed changes. Closed by commit R119:cc9c3d32a381: Support drag and drop between shared folder view containments (authored by mwolff, committed by amantia). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D8850: Support drag and drop between shared folder view containments

amantia updated this revision to Diff 23065. amantia added a comment. Rebased REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8850?vs=22868=23065 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8850 AFFECTED FILES

D8598: FolderView: position files at drop event target position

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e94888701c32: FolderView: position files at drop event target position (authored by mwolff, committed by amantia). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

  1   2   3   >