[frameworks-plasma] [Bug 457079] Remove "&" character from tooltip from Configure File Launcher icon

2022-07-24 Thread Andreas Sturmlechner
https://bugs.kde.org/show_bug.cgi?id=457079 Andreas Sturmlechner changed: What|Removed |Added CC||ast...@gentoo.org --- Comment #2 from

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

2020-09-16 Thread Andreas Sturmlechner
asturmlechner added a comment. In D23883#530551 , @davidedmundson wrote: > It only exists as a hack around some Qt5.9(?) bug to allow plasma stuff to be in wayland without needing us to force an environment variable. > Personally I want to

Re: Plasma 5.20 and Qt versions

2020-06-15 Thread Andreas Sturmlechner
On Fri, 12 Jun 2020 at 13:34, David Edmundson wrote: > We're in the process of determining our dependencies for Plasma 5.20, our > release in about 4 months. > > Ideally we would like to depend on Qt5.15, we can land some wayland fixes > that would be otherwise hard to #ifdef as well as do

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

2020-05-07 Thread Andreas Sturmlechner
asturmlechner added a comment. In D29514#665912 , @ngraham wrote: > In D29514#665911 , @asturmlechner wrote: > > > In D29514#665869 , @ngraham wrote: >

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

2020-05-07 Thread Andreas Sturmlechner
asturmlechner added a comment. In D29514#665869 , @ngraham wrote: > Hmm, on my system, the file is located at `/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find it: Where is synaptics-properties.h located on

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

2020-05-07 Thread Andreas Sturmlechner
asturmlechner closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29514 To: asturmlechner, #plasma, zzag Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf,

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

2020-05-07 Thread Andreas Sturmlechner
asturmlechner created this revision. asturmlechner added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. asturmlechner requested review of this revision. REVISION SUMMARY x11 backend of the touchpad KCM uses xserver-properties.h that is part of

D29215: synapticstouchpad.cpp: Drop synaptics-properties.h parent dir from include

2020-04-26 Thread Andreas Sturmlechner
asturmlechner closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29215 To: asturmlechner, #plasma, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham,

D29215: synapticstouchpad.cpp: Drop synaptics-properties.h parent dir from include

2020-04-26 Thread Andreas Sturmlechner
asturmlechner created this revision. asturmlechner added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. asturmlechner requested review of this revision. REVISION SUMMARY Otherwise, this does not get the header from Synaptics_INCLUDE_DIRS. TEST PLAN

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

2020-04-12 Thread Andreas Sturmlechner
asturmlechner added a comment. Thanks for keeping pipewire optional, this is in line with how we have been packaging xdg-desktop-portal-kde in Gentoo so far, we had just been conditionally disabling the cmake finding of these 3 libraries to do it, and will switch over to using the new

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

2019-10-16 Thread Andreas Sturmlechner
asturmlechner closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22210 To: asturmlechner, #plasma, davidedmundson, fvogt, ngraham Cc: ngraham, pino, rdieter, fvogt, davidedmundson, plasma-devel, crossi, LeGast00n, The-Feren-OS-Dev, jraleigh,

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

2019-10-15 Thread Andreas Sturmlechner
asturmlechner added a comment. In D22210#547637 , @davidedmundson wrote: > 1. A period where both X and wayland say "Plasma". > > 1 is super super bad. Which means we need to patch one of the Plasma entries first. I would block this

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

2019-10-15 Thread Andreas Sturmlechner
asturmlechner updated this revision to Diff 67992. asturmlechner added a comment. Switch back to Plasma (Wayland) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22210?vs=62165=67992 BRANCH arcpatch-D22210 REVISION DETAIL

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

2019-10-15 Thread Andreas Sturmlechner
asturmlechner added a comment. In D22210#547621 , @ngraham wrote: > "Plasma on Xorg" is a yucky string to display to users. well, it is what Gnome apparently does, so at least it would have lead to some uniformity. But no strong opinion

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

2019-09-12 Thread Andreas Sturmlechner
asturmlechner added a comment. copy that for Gentoo. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23883 To: heikobecker, #plasma Cc: davidedmundson, asturmlechner, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,

D23148: Add missing headers with DISABLE_MODEMMANAGER_SUPPORT=ON

2019-08-14 Thread Andreas Sturmlechner
asturmlechner closed this revision. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D23148 To: asturmlechner, jgrulich Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D23148: Add missing headers

2019-08-14 Thread Andreas Sturmlechner
asturmlechner created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. asturmlechner requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

2019-07-21 Thread Andreas Sturmlechner
asturmlechner updated this revision to Diff 62165. asturmlechner added a comment. drop translations, rename to 'Plasma on Xorg' REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22210?vs=60995=62165 BRANCH session-rename REVISION DETAIL

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

2019-07-20 Thread Andreas Sturmlechner
asturmlechner added a comment. FWIW, Gnome appear to be calling theirs 'Gnome on Xorg' (and likewise, just 'Gnome' for the wayland session). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22210 To: asturmlechner, #plasma, davidedmundson Cc: rdieter,

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

2019-07-15 Thread Andreas Sturmlechner
asturmlechner added a comment. I'll have to do this downstream, anyway... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22210 To: asturmlechner, #plasma, davidedmundson Cc: rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas,

D22214: doc: Some different phrasing, one instance of s/KDE/Plasma/

2019-07-04 Thread Andreas Sturmlechner
This revision was automatically updated to reflect the committed changes. Closed by commit R119:4dcd1588c1cf: doc: Some different phrasing, one instance of s/KDE/Plasma/ (authored by asturmlechner). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D22214: doc: Some different phrasing, one instance of s/KDE/Plasma/

2019-07-02 Thread Andreas Sturmlechner
asturmlechner created this revision. asturmlechner added a reviewer: Plasma. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. asturmlechner requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

2019-07-02 Thread Andreas Sturmlechner
asturmlechner added a comment. Well, what's the current situation - SDDM have made the decision on their part to append that tech-garbage for Wayland sessions, users end up with: - Plasma - Plasma (Wayland) Per linked issue it is not going to be like that forever; on every(?)

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

2019-07-02 Thread Andreas Sturmlechner
asturmlechner created this revision. asturmlechner added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. asturmlechner requested review of this revision. REVISION SUMMARY SDDM as of 0.18.1 appends " (Wayland)" to the Name of any session file it

D19011: Thunderbolt KCM and KDED module

2019-06-18 Thread Andreas Sturmlechner
asturmlechner added a comment. In D19011#480868 , @ngraham wrote: > and we should lobby distros to ship with the new repo/package. Provide a tarball and I'll gladly turn our git master ebuild into a release ebuild. ;) REPOSITORY R119

D8626: DDCUtil: Improved DDCUtil support for brightness control

2019-04-03 Thread Andreas Sturmlechner
asturmlechner added a comment. Hm, any reason why this is still pending? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D8626 To: dvogel, broulik, davidedmundson Cc: asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D18361: libkworkspace: Allow standalone build

2019-01-18 Thread Andreas Sturmlechner
asturmlechner added a comment. For the record, I would have been in support of this. ;) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18361 To: heikobecker Cc: asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D14147: Port from GConf to GSettings

2019-01-14 Thread Andreas Sturmlechner
asturmlechner added inline comments. INLINE COMMENTS > drosca wrote in CMakeLists.txt:46 > This should probably use cache variables: > > set(USE_GCONF FALSE CACHE STRING "Build with GConf") > set(USE_GSETTINGS TRUE CACHE STRING "Build with GSettings") this still needs to be addressed,

D16073: openconnect: add missing dependency Qt5Xml

2018-10-09 Thread Andreas Sturmlechner
This revision was automatically updated to reflect the committed changes. Closed by commit R116:6919a84c70d8: openconnect: add missing dependency Qt5Xml (authored by asturmlechner). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D16073: openconnect: add missing dependency Qt5Xml

2018-10-09 Thread Andreas Sturmlechner
asturmlechner added a comment. In D16073#340107 , @alexeymin wrote: > If it fixes build error `.../vpn/openconnect/openconnectauth.cpp:38:10: fatal error: QDomDocument: No such file or directory` then fine... Yes, it was exactly that:

D16073: openconnect: add missing dependency Qt5Xml

2018-10-09 Thread Andreas Sturmlechner
asturmlechner updated this revision to Diff 43221. asturmlechner added a comment. Only pull in Qt5Xml if OpenConnect is requested. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16073?vs=43220=43221 BRANCH Plasma/5.14 REVISION

D16073: openconnect: add missing dependency Qt5Xml

2018-10-09 Thread Andreas Sturmlechner
asturmlechner created this revision. asturmlechner added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. asturmlechner requested review of this revision. REVISION SUMMARY QDomDocument is imported from vpn/openconnect/openconnectauth.cpp TEST PLAN

D15435: Add translucent background attribute to desktop icon popup menu

2018-09-12 Thread Andreas Sturmlechner
This revision was automatically updated to reflect the committed changes. Closed by commit R119:cc47b95094a3: Add translucent background attribute to desktop icon popup menu (authored by anemeth, committed by asturmlechner). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D8267: Correcting symlinks between col- and row-resize and split_v and _hBug 384864

2018-07-18 Thread Andreas Sturmlechner
asturmlechner added a comment. ping - could we get this in for 5.14? REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D8267 To: ostroffjh, #plasma, apol Cc: tfoster, apol, asturmlechner, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D13255: Make dependency on KF5NetworkManagerQt optional

2018-06-12 Thread Andreas Sturmlechner
This revision was automatically updated to reflect the committed changes. Closed by commit R845:42723bb3cb70: Make dependency on KF5NetworkManagerQt optional (authored by arfrever, committed by asturmlechner). REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE

D13255: Make dependency on KF5NetworkManagerQt optional

2018-06-11 Thread Andreas Sturmlechner
asturmlechner updated this revision to Diff 35985. asturmlechner added a comment. Use Q_UNUSED REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13255?vs=35896=35985 BRANCH arcpatch-D13255 REVISION DETAIL https://phabricator.kde.org/D13255

D13255: Make dependency on KF5NetworkManagerQt optional

2018-06-09 Thread Andreas Sturmlechner
asturmlechner updated this revision to Diff 35896. asturmlechner added a comment. Update addressing 2/3 points raised REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13255?vs=35291=35896 BRANCH master REVISION DETAIL

D13255: Make dependency on KF5NetworkManagerQt optional

2018-05-31 Thread Andreas Sturmlechner
asturmlechner added a comment. (this is me forwarding a Gentoo user contribution) REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D13255 To: asturmlechner, #plasma, ivan Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D13255: Make dependency on KF5NetworkManagerQt optional

2018-05-31 Thread Andreas Sturmlechner
asturmlechner created this revision. asturmlechner added reviewers: Plasma, ivan. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. asturmlechner requested review of this revision. REPOSITORY R845 Plasma Vault BRANCH Plasma/5.13

D13188: Respect libdir for Firefox native messaging host manifest

2018-05-29 Thread Andreas Sturmlechner
asturmlechner created this revision. asturmlechner added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. asturmlechner requested review of this revision. REPOSITORY R856 Plasma Browser Integration BRANCH Plasma/5.13

D12547: Fix build with Qt 5.11 (missing QStyle)

2018-04-26 Thread Andreas Sturmlechner
asturmlechner closed this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D12547 To: asturmlechner, #plasma, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12547: Fix build with Qt 5.11 (missing QStyle)

2018-04-26 Thread Andreas Sturmlechner
asturmlechner created this revision. asturmlechner added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. asturmlechner requested review of this revision. REVISION SUMMARY Necessary after 6a9df821

D11794: Drop unused dependency

2018-03-30 Thread Andreas Sturmlechner
This revision was automatically updated to reflect the committed changes. Closed by commit R120:0a349abccb5f: Drop unused dependency (authored by asturmlechner). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11794?vs=30887=30917 REVISION DETAIL

D11794: Drop unused dependency

2018-03-29 Thread Andreas Sturmlechner
asturmlechner created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. asturmlechner requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D11794

D11413: Fix build with Qt 5.11 (missing headers)

2018-03-19 Thread Andreas Sturmlechner
asturmlechner abandoned this revision. asturmlechner added a comment. Obsolete by f83d0336a875f04361acb714c2eab490335d8d88 REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D11413 To:

D11413: Fix build with Qt 5.11 (missing headers)

2018-03-17 Thread Andreas Sturmlechner
asturmlechner created this revision. asturmlechner added a reviewer: ivan. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. asturmlechner requested review of this revision. REPOSITORY R845 Plasma Vault BRANCH master REVISION DETAIL

D10541: make kdesu available in bindir and thus $PATH by default (opt-out)

2018-02-15 Thread Andreas Sturmlechner
asturmlechner added a comment. > (so as to not conflict with kdelibs4's kdesu). I don't think you need to care about conflicts with kde-runtime at this point. There is no reason why on a Plasma-5 system the old binary should be present as it works like a drop-in replacement. REPOSITORY

D8267: Correcting symlinks between col- and row-resize and split_v and _hBug 384864

2018-02-11 Thread Andreas Sturmlechner
asturmlechner added a subscriber: apol. asturmlechner added a comment. It seems to me there was no change to these files since they were imported into this reporitory with 8ba33ca2a934dc1f2a34659eab1eef11f89c170c , so

Re: how to find kdesu?

2018-01-17 Thread Andreas Sturmlechner
On Wednesday, 17 January 2018 at 12:43, Harald Sitter wrote: > Should this bugger maybe be in bin/ rather than libexec/? Historically, it was moved around between bin and libexec at least once, but ultimately ended up in libexec because 'it should not be available in std. path'. (Some)

D8267: Correcting symlinks between col- and row-resize and split_v and _hBug 384864

2017-11-12 Thread Andreas Sturmlechner
asturmlechner added a comment. ping - anyone here to give a ship it? ;) REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D8267 To: ostroffjh, #plasma Cc: asturmlechner, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D7981: cmakeeditor.rb: kdoctools_install conditional on KF5DocTools_FOUND

2017-10-01 Thread Andreas Sturmlechner
asturmlechner closed this revision. REPOSITORY R572 releaseme REVISION DETAIL https://phabricator.kde.org/D7981 To: asturmlechner, #plasma, sitter, O2 releaseme Cc: palimaka, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7981: cmakeeditor.rb: kdoctools_install conditional on KF5DocTools_FOUND

2017-10-01 Thread Andreas Sturmlechner
asturmlechner added a comment. In https://phabricator.kde.org/D7981#149086, @sitter wrote: > Note that ki18n is also currently marked REQUIRED though. thanks, I'm not concerned about ki18n as I have not seen it being optional anywhere. REPOSITORY R572 releaseme BRANCH

D7981: cmakeeditor.rb: kdoctools_install conditional on KF5DocTools_FOUND

2017-09-25 Thread Andreas Sturmlechner
asturmlechner edited the summary of this revision. REPOSITORY R572 releaseme REVISION DETAIL https://phabricator.kde.org/D7981 To: asturmlechner, #plasma, sitter, O2 releaseme Cc: palimaka, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7981: cmakeeditor.rb: kdoctools_install conditional on KF5DocTools_FOUND

2017-09-25 Thread Andreas Sturmlechner
asturmlechner updated this revision to Diff 19901. asturmlechner added a comment. Owners added a reviewer: O2: releaseme. Re-added search for KF5DocTools REPOSITORY R572 releaseme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7981?vs=19893=19901 BRANCH master REVISION DETAIL

D7981: cmakeeditor.rb: kdoctools_install conditional on KF5DocTools_FOUND

2017-09-25 Thread Andreas Sturmlechner
asturmlechner added a comment. In https://phabricator.kde.org/D7981#148820, @sitter wrote: > This breaks repos which have no find_package call already. Fine, I can re-add that without REQUIRED keyword. Out of curiousity, do you know of an example? REPOSITORY R572 releaseme

D7981: cmakeeditor.rb: kdoctools_install conditional on KF5DocTools_FOUND

2017-09-25 Thread Andreas Sturmlechner
asturmlechner created this revision. asturmlechner added reviewers: Plasma, sitter. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Many packages have KF5DocTools optional, but as soon as a release is made that

D7756: Don't enter test subdirectories if BUILD_TESTING=OFF

2017-09-10 Thread Andreas Sturmlechner
This revision was automatically updated to reflect the committed changes. Closed by commit R320:ffc2a64d1f97: Don't enter test subdirectories if BUILD_TESTING=OFF (authored by asturmlechner). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D7756: Don't enter test subdirectories if BUILD_TESTING=OFF

2017-09-10 Thread Andreas Sturmlechner
asturmlechner created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Qt5Test is an optional dependency but not followed in some subdirs. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL

D6494: Drop unused dependencies KF5WindowSystem and KF5XmlGui

2017-08-20 Thread Andreas Sturmlechner
asturmlechner closed this revision. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D6494 To: asturmlechner, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6494: Drop unused dependencies KF5WindowSystem and KF5XmlGui

2017-08-15 Thread Andreas Sturmlechner
asturmlechner added a comment. So, now that the required change is in plasma-framework 5.37 I guess it would be safe for me to push - and also raise the minimum KF5 version to 5.37? REPOSITORY R118 Plasma SDK BRANCH master REVISION DETAIL https://phabricator.kde.org/D6494 To:

Re: kscreenlocker: loginctl/systemd

2017-08-10 Thread Andreas Sturmlechner
On Wednesday, 9 August 2017 at 14:00, Hartmut Goebel wrote: > Now when building kscreenlocker I get this message: > > -- The following RUNTIME packages have not been found: > > * loginctl , Send control commands to the login manager , >

D6175: Fix build with future glibc (major/minor macros), BSD compatible

2017-07-25 Thread Andreas Sturmlechner
This revision was automatically updated to reflect the committed changes. Closed by commit R108:35c278e52537: Fix build with future glibc (major/minor macros), BSD compatible (authored by asturmlechner). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D6175: Fix build with future glibc (major/minor macros), BSD compatible

2017-07-25 Thread Andreas Sturmlechner
asturmlechner updated this revision to Diff 17180. asturmlechner added a comment. Restricted Application edited projects, added Plasma; removed KWin. Switch to master REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6175?vs=15332=17180 BRANCH master

D6493: Add KF5WindowSystem to link interface

2017-07-19 Thread Andreas Sturmlechner
This revision was automatically updated to reflect the committed changes. Closed by commit R242:5033a104e226: Add KF5WindowSystem to link interface (authored by asturmlechner). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D6493: Add KF5WindowSystem to link interface

2017-07-18 Thread Andreas Sturmlechner
asturmlechner updated this revision to Diff 16896. asturmlechner added a comment. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Changed according to review REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D6495: Don't list KF5::WindowSystem in public libraries

2017-07-03 Thread Andreas Sturmlechner
asturmlechner added a comment. Thanks, works for me! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6495 To: davidedmundson, #plasma Cc: asturmlechner, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D6494: Drop unused dependencies KF5WindowSystem and KF5XmlGui

2017-07-03 Thread Andreas Sturmlechner
asturmlechner created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Depends on https://phabricator.kde.org/D6493 TEST PLAN Builds fine. REPOSITORY R118 Plasma SDK BRANCH master REVISION DETAIL

D6175: Fix build with future glibc (major/minor macros), BSD compatible

2017-06-11 Thread Andreas Sturmlechner
asturmlechner added a comment. In https://phabricator.kde.org/D6175#115496, @graesslin wrote: > If I understand correctly this is no longer a change suited for the 5.8 branch. Okay, then I guess 5.10 would be it? REPOSITORY R108 KWin REVISION DETAIL

D6175: Fix build with future glibc (major/minor macros), BSD compatible

2017-06-10 Thread Andreas Sturmlechner
asturmlechner created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY Also adding sys/types.h which is not implicitly included from all over. Thanks-to: [ade] in #kde-devel See also:

D5853: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally

2017-05-17 Thread Andreas Sturmlechner
asturmlechner added a comment. Should this be picked for 5.8 branch as well? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D5853 To: asturmlechner, #plasma, mart Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,

D5853: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally

2017-05-17 Thread Andreas Sturmlechner
This revision was automatically updated to reflect the committed changes. Closed by commit R98:0a34d8667c6e: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally (authored by asturmlechner). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE

D5853: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally

2017-05-17 Thread Andreas Sturmlechner
asturmlechner added a comment. Yes, I have commit access - it just happens to be my first use of arcanist instead of rbtools - can I git push straight to Plasma/5.10 branch? REPOSITORY R98 Breeze for Gtk BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D5853 To:

D5853: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally

2017-05-14 Thread Andreas Sturmlechner
asturmlechner created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY GTK will search /usr/share/themes//gtk- and then earlier versions all the way back to 3.0. See also:

Re: Re: DrKonqi dependencies

2017-03-26 Thread Andreas Sturmlechner
On Sunday, 19 March 2017 at 16:22, Martin Gräßlin wrote: > Am 2017-03-19 14:19, schrieb Kai Uwe Broulik: > > I'd be fine with splitting drkonqi into its own repository, René > > recently brought this up as well. > > Ideally it would be part of KF5, e.g. a kcrash-runtime tier-3 repo. So how

Re: Re: DrKonqi dependencies

2017-03-19 Thread Andreas Sturmlechner
commit 1ee858f194fd2c8dcb2cbd3f436fffe7207ba0cc Author: Andreas Sturmlechner <andreas.sturmlech...@gmail.com> Date: Sun Mar 19 12:54:34 2017 +0100 drkonqi: Standalone sub-project diff --git a/drkonqi/CMakeLists.txt b/drkonqi/CMakeLists.txt index cdae1d49..3923a8f4 100644 --- a/drkonqi/CMakeLis

Re: DrKonqi dependencies

2017-03-19 Thread Andreas Sturmlechner
On 19.03.2017 11:56, Christoph Feck wrote: > Using openSUSE packages here, installing drkonqi does not drag in the > Plasma workspace, only some KF5 frameworks. So the splitting can also be > done by the distribution. Them fixing it in packaging does not make it right though. Everone building

Re: Review Request 122209: [plasma-workspace] Make tests optional

2017-02-08 Thread Andreas Sturmlechner
/CMakeLists.txt d502cb82516e85a76685d7e3d7106a41dcf0cfff Diff: https://git.reviewboard.kde.org/r/122209/diff/ Testing --- Built with (all successful) and without tests. Thanks, Andreas Sturmlechner

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

2017-01-15 Thread Andreas Sturmlechner
marked as submitted. Review request for Plasma, Ivan Čukić and Martin Koller. Changes --- Submitted with commit b1243563fa2f5a07db6b8a26c966874bfd1c27dd by Andreas Sturmlechner to branch master. Repository: kio-extras Description --- 2 commits: - Make activities kioslave optional

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

2017-01-15 Thread Andreas Sturmlechner
marked as submitted. Review request for Plasma, Ivan Čukić and Martin Koller. Changes --- Submitted with commit b1243563fa2f5a07db6b8a26c966874bfd1c27dd by Andreas Sturmlechner to branch master. Repository: kio-extras Description --- 2 commits: - Make activities kioslave optional

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

2017-01-15 Thread Andreas Sturmlechner
. - Make KF5Html dependency optional: only used by man Diffs (updated) - CMakeLists.txt ba41101bb0cb247e55ded79224cd6bbbeb3f6b20 Diff: https://git.reviewboard.kde.org/r/129783/diff/ Testing --- Thanks, Andreas Sturmlechner

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

2017-01-07 Thread Andreas Sturmlechner
eed prettier, thanks. - Andreas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129783/#review101846 --- On Jan. 7, 2017, 12:38

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

2017-01-07 Thread Andreas Sturmlechner
dependency optional: only used by man Diffs (updated) - CMakeLists.txt ba41101bb0cb247e55ded79224cd6bbbeb3f6b20 Diff: https://git.reviewboard.kde.org/r/129783/diff/ Testing --- Thanks, Andreas Sturmlechner

Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

2017-01-06 Thread Andreas Sturmlechner
ba41101bb0cb247e55ded79224cd6bbbeb3f6b20 Diff: https://git.reviewboard.kde.org/r/129783/diff/ Testing --- Thanks, Andreas Sturmlechner

Re: Review Request 129725: [sddm-kcm] Drop unused dependency

2016-12-30 Thread Andreas Sturmlechner
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 5755bf5743758333efc1961a04aeae76163dd326 by Andreas Sturmlechner to branch Plasma/5.8. Repository: sddm-kcm Description --- Drop unused dependency Diffs - CMakeLists.txt

Review Request 129725: [sddm-kcm] Drop unused dependency

2016-12-29 Thread Andreas Sturmlechner
--- Drop unused dependency Diffs - CMakeLists.txt 24d7239ef3df342b330c55670085cdb04621348f Diff: https://git.reviewboard.kde.org/r/129725/diff/ Testing --- Thanks, Andreas Sturmlechner

Re: Review Request 128957: Make KF5Baloo optional

2016-11-04 Thread Andreas Sturmlechner
marked as submitted. Review request for Plasma and David Edmundson. Changes --- Submitted with commit 2b7258fdd86bff594799a154f651ce396c4e69a8 by Andreas Sturmlechner to branch master. Repository: plasma-desktop Description --- https://mail.kde.org/pipermail/kde-frameworks-devel

Re: Review Request 128957: Make KF5Baloo optional

2016-10-20 Thread Andreas Sturmlechner
/ Testing --- Several days of Plasma-5 without any issues. Usage of krunner without any segfaults. Thanks, Andreas Sturmlechner

Re: Review Request 128956: Make KF5Baloo optional

2016-10-20 Thread Andreas Sturmlechner
marked as submitted. Review request for Plasma. Changes --- Submitted with commit dfefc273af38b9031ba596c20c52165ae4d2b6c3 by Andreas Sturmlechner to branch master. Repository: plasma-workspace Description --- https://mail.kde.org/pipermail/kde-frameworks-devel/2016-September

Re: Review Request 128956: Make KF5Baloo optional

2016-10-09 Thread Andreas Sturmlechner
- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128956/#review99882 --- On Sept. 20, 2016, 12:06 p.m., Andreas Sturmlechner wrote: > > ---

Re: Review Request 128956: Make KF5Baloo optional

2016-10-09 Thread Andreas Sturmlechner
> On Sept. 20, 2016, 12:10 p.m., David Edmundson wrote: > > >Usage of krunner without any segfaults. > > > > You can just disable it with the provided checkbox, you don't gain anything > > from disabling it at compile time. > > Andreas Sturmlechner wrot

Re: Review Request 128956: Make KF5Baloo optional

2016-10-08 Thread Andreas Sturmlechner
> On Sept. 20, 2016, 12:29 p.m., Marco Martin wrote: > > -1, would mean one code path/build config option to maintain for us > > Andreas Sturmlechner wrote: > I would understand if Plasma did much more with Baloo. But I don't see > that right now, it enables two ra

Re: Review Request 128956: Make KF5Baloo optional

2016-10-08 Thread Andreas Sturmlechner
> On Sept. 20, 2016, 12:10 p.m., David Edmundson wrote: > > >Usage of krunner without any segfaults. > > > > You can just disable it with the provided checkbox, you don't gain anything > > from disabling it at compile time. > > Andreas Sturmlechner wrot

Re: Review Request 128956: Make KF5Baloo optional

2016-09-20 Thread Andreas Sturmlechner
it: https://git.reviewboard.kde.org/r/128956/#review99320 --- On Sept. 20, 2016, 12:06 p.m., Andreas Sturmlechner wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 128956: Make KF5Baloo optional

2016-09-20 Thread Andreas Sturmlechner
> On Sept. 20, 2016, 12:10 p.m., David Edmundson wrote: > > >Usage of krunner without any segfaults. > > > > You can just disable it with the provided checkbox, you don't gain anything > > from disabling it at compile time. > > Andreas Sturmlechner wrot

Re: Review Request 128956: Make KF5Baloo optional

2016-09-20 Thread Andreas Sturmlechner
.kde.org/r/128956/#review99316 --- On Sept. 20, 2016, 12:06 p.m., Andreas Sturmlechner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Review Request 128957: Make KF5Baloo optional

2016-09-20 Thread Andreas Sturmlechner
cf2e79a8eaf12c944fea845ff688840a561abf6b kcms/CMakeLists.txt 53ca49a4d17a05c3d8d9a6a4c2e37a6ec0fd9284 Diff: https://git.reviewboard.kde.org/r/128957/diff/ Testing --- Several days of Plasma-5 without any issues. Usage of krunner without any segfaults. Thanks, Andreas Sturmlechner

Review Request 128956: Make KF5Baloo optional

2016-09-20 Thread Andreas Sturmlechner
9da918358bd797b8fe00de646b6576ba22976d0e runners/CMakeLists.txt 48cc3799f834a57031ae387a35f41859178fe317 Diff: https://git.reviewboard.kde.org/r/128956/diff/ Testing --- Several days of Plasma-5 without any issues. Usage of krunner without any segfaults. Thanks, Andreas Sturmlechner

Re: Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

2016-08-02 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128576/#review98020 --- Works for me, thanks! - Andreas Sturmlechner On Aug. 2

Review Request 127662: [kwin] Fix build with future glibc (major/minor macros)

2016-04-16 Thread Andreas Sturmlechner
://git.reviewboard.kde.org/r/127662/diff/ Testing --- builds fine with older glibc (tested with glibc-2.21) as well as a patched glibc-2.23 with the removal already implemented. Thanks, Andreas Sturmlechner ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 127365: [plasma-sdk] Make Qt5Test really optional, fix plasmate dependencies

2016-03-23 Thread Andreas Sturmlechner
marked as submitted. Review request for Plasma. Changes --- Submitted with commit a3176e4ef2f09c766e22bceb0855beff8fe2f344 by Andreas Sturmlechner to branch master. Repository: plasma-sdk Description --- KF5NewStuff, KF5Parts are only required for plasmate. Could not push

  1   2   >