D11065: [Active Window Control] Slightly fix vertical alignment of window name

2018-03-11 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R884 Active Window Control Applet for Plasma BRANCH realign REVISION DETAIL https://phabricator.kde.org/D11065 To: Pitel, #plasma, martinkostolny Cc: abetts, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol,

D11064: add preview images to fonts kcm

2018-03-06 Thread Andres Betts
abetts added a comment. I would use this as a guide https://community.kde.org/KDE_Visual_Design_Group/HIG/Color And I would select Icon Grey for the header and Shade Black for the text below. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064

D11064: add preview images to fonts kcm

2018-03-06 Thread Andres Betts
abetts added a comment. In D11064#220118 , @progwolff wrote: > Seems like VDG is happy then :D > Many thanks to both of you! > > @davidedmundson Any objections left? I don't have any objections. I would say, however, keep an

D11064: add preview images to fonts kcm

2018-03-06 Thread Andres Betts
abetts added a comment. In D11064#220102 , @progwolff wrote: > We don't have a font name here. The choices are always "Vendor default", "None", "RGB", "BGR", "vertical RGB", "vertical BGR". > I am not sure what a number would mean here?

D11064: add preview images to fonts kcm

2018-03-06 Thread Andres Betts
abetts added a comment. You are right! I was confused. Looks great then! Would having a font number on the side help? Like this 12 **Font Name** A quick brown fox jumps over the rope REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To:

D11064: add preview images to fonts kcm

2018-03-06 Thread Andres Betts
abetts added a comment. That seems pretty good to me. I would even make the title label bigger, so that it looks like a header. Also, can the list be longer? At least, double the size? People tend to have a lot of fonts installed. We install a lot of them by default. This can help the

D11064: add preview images to fonts kcm

2018-03-06 Thread Andres Betts
abetts added a comment. > F5743165: Screenshot_20180306_101833.png I like this one! :D above REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: ngraham,

D11063: [mediacontroller applet] Reorder elements

2018-03-06 Thread Andres Betts
abetts added a comment. Not sure if it is within the scope of this patch but the spacing is uneven vertically between elements in the notification window. They need more space to breathe. Media Player Cover Artwork Progress Bar | | Song Title | | Media

D11064: add preview images to fonts kcm

2018-03-06 Thread Andres Betts
abetts added a comment. Number 2 seems like the best option. I would also make sure that there is a color difference between title label and sample text. That way it is easier to distinguish between list items. When all labels are the same color, you give equal importance to all elements.

D11064: add preview images to fonts kcm

2018-03-05 Thread Andres Betts
abetts added a comment. Thanks so much for your work! As I am not a developer, as you progress with the patch, can you also please post screenshots? Just so I get where your work is going. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff,

D11064: add preview images to fonts kcm

2018-03-05 Thread Andres Betts
abetts added a comment. Thank you for this. This is what I thought was best. It is a method that many applications use. It is straightforward and quick. Is there a way that the list width can be dynamic so as to accommodate the name of the font family? Sometimes font families are very long.

D10243: Improve visibility of disconnected Wi-Fi icons

2018-03-02 Thread Andres Betts
abetts added a comment. In D10243#217109 , @andreask wrote: > F5736934: network.svgz > > sorry I'm not the maintainer for the breeze plasma theme and arc isn't my friend so I upload the svg file with

D10475: Make it possible to show the title despite having ctx actions

2018-02-22 Thread Andres Betts
abetts added a comment. I am in favor of placing the Titles right aligned, but only if we don't put more than 1 control to the right of the title. If we can't compromise on that, another option is to keep titles center-aligned. REPOSITORY R169 Kirigami REVISION DETAIL

D10429: Disable the title bar separator by default

2018-02-21 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10429 To: fvogt, #vdg, #plasma, ngraham Cc: abetts, rizzitello, mmustac, broulik, anthonyfieroni, januz, rikmills, anemeth, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D10500: Make the review pop-up a bit more user-friendly

2018-02-15 Thread Andres Betts
abetts added a comment. Looks good to me. I would change the hover animation. Most places that use star ratings tend to highlight all stars up to where your cursor is located. It gives the impression that you are also enabling the starts up to your location. If your cursor is in the fourth

D10483: Polish ToolBarApplicationHeader appearance

2018-02-13 Thread Andres Betts
abetts added a comment. Sorry guys, this proposed left alignment just won't work IMHO. The reason is that we are turning the bar into a CSD. Unlike a desktop application, we don't have the ability to shrink the application in mobile. What this amounts to is that people will want to add more

D10438: increase left/right margin of menuitems

2018-02-12 Thread Andres Betts
abetts added a comment. In D10438#205009 , @ngraham wrote: > Let's try to avoid radical proposals like getting rid of keyboard shortcuts and icons. For now, let's focus on the initial goal, or perhaps a slightly modified goal of adding room to

D10438: increase left/right margin of menuitems

2018-02-12 Thread Andres Betts
abetts added a comment. How are we accounting for stacking menu items that have: Checkbox - Item Icon - Label -- Shortcut-Arrow Icon The first part of that tends to make the checkbox be closest to the edge. Are we thinking we should/not use icons in menus, keep the same? REPOSITORY

D10438: increase left/right margin of menuitems

2018-02-11 Thread Andres Betts
abetts added a comment. This could work, just the left padding is too much in this patch. Maybe reduce by a 3rd? or Half? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc: abetts, anemeth, plasma-devel,

D10337: First approach to a plasmoid that can display the state of caps lock

2018-02-06 Thread Andres Betts
abetts added a comment. Does this have a look yet? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10337 To: apol, #plasma, jriddell Cc: abetts, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

2018-01-31 Thread Andres Betts
abetts added a comment. In https://phabricator.kde.org/D10170#198634, @ngraham wrote: > Eh, maybe I'm wrong. Still... [shakes old man stick] I don't like it! These whippersnappers and their transparency! Back in my day things were opaque and we liked it that way! > > I won't die on

D10170: Added optional transparency/blur to menu frames

2018-01-31 Thread Andres Betts
abetts removed a reviewer: VDG. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma Cc: abetts, colomar, andreask, zzag, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

2018-01-31 Thread Andres Betts
abetts added subscribers: andreask, colomar, abetts. abetts added a comment. In https://phabricator.kde.org/D10170#198471, @hpereiradacosta wrote: > Hello, > Hi, > thanks for the patch ! > > Few comments: > 1/ the code does not compile under kde4 (cmake -DUSE_KDE4). You

D10170: Added optional transparency/blur to menu frames

2018-01-31 Thread Andres Betts
abetts removed a reviewer: abetts. This revision now requires review to proceed. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, #vdg Cc: zzag, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10170: Added optional transparency/blur to menu frames

2018-01-31 Thread Andres Betts
abetts accepted this revision. This revision is now accepted and ready to land. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, #vdg, abetts Cc: zzag, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

2018-01-26 Thread Andres Betts
abetts added a comment. Is this change purely a conversation of what developers use in code to call up fonts in their applications? Or does this also include a discussion where regular users have interfaces that allow changes to font naming? Let's say, something like System Settings that

D10096: Softer shadow on the screenshots

2018-01-25 Thread Andres Betts
abetts added a comment. I like it, it is definitively softer. The horizontal length could be shrunk a bit. Maybe 150, or 100? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10096 To: apol, ngraham Cc: abetts, plasma-devel, ZrenBot, progwolff,

D10032: Swap play/pause icons in mediacontroller plasmoid

2018-01-23 Thread Andres Betts
abetts added a comment. Could you please share a screenshot of the issue? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10032 To: nicolasfella, #plasma, #vdg Cc: abetts, davidedmundson, broulik, ngraham, plasma-devel, #vdg, ZrenBot, progwolff,

D9984: WIP: Add bookmarks runner

2018-01-23 Thread Andres Betts
abetts added a comment. I like this idea. Can the bookmark list be offloaded to a temp file while the browser isn't running? REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D9984 To: broulik, #plasma, #vdg, davidedmundson Cc: abetts, mart,

D9878: [Notifications] Keep notification popup open when covered by fullscreen window

2018-01-23 Thread Andres Betts
abetts added a comment. I am in favor of this idea visually. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9878 To: broulik, #plasma, hein, graesslin, #vdg Cc: abetts, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10027: Removed duplicate preview screenshots

2018-01-22 Thread Andres Betts
abetts accepted this revision. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10027 To: anemeth, apol, #discover_software_store, davidedmundson, abetts Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10002: Improve header and screenshots

2018-01-20 Thread Andres Betts
abetts accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10002 To: ngraham, apol, abetts, andreaska, colomar, #discover_software_store, #vdg Cc: plasma-devel,

D9414: Implement OSD to select action when unknown monitors is connected

2018-01-16 Thread Andres Betts
abetts added a comment. Will this OSD need any kind of styling? Or will we just use what was shown above in the screenshot? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9414 To: dvratil, sebas, davidedmundson, #vdg Cc: abetts, broulik, kamathraghavendra,

D9792: even slimmer scrollbars

2018-01-10 Thread Andres Betts
abetts accepted this revision. abetts added a comment. This revision is now accepted and ready to land. I like it. I think it falls in line with a less obtrusive bar and one that demands attention. REPOSITORY R31 Breeze BRANCH phab/slimScrollbars REVISION DETAIL

D9773: Use 1px padding on titlebuttons

2018-01-09 Thread Andres Betts
abetts added a comment. In https://phabricator.kde.org/D9773#188482, @tomanderson wrote: > Thanks Andres. Could you also merge this CL for me? I don't have write permissions for the repo. Hey Tom, Thanks for the comment. I will leave this to the dev team. My vote was as

D9773: Use 1px padding on titlebuttons

2018-01-09 Thread Andres Betts
abetts accepted this revision. This revision is now accepted and ready to land. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D9773 To: tomanderson, #breeze, abetts Cc: plasma-devel, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

2018-01-05 Thread Andres Betts
abetts accepted this revision. abetts added a comment. Thanks guys! REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9627 To: ngraham, #vdg, #breeze, hpereiradacosta, abetts Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

2018-01-05 Thread Andres Betts
abetts added a comment. In https://phabricator.kde.org/D9627#186584, @hpereiradacosta wrote: > In https://phabricator.kde.org/D9627#186582, @abetts wrote: > > > Would you consider changing the word "Normal" for something more related to measurements? For example, regular, default,

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

2018-01-05 Thread Andres Betts
abetts added a comment. Would you consider changing the word "Normal" for something more related to measurements? For example, regular, default, current. Normal works better in other languages like Spanish where it is related to measurements. In English that link is not as strong.

D9638: [effects] add 'Slide Desktops' effect

2018-01-03 Thread Andres Betts
abetts added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9638#185606, @zzag wrote: > In https://phabricator.kde.org/D9638#185547, @abetts wrote: > > > What I would maybe want to add would be some sort of effect,

D9637: Add jump list action for "Updates"

2018-01-03 Thread Andres Betts
abetts accepted this revision. abetts added a comment. This revision is now accepted and ready to land. I like this, seems very intuitive, in a corner, less thinking in selecting the item. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9637 To:

D9627: Reduce menu shadows to half the size of the window shadows

2018-01-03 Thread Andres Betts
abetts accepted this revision. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9627 To: ngraham, #vdg, #breeze, hpereiradacosta, abetts Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

2018-01-03 Thread Andres Betts
abetts added a comment. Restricted Application edited projects, added KWin; removed Plasma. This is great work. I like the results. I like the gap as well. It makes for a good idea of separation. What I would maybe want to add would be some sort of effect, darkening, or slight zooming in/out

D9549: Horizontally center shadows and make them bigger

2018-01-02 Thread Andres Betts
abetts added a comment. The only thing that we could address later is that the concentration of this shadow for the menus makes it so that the shadows become a tad darker. Since the space they have to spread in is smaller, the colors combine a little bit making the shadow be more

D9391: [effects] Add 'Fullscreen' effect

2017-12-31 Thread Andres Betts
abetts added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9391#184475, @zzag wrote: > In https://phabricator.kde.org/D9391#184440, @abetts wrote: > > > Could you please post a new video with a before and after? I would

D9549: Horizontally center shadows and make them bigger

2017-12-31 Thread Andres Betts
abetts added a comment. In https://phabricator.kde.org/D9549#184487, @hpereiradacosta wrote: > In https://phabricator.kde.org/D9549#184007, @abetts wrote: > > > @hpereiradacosta I feel this is a good direction for the theme. I am sure we can evolve it to fit new ideas. > > >

D8232: Add option to center shadow

2017-12-31 Thread Andres Betts
abetts added a comment. In https://phabricator.kde.org/D8232#184486, @hpereiradacosta wrote: > In https://phabricator.kde.org/D8232#184470, @abetts wrote: > > > In https://phabricator.kde.org/D8232#183783, @ngraham wrote: > > > > > Per recent https://phabricator.kde.org/tag/vdg/

D8232: Add option to center shadow

2017-12-31 Thread Andres Betts
abetts added a comment. In https://phabricator.kde.org/D8232#183783, @ngraham wrote: > Per recent https://phabricator.kde.org/tag/vdg/ discussions, I've put together a patch that changes the defaults to horizontally center window and menu shadows, and make them a bit larger:

D9391: [effects] Add 'Fullscreen' effect

2017-12-31 Thread Andres Betts
abetts added a comment. Restricted Application edited projects, added KWin; removed Plasma. Could you please post a new video with a before and after? I would like to preview it. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9391 To: zzag, #kwin, #plasma, graesslin

D9549: Horizontally center shadows and make them bigger

2017-12-31 Thread Andres Betts
abetts added a comment. In https://phabricator.kde.org/D9549#184434, @hpereiradacosta wrote: > In https://phabricator.kde.org/D9549#184334, @cfeck wrote: > > > I remember the shadows were made thin on the left so that cascading popup menus look smoother. > > > Hello christoph,

D9549: Horizontally center shadows and make them bigger

2017-12-29 Thread Andres Betts
abetts added a comment. @hpereiradacosta I feel this is a good direction for the theme. I am sure we can evolve it to fit new ideas. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9549 To: ngraham, abetts, hpereiradacosta, #vdg, #breeze Cc: januz,

D9549: Horizontally center shadows and make them bigger

2017-12-29 Thread Andres Betts
abetts added a comment. In https://phabricator.kde.org/D9549#183809, @apol wrote: > In https://phabricator.kde.org/D9549#183807, @mvourlakos wrote: > > > Dont merge please, this needs authorization from VDG first > > > @ngraham and @abetts are the VDG, no? Last I checked

D9549: Horizontally center shadows and make them bigger

2017-12-29 Thread Andres Betts
abetts accepted this revision. abetts added a comment. This revision is now accepted and ready to land. I love it! People, please accept. Just notice how the depth perception works better this way. With the current implementation, shadows don't show a strong depth perception and they almost

D9474: [Kickoff / Kicker] Move "Add to favorites" entry to the bottom of the context menu

2017-12-27 Thread Andres Betts
abetts added a comment. Can you post an image of what this will look like? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9474 To: broulik, #plasma, hein, ivan Cc: abetts, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D9324: [Air theme] Add task bar progress graphic

2017-12-14 Thread Andres Betts
abetts added a comment. What should be the move here? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9324 To: broulik, #plasma, #vdg, ngraham Cc: abetts, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D9201: Slightly reduce vertical gutter width.

2017-12-12 Thread Andres Betts
abetts added a comment. Does the grid and spacing cover only the areas in yellow, or does it cover the entire screen? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9201 To: hein, #plasma Cc: abetts, Zren, plasma-devel, ZrenBot, progwolff, lesliezhai,

D9284: Make it obvious what "Display window borders for maximized windows" is for

2017-12-12 Thread Andres Betts
abetts added a comment. Looks good! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9284 To: ngraham, hpereiradacosta, #breeze, #vdg Cc: abetts, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D9215: Make Appmenu work based on the presence of a visual representation

2017-12-12 Thread Andres Betts
abetts added a comment. Is there a screenshot of this change? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9215 To: mart, #plasma, davidedmundson Cc: abetts, davidedmundson, ngraham, mvourlakos, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai,

D8787: Fix PWD dialog

2017-12-05 Thread Andres Betts
abetts added a comment. In https://phabricator.kde.org/D8787#176346, @ivan wrote: > Since VDG has not responded. Can you remove the padding and make the name bold? What was the question exactly? REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8787

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

2017-11-21 Thread Andres Betts
abetts added a comment. **These are the good examples of what I think it should be:** TITLE [ ] Verb/action explanation TITLE [ ] verb/explanation **IF** [ ] verb/explanation **But never** Verb/Explanation [X ] Verb/Explanation [X ] verb/explanation

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

2017-11-20 Thread Andres Betts
abetts added a comment. I am ok with that idea. I agree that it is redundant. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc: ngraham, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai,

D8869: Don't use a scrollview to display package changelogs

2017-11-17 Thread Andres Betts
abetts added a comment. What's the point of having the "open" button if this scrollview is accepted? After all, you won't see much more if you click open and an install button and a package description. REPOSITORY R134 Discover Software Store REVISION DETAIL

D8849: [Folder View Filter Config] Use TableView for mime types

2017-11-16 Thread Andres Betts
abetts added a comment. In https://phabricator.kde.org/D8849#168791, @hein wrote: > I like it, but should the default sort column be the name so that there's no awkward arrow in the header element for the checkboxes? > > I feel like QWidget views or rather QStandardItemDelegate avoid

D8754: Baloo KCM text improvements

2017-11-10 Thread Andres Betts
abetts added a comment. I think that people these days understand that indexing your files is a component of searching. If the word indexing is not liked, maybe it could be Capture file content data Read file content data Record file content data Etc. I would also suggest

D8684: text improvements for Colors, Icons, Style, and Workspace KCMs

2017-11-07 Thread Andres Betts
abetts accepted this revision. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D8684 REVISION DETAIL https://phabricator.kde.org/D8684 To: ngraham, abetts, #vdg, #plasma, #documentation, apol Cc: lueck, apol, plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8361: Add option to change Oxygen's windows decoration shadow intensity

2017-11-07 Thread Andres Betts
abetts added a comment. In https://phabricator.kde.org/D8361#165580, @ngraham wrote: > Yeah, maybe a combobox toggling between Glow and Shadow styles/blending modes would be more intuitive here. That's what I mean. REPOSITORY R113 Oxygen Theme REVISION DETAIL

D8361: Add option to change Oxygen's windows decoration shadow intensity

2017-11-07 Thread Andres Betts
abetts accepted this revision as: abetts. abetts added a comment. This revision is now accepted and ready to land. I like this change, I think it makes sense. However, if there is a way to know that the user "means" to use shadow then lets do this. If the user means to do "glow" this

D8684: text improvements for Colors, Icons, Style, and Workspace KCMs

2017-11-06 Thread Andres Betts
abetts added a comment. Just on the first image "Inactive selection changes color" to "Change colors for inactive selection" Just to make sure that the checkbox starts with a verb. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D8684 REVISION DETAIL

D8686: Screenlocker KCM text improvements

2017-11-06 Thread Andres Betts
abetts accepted this revision. abetts added a comment. This revision is now accepted and ready to land. I would agree, keyboard shortcut seems better. It just felt like the label didn't have context for the shortcut button next to it. REPOSITORY R133 KScreenLocker BRANCH master

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-11-05 Thread Andres Betts
abetts accepted this revision. abetts added a comment. This revision is now accepted and ready to land. I don't have any objections to this revision. If you used one of the suggested colors for text. Let's go for the change. REPOSITORY R31 Breeze BRANCH arcpatch-D7424 REVISION DETAIL

D8006: Add edit button to desktop theme

2017-11-02 Thread Andres Betts
abetts added a comment. Well, looks like there are no objections... hehe REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8006 To: davidedmundson, #plasma Cc: abetts, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas,

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-10-31 Thread Andres Betts
abetts added a comment. Seems good to me. @jensreuterberg ? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7424 To: ngraham, hpereiradacosta, jensreuterberg, jriddell, kvermette, #vdg Cc: abetts, januz, progwolff, broulik, sebas, plasma-devel, ZrenBot, lesliezhai,

D7957: Turn on frames around dock widgets by default

2017-10-29 Thread Andres Betts
abetts added a comment. In https://phabricator.kde.org/D7957#161647, @ngraham wrote: > The shadow seems a bit gratuitous to me, but I have to say I do like the extra borders and the nice explicit separator between Panels. Maybe another idea, instead of shadows is changing the

D7957: Turn on frames around dock widgets by default

2017-10-29 Thread Andres Betts
abetts added a comment. I would even go as far as doing this: F5457461: Shadows.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7957 To: ngraham, #breeze, #vdg Cc: abetts, broulik, emmanuelp, elvisangelaccio,

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-10-29 Thread Andres Betts
abetts added a comment. Do you know if your colors match any of these? Color HIG If it doesn't or one of those colors can't work for you, we would need to have a bigger discussion with the team about that since it would

D8424: Folder View location properties: Improve visual layout

2017-10-25 Thread Andres Betts
abetts added a comment. I like this, I would even place the "title" to align with "location" and push the combobox where it says "none" to align with the radial buttons. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8424 To: marten, #plasma, hein Cc:

D8232: Add option to center shadow

2017-10-14 Thread Andres Betts
abetts added a comment. That's a cool idea. I would just try to make it smoother. The proposals still look pretty rough. I don't know programming, but can you tell me the current parameters to create the shadow with this patch? Blur, spread, color? REPOSITORY R31 Breeze REVISION DETAIL

D7765: make krunner accessible

2017-09-12 Thread Andres Betts
abetts added a comment. In https://phabricator.kde.org/D7765#144777, @mart wrote: > - better navigation Can I help in this area? Does it mean visual design? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7765 To: mart, #plasma, davidedmundson,

D6061: prototype of kactivity-based most used modules entries

2017-06-01 Thread Andres Betts
abetts added a comment. In https://phabricator.kde.org/D6061#113477, @mart wrote: > first page look as per vdg suggestion > F3773242: Spectacle.y10298.png I would like to suggest making the system settings icon 512 and the row of 5 icons

Re: Selecting a Plasma logo

2016-08-08 Thread Andres Betts
Hey Sebastian, Let me explain the reasons about changing the logo and what stage this is at. In my personal view, after working for some time on coming up with a new logo proposal, we received a few comments and changes to it that, to me, had no backing. One idea was shared that others wanted my

Re: Selecting a Plasma logo

2016-08-08 Thread Andres Betts
de.org) wrote: > Hi Andres, > > Sorry it took a few days to reply. > > On dinsdag 2 augustus 2016 07:45:10 CEST Andres Betts wrote: > > Let me explain the reasons about changing the logo and what stage this is > at. In my personal view, after working for some time on comin

Re: RFC: Use Grid as default for KWin's Presnt windows effect

2015-01-09 Thread Andres Betts
to name each window. --  Andres Betts On January 9, 2015 at 9:17:39 AM, Martin Klapetek (martin.klape...@gmail.com) wrote: Hey there, so I've been thinking about the Present Windows effect of KWin. The default setting for laying the windows out is currently Natural, but to me that layout

Re: RFC: Use Grid as default for KWin's Presnt windows effect

2015-01-09 Thread Andres Betts
it there if you wanted extra input. --  Andres Betts On January 9, 2015 at 9:32:55 AM, Martin Klapetek (martin.klape...@gmail.com) wrote: On Fri, Jan 9, 2015 at 5:24 PM, Andres Betts anditosan1...@gmail.com wrote: My only objection to that is that the grid will end up making the each window generally

<    1   2   3   4