Re: Review Request: More improvements to the Fifteen puzzle

2010-10-26 Thread Anthony Bryant
is important :) Good point, thanks. I've just fixed in my local copy. I'll commit in a few minutes. - Anthony --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5617/#review8359

Re: Review Request: More improvements to the Fifteen puzzle

2010-10-25 Thread Anthony Bryant
it in before feature freeze if possible. - Anthony On 2010-10-13 13:40:36, Anthony Bryant wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboa

Review Request: More improvements to the Fifteen puzzle

2010-10-13 Thread Anthony Bryant
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5617/ --- Review request for Plasma. Summary --- Lots more improvements to the fi

Re: Review Request: Fifteen puzzle config dialog upgrade

2010-10-12 Thread Anthony Bryant
moment (i.e. want to start a new game) > > Anthony Bryant wrote: > As I said, I'm working on another patch which will add a shuffle button > to the solved board. However, in the mean time there is already a context > menu entry for shuffling the puzzle. > > Marc

Re: Review Request: Fifteen puzzle config dialog upgrade

2010-10-12 Thread Anthony Bryant
moment (i.e. want to start a new game) > > Anthony Bryant wrote: > As I said, I'm working on another patch which will add a shuffle button > to the solved board. However, in the mean time there is already a context > menu entry for shuffling the puzzle. > > Marc

Re: Review Request: Fifteen puzzle config dialog upgrade

2010-10-12 Thread Anthony Bryant
-- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5608/#review8084 ------- On 2010-10-12 02:17:13, Anthony Bryant wrote: > > --- >

Review Request: Fifteen puzzle config dialog upgrade

2010-10-11 Thread Anthony Bryant
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5608/ --- Review request for Plasma. Summary --- This patch fixes some usability

Re: Review Request: Cleanups in pager

2010-09-24 Thread Anthony Bryant
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5355/ --- (Updated 2010-09-24 23:59:14.824625) Review request for Plasma. Changes --

Review Request: Workaround plasma tooltips causing "holes" in windows

2010-09-22 Thread Anthony Bryant
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5415/ --- Review request for Plasma. Summary --- Works around an X bug that cause

Re: Review Request: Cleanups in pager

2010-09-21 Thread Anthony Bryant
> On 2010-09-17 16:18:36, Aaron Seigo wrote: > > the patch doesn't apply to current trunk .. could you update the review > > board request? thanks :) > > Anthony Bryant wrote: > I thought I did that yesterday (and there haven't been any commits to >

Re: Review Request: Cleanups in pager

2010-09-17 Thread Anthony Bryant
ll not apply? - Anthony --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5355/#review7667 --- On 2010-09-17 02:29

Re: Review Request: Cleanups in pager

2010-09-16 Thread Anthony Bryant
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5355/ --- (Updated 2010-09-17 02:29:59.112027) Review request for Plasma. Changes --

Review Request: Cleanups in pager

2010-09-14 Thread Anthony Bryant
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5355/ --- Review request for Plasma. Summary --- * Make configAccepted() just wri

Re: configChanged coverage for 4.6

2010-09-13 Thread Anthony Bryant
On Tue, Sep 14, 2010 at 12:55 AM, Aaron J. Seigo wrote: > feedback time: was this a useful / helpful way to go about getting such > improvements done? for those who got involved: was it enjoyable for you, and > would you do it again? It was definitely a nice way to get into hacking on plasma, and

Review Request: configChanged() for the Tasks plasmoid

2010-09-10 Thread Anthony Bryant
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5313/ --- Review request for Plasma. Summary --- Add configChanged() to the Tasks

Review Request: Fix some issues with resizing panels

2010-06-27 Thread Anthony Bryant
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4463/ --- Review request for Plasma. Summary --- Resizing a horizontal panel's height

Re: Review Request: Fixes for screen hotplugging

2010-06-24 Thread Anthony Bryant
://reviewboard.kde.org/r/4451/#review6266 ------- On 2010-06-24 15:39:08, Anthony Bryant wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request: Fixes for screen hotplugging

2010-06-24 Thread Anthony Bryant
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4451/ --- (Updated 2010-06-24 15:39:08.285730) Review request for Plasma. Summary (updat

Review Request: Fixes for screen hotplugging

2010-06-23 Thread Anthony Bryant
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4451/ --- Review request for Plasma. Summary --- This patch fixes a few problems that

Re: Pager config not working with vertical Panel

2009-07-28 Thread Anthony Bryant
On Tue, Jul 28, 2009 at 9:46 PM, Aaron J. Seigo wrote: > whew! ok :) Anthony: can you commit your patch then and backport it? thanks. I would if I had an svn account - could you do it for me? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mai

Re: Pager config not working with vertical Panel

2009-07-28 Thread Anthony Bryant
On Tue, Jul 28, 2009 at 4:00 PM, Richard Dale wrote: > I have four virtual desktops and a vertical panel on the right. If I > use the configure dialog to set the number of columns to two, it works > fine, and I have my four desktops in two rows and two columns. If I > set the number of columns to o

Re: Review Request: Fix layout problems in the pager applet

2009-07-26 Thread Anthony Bryant
--------- On 2009-07-25 21:40:41, Anthony Bryant wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1124/ >

Re: Review Request: Fix layout problems in the pager applet

2009-07-26 Thread Anthony Bryant
it it for me? - Anthony --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1124/#review1799 --- On 2009-07-25 21:40

Re: Review Request: Fix layout problems in the pager applet

2009-07-25 Thread Anthony Bryant
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1124/ --- (Updated 2009-07-25 21:40:41.819952) Review request for Plasma. Changes --

Re: Review Request: Fix layout problems in the pager applet

2009-07-25 Thread Anthony Bryant
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1124/ --- (Updated 2009-07-25 14:03:16.312849) Review request for Plasma. Changes --

Re: Review Request: Fix layout problems in the pager applet

2009-07-25 Thread Anthony Bryant
ted there could be layout problems afterwards. e.g. if the size shrinks there will be clipping errors. - Anthony --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1124/#r

Re: Review Request: Fix layout problems in the pager applet

2009-07-24 Thread Anthony Bryant
This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1124/#review1756 --- On 2009-07-25 01:11:34, Anthony Bryant wrote: > > -

Review Request: Fix layout problems in the pager applet

2009-07-24 Thread Anthony Bryant
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1124/ --- Review request for Plasma. Summary --- This patch fixes a few problems with

[PATCH] Fix for crash when changing positioning mode

2009-03-01 Thread Anthony Bryant
of lines) and commit it for me? (I don't have an svn account.) Thanks, Anthony Bryant. slideshow-config.kcrash Description: Binary data Index: wallpapers/image/image.cpp === --- wallpapers/image/image.cpp (revision 933847) ++

Re: [PATCH] Fifteen puzzle sizing change (and other fixes)

2008-09-15 Thread Anthony Bryant
2008/9/15 Aaron J. Seigo <[EMAIL PROTECTED]> > On Monday 15 September 2008, Anthony Bryant wrote: > > I found another bug in the puzzle: double (or triple) clicking on a piece > > ok, the patch is now committed; i also went through and made the "split > pixmap&quo

Re: [PATCH] Fifteen puzzle sizing change (and other fixes)

2008-09-15 Thread Anthony Bryant
I found another bug in the puzzle: double (or triple) clicking on a piece could make it stop halfway between places and mess up the whole puzzle layout until you resized it. So here's yet another update to the patch to fix that. I also changed the animation from SlideInMovement to FastSlideInMoveme

Re: [PATCH] Fifteen puzzle sizing change (and other fixes)

2008-09-11 Thread Anthony Bryant
I was just wondering whether anyone's had any time to look at/try out my patch. Also, here's an updated diff that uses the current trunk. Thanks in advance, Anthony. Index: fifteen.cpp === --- fifteen.cpp (revision 859913) +++ fiftee

Re: [PATCH] Fifteen puzzle sizing change (and other fixes)

2008-09-07 Thread Anthony Bryant
Finally got around to learning enough C++ and Qt to implement the svg changes. There is one difference from the suggestions though... I didn't completely abandon the pixmap support, as I'm not sure how to split a user-selected image into elements in a Plasma::Svg Basically what it does now is use

Re: [PATCH] Fifteen puzzle sizing change (and other fixes)

2008-09-03 Thread Anthony Bryant
2008/9/3 Aaron J. Seigo <[EMAIL PROTECTED]> > hmm.. looking at it further, it would probably make even more sense to have > one Plasma::Svg shared amongst all the pieces, have a flag for identical or > not > (and if not, use elementIDs in the svg to determine which block is which), > and > let Pla

[PATCH] Fifteen puzzle sizing change (and other fixes)

2008-09-03 Thread Anthony Bryant
Hi, I've been using KDE from trunk for a while now, and I thought I would try to fix a few bugs I noticed in the fifteen puzzle applet (and also add a few new features) as my first contribution, if someone would be kind enough to look over and possibly commit it. Basically I've taken out the size