arfrever added inline comments.
INLINE COMMENTS
> CMakeLists.txt:23
>
> -find_package(PipeWire)
> -set_package_properties(PipeWire PROPERTIES
> -TYPE OPTIONAL
> -PURPOSE "Required for screencast portal"
> -)
> -
> -find_package(GBM)
> -set_package_properties(GBM PROPERTIES
> -TYPE O
arfrever added a comment.
cmake fails with:
...
-- Configuring done
CMake Error at formatter/declarative/CMakeLists.txt:3 (add_library):
Target "FormatterPlugin" links to target "Qt5::Qml" but the target was not
found. Perhaps a find_package() call is missing for an
arfrever added a comment.
This change was committed in 5.12 and 5.13, but not yet in master branch.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D15263
To: apol, #plasma, hein
Cc: arfrever, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jen
arfrever added inline comments.
INLINE COMMENTS
> CMakeLists.txt:97
> +if ( NOT HAVE_LOGINCTL )
> +find_package(ConsoleKit)
> +set_package_properties(ConsoleKit PROPERTIES
I would suggest that this build-time detection of ConsoleKit occur always, and
as a result, that ck-unlock-session
> On Sept. 17, 2016, 9:39 p.m., Hugo Pereira Da Costa wrote:
> > Sorry for the delay
> > ... for some reason I don't always recieve notifications from reviewboard
>
> Hugo Pereira Da Costa wrote:
> Ping ?
> Do people have commit rights ? Should I commit it myself ?
>
> Peter Wu wrote:
