D29709: Give all OverlaySheets consistent headers

GB_2 added inline comments. INLINE COMMENTS > UpdatesPage.qml:39 > id: sheet > +header: Kirigami.Heading { text: i18n("Update issue") } > + "Update Issue" REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D29709 To: ngraham, apol,

D29439: [RFC] Adjust color schemes for tools area/Breeze evolution

GB_2 added a comment. Do we still want to ship the old Breeze Classic with Plasma or do we put it in `kde-vdg-extras`? I think there are quite a few people who like the mix of dark header and light content. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29439 To:

D28744: Rewrite of the global shortcuts kcm

GB_2 added a comment. Nitpick: put the "Add Application..." button on the left (T10384 ). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28744 To: davidre, #vdg, #plasma Cc: GB_2, broulik, davidedmundson, nicolasfella,

D28842: Raise size of default fixed-width font from 9 to 10pt

GB_2 added a comment. Thanks for this :-) REPOSITORY R119 Plasma Desktop BRANCH even-bigger-hack (branched from master) REVISION DETAIL https://phabricator.kde.org/D28842 To: ngraham, #vdg, #plasma, #ktexteditor, #kate, #konsole, ndavis Cc: GB_2, plasma-devel, Orage, LeGast00n,

D28461: In sidebar mode show if a module is in default state or not

GB_2 added a comment. In D28461#640439 , @The-Feren-OS-Dev wrote: > How about instead of a blue dot there's instead an option in the SySe hamburger button menu to use search to filter out any settings pages where settings haven't been changed,

D21978: RFC: Fix search not returning results in Kickoff when cursor is below tabbar

GB_2 added a comment. Can you please try to further investigate this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21978 To: filipf, hein, #plasma, ngraham Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen,

D25945: Sync dark theme preference for GTK3 applications

GB_2 added a comment. In D25945#577731 , @gikari wrote: > In D25945#577677 , @cblack wrote: > > > For flatpaks not respecting the setting preference, have you checked that the dark theme variant is

D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

GB_2 added a comment. Ping. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D25778 To: ognarb, #vdg, #plasma Cc: GB_2, filipf, guoyunhe, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D24070: Don't use toolTipMainText to show info, rather use the second line

GB_2 added a comment. Ping :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma, ndavis Cc: GB_2, ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham,

D22684: [Klipper] Fix clipboard history management

GB_2 added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22684 To: pdabrowski, #plasma, #plasma_workspaces, ngraham, davidedmundson Cc: GB_2, davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen,

D25670: Synchronize decorations buttons order in GTK headerbars

GB_2 added a comment. Works great! REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D25670 To: gikari, #vdg, cblack, #plasma Cc: GB_2, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin,

D25945: Sync dark theme preference for GTK3 applications

GB_2 added a comment. Works perfectly fine for me without waiting. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D25945 To: gikari, apol, cblack, broulik, #vdg Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen,

D25844: Add grouping options in Icons-only Task Manager

GB_2 added a comment. I already made a patch for this: D23242 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25844 To: gvgeo, #plasma, #vdg Cc: GB_2, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

GB_2 added a comment. In D24275#571532 , @cblack wrote: > In D24275#571531 , @GB_2 wrote: > > > Works now :-) > > > With the cmake or the meson? Meson. REPOSITORY R99 KDE Gtk

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

GB_2 added a comment. Works now :-) REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24275 To: cblack, #plasma, apol Cc: GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf,

D25633: Fix Cuttlefish mouse click selection in icon grid

This revision was automatically updated to reflect the committed changes. Closed by commit R118:dd263acd2f62: Fix Cuttlefish mouse click selection in icon grid (authored by GB_2). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25633?vs=70626=70637

D25635: Add icon to browser integration do not remind menu item

This revision was automatically updated to reflect the committed changes. Closed by commit R856:e37eef54ab35: Add icon to browser integration do not remind menu item (authored by GB_2). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D25635: Add icon to browser integration do not remind menu item

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7791325: Plasma Browser Integration Do Not Remind Menu Item Icon.png

D25633: Fix Cuttlefish mouse click selection in icon grid

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Fixes the selection preview being changed before the selection rectangle changes. TEST PLAN Click

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

GB_2 added a comment. In D25361#566193 , @ngraham wrote: > I share you concern about this KCM becoming a dumping ground. But I don't see a better place for this setting right now. And I think it does make some sense for it to hold general

D25381: Make QPushButton/QToolButton the same height as QLineEdit

GB_2 added a comment. Plus in the screenshot it looks like it's still not quite the same heihgt. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D25381 To: guoyunhe, #breeze, #plasma Cc: GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D25381: Make QPushButton/QToolButton the same height as QLineEdit

GB_2 added a comment. In D25381#564370 , @ngraham wrote: > +1 conceptually, this will be nice to finally have fixed. > > But might the opposite make more sense? If we make buttons shorter, we're slightly reducing their click targets, but if

D23117: [Look and feel] Add a way for LNF themes to manually specify Splash Screen, Latte Layout and Borderless Maximised Windows

GB_2 added a comment. Ping :-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23117 To: The-Feren-OS-Dev, #plasma, davidedmundson, mart Cc: fvogt, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin,

D25351: [Style KCM] Change name to KDE/Qt Application Style

GB_2 added a comment. In D25351#563677 , @ngraham wrote: > I think the only way to satisfactorily do that is to remove the GTK KCM entirely, and then the remaining KCM can keep its current name ("Application Style"). I'm in favor of that, but

D25351: [Style KCM] Change name to KDE/Qt Application Style

GB_2 added a comment. I thought we wanted to merge the GTK Application Style with this KCM, and have the GTK theme comboxes accessible with a button in the KCM (like for the toolbar style)? I wouldn't rename the KCM until we are sure that we don't want to merge the two KCMs. REPOSITORY

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

GB_2 added a comment. @hein If you really still think we shouldn't do this then I can change this patch to only affect the "Show Only Minimized" option and close the bug as INTENTIONAL. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23242 To: GB_2,

D24798: Migrate QQC1 to QQC2

GB_2 added a comment. In D24798#562431 , @guoyunhe wrote: > Thanks for the tip. It seems added the border, but when scrolling, the top border or bottom border disappear. It cannot show full border at all sides. Yeah, that is a general

D24744: Remove unneeded options in GTK KCM

GB_2 added a comment. Ok, then we should keep it in the GTK KCM until we have the option for Qt applications. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24744 To: gikari, #vdg, #plasma Cc: ngraham, broulik, filipf, GB_2, plasma-devel,

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

This revision was automatically updated to reflect the committed changes. Closed by commit R119:da268696a6af: [Task Manager] Toggle mute when the audio indicator is clicked (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

GB_2 updated this revision to Diff 69128. GB_2 added a comment. Remove unneeded properties REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19822?vs=69127=69128 BRANCH arcpatch-D19822 REVISION DETAIL https://phabricator.kde.org/D19822 AFFECTED

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

GB_2 updated this revision to Diff 69127. GB_2 added a comment. Move into AudioStream REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19822?vs=65691=69127 BRANCH arcpatch-D19822 REVISION DETAIL https://phabricator.kde.org/D19822 AFFECTED FILES

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

GB_2 added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19822 To: faridb, #plasma, #vdg, ngraham, hein, GB_2 Cc: GB_2, mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D25055: [containments/desktop] Delete the "Tweaks" page and its options

GB_2 added a comment. I wonder, can that be added to mouse actions instead of a page with only one option? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25055 To: ngraham, mart, GB_2, #plasma, hein Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D25055: [containments/desktop] Delete the "Tweaks" page and its options

GB_2 added a comment. In D25055#556751 , @mart wrote: > I would prefer keeping the press to move stuff Is there a reason to disable it? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25055 To: ngraham,

D24855: Rename "Close Edit Mode" tooltip to "Finish Customizing Layout"

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a74c3657a071: Rename Close Edit Mode tooltip to Finish Customizing Layout (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D24744: Remove unneeded options in GTK KCM

GB_2 added a comment. I'd be fine with that (we could always add it later in the Application Style KCM when we have it for Qt). REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24744 To: gikari, #vdg, #plasma Cc: ngraham, broulik, filipf, GB_2,

D25053: Don't show "Customize Layout..." menu item in panel context menu

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY "Edit Panel..." already enters the edit mode, so there's no need to clutter the context menu with

D24855: Rename "Close Edit Mode" tooltip to just "Close"

GB_2 updated this revision to Diff 68986. GB_2 added a comment. "Close" -> "Finish Customizing Layout" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24855?vs=68514=68986 BRANCH arcpatch-D24855 REVISION DETAIL

D24162: Hide "Lock Widgets" button from panel edit mode toolbar

This revision was automatically updated to reflect the committed changes. Closed by commit R119:88bce0e49c7e: Hide Lock Widgets button from panel edit mode toolbar (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24162?vs=68476=68985

D24839: Only show "Unlock Widgets" in the UI, not "Lock Widgets"

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f9a664cfd898: Only show Unlock Widgets in the UI, not Lock Widgets (authored by GB_2). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24839?vs=68510=68984

D24839: Only show "Unlock Widgets" in the UI, not "Lock Widgets"

GB_2 added a comment. Ping. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D24839 REVISION DETAIL https://phabricator.kde.org/D24839 To: GB_2, #plasma, #vdg, ngraham, mart Cc: broulik, mart, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D24906: [KCMs/Night Color] Explain Night Color feature inline

GB_2 added a comment. In the Desktop Effects KCM the label is top-left aligned. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24906 To: ngraham, #vdg, #plasma, ndavis, zzag Cc: GB_2, ahiemstra, davidedmundson, ndavis, plasma-devel, LeGast00n,

D24265: support global edit mode

GB_2 added a comment. In D24265#551189 , @mart wrote: > - don't dismiss applet edit mode when overing the handle Also happens with the resize handles :/ REPOSITORY R119 Plasma Desktop REVISION DETAIL

D24855: Rename "Close Edit Mode" tooltip to just "Close"

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY We don't call it the "edit mode" anywhere else in the UI. An alternative would be "Finish Customizing

D24839: Only show "Unlock Widgets" in the UI, not "Lock Widgets"

GB_2 updated this revision to Diff 68510. GB_2 added a comment. Avoid negating entire boolean statements REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24839?vs=68480=68510 BRANCH arcpatch-D24839 REVISION DETAIL

D24162: Hide "Lock Widgets" button from panel edit mode toolbar

GB_2 added a comment. In D24162#551673 , @ngraham wrote: > Oh, so that would need to be done in D24839 then? That would need to be a new patch IMO. REPOSITORY R119 Plasma Desktop BRANCH master

D24162: Hide "Lock Widgets" button from panel edit mode toolbar

GB_2 added a comment. In D24162#551671 , @ngraham wrote: > The Edit Panel menu item probably shouldn't be visible while that panel is currently being edited: F7642545: Screenshot_20191021_131210.png

D24839: Only show "Unlock Widgets" in the UI, not "Lock Widgets"

GB_2 updated this revision to Diff 68480. GB_2 added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24839?vs=68468=68480 BRANCH arcpatch-D24839 REVISION DETAIL https://phabricator.kde.org/D24839 AFFECTED FILES

D24162: Hide "Lock Widgets" button from panel edit mode toolbar

GB_2 updated this revision to Diff 68476. GB_2 added a comment. Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24162?vs=66679=68476 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24162 AFFECTED FILES

D24839: Only show "Unlock Widgets" in the UI, not "Lock Widgets"

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Not needed for normal users with the new edit mode system. TEST PLAN Lock the widgets before

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

GB_2 added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23242 To: GB_2, #plasma, #vdg, hein, ngraham Cc: ngraham, hein, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin,

D24265: support global edit mode

GB_2 added inline comments. INLINE COMMENTS > ToolBoxButton.qml:230 > +PlasmaComponents3.ToolTip { > +text: i18n("Close Edit Mode") > +} Please change to "Finish Customizing Layout" to match the menu entry. REPOSITORY R119 Plasma Desktop

D24265: support global edit mode

GB_2 added a comment. In D24265#549640 , @mart wrote: > i would prefer not to, but can be tried with eventually in the future Ok, we can do that in another patch. This is fine once you address my inline comment "Not done." and fix this:

D24265: support global edit mode

GB_2 added a comment. Why not? Currently you have to open the context menu for the panel or desktop, so it's inconsistent and confusing if you want to move a widget and the don't get the option to (without click+hold). REPOSITORY R119 Plasma Desktop BRANCH mart/editMode REVISION

D24265: support global edit mode

GB_2 added a comment. I'd also add the "Customize Layout..." button to the widget menu, that way you can discover it much more easily. REPOSITORY R119 Plasma Desktop BRANCH mart/editMode REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma, ngraham Cc: ngraham, GB_2,

D24265: support global edit mode

GB_2 added a comment. An "Add Panel..." button in the toolbox would be very useful too :-) REPOSITORY R119 Plasma Desktop BRANCH mart/editMode REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma, ngraham Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24265: support global edit mode

GB_2 added a comment. Only one last issue: the widget resizing handles disappear when you are on a blank area of the widget handle (the bar to the left/right). INLINE COMMENTS > GB_2 wrote in ToolBoxButton.qml:292 > This should probably be changed to "Finish Customizing Layout" to match the

D24744: Remove unneeded options in GTK KCM

GB_2 added a comment. In D24744#549486 , @gikari wrote: > In D24744#549450 , @GB_2 wrote > > > Well, it'll be gone completely soon and the GTK theme comboboxes will be in the Application Style KCM.

D24744: Remove unneeded options in GTK KCM

GB_2 added a comment. In D24744#549444 , @filipf wrote: > So much nicer, awesome work. +1 for the visuals of the rehauled kcm. Well, it'll be gone completely soon and the GTK theme comboboxes are going to be in the Application Style KCM.

D24744: Remove unneeded options in GTK KCM

GB_2 added a comment. Wow, it's so empty now! Great job! REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24744 To: gikari, #vdg Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin,

D24732: Rewrite AppChooser dialog

GB_2 added inline comments. INLINE COMMENTS > AppChooserDialog.qml:47 > +horizontalAlignment: Text.AlignHCenter > +text: i18n("Select application to open %1. Other applications > are available in Discover.", fileName) > +textFormat: Text.RichText "Select an application

D24720: [applets/systemtray] Rewrite popups with layouts

GB_2 added a comment. > F761074 Can we align the header with the search field/content here? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24720 To: filipf, #plasma, #vdg Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D24607: Fix showing menu toolbutton when no drawer is available

GB_2 added a comment. Love the test plan  REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D24607 To: nicolasfella, mart Cc: GB_2, plasma-devel, fbampaloukas, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein

D24533: Draw categories in iconview in a similiar style as Kirigami and new KCategoryDrawer

GB_2 added a comment. In D24533#544784 , @filipf wrote: > This sort of a style, the line is right next to the title. > > F7567596: image.png Hmm, I think that would be too inconsistent again.

D24011: Provide a telemetrics kcm module for Plasma

GB_2 added a comment. I have updated two PCs and on both telemetry was on by default... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24011 To: apol, #plasma, vkrause, ngraham Cc: GB_2, aspotashev, ngraham, bcooksley, davidedmundson, ognarb, broulik,

D24265: support global edit mode

GB_2 added a comment. BTW, it would also be nice to have click and hold on the panel to open the panel controller toolbox :-) REPOSITORY R119 Plasma Desktop BRANCH mart/editMode REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma, ngraham Cc: ngraham, GB_2,

D24265: support global edit mode

GB_2 added inline comments. INLINE COMMENTS > ToolBoxButton.qml:292 > +PlasmaComponents3.ToolTip { > +text: i18n("Close Edit Mode") > +} This should probably be changed to "Finish Customizing Layout" to match the current menu entry.

D24264: edit mode action and dbus

GB_2 added a comment. It still leaves the edit mode when closing a panel controller toolbox. REPOSITORY R120 Plasma Workspace BRANCH mart/editMode REVISION DETAIL https://phabricator.kde.org/D24264 To: mart, #plasma, #vdg, ngraham Cc: GB_2, ngraham, davidedmundson, plasma-devel,

D24265: support global edit mode

GB_2 added a comment. This works very well now except for the vertical desktop toolbox. I don't think being able to have a vertical toolbar is practical, you can't really read the button labels and it's also glitching around when switching between horizontal and vertical mode. I think just

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

GB_2 added inline comments. INLINE COMMENTS > main.qml:27 > +import org.kde.kcm 1.1 as KCM > +import Qt.labs.platform 1.1 > + Is this actually used? Also, because it's not installed by default it shows an error. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D24454: Include an emoji picker

GB_2 added a comment. For "All" I think we should use an icon like `view-list-icons`, otherwise +1. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24454 To: apol, #plasma Cc: GB_2, mart, ngraham, davidedmundson, broulik, plasma-devel, LeGast00n,

D24265: support global edit mode

GB_2 added a comment. It would be nice if the desktop toolbox had a shadow and had the standard background. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma, ngraham Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24265: support global edit mode

GB_2 added a comment. In D24265#544016 , @mart wrote: > this happens because some other window gets focus (that behavior in somewhere deep in kwin and i think makes sense). > Would you keep edit mode active when the focus goes to another app?

D24265: support global edit mode

GB_2 added a comment. In D24265#543873 , @ngraham wrote: > I would tend to agree. If we feel that it's too difficult to exit this mode, maybe we should make it more obvious, like changing the X button in the toolbox to a toolbutton with the

D24265: support global edit mode

GB_2 added a comment. In D24265#543173 , @mart wrote: > hmm, not sure it's a bad thing, it all makes this mode to automatically exit.. which makes it almost a "quasimode", countering a bit the evils of being a modal ui When you are done

D24479: [KCM] Make multi-screen draggability more obvious

GB_2 added a comment. What about using a SizeAllCursor, like the screen edge button in the Plasma panel edit mode? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24479 To: ngraham, romangg, #plasma, #vdg Cc: GB_2, davidedmundson, broulik, plasma-devel, LeGast00n,

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

GB_2 added a comment. Relevant: https://bugs.kde.org/show_bug.cgi?id=351647 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23718 To: tcanabrava, #plasma, mart, ngraham Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D14830: Add "Configure Displays" context menu entry on the desktop

GB_2 added a comment. Is there a reason this got abandoned? :/ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14830 To: broulik, #plasma, #vdg, fischbach, harmathy, davidedmundson Cc: GB_2, gregormi, mart, davidedmundson, abetts, romangg, fabianr, ngraham,

D24265: support global edit mode

GB_2 added a comment. A few bugs I found: - when you open the desktop context menu it enters the edit mode automatically (probably because it thinks you still click) - after closing the panel controller or "Add Widgets..." sidebar it closes the edit mode too REPOSITORY R119 Plasma

D24299: Fix "Show intro page" button not resetting titlebar title

GB_2 added a comment. In D24299#539868 , @ngraham wrote: > this doesn't work for the case of clicking on one of the categories shown on the home page and then clicking on the home button. You're right, maybe @mart can help :-)

D24264: edit mode action and dbus

GB_2 added a comment. Just showing the handles when you hover over a widget (or tap on one on touch) is fine IMO. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24264 To: mart, #plasma Cc: GB_2, ngraham, davidedmundson, plasma-devel, LeGast00n,

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

GB_2 added a comment. The KDE HIG suggests something like this: https://hig.kde.org/_images/Slider.Speed.qml.png REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham, #vdg, #plasma, romangg Cc: GB_2, ndavis, cullmann, plasma-devel, LeGast00n,

D24299: Fix "Show intro page" button not resetting titlebar title

GB_2 created this revision. GB_2 added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY This fixes it. TEST PLAN Click the "Show intro page button". REPOSITORY R124 System Settings

D23274: Add "Show intro page" button to System Settings sidebar

GB_2 added a comment. @mart I found a bug with this: the titlebar title doesn't update. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg, ngraham, mart Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev,

D20972: [sidebar] Make search field not glued to the separator

GB_2 requested changes to this revision. GB_2 added a comment. This revision now requires changes to proceed. In D20972#517463 , @filipf wrote: > D23274 makes this unnecessary. It landed. REPOSITORY

D23274: Add "Show intro page" button to System Settings sidebar

GB_2 added a comment. This can be closed. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg, ngraham, mart Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D6056: [Run Command] Auto-close on focus loss only if query field is empty

GB_2 added a comment. Is there a reason this isn't landed yet? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6056 To: broulik, #plasma, #vdg, davidedmundson, ngraham Cc: GB_2, elcste, shubham, ngraham, cfeck, anthonyfieroni, plasma-devel, LeGast00n,

D13881: oxygen-demo : add KMessage preview

GB_2 added a comment. Looks fine IMO. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D13881 To: rjvbb, #vdg, plasma-devel Cc: GB_2, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D10263: Fix being unable to close the toolbox menu by clicking outside

GB_2 added a comment. Can be abandoned because of D24265 . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10263 To: hein, #plasma, mart Cc: GB_2, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D21815: [sddm-theme] Start moving from QQC1 to QQC2

GB_2 added a comment. Ping. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D21815 REVISION DETAIL https://phabricator.kde.org/D21815 To: cblack, #plasma, #vdg, davidedmundson, filipf Cc: ndavis, GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24265: support global edit mode

GB_2 added a comment. Nice! I guess D23951 is still relevant? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen,

D24161: Make KCM look more like applet

GB_2 added a comment. I'd also align the mute button with the slider, like in the applet. INLINE COMMENTS > DeviceListItem.qml:89 > +Button { > +text: i18n("Default device") > +icon.name: "favorite" "Default Device" REPOSITORY R115

D24129: Fix clipping and use a real ScrollView for the Display Configuration KCM screen overview

This revision was automatically updated to reflect the committed changes. Closed by commit R104:ff0ac9ab879d: Fix clipping and use a real ScrollView for the Display Configuration KCM screen… (authored by GB_2). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D24161: Make KCM look more like applet

GB_2 added inline comments. INLINE COMMENTS > sefaeyeoglu wrote in MuteButton.qml:32 > I feel like QQC2 tooltips look out of place. They don't have the same shadow > as //normal// tooltips and do not fade in That is something that needs to be fixed in the QQC2 desktop style, so it is

D24246: Only show panel toolbox when desktop toolbox is open

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d9533e674adc: Only show panel toolbox when desktop toolbox is open (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24246?vs=66906=66911

D24129: Fix clipping and use a real ScrollView for the Display Configuration KCM screen overview

GB_2 added a comment. Ping. REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.kde.org/D24129 To: GB_2, #plasma, #vdg, ngraham Cc: romangg, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D24246: Only show panel toolbox when desktop toolbox is open

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY This way the panel toolbox isn't always visible, because with D23951

D24228: [containments/desktop] Use new colorful filter icon

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7431292: Desktop Configuration Filter Icon.png TEST PLAN

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

GB_2 added a comment. In D23718#536359 , @ngraham wrote: > The frame's alignment and padding seem off: F7416705: Screenshot_20190923_075306.png > > Could we use a list more like the one used in the

D23274: Add "Show intro page" button to System Settings sidebar

This revision was automatically updated to reflect the committed changes. Closed by commit R124:de351c8ed6c3: Add Show intro page button to System Settings sidebar (authored by GB_2). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23274?vs=66829=66830#toc REPOSITORY R124 System

  1   2   3   4   5   6   7   >