D21815: [sddm-theme] Start moving from QQC1 to QQC2

GB_2 added a comment. In D21815#490482 , @filipf wrote: > If keeping the new menu style we have to wait until all those patches get merged in Plasma. > > Might be better to just follow current style; updating it to the new one would be a

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

GB_2 added a comment. In D19822#442630 , @filipf wrote: > Just throwing out another possible solution: the PlasmaComponents Highlight thingy: > > F6747233: Screenshot_20190403_005556.png > >

D14830: Add "Configure Displays" context menu entry on the desktop

GB_2 added inline comments. INLINE COMMENTS > GB_2 wrote in menu.cpp:117 > I'd change it to "Manage Displays..." to make the differentiate the name even > more from the "Configure Desktop..." menu entry. *to differentiate REPOSITORY R120 Plasma Workspace REVISION DETAIL

D14830: Add "Configure Displays" context menu entry on the desktop

GB_2 added inline comments. INLINE COMMENTS > menu.cpp:117 > > +m_displaySettingsAction = new > QAction(i18nc("plasma_containmentactions_contextmenu", "Configure > Displays..."), this); > + >

D14830: Add "Configure Displays" context menu entry on the desktop

GB_2 added a comment. I think we should definitely add this shortcut, because it is very useful for the people mentioned and for other situations. I agree that it should be on by default, then it's already there when you need it. In D14830#472177

D23127: [plasma-desktop] Add desktop context menu entry for Displays KCM

GB_2 abandoned this revision. GB_2 added a comment. Oh, didn't know that existed, it wasn't mentioned anywhere in the bug report. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23127 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, plasma-devel, #plasma,

D23127: [plasma-desktop] Add desktop context menu entry for Displays KCM

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 355679 F7237121: Displays KCM Desktop Context Menu Entry.png

D23128: [plasma-workspace] Add desktop context menu entry for Displays KCM

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7237121: Displays KCM Desktop Context Menu Entry.png TEST

D23049: Add Kirigami ListSectionHeader component

GB_2 updated this revision to Diff 63662. GB_2 added a comment. Improve example REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63653=63662 BRANCH arcpatch-D23049 REVISION DETAIL https://phabricator.kde.org/D23049 AFFECTED FILES

D23049: Add Kirigami ListSectionHeader component

GB_2 added a comment. In D23049#511210 , @ngraham wrote: > Hmm, if software making use of this needs to manually add a label, that seems to defeat part of the point of using a standard component. The label in the example was just

D23049: Add Kirigami ListSectionHeader component

GB_2 updated this revision to Diff 63653. GB_2 added a comment. Ditch the extra property REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63444=63653 BRANCH arcpatch-D23049 REVISION DETAIL https://phabricator.kde.org/D23049 AFFECTED FILES

D22896: Port System Settings sidebar to QQC2

GB_2 updated this revision to Diff 63614. GB_2 marked 7 inline comments as done. GB_2 added a comment. Address comments REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63611=63614 BRANCH arcpatch-D22896 REVISION DETAIL

D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

GB_2 updated this revision to Diff 63611. GB_2 added a comment. Use a QMenu REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63460=63611 BRANCH arcpatch-D22896 REVISION DETAIL https://phabricator.kde.org/D22896 AFFECTED FILES

D23097: [Task Manager] Add icon to the grouping menu entry

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6bf630cce15a: [Task Manager] Add icon to the grouping menu entry (authored by simonkr, committed by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D23097: [Task Manager] Add icon to the grouping menu entry

GB_2 updated this revision to Diff 63585. GB_2 added a comment. Fix diff REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23097?vs=63584=63585 BRANCH arcpatch-D23097 REVISION DETAIL https://phabricator.kde.org/D23097 AFFECTED FILES

D23097: [Task Manager] Add icon to the grouping menu entry

GB_2 updated this revision to Diff 63584. GB_2 added a comment. Fix indentation REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23097?vs=63580=63584 BRANCH arcpatch-D23097 REVISION DETAIL https://phabricator.kde.org/D23097 AFFECTED FILES

D23097: [Task Manager] Add icon to the grouping menu entry

GB_2 added a comment. Don't forget the inline comment ;-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23097 To: simonkr, #plasma, #vdg, hein Cc: GB_2, #vdg, plasma-devel, #plasma, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh,

D23097: Add icon to the taskmanager grouping menu entry

GB_2 added a comment. I think the icon `view-group` fits better. INLINE COMMENTS > ContextMenu.qml:577 > text: i18n("Allow this program to be grouped") > - > +icon: "object-group" > onClicked: tasksModel.requestToggleGrouping(menu.modelIndex)

D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

GB_2 added a comment. In D22896#509989 , @ngraham wrote: > Maybe the show most used action should go in a separate patch. This one feels like it's getting overloaded with too many different changes. Yeah, we that feature is also not

D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

GB_2 updated this revision to Diff 63460. GB_2 added a comment. "Configure" -> "Configure..." REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63458=63460 BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent

D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

GB_2 added a subscriber: mart. GB_2 added a comment. Ping @mart, can you please help here? REPOSITORY R124 System Settings BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent (branched from master) REVISION DETAIL https://phabricator.kde.org/D22896 To: GB_2,

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 updated this revision to Diff 63458. GB_2 added a comment. Add a "Show Most Used Page" button REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63404=63458 BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent

D23049: Add Kirigami ListSectionHeader component

GB_2 updated this revision to Diff 63444. GB_2 added a comment. Add example code REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63443=63444 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSectionHeader component

GB_2 updated this revision to Diff 63443. GB_2 added a comment. Update `customItems` description REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63442=63443 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSectionHeader component

GB_2 added a comment. In D23049#509439 , @ngraham wrote: > Idea: add a `RowLayout` inside the `contentItem` and put the `Heading` in there, then expose a property called like "CustomItems" that allows the implementation to add additional items

D23049: Add Kirigami ListSectionHeader component

GB_2 updated this revision to Diff 63442. GB_2 added a comment. Add `customItems` list REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63432=63442 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSectionHeader component

GB_2 updated this revision to Diff 63432. GB_2 added a comment. Use Kirigami 2.10 REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63430=63432 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSectionHeader component

GB_2 added a comment. In D23049#509339 , @ognarb wrote: > Something is probably wrong with the version numbers. Yeah, I don't know which I should choose and why, I just copied it from the other list items. REPOSITORY R169 Kirigami

D23049: Add Kirigami ListSection component

GB_2 updated this revision to Diff 63430. GB_2 added a comment. Rename to ListSectionHeader REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63429=63430 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSection component

GB_2 updated this revision to Diff 63429. GB_2 added a comment. Use correct background color REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63428=63429 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSection component

GB_2 updated this revision to Diff 63428. GB_2 added a comment. Set `sectionDelegate` to `true` REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63426=63428 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSection component

GB_2 updated this revision to Diff 63426. GB_2 added a comment. Update copyright REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63425=63426 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSection component

GB_2 added a comment. In D23049#509301 , @ngraham wrote: > Maybe call it a `ListSectionHeader` or just `SectionHeader`? I think just the word section is more accurate, because that's what the property that it will be used in is called

D23049: Add Kirigami ListSection component

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in ListSection.qml:28 > coherent -> consistent I just copied it from the other list items :-) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23049 To: GB_2, #kirigami, #vdg Cc: ngraham, #vdg, plasma-devel,

D23049: Add Kirigami ListSection component

GB_2 updated this revision to Diff 63425. GB_2 added a comment. Remove duplicate AbstractListItem REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63424=63425 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSection component

GB_2 created this revision. GB_2 added reviewers: Kirigami, VDG. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Adds a standard ListSection component to make ListView sections look consistent. F7181620:

D22879: Rename "Look and Feel" KCM to "Global Theme"

GB_2 added inline comments. INLINE COMMENTS > metadata.desktop:2 > [Desktop Entry] > -Comment=Test Look and Feel package > +Comment=Test Global Theme package > Comment[ast]=Paquete d'aspeutu y sentir de prueba Lowercase "global theme". REPOSITORY R119 Plasma Desktop BRANCH lnf-to-global

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 updated this revision to Diff 63404. GB_2 added a comment. Rebase REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63403=63404 BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent (branched from master)

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 updated this revision to Diff 63403. GB_2 added a comment. Use Qt Labs Platform menu (need to wait until https://bugreports.qt.io/browse/QTBUG-77404 is fixed) REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63338=63403 BRANCH

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 added inline comments. INLINE COMMENTS > broulik wrote in SidebarMode.cpp:570 > Not a huge fan of this. > Can this be done in qqc2-desktop-style to be generic and fix every `Menu` and > `ComboBox` popup? Not really, seems like the KQuickStyleItem only has access to the QML window of the

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 updated this revision to Diff 63338. GB_2 added a comment. Rebase on master REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63180=63338 BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent (branched from

D22977: Make the Notifications KCM category headers look consistent with other Kirigami lists

GB_2 added a comment. In D22977#507716 , @ngraham wrote: > Once all is said and done we should really make an actual Kirigami component that has these visual settings by default so we don't need to adjust it in 10 places if we ever decide to

D22977: Make the Notifications KCM category headers look consistent with other Kirigami lists

This revision was automatically updated to reflect the committed changes. Closed by commit R119:91ec99d32e90: Make the Notifications KCM category headers look consistent with other Kirigami… (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D22977: Make the Notifications KCM category headers look consistent with other Kirigami lists

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7172863: Consistent Notifications KCM Category Headers.png

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 updated this revision to Diff 63180. GB_2 added a comment. Close menu when clicking anywhere in the window. Most likely not the best solution. REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=62976=63180 BRANCH

D22953: Make the System Settings category headers look consistent with other Kirigami lists

This revision was automatically updated to reflect the committed changes. Closed by commit R124:1fff71c11e63: Make the System Settings category headers look consistent with other Kirigami… (authored by GB_2). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE

D22953: Make the System Settings category headers look consistent with other Kirigami lists

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7167951: Consistent System Settings Category Headers.png

D22940: Add label to the lockscreen config's "Show media controls" checkbox and make QML imports consistent

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b4ccffec69ec: Add label to the lockscreen configs Show media controls checkbox and make… (authored by GB_2). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22940: Add label to the lockscreen config's "Show media controls" checkbox and make QML imports consistent

GB_2 updated this revision to Diff 63125. GB_2 added a comment. Add translation context REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22940?vs=63117=63125 BRANCH

D22940: Add label to the lockscreen config's "Show media controls" checkbox and make QML imports consistent

GB_2 updated this revision to Diff 63117. GB_2 added a comment. Put checkbox id property above text property REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22940?vs=63099=63117 BRANCH

D21978: RFC: Fix search not returning results in Kickoff when cursor is below tabbar

GB_2 added a comment. In D21978#497409 , @filipf wrote: > Ping, I'm still seeing the issue with the other patch landed. Me too. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21978 To: filipf, hein,

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

GB_2 added a comment. The `icons` folder can be deleted since it's not used anymore I think. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D22468 To: romangg, #plasma, #kwin Cc: GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, broulik, filipf,

D22940: Add a label to the lockscreen config's "Show media controls" checkbox and make the QML imports consistent

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7164807 TEST PLAN Open the Appearance tab of the Screen

D22911: Improve the look of the Lock Screen KCM UI

This revision was automatically updated to reflect the committed changes. Closed by commit R133:bf5040930785: Improve the look of the Lock Screen KCM UI (authored by GB_2). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22911?vs=63079=63083 REVISION

D22911: Improve the look of the Lock Screen KCM UI

GB_2 updated this revision to Diff 63079. GB_2 added a comment. Correct ki18ncp comment REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22911?vs=63078=63079 BRANCH improved-lock-screen-kcm-ui (branched from master) REVISION DETAIL

D22911: Improve the look of the Lock Screen KCM UI

GB_2 updated this revision to Diff 63078. GB_2 added a comment. Address comments REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22911?vs=63030=63078 BRANCH improved-lock-screen-kcm-ui (branched from master) REVISION DETAIL

D22911: Improve the look of the Lock Screen KCM UI

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in kcm.ui:49 > Capitalize Automatically Ok, I just followed the style from D21610 , if it's wrong then it needs to be corrected ther too. > ngraham wrote in kcm.ui:78 > While we're at it, I might

D22911: Improve the look of the Lock Screen KCM UI

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Apply the KDE HIG and make the desktop file consistent. F7150699: Improved Lock Screen KCM UI.png

D22880: Rename "Plasma Theme" to "Plasma Style"

GB_2 added inline comments. INLINE COMMENTS > kcm_desktoptheme.desktop:41 > Name[zh_TW]=Plasma 主題 > Comment=Choose Plasma theme > Comment[ca]=Trieu el tema del Plasma You forgot to change the name here too. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 added a comment. That is good enough IMO, but if anyone knows how to fix this, then please do :-) REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D22896 To: GB_2, #plasma, #vdg Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n,

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 added a comment. In D22896#505835 , @ngraham wrote: > Yeah that's pretty bad. I think we need to fix that first--or at the very least, make it close when clicking on the button. It does that. Making it close when clicking anywhere

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7141216: System Settings Sidebar QQC2 Port.png Only issue

D22879: Rename "Look and Feel" KCM to "Global Theme"

GB_2 accepted this revision as: VDG, GB_2. GB_2 added a comment. This revision is now accepted and ready to land. We should probably also change the name in the KDE Store and Look and Feel Explorer. INLINE COMMENTS > metadata.desktop:2 > [Desktop Entry] > -Comment=Test Look and Feel

D22871: Use better Workspace Behavior KCM title and icon

This revision was automatically updated to reflect the committed changes. Closed by commit R119:acddedf0bb1d: Use better Workspace Behavior KCM title and icon (authored by Bjrn Feber bfe...@protonmail.com, committed by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D22871: Use better Workspace Behavior KCM title and icon

GB_2 updated this revision to Diff 62933. GB_2 added a comment. Drop word "the" in descriptions REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22871?vs=62930=62933 BRANCH use-better-global-workspace-behavior-kcm-title-and-icon (branched from

D22871: Use better Workspace Behavior KCM title and icon

GB_2 added a comment. In D22871#505360 , @ngraham wrote: > If we're going to make it "General", do we even need the word "Behavior" in there? It's implied by its category, no? I suppose there would be no visible parent category when running in

D22880: Rename "Plasma Theme" to "Plasma Style"

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in plasma-themes.knsrc:42 > > The KDE Store category name should probably be updated too. > > You mean here? What does this actually do? I mean in the actual store online :-) REPOSITORY R119 Plasma Desktop BRANCH

D22880: Rename "Plasma Theme" to "Plasma Style"

GB_2 accepted this revision as: VDG, GB_2. GB_2 added a comment. This revision is now accepted and ready to land. The KDE Store category name should probably be updated too. REPOSITORY R119 Plasma Desktop BRANCH plasma-theme-to-plasma-style (branched from master) REVISION DETAIL

D22871: Use better Global Workspace Behavior KCM title and icon

GB_2 updated this revision to Diff 62930. GB_2 added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. Use name "General Behavior" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22871?vs=62892=62930

D22871: Use better Global Workspace Behavior KCM title and icon

GB_2 added a comment. In D22871#505311 , @ngraham wrote: > Hmm, seems a little bit long to me. Maybe just, "Global Behavior"? Or even just, "General"? It's already in a section with the word "Behavior" in it, after all. I'll name it

D22872: Rename "Desktop Behavior" category to "Workspace Behavior"

This revision was automatically updated to reflect the committed changes. Closed by commit R124:c9f7aaa0765c: Rename Desktop Behavior category to Workspace Behavior (authored by GB_2). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

This revision was automatically updated to reflect the committed changes. Closed by commit R258:894f6706afef: Improve the look of the Plymouth Boot Splash Screen KCM UI (authored by GB_2). REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

GB_2 updated this revision to Diff 62899. GB_2 added a comment. Clean up debug messages REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20549?vs=62050=62899 BRANCH arcpatch-D20549 REVISION DETAIL https://phabricator.kde.org/D20549 AFFECTED FILES

D21860: Set a font for gtk applications in the fonts kcm

GB_2 added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21860 To: gikari, #plasma, apol Cc: nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

GB_2 added inline comments. INLINE COMMENTS > zzag wrote in main.qml:118 > but it depends on how you look at it. "Night color temperature" might be a > better string. As it speaks about color temperature and not temperature of > "Night Color." Agreed. REPOSITORY R119 Plasma Desktop BRANCH

D22872: Rename "Desktop Behavior" category to "Workspace Behavior"

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY "Desktop" to users means the desktop folder, so use a more appropriate name for this category. TEST

D22871: Use better Global Workspace Behavior KCM title and icon

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Consistently call the KCM "Global Workspace Behavior" and use `preferences-desktop` as the icon

D22861: [Kicker/Kickoff] Use better "Remove from Favorites" icon

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d90e82ef7c19: [Kicker/Kickoff] Use better Remove from Favorites icon (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22861?vs=62869=62888

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

GB_2 added inline comments. INLINE COMMENTS > main.qml:118 > +RowLayout { > Kirigami.FormData.label: i18n("Night Color temperature:") > enabled: activator.checked Lowercase c? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D22861: [Kicker/Kickoff] Use better "Remove from Favorites" icon

GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Don't use a minus, because there is no plus next to it. F7127189: Kickoff Remove from Favorites Icon.png

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

GB_2 added a comment. Ping @broulik I think we should finally land this and make more changes later in case there are still any issues left. REPOSITORY R258 Plymouth KCM REVISION DETAIL https://phabricator.kde.org/D20549 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: davidedmundson,

D22716: Add icons to Categories, Installed, and Sources globaldrawer entries

GB_2 added inline comments. INLINE COMMENTS > KNSBackend.cpp:214 > }; > -auto actualCategory = new Category(m_displayName, > QStringLiteral("plasma"), filters, backendName, categories, QUrl(), true); > +const auto iconName = knsrcPlasma.contains(fileName)? >

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

GB_2 updated this revision to Diff 62050. GB_2 added a comment. Make sure Apply button gets enabled when selecting a theme for the first time REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20549?vs=62043=62050 BRANCH arcpatch-D20549 REVISION

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

GB_2 updated this revision to Diff 62043. GB_2 added a comment. Move progress bar above GHNS button REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20549?vs=61991=62043 BRANCH arcpatch-D20549 REVISION DETAIL https://phabricator.kde.org/D20549

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

GB_2 updated this revision to Diff 61991. GB_2 added a comment. - use more bindings - set `sourceSize` on the thumbnail REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20549?vs=60944=61991 BRANCH arcpatch-D20549 REVISION DETAIL

D21815: [sddm-theme] Start moving from QQC1 to QQC2

GB_2 added a comment. Ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21815 To: cblack, #plasma, #vdg, davidedmundson Cc: GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf,

D22191: Implement syncing of theme preferences between SDDM and Plasma

GB_2 added inline comments. INLINE COMMENTS > kcm_sddm.actions:301 > +Name=Sync Settings > +Description=Syncs user settings with SDDM settings > +Policy=auth_admin I think the long form of sync would be better in the description: Synchronizes REPOSITORY R123 SDDM Configuration Panel (KCM)

D22191: Implement syncing of theme preferences between SDDM and Plasma

GB_2 added inline comments. INLINE COMMENTS > advanceconfig.ui:226 > + > + > + It would be nice if you added the icon `view-refresh` to this button... > advanceconfig.ui:233 > + > + > + ...and here the icon `document-revert` or `edit-undo`. >

D22191: Implement syncing of theme preferences between SDDM and Plasma

GB_2 added a comment. In D22191#489838 , @ndavis wrote: > > Settings UI: > > F6953661: Screenshot_20190701_234413.png > > This control layout seems to imply that a user must press the "Sync" button

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

GB_2 added inline comments. INLINE COMMENTS > broulik wrote in kcm.cpp:88 > Ideally here we would reload the model and then set the newly installed theme > as current I think it should not select the newest installed theme instead of still having the current one selected, because in the "Get

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

GB_2 updated this revision to Diff 60944. GB_2 marked 2 inline comments as done. GB_2 added a comment. - Split model reloading from the `load()` function - Emit `selectedPluginIndexChanged();` after reloading the model REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE

D22170: [latte-dock] Use new activities icon

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Use the new icon added in D22155 . F6948355: latte-dock

D22169: [plasma-active-window-control] Use new activities icon

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Use the new icon added in D22155 and use an alternative icon for

D22168: [plasma-desktop] Use new activities icon

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Use the new icon added in D22155 . F6948267: plasma-desktop

D22167: [plasma-workspace] Use new activities icon

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Use the new icon added in D22155 . F6948276: plasma-workspace

D10362: Change reveal password button logic

GB_2 added a comment. Ping REPOSITORY R242 Plasma Framework (Library) BRANCH change-reveal-password-button-logic (branched from master) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: kde-frameworks-devel, rizzitello, elvisangelaccio,

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

GB_2 added a comment. Great! I'd only change the name of these avatars: Boss Konqi -> Banker Konqi Hacker Konqi -> Developer Konqi / Programmer Konqi REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D21939 To: ndavis, #vdg, #plasma Cc: GB_2, ngraham,

D21860: Set a font for gtk applications in the fonts kcm

GB_2 added a comment. So when this lands I guess we need to remove the font option from the GTK KCM. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21860 To: gikari, #plasma, apol Cc: GB_2, abetts, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas,

D21832: [sddm-kcm] Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

GB_2 added a comment. I think `plasma-sddm.conf` is a better filename. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH new-config-location (branched from master) REVISION DETAIL https://phabricator.kde.org/D21832 To: filipf, davidedmundson, ngraham, #plasma Cc: GB_2,

D21134: [Notifications] Tweak paddings

GB_2 added a comment. In D21134#478796 , @alex-l wrote: > Just a mockup but is this middle ground solution good enough? I absolutely love it! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21134 To:

<    1   2   3   4   5   6   7   >