D28873: Add SwipeNavigator component

camiloh added a comment. What about having as a view a component that is not a Kirigami.Page? Such as a StackView or a Rectangle. Why not use an attached property to define its title, icon and other props instead of focing to wrap those components into a kirigami.Page? REPOSITORY R169

D27212: Have pullback toolbars on scrollable pages also for footers

This revision was automatically updated to reflect the committed changes. Closed by commit R169:7712c75953c5: Have pullback toolbars on scrollable pages also for footers (authored by camiloh). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D27653: Fix ActionToolBar/PrivateActionToolButton in combination with QQC2 Action

camiloh added a comment. works okay for me with qqc2 actions REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27653 To: ahiemstra, #kirigami Cc: camiloh, ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart,

D27212: Have pullback toolbars on scrollable pages also for footers

camiloh marked 2 inline comments as done. camiloh added a comment. everythign is now fixed :) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27212 To: camiloh, #kirigami, mart Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra,

D24623: Missing links to pagepool source files

This revision was automatically updated to reflect the committed changes. Closed by commit R169:51205eba731a: Missing links to pagepool source files (authored by camiloh). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24623?vs=67873=76338 REVISION DETAIL

D27212: Have pullback toolbars on scrollable pages also for footers

camiloh updated this revision to Diff 76337. camiloh added a comment. downgrade qqc2 version to 2.4 and remove white spaces REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27212?vs=75195=76337 BRANCH arcpatch-D27212 REVISION DETAIL

D27638: allow to take qqc2 actions and fix issues with it not having the visible prop

camiloh created this revision. camiloh added reviewers: ahiemstra, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. camiloh requested review of this revision. REVISION SUMMARY This allows to correctly display the QQC2 Actions too, the issue was due to the loader

D27212: Have pullback toolbars on scrollable pages also for footers

camiloh updated this revision to Diff 75195. camiloh added a comment. correct undefined line REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27212?vs=75168=75195 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27212 AFFECTED FILES

D27212: Have pullback toolbars on scrollable pages also for footers

camiloh created this revision. camiloh added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. camiloh requested review of this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D27212 AFFECTED

D24623: Missing links to pagepool source files

camiloh created this revision. camiloh added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. camiloh requested review of this revision. REVISION SUMMARY failing to build on android with qmake REPOSITORY R169 Kirigami BRANCH

D23081: remove references from the icon qrc to missing icons.

This revision was automatically updated to reflect the committed changes. Closed by commit R169:b3ffca1363b1: remove references from the icon qrc to missing icons. (authored by camiloh). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23081?vs=63518=63889

D23154: allow to set custom icon for the left drawer handle

This revision was automatically updated to reflect the committed changes. Closed by commit R169:191ff22b1cb9: allow to set custom icon for the left drawer handle (authored by camiloh). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23154?vs=63742=63758

D23154: allow to set custom icon for the left drawer handle

camiloh added a comment. In D23154#511924 , @ngraham wrote: > Needs moar `@since 5.62` where ? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23154 To: camiloh, #kirigami, mart Cc: ngraham, plasma-devel,

D23154: allow to set custom icon for the left drawer handle

camiloh updated this revision to Diff 63742. camiloh added a comment. code style spaces REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23154?vs=63740=63742 BRANCH left-drawer-handle-custom-icon (branched from master) REVISION DETAIL

D23154: allow to set custom icon for the left drawer handle

camiloh updated this revision to Diff 63740. camiloh added a comment. more compact code and fix coding style spaces REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23154?vs=63738=63740 BRANCH left-drawer-handle-custom-icon (branched from master)

D23154: allow to set custom icon for the left drawer handle

camiloh updated this revision to Diff 63738. camiloh added a comment. add default handle icon props to null REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23154?vs=63737=63738 BRANCH left-drawer-handle-custom-icon (branched from master) REVISION

D23154: allow to set custom icon for the left drawer handle

camiloh created this revision. camiloh added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. camiloh requested review of this revision. REVISION SUMMARY it allows to set a icon to the globaldrawer handle, for that both close and open handle

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

This revision was automatically updated to reflect the committed changes. Closed by commit R169:fd8fec5b8923: Allow usage of QQC2 actions on Kirigami components and now make K.Action based… (authored by camiloh). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh updated this revision to Diff 63727. camiloh added a comment. clean up code, remove comments and documentation fixes REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22974?vs=63726=63727 BRANCH k-action-to-qqc2-action (branched from master)

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh updated this revision to Diff 63726. camiloh added a comment. remove debugging line REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22974?vs=63725=63726 BRANCH k-action-to-qqc2-action (branched from master) REVISION DETAIL

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh added a comment. In D22974#508067 , @mart wrote: > good direction, unfortunately we can't remove the custom toolbutton contentitem yet, so for now let's keep the custom icon group The solution here was to add back the

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh updated this revision to Diff 63725. camiloh added a comment. fallback to custom kirigamiAction property for PrivateActionToolButton - useage of the fallback property due to: if we use QQC2.ToolButton default action property then the style will draw the content, and since this

D23081: remove references from the icon qrc to missing icons.

camiloh created this revision. camiloh added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. camiloh requested review of this revision. REVISION SUMMARY this issue was affecting the building of app when using kirigami static linked REPOSITORY

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh updated this revision to Diff 63242. camiloh added a comment. remove todo line REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22974?vs=63241=63242 BRANCH k-action-to-qqc2-action (branched from master) REVISION DETAIL

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh updated this revision to Diff 63241. camiloh added a comment. Correct possible undefined result pointed out by Aleix REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22974?vs=63240=63241 BRANCH k-action-to-qqc2-action (branched from master)

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh added inline comments. INLINE COMMENTS > camiloh wrote in ActionToolBar.qml:184 > I think it then gets marked as visible = true You were right, I have now fixed it. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22974 To: camiloh, #kirigami, mart Cc:

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh updated this revision to Diff 63240. camiloh marked an inline comment as done. camiloh added a comment. further changes to make components work with new Kirigami.Action based on QQC2.Action, and proposed solution to draw the PrivateActionToolButton REPOSITORY R169 Kirigami CHANGES

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh marked 2 inline comments as done. camiloh added a comment. I have worked on the duplicating icons, by not using the contentItem to draw the icons and label, and instead use the style implementation. The only thing missing would be the dropdown icon for actions with submenus, I'm

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh created this revision. camiloh added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. camiloh requested review of this revision. REVISION SUMMARY The ideal is to be able to add regular qqc2 actions to the actiontoolbar, pageheaders,

D22648: make handle follow arbitrary height of the drawer

This revision was automatically updated to reflect the committed changes. Closed by commit R169:518444e4191a: make handle follow arbitrary height of the drawer (authored by camiloh). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22648?vs=62345=62535

D22648: make handle follow arbitrary height of the drawer

camiloh updated this revision to Diff 62345. camiloh added a comment. now using root.parent instead of applicationWindow() REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22648?vs=62309=62345 BRANCH handle-follow-drawer (branched from master) REVISION

D22648: make handle follow arbitrary height of the drawer

camiloh updated this revision to Diff 62309. camiloh added a comment. take into consideration the y position Summary: if the drawer height prop has been set to a custom value, might as well the y position too, so take it into account to position the handle REPOSITORY R169 Kirigami

D22648: make handle follow arbitrary height of the drawer

camiloh created this revision. camiloh added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. camiloh requested review of this revision. REVISION SUMMARY If the height of the drawer is set to a different value from the applicationWindow height, then

D22572: Remove scaling of iconsize unit for isMobile

This revision was automatically updated to reflect the committed changes. Closed by commit R169:a89b2334f137: Remove scaling of iconsize unit for isMobile (authored by camiloh). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22572?vs=62086=62285 REVISION

D22572: Remove scaling of iconsize unit for isMobile

camiloh created this revision. camiloh added a reviewer: VDG. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. camiloh requested review of this revision. REVISION SUMMARY On Android icons using the iconSizes units look to big for the intended size, this changed has

Re: Kirigami/qmake deployment on Android problems

but still dies. 2017-10-23 11:03 GMT-05:00 Camilo Higuita Rodriguez <chigui...@unal.edu.co>: > I've been messing around more and i found out that the minimalqmake > example dies on my desktop when in the file qtquickcontrols2.conf is set > > Style=Material > > but if

Re: Kirigami/qmake deployment on Android problems

I've been messing around more and i found out that the minimalqmake example dies on my desktop when in the file qtquickcontrols2.conf is set Style=Material but if instead is set Style=Default it works on the desktop. On android it still crashes 2017-10-23 9:27 GMT-05:00 Camilo Higuita

Re: Kirigami/qmake deployment on Android problems

gami app. 2017-10-23 4:18 GMT-05:00 Marco Martin <notm...@gmail.com>: > On Sun, Oct 22, 2017 at 10:10 PM, Camilo Higuita Rodriguez > <chigui...@unal.edu.co> wrote: > > Hi, > > I've been trying for the past two days to get my Kirigami application up > and > > worki

Kirigami/qmake deployment on Android problems

Hi, I've been trying for the past two days to get my Kirigami application up and working on Android. It all works fine in the desktop, but when i try to deploy it to an android device the application dies. I'm using qmake, because with cmake i haven't been able to get pass this error:

Kirigami/qmake problems (updated)

Hi, sorry for spamming but in my last message i was missing some information. I'm trying to build an application using Kirigami, but i'm stuck with a few issues, and i thought maybe you could help me figure out what's wrong, since i lack experience. I'm using qmake and QtCreator to deploy the

Fwd: Kirigami/qmake deployment on Android problems

Hi, I've been trying for the past two days to get my Kirigami application up and working on Android. It all works fine in the desktop, but when i try to deploy it to an android device the application dies. I'm using qmake, because with cmake i haven't been able to get pass this error: