D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-04 Thread Carson Black
cblack updated this revision to Diff 65401. cblack added a comment. Wrap those strings with i18n() REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65400&id=65401 BRANCH modernization (branched from master) REVISION DETAIL https://phabricato

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-04 Thread Carson Black
cblack updated this revision to Diff 65400. cblack marked an inline comment as done. cblack added a comment. Add changes based off of feedback, screenshot functionality REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65356&id=65400 BRANCH mode

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-03 Thread Carson Black
cblack updated this revision to Diff 65356. cblack added a comment. Removed checkbox for unused feature REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65355&id=65356 BRANCH modernization (branched from master) REVISION DETAIL https://phabr

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-03 Thread Carson Black
cblack created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Cuttlefish's UI got an overhaul. - Won't break if window width is different than expected. - Plasma components have been replac

D23560: [GTK3] Make CSD window decorations 18px instead of 16px

2019-08-29 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R98:523249683744: [GTK3] Make CSD window decorations 18px instead of 16px (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23560?vs=64933&id=64

D23560: [GTK3] Make CSD window decorations 18px instead of 16px

2019-08-29 Thread Carson Black
cblack created this revision. cblack added a reviewer: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY As mentioned by @ndavis in D23547 , window buttons should be 18p

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

2019-08-29 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R98:7b3d0777ea6c: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme. (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D235

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

2019-08-28 Thread Carson Black
cblack updated this revision to Diff 64909. cblack added a comment. Fix the rest of those SVGs REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23547?vs=64906&id=64909 BRANCH checks-and-radios (branched from master) REVISION DETAIL https://phabric

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

2019-08-28 Thread Carson Black
cblack added a comment. In D23547#521615 , @ndavis wrote: > I should have been more clear, but I meant all of the checkbox and radio button SVGs. The SVGs I provided just did the most difficult changes and could be reused to create the other ver

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

2019-08-28 Thread Carson Black
cblack updated this revision to Diff 64906. cblack added a comment. Use provided SVGs REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23547?vs=64900&id=64906 BRANCH checks-and-radios (branched from master) REVISION DETAIL https://phabricator.kde.

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

2019-08-28 Thread Carson Black
cblack updated this revision to Diff 64900. cblack added a comment. Update based off of feedback REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23547?vs=64894&id=64900 BRANCH checks-and-radios (branched from master) REVISION DETAIL https://phabr

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

2019-08-28 Thread Carson Black
cblack updated this revision to Diff 64894. cblack added a comment. Change from hover color to focus color REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23547?vs=64893&id=64894 BRANCH checks-and-radios (branched from master) REVISION DETAIL htt

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

2019-08-28 Thread Carson Black
cblack created this revision. cblack added a reviewer: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Checkboxes and radiobuttons are now recolored according to the user's colour tastes. REPOSITORY R

D23451: [GTK3] Recolor CSD titlebuttons according to user's color scheme

2019-08-26 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R98:fa8e67c617f3: [GTK3] Recolor CSD titlebuttons according to user's color scheme (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23451?vs=64

D23451: [GTK3] Recolor CSD titlebuttons according to user's color scheme

2019-08-26 Thread Carson Black
cblack updated this revision to Diff 64698. cblack added a comment. DRY that code REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23451?vs=64606&id=64698 BRANCH window-button-symbolics (branched from master) REVISION DETAIL https://phabricator.kd

D23451: [GTK3] Recolor CSD titlebuttons according to user's color scheme

2019-08-25 Thread Carson Black
cblack created this revision. cblack added reviewers: Breeze, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Window titlebuttons on CSD windows now respect the user's colorscheme, preventing colorschemes s

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-08-21 Thread Carson Black
cblack updated this revision to Diff 64261. cblack added a comment. Unscrew indentation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21815?vs=64260&id=64261 BRANCH arcpatch-D21815 REVISION DETAIL https://phabricator.kde.org/D21815 AFFECTED

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-08-21 Thread Carson Black
cblack updated this revision to Diff 64260. cblack added a comment. Add font.pointSize: config.fontSize REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21815?vs=63936&id=64260 BRANCH arcpatch-D21815 REVISION DETAIL https://phabricator.kde.org/

D20746: Remove disable for showing only minimized tasks on Icons only task manager

2019-08-18 Thread Carson Black
cblack abandoned this revision. cblack added a comment. Change made here is being made in D23242 . Abandoning this. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20746 To: cblack, #plasma, hein, #vdg Cc: broulik, ngraham,

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-08-17 Thread Carson Black
cblack updated this revision to Diff 63936. cblack added a comment. The new highlight style has been yeeted in favor of the current one REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21815?vs=60379&id=63936 BRANCH arcpatch-D21815 REVISION DETAI

D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-13 Thread Carson Black
cblack updated this revision to Diff 63676. cblack added a comment. Tweak colors some more REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23079?vs=63515&id=63676 BRANCH firefox-csd-fix (branched from master) REVISION DETAIL https://phabricator.k

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

2019-08-13 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R98:80bcaaf483da: [GTK3 -> Chrome/ium] Tweak tab stylings (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23080?vs=63661&id=63663 REVISION DE

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

2019-08-13 Thread Carson Black
cblack added a comment. I'm aware of the visibility issues of the window buttons on Breeze light CSD, however fixing those would require changes outside of the scope of this patch. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D23080 To: cblack, #breeze, #vdg

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

2019-08-13 Thread Carson Black
cblack updated this revision to Diff 63661. cblack added a comment. Change around the colors a bit REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23080?vs=63559&id=63661 BRANCH chromium-tweaks (branched from master) REVISION DETAIL https://phabr

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

2019-08-11 Thread Carson Black
cblack updated this revision to Diff 63559. cblack added a comment. Add some extra colors + backdrop colors REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23080?vs=63516&id=63559 BRANCH chromium-tweaks (branched from master) REVISION DETAIL http

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

2019-08-10 Thread Carson Black
cblack created this revision. cblack added reviewers: Breeze, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Tabs have had their colors changed to make it easier to tell which is active. REPOSITORY R98 B

D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Carson Black
cblack updated this revision to Diff 63515. cblack added a comment. Add background color to make SSD decorations more legible with patch REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23079?vs=63514&id=63515 BRANCH firefox-csd-fix (branched from ma

D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Carson Black
cblack created this revision. cblack added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY This fixes the CSD colors of Firefox to be more legible, but not without some caveats due to upstream i

D22992: [KRDB] Fix wrong names in GTK colordef exports

2019-08-07 Thread Carson Black
cblack updated this revision to Diff 63277. cblack added a comment. Fix foreground color names REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22992?vs=63276&id=63277 BRANCH fix-colordef-names (branched from master) REVISION DETAIL https://phabr

D22992: [KRDB] Fix wrong names in GTK colordef exports

2019-08-07 Thread Carson Black
cblack created this revision. cblack added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY The background color states of the button color variants were exporting to the wrong name. TEST

D22971: GTK3 - Fix menu port to colordefs

2019-08-06 Thread Carson Black
cblack created this revision. cblack added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY In D22877 , some git spaghetti caused some work on _menus.sc

D22971: GTK3 - Fix menu port to colordefs

2019-08-06 Thread Carson Black
cblack updated this revision to Diff 63212. cblack added a comment. Forgot about you there making the menus look chonkier than they should REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22971?vs=63211&id=63212 BRANCH fix-menu (branched from master)

D22844: [kcm-colors] Export colorscheme to GTK color definitions

2019-08-06 Thread Carson Black
cblack updated this revision to Diff 63207. cblack added a comment. Fix the rebase shenanigans REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=63196&id=63207 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL https://phabricat

D22844: [kcm-colors] Export colorscheme to GTK color definitions

2019-08-06 Thread Carson Black
cblack updated this revision to Diff 63196. cblack added a comment. Rebasing shenanigans, pt 3. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=63188&id=63196 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL https://phabrica

D22844: [kcm-colors] Export colorscheme to GTK color definitions

2019-08-06 Thread Carson Black
cblack updated this revision to Diff 63188. cblack added a comment. Rebase properly now? REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=63187&id=63188 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL https://phabricator.kde

D22844: [kcm-colors] Export colorscheme to GTK color definitions

2019-08-06 Thread Carson Black
cblack updated this revision to Diff 63187. cblack added a comment. Update to match master. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=63185&id=63187 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL https://phabricator.

D22844: [kcm-colors] Export colorscheme to GTK color definitions

2019-08-06 Thread Carson Black
cblack updated this revision to Diff 63185. cblack added a comment. Fix GtkColors flag REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=63123&id=63185 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL https://phabricator.kde.o

D22844: [kcm-colors] Export colorscheme to GTK color definitions

2019-08-05 Thread Carson Black
cblack updated this revision to Diff 63123. cblack added a comment. Add KRdbExportGtkColors flag to kcminit_style() REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=63025&id=63123 BRANCH kcm-colors-gtk (branched from master) REVISION DETAI

D22844: [kcm-colors] Export colorscheme to GTK color definitions

2019-08-03 Thread Carson Black
cblack updated this revision to Diff 63025. cblack added a comment. Deduplicate colors exporting code REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=63010&id=63025 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL https://ph

D22844: [kcm-colors] Export colorscheme to GTK color definitions

2019-08-02 Thread Carson Black
cblack updated this revision to Diff 63010. cblack added a comment. Fix WM colors on first go round REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=63009&id=63010 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL https://phab

D22844: [kcm-colors] Export colorscheme to GTK color definitions

2019-08-02 Thread Carson Black
cblack updated this revision to Diff 63009. cblack added a comment. Colors are now applied from the active colorscheme every time REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=63001&id=63009 BRANCH kcm-colors-gtk (branched from master)

D22844: [kcm-colors] Export colorscheme to GTK color definitions

2019-08-02 Thread Carson Black
cblack updated this revision to Diff 63001. cblack added a comment. Make GTK colors its own KRDB flag REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=62859&id=63001 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL https://ph

D22845: [GTK3] Convert all colors to use GTK color definitions

2019-08-01 Thread Carson Black
cblack added a comment. In D22845#505092 , @ngraham wrote: > Hmm, now you've removed the 3.18 and 3.20 versions entirely in favor of a single 3.0 version. This change seems like it should be done in a separate patch. Closing this to reor

D22876: [Breeze-GTK] Merge gtk320 and gtk318 into gtk3

2019-08-01 Thread Carson Black
cblack created this revision. cblack added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY GTK 3.20 and GTK 3.18 are now merged into a single GTK 3.0 directory. This will reduce work needed i

D22845: [GTK3] Convert all colors to use GTK color definitions

2019-07-31 Thread Carson Black
cblack added a comment. In D22845#504927 , @ngraham wrote: > Neato mosquito! > > Unfortunately, it doesn't build: > > [ 75%] Building CXX object kconf_update/CMakeFiles/gtkbreeze5.5.dir/main.cpp.o > Installing into /home/nate/kde/bu

D22845: [GTK3] Convert all colors to use GTK color definitions

2019-07-31 Thread Carson Black
cblack updated this revision to Diff 62882. cblack added a comment. Forgot to add you REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22845?vs=62881&id=62882 BRANCH colordefs (branched from master) REVISION DETAIL https://phabricator.kde.org/D228

D22845: [GTK3] Convert all colors to use GTK color definitions

2019-07-31 Thread Carson Black
cblack updated this revision to Diff 62881. cblack added a comment. Fix CMakeLists.txt REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22845?vs=62858&id=62881 BRANCH colordefs (branched from master) REVISION DETAIL https://phabricator.kde.org/D22

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

2019-07-31 Thread Carson Black
cblack updated this revision to Diff 62859. cblack added a comment. Dump the rest of the colors. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=62847&id=62859 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL https://phabric

D22845: [GTK3] Convert all colors to use GTK color definitions

2019-07-31 Thread Carson Black
cblack updated this revision to Diff 62858. cblack added a comment. Fix some issues with incorrect colors being used REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22845?vs=62825&id=62858 BRANCH colordefs (branched from master) REVISION DETAIL h

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

2019-07-31 Thread Carson Black
cblack added a comment. In D22844#504691 , @davidre wrote: > It seems the header with the new flag is missing from the diff. I put it alongside the content in the existing `exportColors` flag because there's no reason to make a flag for e

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

2019-07-31 Thread Carson Black
cblack updated this revision to Diff 62847. cblack added a comment. Incorporate feedback REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=62819&id=62847 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL https://phabricator.kde

D22845: [GTK3] Convert all colors to use GTK color definitions

2019-07-30 Thread Carson Black
cblack updated this revision to Diff 62825. cblack added a comment. Good job at picking up that change, arc. See previous change. REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22845?vs=62824&id=62825 BRANCH colordefs (branched from master) REVISI

D22845: [GTK3] Convert all colors to use GTK color definitions

2019-07-30 Thread Carson Black
cblack updated this revision to Diff 62824. cblack added a comment. Forgot about changing the build_theme.sh to export to my home directory under the name Breeze-Dev, reversed that REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22845?vs=62822&id=6282

D22845: [GTK3] Convert all colors to use GTK color definitions

2019-07-30 Thread Carson Black
cblack created this revision. cblack added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY All of the colors pulled from a colorscheme in Breeze GTK now use GTK's color definitons, allowi

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

2019-07-30 Thread Carson Black
cblack created this revision. cblack added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY This exports the active colorscheme to ~/.config/gtk-3.0/colors.css and sets up ~/.config/gtk-3.0/gt

D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen

2019-07-17 Thread Carson Black
cblack updated this revision to Diff 61916. cblack added a comment. Hide logo by default REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22458?vs=61859&id=61916 BRANCH distro-logo-slot (branched from master) REVISION DETAIL https://phabricator

D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen

2019-07-16 Thread Carson Black
cblack added a comment. Doesn't really matter to me ¯\_(ツ)_/¯ If other people want it off by default, I'll update the default theme.conf REPOSITORY R120 Plasma Workspace BRANCH distro-logo-slot (branched from master) REVISION DETAIL https://phabricator.kde.org/D22458 To: cblack, #vd

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-16 Thread Carson Black
cblack updated this revision to Diff 61859. cblack added a comment. Remove sourceSize.width REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22458?vs=61825&id=61859 BRANCH distro-logo-slot (branched from master) REVISION DETAIL https://phabrica

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-15 Thread Carson Black
cblack updated this revision to Diff 61825. cblack added a comment. More sizing tweaks REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22458?vs=61819&id=61825 BRANCH distro-logo-slot (branched from master) REVISION DETAIL https://phabricator.k

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-15 Thread Carson Black
cblack updated this revision to Diff 61819. cblack added a comment. Sizing tweaks REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22458?vs=61814&id=61819 BRANCH distro-logo-slot (branched from master) REVISION DETAIL https://phabricator.kde.or

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-15 Thread Carson Black
cblack updated this revision to Diff 61814. cblack added a comment. Add sourceSize.width to the party REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22458?vs=61813&id=61814 BRANCH distro-logo-slot (branched from master) REVISION DETAIL https:

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-15 Thread Carson Black
cblack updated this revision to Diff 61813. cblack added a comment. Define sourceSize.height REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22458?vs=61809&id=61813 BRANCH distro-logo-slot (branched from master) REVISION DETAIL https://phabric

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-15 Thread Carson Black
cblack added inline comments. INLINE COMMENTS > filipf wrote in Main.qml:415 > to the height and width of the item I believe, at least that's what I did > here: https://github.com/KDE/sddm-kcm/blob/master/src/qml/main.qml#L54 I don't really have a defined width, but I guess I could define the h

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-15 Thread Carson Black
cblack added inline comments. INLINE COMMENTS > broulik wrote in Main.qml:415 > Also set a `sourceSize` and probably `asynchronous: true` I haven't a clue what I should set `sourceSize` to ¯\_(ツ)_/¯ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22458 To: cb

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-15 Thread Carson Black
cblack updated this revision to Diff 61809. cblack added a comment. Rename config file properties to not say "distro" Use gridunit Use opacityanimator REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22458?vs=61774&id=61809 BRANCH distro-logo-

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-15 Thread Carson Black
cblack added inline comments. INLINE COMMENTS > broulik wrote in Main.qml:414 > Why not just a bool? the config object exposes `true` as `"true"`, not `true`, so ¯\_(ツ)_/¯ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22458 To: cblack, #vdg, #plasma Cc: dav

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-14 Thread Carson Black
cblack updated this revision to Diff 61774. cblack added a comment. Use units.longDuration REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22458?vs=61761&id=61774 BRANCH distro-logo-slot (branched from master) REVISION DETAIL https://phabricat

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-14 Thread Carson Black
cblack updated this revision to Diff 61761. cblack added a comment. Logo has text now REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22458?vs=61756&id=61761 BRANCH distro-logo-slot (branched from master) REVISION DETAIL https://phabricator.kd

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-14 Thread Carson Black
cblack added a comment. In D22458#495455 , @ngraham wrote: > An interesting idea. Are you in contact with any distros that have requested this or would make use of it? This was created directly because an LCP (artwork dude) at openSUSE re

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-14 Thread Carson Black
cblack updated this revision to Diff 61756. cblack added a comment. This is why you shouldn't forget to test - default logo is now no longer pitifully small REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22458?vs=61755&id=61756 BRANCH distro-lo

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-14 Thread Carson Black
cblack created this revision. cblack added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY The Breeze SDDM theme now shows a logo that can be configured by distro vendors or curious users. TEST

D22452: Fix text color in non-selected tabs in Firefox

2019-07-14 Thread Carson Black
cblack added a comment. I would probably replace `color: #eff0f1;` -> `color: t_color(text);` `background-color: #475057;` -> `background-color: t_color(background);` in `_firefox.scss` to not hardcode the colors REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kd

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-22 Thread Carson Black
cblack updated this revision to Diff 60379. cblack added a comment. - Change toolBtn to be more descriptive based on file the id was in - Styling changes on menus (they now have shadows) - Menu item highlight is tweaked as per T11124 (can revert if shou

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-22 Thread Carson Black
cblack added a comment. In D21815#482624 , @filipf wrote: > For positioning the menu maybe you could have a look at how it was done in Kickoff config window: https://github.com/KDE/plasma-desktop/blob/master/applets/kickoff/package/contents/ui/C

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-20 Thread Carson Black
cblack updated this revision to Diff 60136. cblack added a comment. - Remove Item {} root and embed QQC2.Menu {} in PlasmaComponents.ToolButton{} - If toolbutton is larger than largest menu item, resize menu to size of toolbutton - Other minor things REPOSITORY R120 Plasma Workspace CH

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-20 Thread Carson Black
cblack added inline comments. INLINE COMMENTS > filipf wrote in SessionButton.qml:47 > While we're doing this, can you perhaps make the menu pop up *above* the > button? It seems that changing the `y` value doesn't affect its y position for whatever reason. REPOSITORY R120 Plasma Workspace

D21877: Hide tooltip when PrivateActionToolButton is pressed

2019-06-17 Thread Carson Black
cblack created this revision. cblack added reviewers: Plasma, Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY The tooltip used to remain even as the button was pressed, now it doesn't/shouldn't. TES

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-15 Thread Carson Black
cblack updated this revision to Diff 59884. cblack added a comment. Use PC3 components in the kb & session buttons instead of PC2 components REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21815?vs=59880&id=59884 BRANCH sddm-qqc2-port (branched f

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-15 Thread Carson Black
cblack added inline comments. INLINE COMMENTS > cblack wrote in SessionButton.qml:23 > The `menu` property seems to be removed in PC3 Additionally, `ToolButton` still seems to use QQC1 even in PC3. REPOSIT

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-15 Thread Carson Black
cblack added inline comments. INLINE COMMENTS > davidedmundson wrote in SessionButton.qml:23 > Note that (confusingly) Plasma components 2 is QQC1 > Plasma components3 is QQC2 > > It might fix the menu issue The `menu` property seems to be removed in PC3 REPOSITORY R120 Plasma Workspace REV

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-15 Thread Carson Black
cblack added inline comments. INLINE COMMENTS > davidedmundson wrote in SessionButton.qml:27 > Why the wrapper? QML files can only have one root, and the ToolButton's `menu` property doesn't accept QQC2 menus, meaning they have to be separated. REPOSITORY R120 Plasma Workspace REVISION DETA

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-15 Thread Carson Black
cblack updated this revision to Diff 59880. cblack added a comment. Updates based off of feedback, and adding the standard menu fade animation to the QQC2 menus. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21815?vs=59842&id=59880 BRANCH sddm

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-14 Thread Carson Black
cblack updated this revision to Diff 59842. cblack added a comment. Looks like this change managed to hide from Arcanist's gaze. Should have been there in the first place. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21815?vs=59841&id=59842 BRA

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-14 Thread Carson Black
cblack created this revision. cblack added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Components that used QQC1 in `sddm-theme/` (excluding the symlinked `components` folder) have be

D21794: Style the session selector to be more Breeze

2019-06-14 Thread Carson Black
cblack added a comment. @filipf Don't know but the answer is probably a no. INLINE COMMENTS > ngraham wrote in BreezeMenuStyle.qml:6 > Why does this have to be QQC1? 1. Styles are a QQC1 thing (QQC2 components can't take them) 2. The PlasmaComponents.ToolButton's `menu` property won't accept

D21794: Style the session selector to be more Breeze

2019-06-14 Thread Carson Black
cblack updated this revision to Diff 59809. cblack removed a subscriber: ngraham. cblack added a comment. Remove unneeded property. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21794?vs=59808&id=59809 BRANCH better-session-menu (branched from

D21794: Style the session selector to be more Breeze

2019-06-14 Thread Carson Black
cblack updated this revision to Diff 59808. cblack added a comment. Tweak border coloration (steal it from Kirigami) and remove whitespace REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21794?vs=59806&id=59808 BRANCH better-session-menu (branche

D21794: Style the session selector to be more Breeze

2019-06-14 Thread Carson Black
cblack updated this revision to Diff 59806. cblack added a comment. Menu border, less hardcoding, and moving the menu style into a seperate file to reduce duplicated code. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21794?vs=59803&id=59806 BRA

D21794: Style the session selector to be more Breeze

2019-06-14 Thread Carson Black
cblack added a comment. As requested by @apol, here is a screenshot of the menu with the new styling (I'm using a custom colorscheme currently, which is why the menu appears black in this screenshot). F6889655: image.png INLINE COMMENTS > filipf wrote

D21794: Style the session selector to be more Breeze

2019-06-14 Thread Carson Black
cblack updated this revision to Diff 59803. cblack added a comment. Less harcoding & style keyboard button as well REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21794?vs=59771&id=59803 BRANCH better-session-menu (branched from master) REVISION

D21794: Style the session selector to be more Breeze

2019-06-13 Thread Carson Black
cblack created this revision. cblack added reviewers: VDG, filipf. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY The session selector's menu is now styled to resemble the Breeze theme rather than the default Q

D20746: Remove disable for showing only minimized tasks on Icons only task manager

2019-04-23 Thread Carson Black
cblack added a comment. In D20746#455012 , @ngraham wrote: > -snip- > Can you describe what it is that makes you want this functionality in the IOTM rather than just using the regular task manager and enabling this feature? The regular

D20746: Remove disable for showing only minimized tasks on Icons only task manager

2019-04-22 Thread Carson Black
cblack created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY This patch removes the visible: property that hides the option to show only tasks that are minimized to users of the icons only task

<    2   3   4   5   6   7