Review Request 127485: KCM: Add button to set default devices

m-default-device.png https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/6d5d5bb5-3619-470c-b6d6-e7693d888c9b__kcm-default-device.png Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127484: applet: Add streams tab to manage applications volume

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/#review93937 --- On March 24, 2016, 2:28 p.m., David Rosca wrote: > >

Re: Review Request 127484: applet: Add streams tab to manage applications volume

omatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/#review93929 --- On March 24, 2016, 2:28 p.m., David Rosca wrote: > > ---

Re: Review Request 127484: applet: Add streams tab to manage applications volume

ly generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/#review93930 --- On March 24, 2016, 2:28 p.m., David Rosca wrote: > > --- > This is an auto

Re: Review Request 127484: applet: Add streams tab to manage applications volume

://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/30a3cdfb-b6b5-41c7-bb15-37c6b87604a4__applet-streams.png applet-streams-more-devices.png https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/82f0eb13-95a5-4d0c-b50b-682cf7c3b384__applet-streams-more-devices.png Thanks, David

Re: Review Request 127484: applet: Add streams tab to manage applications volume

-4d0c-b50b-682cf7c3b384__applet-streams-more-devices.png applet-streams-more-devices.png https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/b2dafc91-4bde-42dc-bfd5-036ee001b984__applet-streams-more-devices.png Thanks, David Rosca

Review Request 127484: applet: Add streams tab to manage applications volume

-b6b5-41c7-bb15-37c6b87604a4__applet-streams.png applet-streams-more-devices.png https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/82f0eb13-95a5-4d0c-b50b-682cf7c3b384__applet-streams-more-devices.png Thanks, David Rosca ___ Plasma-devel

Re: Review Request 127467: PulseClient: Implement heuristics to find icon for stream

ns (hello chrome, as usual ;) is a good way to go.. > > should use the same heuristics as the taskbar? > > David Rosca wrote: > I now added special case for plasmashell and kded, as those have no > desktop file. Even though it's still hacky, I think it's better than to

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

> On March 24, 2016, 6:25 a.m., David Rosca wrote: > > Please see https://git.reviewboard.kde.org/r/125088/. I myself am against > > blocking it, but there is a valid reason for it. > > > > Also, I think you can just remove the MouseArea (as Slider allows to change

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

> On March 24, 2016, 6:25 a.m., David Rosca wrote: > > Please see https://git.reviewboard.kde.org/r/125088/. I myself am against > > blocking it, but there is a valid reason for it. > > > > Also, I think you can just remove the MouseArea (as Slider allows to change

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

> On March 24, 2016, 6:25 a.m., David Rosca wrote: > > Please see https://git.reviewboard.kde.org/r/125088/. I myself am against > > blocking it, but there is a valid reason for it. > > > > Also, I think you can just remove the MouseArea (as Slider allows to change

Re: Review Request 127467: PulseClient: Implement heuristics to find icon for stream

show icon at all for these apps... - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127467/#review93884 ------- On

Re: Review Request 127467: PulseClient: Implement heuristics to find icon for stream

, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

myself am against blocking it, but there is a valid reason for it. Also, I think you can just remove the MouseArea (as Slider allows to change value with mouse wheel by default) instead of reimplementing the logic. - David Rosca On March 23, 2016, 5:43 p.m., Anthony Fieroni wrote

Review Request 127477: KCM: Add ScrollView to PulseView

--- Tabs in KCM now shows scrollbar when contents overflows. Diffs - src/kcm/package/contents/ui/PulseView.qml dd70eed Diff: https://git.reviewboard.kde.org/r/127477/diff/ Testing --- Thanks, David Rosca ___ Plasma-devel mailing list

Review Request 127467: KCM: Fix showing empty stream icon

without icon It would now also be possible to do some heuristic with matching binary name to desktop file as the FIXME suggests. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127466: KCM: Fix icon size in StreamListItem

--- Also set smaller spacing. Diffs - src/kcm/package/contents/ui/StreamListItem.qml 7f1d69e Diff: https://git.reviewboard.kde.org/r/127466/diff/ Testing --- Newly added streams now have the same icon size as the other streams. Thanks, David Rosca

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

rg/r/127460/#review93875 --- On March 22, 2016, 3:25 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127460/ > ---

Re: Review Request 127464: Fix 1px offset in QtQuickControls TabView frame

marked as submitted. Review request for Plasma and Hugo Pereira Da Costa. Changes --- Submitted with commit 65a0c6256729a9cffa89702dbda518424de2efc0 by David Rosca to branch Plasma/5.6. Repository: breeze Description --- TabView contents frame border now merges with the left/right

Review Request 127464: Fix 1px offset in QtQuickControls TabView frame

Description --- TabView contents frame border now merges with the left/right tab. Diffs - kstyle/breezestyle.cpp 9a4b674 Diff: https://git.reviewboard.kde.org/r/127464/diff/ Testing --- Looks same as QtWidgets now. Thanks, David Rosca

Re: Review Request 127463: Expand size of CT_ItemViewItem also with QtQuickControls

marked as submitted. Review request for Plasma and Hugo Pereira Da Costa. Changes --- Submitted with commit 9e7983a0896aa13d859b413a888a325bba177c0a by David Rosca to branch Plasma/5.6. Repository: breeze Description --- Fixes the spacing in view items, including ComboBox popup

Review Request 127463: Expand size of CT_ItemViewItem also with QtQuickControls

ime zones. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

marked as submitted. Review request for Plasma and Hugo Pereira Da Costa. Changes --- Submitted with commit c2008d6d3a62b3f7f6e5198e047d39b4a40ecf7e by David Rosca to branch Plasma/5.6. Bugs: 343369 https://bugs.kde.org/show_bug.cgi?id=343369 Repository: breeze Description

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

-1aa3-46d6-bf61-5b84c7eb11cc__popup-light.png popup-dark.png https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/c534f049-0712-490f-8107-13b3670e2318__popup-dark.png Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127460/#review93866 ------- On March 22, 2016, 2:35 p.m., David Rosca wrote: > > -

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

-1aa3-46d6-bf61-5b84c7eb11cc__popup-light.png popup-dark.png https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/c534f049-0712-490f-8107-13b3670e2318__popup-dark.png Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

(updated) - kstyle/breezestyle.cpp 9a4b674 Diff: https://git.reviewboard.kde.org/r/127460/diff/ Testing --- QtQuickControls ComboBox popups now use palette colors and have correct spacing. Thanks, David Rosca ___ Plasma-devel mailing list

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

: 343369 Diffs (updated) - kstyle/breezestyle.cpp 9a4b674 Diff: https://git.reviewboard.kde.org/r/127460/diff/ Testing --- QtQuickControls ComboBox popups now use palette colors and have correct spacing. Thanks, David Rosca ___ Plasma-devel

Review Request 127460: Fix drawing QtQuickControls ComboBox popups

://git.reviewboard.kde.org/r/127460/diff/ Testing --- QtQuickControls ComboBox popups now use palette colors and have correct spacing. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1019: Modify keyboard focus order in lock screen

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEb553843aeda4: Modify keyboard focus order in lock screen (authored by drosca). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

Re: Questions on Plasma i18n strings

Hi, On Wed, Mar 16, 2016 at 5:31 PM, Alexander Potashev wrote: > Hi, > > I don't understand the meaning of a couple of messages in Plasma, and > have a few other requests: > > > 2. In bluedevil, "Add user account" should be changed to "Add device" > in

Re: Review Request 127422: Dialog: Set SkipTaskbar/Pager states before showing window

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 28b4400da8481251084ac38b26b4347703a3ab54 by David Rosca to branch master. Repository: plasma-framework Description --- This sets the states before showing the window and is a proper fix

[Differential] [Closed] D1117: Fix assigning undefined to double warning on startup

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP3df891982bd1: Fix assigning undefined to double warning on startup (authored by drosca). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1069: Fix length returned from PanelView::geometryByDistance

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE3c9d4a1db209: Fix length returned from PanelView::geometryByDistance (authored by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1069?vs=2836=2847#toc REPOSITORY

[Differential] [Updated, 2 lines] D1069: Fix length returned from PanelView::geometryByDistance

drosca updated this revision to Diff 2836. drosca added a comment. Rebase REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1069?vs=2559=2836 BRANCH geometry-by-distance (branched from master) REVISION DETAIL

Review Request 127422: Dialog: Set SkipTaskbar/Pager states before showing window

--- Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127374: Fix taskbar flicking when opening Plasma popups

the _NET_WM_STATE hints are reset by Qt before Expose event, not in Show event. But I'm not sure about this one (didn't look in the code). My patch however fixes it correctly :) - David Rosca On March 15, 2016, 2:36 p.m., David Edmundson wrote

[Differential] [Commented On] D1113: New Desktop Theme KCM

drosca added inline comments. INLINE COMMENTS kcms/desktoptheme-qml/kcm.h:41 It is actually needed to cast to int in model::roleNames() kcms/desktoptheme-qml/package/contents/ui/ThemePreview.qml:31 Because air's background svg has huge margins. This special case could be removed when we

[Differential] [Updated, 818 lines] D1113: New Desktop Theme KCM

drosca updated this revision to Diff 2751. drosca added a comment. Fix issues Remove shadow from clock hands + add center screw Always show vertical scrollbar to fix binding loop on width REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Request, 17 lines] D1134: Alternatives: Add new applet only after the old one was removed

drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY New applet is now added at the same position as the old one. CCBUG: 358827 REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH

Re: Review Request 127355: Replace QMenu::exec with QMenu::popup

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 8f6d1f17e455334fe64b879bcb90bdc238b22696 by David Rosca to branch master. Repository: plasma-framework Description --- ^^ Diffs - src/scriptengines/qml/plasmoid/appletinterface.cpp 2337652

Re: Review Request 127344: FrameSvg: Fix dangling pointers in sharedFrames when theme changes

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 974a2b5071b4f0c12a97525d18c8cf7c5c93f548 by David Rosca to branch master. Repository: plasma-framework Description --- Store theme pointer in FrameData and set it when adding to sharedFrames

Re: Review Request 127342: IconItem: Schedule pixmap update when window changes

marked as submitted. Review request for Plasma. Changes --- Submitted with commit fd4632230006a81c37a9ca2678b36fd49bd6c714 by David Rosca to branch master. Repository: plasma-framework Description --- QQuickItem::polish is not called when window changes. Regression from

Review Request 127355: Replace QMenu::exec with QMenu::popup

as before. There are still two places where QMenu::exec is used (containmentinterface.cpp: processMimeData and mimeTypeRetrieved) but the code is much more complex to replace. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https

[Differential] [Request, 135 lines] D1126: Remove Desktop.SystemSettings import

drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Port to Qt.styleHints (Qt >= 5.5) REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH stylehints (branched from master) REVISION DETAIL

[Differential] [Updated, 825 lines] D1113: New Desktop Theme KCM

drosca updated this revision to Diff 2721. drosca added a comment. Keep the Plasma::Theme in cache Fix logic of needs save REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1113?vs=2682=2721 BRANCH desktoptheme-kcm (branched from master)

Review Request 127344: FrameSvg: Fix dangling pointers in sharedFrames when theme changes

/ Testing --- Test not crashing Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127339: Make QtWebKit optional

marked as submitted. Review request for Plasma. Changes --- Submitted with commit eb73cbee3c2d3fa7d4a52eb239461c062db31472 by David Rosca to branch master. Repository: plasma-sdk Description --- ^^ Diffs - CMakeLists.txt a366672 Diff: https://git.reviewboard.kde.org/r

[Differential] [Closed] D1120: LayoutManager: Restore rotation on remove applet undo

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPa59132ab3eae: LayoutManager: Restore rotation on remove applet undo (authored by drosca). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

Re: Review Request 127340: Applet: Stop deleteNotificationTimer when undo is triggered

6bb02c88ebece5c732bbacd861002bd00999d3bc Diffs - src/plasma/private/applet_p.cpp 14b1deb Diff: https://git.reviewboard.kde.org/r/127340/diff/ Testing --- Add widget -> remove widget -> undo -> wait 60 s -> applet no longer disappears by itself Thanks,

Review Request 127342: IconItem: Schedule pixmap update when window changes

/127342/diff/ Testing --- Add show activity manager applet -> remove -> undo -> icon is now correctly rendered. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127340: Applet: Stop deleteNotificationTimer when undo is triggered

14b1deb Diff: https://git.reviewboard.kde.org/r/127340/diff/ Testing --- Add widget -> remove widget -> undo -> wait 60 s -> applet no longer disappears by itself Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@k

Re: Review Request 127302: IconItem: Animate active and enabled change even with animations disabled

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 46a1181587c3d26c42caeec7281862753ec3f9b5 by David Rosca to branch master. Repository: plasma-framework Description --- `animated: false` should disable just animation when changing source, we still

[Differential] [Request, 16 lines] D1120: LayoutManager: Restore rotation on remove applet undo

drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Undo remove applet now restores rotation REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH undo-rotation (branched from Plasma/5.6)

[Differential] [Request, 4 lines] D1117: Fix assigning undefined to double warning on startup

drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Default value for Layout constraints is -1 REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH desktop-preferred-size-warning (branched from

Review Request 127339: Make QtWebKit optional

--- ^^ Diffs - CMakeLists.txt a366672 Diff: https://git.reviewboard.kde.org/r/127339/diff/ Testing --- Builds fine without QtWebKit Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

[Differential] [Commented On] D1113: New Desktop Theme KCM

drosca added a comment. F94789: kcm_desktoptheme.png REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1113 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma Cc:

[Differential] [Request, 819 lines] D1113: New Desktop Theme KCM

drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY New Desktop Theme KCM It is in new directory (desktoptheme-qml) for easier review. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH

Re: Review Request 127315: Icon applet: Set sensible minimum height

, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D933: Fix minimum size of Applet handle with Folder View

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPad38d1ada6f0: Fix minimum size of applet handle when there is Open with button (authored by drosca). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D941: Fix position of new applets added with drag and drop

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPf3f6867da885: Fix position of new applets added with drag and drop (authored by drosca). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

Review Request 127315: Icon applet: Set sensible minimum height

--- ^^ Diffs - applets/icon/package/contents/ui/main.qml acc493a Diff: https://git.reviewboard.kde.org/r/127315/diff/ Testing --- Icon is now always visible Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 127313: [Icon Item] Don't call loadPixmap in setColorGroup

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127313/#review93329 --- Ship it! Ship It! - David Rosca On March 9, 2016, 11

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

tps://git.reviewboard.kde.org/r/122859/#comment63650> ? - David Rosca On March 9, 2016, 10:29 a.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 127312: Remove QtScript dependency

marked as submitted. Review request for Plasma. Changes --- Submitted with commit d4053782192e55fd66a684171c764dc0328029b8 by David Rosca to branch master. Repository: plasma-framework Description --- It's not used anywhere. Diffs - CMakeLists.txt 7fd7518 src

Review Request 127312: Remove QtScript dependency

/dataenginebindings_p.h 3309d2b src/scriptengines/qml/CMakeLists.txt 842fc88 src/scriptengines/qml/plasmoid/appletinterface.h 16ce955 Diff: https://git.reviewboard.kde.org/r/127312/diff/ Testing --- Builds. Thanks, David Rosca ___ Plasma-devel mailing list

Re: Review Request 127302: IconItem: Animate active and enabled change even with animations disabled

/ Testing --- Tests pass. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127302: IconItem: Animate active change even with animations disabled

- David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127302/#review93303 --- On March 7, 2016, 11:37 a.m., David Rosca wrote: > > --- > This i

Review Request 127302: IconItem: Animate active change even with animations disabled

/iconitem.cpp 6c23a7e Diff: https://git.reviewboard.kde.org/r/127302/diff/ Testing --- Tests pass. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1079: UdevNotifier: Emit new devices on resume from suspend

drosca updated the summary for this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1079 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma, broulik Cc: plasma-devel

[Differential] [Request, 29 lines] D1079: UdevNotifier: Emit new devices on resume from suspend

drosca created this revision. drosca added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Fix reapplying mouse and keybaord settings when resuming from suspend on systems where xcb-xinput is not available. REPOSITORY

Re: Review Request 127277: ContainmentInterface: Fix use of QRect right() and bottom()

marked as submitted. Review request for Plasma. Changes --- Submitted with commit da340aaefa9cb82820743b62879f61bcb709d882 by David Rosca to branch master. Repository: plasma-framework Description --- right() = x() + width() - 1 bottom() = y() + height() - 1 Diffs - src

Re: Review Request 127282: IconItem: Don't overwrite source when using QIcon::name()

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 978b8b3b87671ac6b3a365b6b5b3dbe42b2a017b by David Rosca to branch master. Repository: plasma-framework Description --- source should always return the same value as it was assigned. Also removed

Re: Review Request 127282: IconItem: Don't overwrite source when using QIcon::name()

) - autotests/iconitemtest.h 2de8512 autotests/iconitemtest.cpp 8d3f494 src/declarativeimports/core/iconitem.h 651a101 src/declarativeimports/core/iconitem.cpp b1c4c7a Diff: https://git.reviewboard.kde.org/r/127282/diff/ Testing --- Tests pass. Thanks, David Rosca

Re: Review Request 127282: IconItem: Don't overwrite source when using QIcon::name()

ard.kde.org/r/127282/#review93177 --- On March 4, 2016, 10:12 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Review Request 127282: IconItem: Don't overwrite source when using QIcon::name()

/declarativeimports/core/iconitem.h 651a101 src/declarativeimports/core/iconitem.cpp b1c4c7a Diff: https://git.reviewboard.kde.org/r/127282/diff/ Testing --- Tests pass. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 127280: Fix memory leak in icon item test

this is needed. - David Rosca On March 4, 2016, 8:37 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127277: ContainmentInterface: Fix use of QRect right() and bottom()

> On March 4, 2016, 4:29 p.m., Marco Martin wrote: > > yep, the patch is correct... > > +1 for adding a test tough > > David Rosca wrote: > I'm for adding test too, but there are currently no tests in > plasma-workspace and also I think it won't be easy to test i

Re: Review Request 127277: ContainmentInterface: Fix use of QRect right() and bottom()

ing sprint next week. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127277/#review93168 --- On March 4, 2016, 3:26 p.m., Da

[Differential] [Request, 11 lines] D1072: Make sure desktop toolbox has integer and even size

drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Fixes one pixel gap when positioned on the right side. Also enable clipping only when animation is running. REPOSITORY rPLASMADESKTOP

Review Request 127277: ContainmentInterface: Fix use of QRect right() and bottom()

--- right() = x() + width() - 1 bottom() = y() + height() - 1 Diffs - src/scriptengines/qml/plasmoid/containmentinterface.cpp 845bb4d Diff: https://git.reviewboard.kde.org/r/127277/diff/ Testing --- Thanks, David Rosca ___ Plasma

[Differential] [Commented On] D1069: Fix length returned from PanelView::geometryByDistance

drosca added a comment. Scrath that, it's the Dialog positioning that uses rect instead of region (and that's unrelated to this). ContainmentInterface::adjustToAvailableScreenRegion is fine. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1069

[Differential] [Commented On] D1069: Fix length returned from PanelView::geometryByDistance

drosca added a comment. availableScreenRegion is constructed from screen region minus panel rects (and panel rect = geometryByDistance(0)) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1069 EMAIL PREFERENCES

[Differential] [Commented On] D1069: Fix length returned from PanelView::geometryByDistance

drosca added a comment. I'm not sure if this should go to Plasma/5.6 as it exposes a bug in ContainmentInterface::adjustToAvailableScreenRegion. Fun fact, it was working mostly alright with the wrong available region :D The bug is that it now basically operates on available rect (and

[Differential] [Request, 2 lines] D1069: Fix length returned from PanelView::geometryByDistance

drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY PanelView::length() is not actual length. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH geometry-by-distance (branched from

[Differential] [Commented On] D1066: Fix saving correct length of panel

drosca added a comment. It would probably be worth for 5.7 to rename panel.length to panel.preferredLength. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1066 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Abandoned] D1066: Fix saving correct length of panel

drosca abandoned this revision. drosca added a comment. I see it now, sorry. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1066 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma, davidedmundson

[Differential] [Commented On] D1066: Fix saving correct length of panel

drosca added a comment. The problem is that PanelView::length() is always set to Layout.preferredSize, which says nothing about the actual panel length. PanelView::length() seems to be used only for restoring size of panel, but in most (all?) cases it gets overridden by

[Differential] [Request, 4 lines] D1066: Fix saving correct length of panel

drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY This fixes calculating correct availableScreenRegion as PanelView::length is used in PanelView::geometryByDistance. REPOSITORY

Re: Review Request 127268: Docs for IconItem

t please use your (better) wording. - David Rosca On March 3, 2016, 5:36 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revi

[Differential] [Closed] D1050: Center contents of desktop toolbox

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP3df205ea70f8: Center contents of desktop toolbox (authored by drosca). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1050?vs=2519=2520

[Differential] [Request, 31 lines] D1050: Center contents of desktop toolbox

drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Works only with Breeze theme, other themes needs to adjust widgets/translucentbackground to not have any transparent margins. REPOSITORY

[Differential] [Closed] D1049: Fix crash on item move with manual sorting strategy

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP04fc22dc6e20: Fix crash on item move with manual sorting strategy (authored by drosca). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D1049: Fix crash on item move with manual sorting strategy

drosca added a comment. To master. 5.6 branching didn't happen yet. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH tm-crash (branched from master) REVISION DETAIL https://phabricator.kde.org/D1049 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Updated, 6 lines] D1049: Fix crash on item move with manual sorting strategy

drosca updated this revision to Diff 2516. drosca added a comment. Typo REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1049?vs=2515=2516 BRANCH tm-crash (branched from master) REVISION DETAIL https://phabricator.kde.org/D1049

[Differential] [Request, 6 lines] D1049: Fix crash on item move with manual sorting strategy

drosca created this revision. drosca added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Add nullptr check for item returned from getMemberById. BUG: 358871 REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH tm-crash

[Differential] [Closed] D948: Don't show applet handle outside of desktop

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPb65ef8797d97: Don't show applet handle outside of desktop (authored by drosca). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Updated, 61 lines] D948: Don't show applet handle outside of desktop

drosca updated this revision to Diff 2510. drosca added a comment. Reset verticalCenterOffset when handleMerged changes. Also increment appletItem.z to fix handle showing under other applets. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1045: Emit PaletteChanged when setting colors from look and feel package

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPec5e86a51764: Emit PaletteChanged when setting colors from look and feel package (authored by drosca). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D1045: Emit PaletteChanged when setting colors from look and feel package

drosca added inline comments. INLINE COMMENTS kcms/lookandfeel/kcm.cpp:342 Yes, QDBusMessage::createSignal instead of KGlobalSettings as this just emits one signal. But KGlobalSettings is already used in this file so it doesn't really matter. REPOSITORY rPLASMADESKTOP Plasma Desktop

<    2   3   4   5   6   7   8   9   10   11   >