Re: plasma-desktop build error on RPi2

2016-01-26 Thread David Rosca
Hi, > /usr/include/boost/type_traits/is_reference.hpp:24:16: fatal error: > recursive template instantiation exceeded maximum depth of 256 > ::boost::is_lvalue_reference::value || > ::boost::is_rvalue_reference::value> That means this check for clang [1] is not working. Would be great if yo

Re: Review Request 126841: Use PlasmaCore.IconItem in Kicker, Kickoff and Folder View

2016-01-26 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 58193a3926be45219c3a01b50a39ce189180d75c by David Rosca to branch master. Repository: plasma-desktop Description --- Use PlasmaCore.IconItem with disabled animations and Plasma icon theme overlay

Re: Review Request 126840: KCM Keyboard: Use ECM to generate debug category

2016-01-22 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit ac02735d9d5d4026fc94967794d870989273c3ed by David Rosca to branch master. Repository: plasma-desktop Description --- ^ Diffs - CMakeLists.txt 012039e kcms/keyboard/CMakeLists.txt 7f2e393

Review Request 126841: Use PlasmaCore.IconItem in Kicker, Kickoff and Folder View

2016-01-22 Thread David Rosca
correct color scheme for monochrome icons. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126840: KCM Keyboard: Use ECM to generate debug category

2016-01-22 Thread David Rosca
/xinput_helper.cpp 72b5544 kcms/keyboard/xkb_helper.cpp 2462b4d kcms/keyboard/xkb_rules.h 3e05f22 kcms/keyboard/xkb_rules.cpp ac2df91 Diff: https://git.reviewboard.kde.org/r/126840/diff/ Testing --- Builds Thanks, David Rosca ___ Plasma

Re: Review Request 126822: AppletQuickItem: Don't try to set initial size bigger than parent size

2016-01-21 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit f688c904a81c72d077580ab942b874f398fbd7d4 by David Rosca to branch master. Bugs: 358200 http://bugs.kde.org/show_bug.cgi?id=358200 Repository: plasma-framework Description --- Trying to set

Re: Review Request 126812: plasma-framework: Fix document.svgz to use color from stylesheet

2016-01-21 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 8db7b4f39c0a1e8c2dd4cc82afe50902979a6e65 by David Rosca to branch master. Description --- Fixed "document-encrypt" and "document-decrypt" icons. Diffs - Diff: https://git.r

Re: Review Request 126825: Don't set available space when rotating applet

2016-01-20 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 785cb63428cfe93f1456d03332581ffcda5eed10 by David Rosca to branch master. Repository: plasma-desktop Description --- The space is freed in onPressed, but not taken back in onReleased. LayoutManager

Review Request 126825: Don't set available space when rotating applet

2016-01-20 Thread David Rosca
Diff: https://git.reviewboard.kde.org/r/126825/diff/ Testing --- Rotating the applet no longer makes the whole applet area free in LayoutManager. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Review Request 126822: AppletQuickItem: Don't try to set initial size bigger than parent size

2016-01-20 Thread David Rosca
witch to compact representation. The initial size (from width, height properties) is now lost. Diffs - src/plasmaquick/appletquickitem.cpp 995ec10 Diff: https://git.reviewboard.kde.org/r/126822/diff/ Testing --- Bug fixed. Thanks, David

Re: Review Request 126814: IconItem: Add usePlasmaIcons property

2016-01-20 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 83cec13edb43fa2ac17953dfed90cea3725108bf by David Rosca to branch master. Repository: plasma-framework Description --- Add usePlasmaIcons (enabled by default) property to make it possible to disable

Re: Review Request 126801: Ignore drag events on containment/panel when immutable

2016-01-19 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 92665578f9e8190267af245952e8ace1be5e79a5 by David Rosca to branch master. Repository: plasma-desktop Description --- No applet will be created on drop in immutable state, so ignore the drag events

Re: Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

2016-01-19 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit e22a6d5f6ea420218fe0e099fcd11631d70319e6 by David Rosca to branch master. Repository: plasma-desktop Description --- Fixes issue where the contents rectangle may be smaller than the ScrollView&#

Re: Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

2016-01-19 Thread David Rosca
--------- On Jan. 19, 2016, 4:12 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126802/ >

Re: Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

2016-01-19 Thread David Rosca
ttachments before.png https://git.reviewboard.kde.org/media/uploaded/files/2016/01/18/4d06a54a-ac6c-45dc-8c32-53415e8b35d5__before.png Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126814: IconItem: Add usePlasmaIcons property

2016-01-19 Thread David Rosca
m.cpp 001f65b Diff: https://git.reviewboard.kde.org/r/126814/diff/ Testing --- Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126812: plasma-framework: Fix document.svgz to use color from stylesheet

2016-01-19 Thread David Rosca
b17cd__document.svgz documentsvgz.diff https://git.reviewboard.kde.org/media/uploaded/files/2016/01/19/a29e79a6-497f-40e6-958f-0e7c3dddb8d0__documentsvgz.diff Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126791: plasma-framework: Fix list.svgz to use color from stylesheet

2016-01-19 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 2480dc11fe65c5f7139f0e4677168006a081aeb0 by David Rosca to branch master. Description --- Fixed the color for "list-add" + removed two additional stylsheet defs and left only the firs

Re: Review Request 126800: AppletConfiguration: Use QIconItem for category icons

2016-01-19 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit cf0906fdae6cf256bf747cac2e7569d1cf3b9f6a by David Rosca to branch master. Repository: plasma-desktop Description --- PlasmaCore.IconItem uses plasma color scheme, which is not what we want in applet

Re: Review Request 126794: Use PlasmaCore.IconItem in WidgetExplorer and AlternativesDelegate

2016-01-19 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 32c6a35f0ae3b5074cf4ad3a9530627fbc2f6e0f by David Rosca to branch master. Repository: plasma-desktop Description --- Use PlasmaCore.IconItem to show correct applet icons according to desktop theme

Re: Review Request 126792: IconItem: Try to load QIcon::fromTheme icons as svg

2016-01-19 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 5184ac94c916bf5e5e31d60db841c88009758a62 by David Rosca to branch master. Bugs: 353358 http://bugs.kde.org/show_bug.cgi?id=353358 Repository: plasma-framework Description --- When showing

Re: Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

2016-01-19 Thread David Rosca
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126802/#review91314 --- On Jan. 18, 2016, 7:23 p.m., David Rosca wrote: > > --

Re: Review Request 126800: AppletConfiguration: Use QIconItem for category icons

2016-01-19 Thread David Rosca
because of this issue - using Plasma style. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126800/#review91315 --- On Jan. 18

Re: Review Request 126801: Ignore drag events on containment/panel when immutable

2016-01-19 Thread David Rosca
- containments/desktop/package/contents/ui/main.qml 26bd5d2 containments/panel/contents/ui/main.qml bad6ba0 Diff: https://git.reviewboard.kde.org/r/126801/diff/ Testing (updated) --- Works fine, it is still possible to drag files on folder view. Thanks, David Rosca

Re: Review Request 126801: Don't show drop applet placeholder on desktop in immutable state

2016-01-18 Thread David Rosca
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126801/#review91282 ------- On Jan. 18, 2016, 6:47 p.m., David Rosca wrote: > > ---

Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

2016-01-18 Thread David Rosca
6a54a-ac6c-45dc-8c32-53415e8b35d5__before.png Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126801: Don't show drop applet placeholder on desktop in immutable state

2016-01-18 Thread David Rosca
--- No applet will be created on drop in immutable state, so don't show the drop placeholder. Diffs - containments/desktop/package/contents/ui/main.qml 26bd5d2 Diff: https://git.reviewboard.kde.org/r/126801/diff/ Testing --- Thanks, David

Review Request 126800: AppletConfiguration: Use QIconItem for category icons

2016-01-18 Thread David Rosca
--- PlasmaCore.IconItem uses plasma color scheme, which is not what we want in applet config. Diffs - desktoppackage/contents/configuration/ConfigCategoryDelegate.qml fc87c6f Diff: https://git.reviewboard.kde.org/r/126800/diff/ Testing --- Thanks, David Rosca

Re: Review Request 126786: Quicklaunch: Add option to show title

2016-01-18 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 9b0e06e0d97d03cf8670dcddb27bb8aba1c7ca66 by David Rosca to branch master. Repository: kdeplasma-addons Description --- Add option to show title just like Folder View applet. Diffs - applets

Re: Review Request 126786: Quicklaunch: Add option to show title

2016-01-18 Thread David Rosca
ng by setting height to > > undefined (Q_PROPERTY RESET) > > David Rosca wrote: > Cool, that works. Well, not really. There is too big spacing between the painted text and launchers. So I'll leave it as it was in first diff. - David

Re: Review Request 126786: Quicklaunch: Add option to show title

2016-01-18 Thread David Rosca
ne106> > > > > wrapMode: Text.NoWrap also? Text.NoWrap is default - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126786/#review91263 -------

Re: Review Request 126786: Quicklaunch: Add option to show title

2016-01-18 Thread David Rosca
/2016/01/17/1b8ed953-e68c-4c16-99b2-240740904e5c__quicklaunch-title.png Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126792: IconItem: Try to load QIcon::fromTheme icons as svg

2016-01-18 Thread David Rosca
(updated) - src/declarativeimports/core/iconitem.cpp 9129aa1 Diff: https://git.reviewboard.kde.org/r/126792/diff/ Testing --- Set app icons to breeze light, desktop theme as breeze dark. Icons in desktop toolbox now follows the color scheme. Thanks, David Rosca

Re: Review Request 126786: Quicklaunch: Add option to show title

2016-01-18 Thread David Rosca
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126786/#review91263 --- On Jan. 17, 2016, 9:35 p.m., David Rosca wrote: > > -

Review Request 126794: Use PlasmaCore.IconItem in WidgetExplorer and AlternativesDelegate

2016-01-18 Thread David Rosca
--- Set breeze light app icon theme, breeze dark desktop theme. Applet icons now correctly shows with breeze dark theme. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126792: IconItem: Try to load QIcon::fromTheme icons as svg

2016-01-18 Thread David Rosca
/iconitem.cpp 9129aa1 Diff: https://git.reviewboard.kde.org/r/126792/diff/ Testing --- Set app icons to breeze light, desktop theme as breeze dark. Icons in desktop toolbox now follows the color scheme. Thanks, David Rosca ___ Plasma-devel

Review Request 126791: plasma-framework: Fix list.svgz to use color from stylesheet

2016-01-18 Thread David Rosca
wboard.kde.org/media/uploaded/files/2016/01/18/b9737bb6-fcea-40b5-ae92-d86cb82ef1f7__list.svgz Unzipped diff https://git.reviewboard.kde.org/media/uploaded/files/2016/01/18/e82f9ca0-c914-47c2-8cfe-222195fc8977__listsvg.diff Thanks, David Rosca ___ Plasm

Review Request 126786: Quicklaunch: Add option to show title

2016-01-17 Thread David Rosca
, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126778: Ignore check if just one part of size is zero in compactRepresentationCheck

2016-01-17 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 11937533e83659dc4dab6f7e8e6019863a28ddae by David Rosca to branch master. Bugs: 358039 http://bugs.kde.org/show_bug.cgi?id=358039 Repository: plasma-framework Description --- When debugging the

Review Request 126778: Ignore check if just one part of size is zero in compactRepresentationCheck

2016-01-17 Thread David Rosca
--- Fixes the bug. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126743: Fix shrinking panel on top/left/right edge

2016-01-14 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 2f07fdd5d34673f856b8f8401ab8447000254aaa by David Rosca to branch Plasma/5.5. Bugs: 357835 https://bugs.kde.org/show_bug.cgi?id=357835 Repository: plasma-desktop Description --- Use the new

Review Request 126743: Fix shrinking panel on top/left/right edge

2016-01-14 Thread David Rosca
/diff/ Testing --- Panels can be shrinked now Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126731: Fix calculation of availableSpace for applets

2016-01-13 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 2c56715c93cb439df77f29260e3bfc9cbd76e806 by David Rosca to branch master. Bugs: 346815 https://bugs.kde.org/show_bug.cgi?id=346815 Repository: plasma-desktop Description --- Fix calculation when

Re: Review Request 126731: Fix calculation of availableSpace for applets

2016-01-13 Thread David Rosca
containments/desktop/package/contents/ui/main.qml fc52250 Diff: https://git.reviewboard.kde.org/r/126731/diff/ Testing --- No longer possible to place applets on top of each others. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel

Re: Review Request 126731: Fix calculation of availableSpace for applets

2016-01-13 Thread David Rosca
/desktop/package/contents/code/LayoutManager.js fbb879e containments/desktop/package/contents/ui/main.qml fc52250 Diff: https://git.reviewboard.kde.org/r/126731/diff/ Testing --- No longer possible to place applets on top of each others. Thanks, David Rosca

Re: Review Request 126731: Fix calculation of availableSpace for applets

2016-01-13 Thread David Rosca
> On Jan. 13, 2016, 1:48 p.m., Bhushan Shah wrote: > > Fixes: https://bugs.kde.org/show_bug.cgi?id=346815 ? > > David Rosca wrote: > Yes, almost. > > Some applets (eg. color picker) somehow ends not being in `resultsFlow` > children, so thei

Re: Review Request 126731: Fix calculation of availableSpace for applets

2016-01-13 Thread David Rosca
1/#review91002 --- On Jan. 13, 2016, 1:43 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.re

Review Request 126731: Fix calculation of availableSpace for applets

2016-01-13 Thread David Rosca
/diff/ Testing --- No longer possible to place applets on top of each others. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126637: IconItem: Add animated property

2016-01-06 Thread David Rosca
marked as submitted. Review request for Plasma and Kai Uwe Broulik. Changes --- Submitted with commit e4ea8d55b7524e1998263c026dcb45d19667d13f by David Rosca to branch master. Repository: plasma-framework Description --- Add property animated, that allows to disable cross-fade

Re: Review Request 126635: TaskManager: Fix tooltip overflowing screen size

2016-01-06 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 1f670d643c68c16a176cfba33592d9c11d71e881 by David Rosca to branch master. Repository: plasma-desktop Description --- Plasma.Dialog ensures the tooltip doesn't overflow the screen size, but it

Re: Review Request 126637: IconItem: Add animated property

2016-01-06 Thread David Rosca
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126637/#review90692 --- On Jan. 6, 2016, 11 a.m., David Rosca wrote: > > -

Review Request 126653: Revert "Don't fade animate icon in plasma tooltips"

2016-01-06 Thread David Rosca
hidden. It does not work in some cases + https://git.reviewboard.kde.org/r/122859/ is a correct fix for this. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126637: IconItem: Add animated property

2016-01-05 Thread David Rosca
> On Jan. 5, 2016, 1:56 p.m., David Edmundson wrote: > > +1 from me > > > > Though AFIAK Kai was doing something related here too? > > David Rosca wrote: > Yes, but that is only to disable the animation when showing the IconItem > after being hidden. &

Re: Review Request 126636: TaskManager: Enable vertical scroll in tooltip

2016-01-05 Thread David Rosca
> > We explicitly disable interactive (scrolling) on the scrollArea > > > > then we put a mouse area on top which forwards scroll events to the > > scroll area. > > David Rosca wrote: > This translates vertical scroll to horizontal. It only actual

Re: Review Request 126636: TaskManager: Enable vertical scroll in tooltip

2016-01-05 Thread David Rosca
ea is interactive = when all windows don't fit in tooltip. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126636/#review90648 -------

Re: Review Request 126636: TaskManager: Enable vertical scroll in tooltip

2016-01-05 Thread David Rosca
12:52 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126636/ > --- > > (U

Re: Review Request 126637: IconItem: Add animated property

2016-01-05 Thread David Rosca
matically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126637/#review90647 --- On Jan. 5, 2016, 12:52 p.m., David Rosca wrote: > > --- > This is an au

Review Request 126637: IconItem: Add animated property

2016-01-05 Thread David Rosca
--- Setting `animated: false` disables the animation. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126636: TaskManager: Enable vertical scroll in tooltip

2016-01-05 Thread David Rosca
--- Enable vertical scroll for windows ScrollArea. Diffs - applets/taskmanager/package/contents/ui/ToolTipDelegate.qml 972dd62 Diff: https://git.reviewboard.kde.org/r/126636/diff/ Testing --- Scrolling works Thanks, David Rosca

Review Request 126635: TaskManager: Fix tooltip overflowing screen size

2016-01-05 Thread David Rosca
ip no longer overflows the screen size with too many windows and scrolling works. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126634: SystemTray: Fix height of lines in table in Entries config

2016-01-05 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 5219f7977e7b0391972c536aa71992f795205228 by David Rosca to branch master. Repository: plasma-workspace Description --- Setting text to button makes its height return useful value. Diffs

Review Request 126634: SystemTray: Fix height of lines in table in Entries config

2016-01-05 Thread David Rosca
-03601341bbcc__after.png Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2015-12-28 Thread David Rosca
tooltips without custom contents) don't have the crossfade animation at all, so I can no longer reproduce this bug. - David Rosca On Dec. 28, 2015, 12:17 a.m., Kai Uwe Broulik wrote: > > --- > This is an automatically genera

Re: Review Request 126468: AppletQuickItem: Drop timer to create full representation

2015-12-22 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 344dbeb93884af36f66e9a5133e7be7bd1b1e70d by David Rosca to branch master. Repository: plasma-framework Description --- The timer only added 250ms delay before creating the full representation

Re: Review Request 126468: AppletQuickItem: Drop timer to create full representation

2015-12-22 Thread David Rosca
automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126468/#review89902 ------- On Dec. 22, 2015, 10:01 a.m., David Rosca wrote: > > --- > Thi

Review Request 126468: AppletQuickItem: Drop timer to create full representation

2015-12-22 Thread David Rosca
Diff: https://git.reviewboard.kde.org/r/126468/diff/ Testing --- Works fine. Sometimes the very first popup is still a little buggy, but it is much better than before and also the bug doesn't come back again during the plasmashell lifetime. Thanks, David

Re: Review Request 126449: Containment: Don't emit appletCreated with null applet

2015-12-21 Thread David Rosca
> On Dec. 21, 2015, 1:54 p.m., David Edmundson wrote: > > Thanks! > > > > This will fix https://bugs.kde.org/show_bug.cgi?id=356428 right? > > David Rosca wrote: > It should, according to the backtrace. > > David Edmundson wrote: > at which

Re: Review Request 126449: Containment: Don't emit appletCreated with null applet

2015-12-21 Thread David Rosca
> On Dec. 21, 2015, 1:54 p.m., David Edmundson wrote: > > Thanks! > > > > This will fix https://bugs.kde.org/show_bug.cgi?id=356428 right? > > David Rosca wrote: > It should, according to the backtrace. > > David Edmundson wrote: > at which

Re: Review Request 126449: Containment: Don't emit appletCreated with null applet

2015-12-21 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit bca8e87531a3cc964b415755f50abebecef68a86 by David Rosca to branch master. Repository: plasma-framework Description --- ContainmentPrivate::createApplet may return null pointer (eg. when desktop is

Re: Review Request 126449: Containment: Don't emit appletCreated with null applet

2015-12-21 Thread David Rosca
ally generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126449/#review89825 --- On Dec. 21, 2015, 11:17 a.m., David Rosca wrote: > > --- > This is an automatica

Review Request 126449: Containment: Don't emit appletCreated with null applet

2015-12-21 Thread David Rosca
to desktop with locked widgets. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126337: KCM Removable Devices: Fix enabling ui elements when changing global enabled setting

2015-12-13 Thread David Rosca
marked as submitted. Review request for Plasma and Kai Uwe Broulik. Changes --- Submitted with commit c582f9d8e5f0d99306c7a57fa28f7b347bd4f3e6 by David Rosca to branch Plasma/5.5. Repository: plasma-desktop Description --- The logic was reverted, so when you enabled device auto

Re: Review Request 126337: KCM Removable Devices: Fix enabling ui elements when changing global enabled setting

2015-12-13 Thread David Rosca
://git.reviewboard.kde.org/r/126337/diff/ Testing --- Works now Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126337: KCM Removable Devices: Fix enabling ui elements when changing global enabled setting

2015-12-13 Thread David Rosca
-desktop Description --- The logic was reverted, so when you enabled device auto-mounting, all ui were greyed out. Diffs - solid-device-automounter/kcm/DeviceAutomounterKCM.cpp dba1d8c Diff: https://git.reviewboard.kde.org/r/126337/diff/ Testing --- Works now Thanks, David

Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

2015-11-26 Thread David Rosca
marked as submitted. Review request for Plasma and Martin Klapetek. Changes --- Submitted with commit ea03996f34d9d22083bdbe5fcdc11910e50253b7 by David Rosca to branch Plasma/5.5. Bugs: 355798 https://bugs.kde.org/show_bug.cgi?id=355798 Repository: bluedevil Description

Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

2015-11-25 Thread David Rosca
d->sizeHint()) in second diff works. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126160/#review88839 -------

Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

2015-11-25 Thread David Rosca
: https://git.reviewboard.kde.org/r/126160/diff/ Testing --- The window gets resized now if there is not enough free space for PIN. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

2015-11-25 Thread David Rosca
mail. To reply, visit: https://git.reviewboard.kde.org/r/126160/#review88800 ------- On Nov. 25, 2015, 5:03 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.o

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

2015-11-25 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit ceb827322c3402ae08e88f60fbed7a09ed0a222b by David Rosca to branch master. Repository: plasma-desktop Description --- Make the windows in tooltip scrollable when it doesn't fit on the screen.

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

2015-11-25 Thread David Rosca
f text". The 1.6 constant looks > > weird here, and I'm against adding font specific hacks in, especially since > > at that point in the code, we don't even know what the font is. > > > > This is not a structural solution, so -1. > > David Rosca wrote: >

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

2015-11-25 Thread David Rosca
> On Nov. 25, 2015, 1:04 p.m., Eike Hein wrote: > > Ship It! > > David Rosca wrote: > Hmm, it no longer works because the tooltip size is not bound by the > available screen size. > So it needs fix in plasma-framework first. > > Marco Martin wrote: >

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

2015-11-25 Thread David Rosca
matically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125908/#review88795 --- On Nov. 5, 2015, 9:05 a.m., David Rosca wrote: > > --- > This is an automat

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click

2015-11-25 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126165/#review88810 --- On Nov. 25, 2015, 2:18 p.m., David Rosca wrote: > >

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click

2015-11-25 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit ca9b6310ceba285a67098b705b7015ae6202f21c by David Rosca to branch master. Repository: kdeplasma-addons Description --- It is now possible to paste with mouse click even when ContentTracker's u

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click

2015-11-25 Thread David Rosca
pastes on left click when it gets uri from activity manager. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126165/#review88801 ------

Re: Review Request 126162: taskmanager: Fix sometimes not showing labels in tooltip

2015-11-25 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 0ed62041f1715d4e732576bde3e98b7c6d1f3190 by David Rosca on behalf of Fabian Vogt to branch Plasma/5.5. Bugs: 346348 https://bugs.kde.org/show_bug.cgi?id=346348 Repository: plasma-desktop Description

Review Request 126165: quickshare: Trigger paste from clipboard action on click

2015-11-25 Thread David Rosca
u and select Paste. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126162: taskmanager: Fix sometimes not showing labels in tooltip

2015-11-25 Thread David Rosca
ot;Fabian Vogt " - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126162/#review88793 --- On Nov. 24, 2015

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

2015-11-24 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125908/#review88775 --- Ping - David Rosca On Nov. 5, 2015, 9:05 a.m., David Rosca

Review Request 126162: taskmanager: Fix sometimes not showing labels in tooltip

2015-11-24 Thread David Rosca
from step 1., let the tooltip show and then move mouse out to hide it. 4. Mouse over some other taskmanager entry that is for running application 5. Tooltip is shown without labels Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org

Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

2015-11-24 Thread David Rosca
now if there is not enough free space for PIN. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125465: kcm_keyboard: Use udev device notifier when xcb-xinput is not available

2015-11-18 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit daa54f5f9ec969edca3943fd7efe662c6e25bb38 by David Rosca to branch master. Bugs: 346336 https://bugs.kde.org/show_bug.cgi?id=346336 Repository: plasma-desktop Description --- xcb-xinput is not

Re: Review Request 126093: kcm_fonts: Don't touch any Xft options when anti-aliasing is set to system settings

2015-11-17 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 6c78b092786e6c4315144e81982edd50294d2749 by David Rosca to branch master. Repository: plasma-desktop Description --- When anti-aliasing is set to system settings, fonts kcm still saves XftHintStyle

Re: Review Request 125465: kcm_keyboard: Use udev device notifier when xcb-xinput is not available

2015-11-17 Thread David Rosca
freeze. - David Rosca On Oct. 1, 2015, 8:05 a.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Review Request 126093: kcm_fonts: Don't touch any Xft options when anti-aliasing is set to system settings

2015-11-17 Thread David Rosca
/126093/diff/ Testing --- No Xft* is written to kdeglobal if anti-aliasing == system settings + it still gets correctly saved when anti-aliasing is set. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Review Request 126052: Quicklaunch: Switch to vertical mode when height > width

2015-11-15 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 69a6982e44f6b14e479b1881bc649d14f570aa3b by David Rosca to branch master. Repository: kdeplasma-addons Description --- Switch to vertical mode when in Planar form factor and height > width. Di

Review Request 126052: Quicklaunch: Switch to vertical mode when height > width

2015-11-13 Thread David Rosca
tps://git.reviewboard.kde.org/r/126052/diff/ Testing --- Resizing the applet on desktop correctly switches to normal/vertical modes. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/pla

Re: Review Request 125980: Gtk2: Fix scrollbar background in Firefox

2015-11-06 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit b7d97e45ee4cafba229505389139cea17c2e5f07 by David Rosca to branch master. Repository: breeze-gtk Description --- Firefox is using colors from ACTIVE palette in scrollbars, which makes it darker

Re: Review Request 125979: Gtk2: Fix arrow states

2015-11-06 Thread David Rosca
marked as submitted. Review request for Plasma. Changes --- Submitted with commit ff9ab494e1da5370e4a409d1dbdda97e56316e80 by David Rosca to branch master. Repository: breeze-gtk Description --- Not specifying state in style makes that style used for all states. This made the

Review Request 125979: Gtk2: Fix arrow states

2015-11-06 Thread David Rosca
visually disabled when it's not possible to scroll in that direction. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

<    4   5   6   7   8   9   10   11   12   >