D8493: Make Folder View screen aware

hein accepted this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8493 To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, apol, mwolff Cc: anthonyfieroni, ngraham, mwolff, davidedmundson, broulik, mart, plasma-devel,

D8692: QML mouse cursor KCM and components

hein added a comment. Related to the above: We also have various cases where applications bring up KCMs via kcmshell, e.g. KIO's Web Shortcuts KCM. That means also at runtime none of this can depend on plasma-desktop in any way. KCMs need to work outside of Plasma with a sane dep tree.

D8692: QML mouse cursor KCM and components

hein added a comment. I don't think we can put the components into plasma-desktop, especially SimpleKCM if you really intend it to be used by all KCMs as root item. That would make any KCM requiring something like this depend on plasma-desktop. We have many KCMs in frameworks (e.g. KIO and

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. > Given you're now familiar with this code, can you look through: Done. Two reassigned/retitled, one closed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc: mmustac, ngraham, davidedmundson,

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein updated this revision to Diff 22828. hein added a comment. - Implement latest VDG mockup. This simplifies the UI from two seperate timeout settings to one, but in the config files we still have two. We write both, but the code needs to make a decision which one to read and show

D8692: QML mouse cursor KCM and components

hein requested changes to this revision. hein added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcmcursortheme.cpp:150 > +emit selectedThemeRowChanged(); > +setNeedsSave(true); > +updateSizeComboBox(); Incorrect Apply button management >

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. Updated screenshot: F5506081: Screenshot_20171123_231847.png Branch is re-pushed as well. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc: mmustac,

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. Thanks, will implement tomorrow! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc: mmustac, ngraham, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8850: Support drag and drop between shared folder view containments

hein added inline comments. INLINE COMMENTS > foldermodel.cpp:1122 > +if (targetUrl.toString().startsWith(url.toString())) { > +m_screenMapper->addMapping(targetUrl.toString(), m_screen, > ScreenMapper::DelayedSignal); > +} else if >

D8915: Update the proxy to source and source to proxy mapping correctly

hein accepted this revision. BRANCH master REVISION DETAIL https://phabricator.kde.org/D8915 To: amantia, #plasma, hein, mwolff Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8598: FolderView: position files at drop event target position

hein accepted this revision. hein added a comment. Small comment change request in the comments, but code-wise good to go. INLINE COMMENTS > foldermodel.cpp:1068 > + * > + * TODO: move this somehow to the Positioner > + */ As mentioned on IRC I'd currently prefer to keep the

D8493: Make Folder View screen aware

hein added a comment. Modulo above edge-casey comments it looks good to me. INLINE COMMENTS > foldermodel.cpp:1324 > +const QString name = item.url().toString(); > +const int screen = m_screenMapper->screenForItem(name); > +// don't do anything if the folderview is

D8864: RFC: [MouseEventListener] Allow accepting mouse event

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D8864 To: broulik, #plasma, hein Cc: apol, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. The above exchange is seriously upsetting and frustrating to me. I implemented the VDG mockup, and now there's discussion about the design in my code review. Please get your act together and make sure the mockups are ready for implementing so the review process of code

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. In https://phabricator.kde.org/D8911#170032, @ngraham wrote: > Can you add "Fixes https://phabricator.kde.org/T7284; so this it will close that Maniphest task once this goes in? Will do when pushing. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D8916: QML port of fonts kcm

hein added inline comments. INLINE COMMENTS > fonts.cpp:570 > +emit smallFontChanged(); > +setNeedsSave(true); > +} Instead of always setting this to true in a prop setter, you need to implement a method that checks whether the new value is actually different from the stored

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. Updated screenshot: F5500694: Screenshot_20171121_174245.png I have a question: As per the mockup, I have no colons after the labels. I'm not sure I like that. Thoughts? @abetts, @ngraham? REPOSITORY R119 Plasma

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein updated this revision to Diff 22681. hein marked 3 inline comments as done. hein added a comment. Address all review comments. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8911?vs=22634=22681 BRANCH kcm-redesign/launchfeedback REVISION

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein marked 3 inline comments as done. hein added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:69 > "Task Manager notification: [checkbox] Enable Task Manager notification" a > bit redundant and overly wordy. How about the following? > > "Task Manager notification: [checkbox]"

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added inline comments. INLINE COMMENTS > davidedmundson wrote in launchfeedback.cpp:169 > how does plasmashell get notified about new TaskbarButtonSettings? KDirWatch on the rc file iirc Note the old business logic doesn't have any anything more there. REPOSITORY R119 Plasma Desktop

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. Review comments: Some of those also apply to the fonts KCM rewrite I based this on, e.g. the broken bindings. Will fix tomorrow, thanks :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc:

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a reviewer: abetts. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. Screenshot: F5499384: Screenshot_20171120_194949.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai,

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. This is on git as branch kcm-redesign/launchfeedback. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein updated this revision to Diff 22634. hein added a comment. Add missing package. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8911?vs=22633=22634 BRANCH kcm-redesign/launchfeedback REVISION DETAIL https://phabricator.kde.org/D8911

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein created this revision. hein added reviewers: Plasma, mart. Restricted Application added a project: Plasma. REVISION SUMMARY - Implements VDG mockup https://phabricator.kde.org/M112/364/ - But using "Task Manager" naming for consistency instead of "Taskbar" - Additional UI tweak of

D8641: FormLayout

hein added a dependent revision: D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8641 To: mart, #plasma, #kirigami, hein Cc: broulik, colomar, ngraham, davidedmundson, plasma-devel, ZrenBot,

D8849: [Folder View Filter Config] Use TableView for mime types

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. If the default sorting isn't on the checkbox, then I'm OK with and accept the original ver (not-so-fond of the variant). REPOSITORY R119 Plasma Desktop REVISION DETAIL

D8524: Add a signal notifying a change in the names of running activities.

hein added a comment. Such a class would imho be pretty redundant to the model class, so now it's back to whether David wants to accept this patch or not. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8524 To: hein, #plasma, davidedmundson Cc:

D8849: [Folder View Filter Config] Use TableView for mime types

hein added a comment. I like it, but should the default sort column be the name so that there's no awkward arrow in the header element for the checkboxes? I feel like QWidget views or rather QStandardItemDelegate avoid this by embedding the checkbox into the column for Qt::DisplayRole

D8770: Resolve the input method issue by always force focus in search field.

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Nice. I think we have the same problem in Kicker and Application Dashboard, which also use append trickery. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D8641: FormLayout

hein added a comment. So if I understand correctly, the Mnemonic stuff currently doesn't seem to have the same aims as KAcceleratorManager does ... KAcceleratorManager acts on a hierarchy of widgets, traverses it, assigns weights to actionable things and possible mnemonics and overall

D8771: Use heuristic weighted length algorithm to calculate the query term length.

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D8771 To: xuetianweng, hein, broulik Cc: cfeck, ihipop, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

Minutes Monday Plasma Hangout

Hi, notes and full log attached! Cheers, Eike Plasma Team meeting, 13-11-2017 Present: notmart, fvogt, bshah, d_ed, sebas, Sho_ notmart: * FormLayout: ** automatic wide/compact layout switch ** automatic text mnemonics/shortcuts * small command line tool to switch look and feel (maybe useful

D8723: When used by QML, only populate after component is complete

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b40c0de099fc: When used by QML, only populate after component is complete (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D8524: Add a signal notifying a change in the names of running activities.

hein added a comment. Looking at the KActivities API more, perhaps not exposing this directly was deliberate of Ivan as otherwise Consumer would probably have all of the Cache signals. Ivan, can you opine on this? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D8524: Add a signal notifying a change in the names of running activities.

hein added a comment. I inquired upstream about a signal/API a few times and wasn't told about this signal. I will look into it, unless Ivan wants to. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8524 To: hein, #plasma, davidedmundson Cc:

D8771: Use heuristic weighted length algorithm to calculate the query term length.

hein added a comment. I've found this problem in many KDE UIs, and I'd like to have a generic solution. How do you feel about adding something like a logicalStringLength() to KCoreAddons or KCodecs? Then we can use it in KRunner, KMail, Amarok, ... REPOSITORY R120 Plasma Workspace

D8744: Use Qt.callLater instead of creating a Timer

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8744 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8524: Add a signal notifying a change in the names of running activities.

hein added a comment. Ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8524 To: hein, #plasma Cc: anthonyfieroni, ivan, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8608: Fix crash in KAStatsFavouritesModel

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D8608 To: davidedmundson, #plasma, hein Cc: anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8524: Add a signal notifying a change in the names of running activities.

hein added a comment. Please re-review, my above comment and diff update were submitted together. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8524 To: hein, #plasma Cc: anthonyfieroni, ivan, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8524: Add a signal notifying a change in the names of running activities.

hein added inline comments. INLINE COMMENTS > anthonyfieroni wrote in activityinfo.cpp:81-86 > They should emit also numberOfRunnigActivitiesChanges, no? They don't need to. It's emitted in response to ::Consumer::runningActivitiesChanged. Actually, doing the reverse might make more sense.

D8524: Add a signal notifying a change in the names of running activities.

hein updated this revision to Diff 22084. hein added a comment. Don't connect too rowsInserted/rowsRemoved. This is already handled by connecting to KActivities::Consumer::runningActivitiesChanged. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D8723: When used by QML, only populate after component is complete

hein updated this revision to Diff 22083. hein added a comment. Fix review comments by David and Kai. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8723?vs=22078=22083 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8723

D8525: Refresh when the names of the running activities change.

hein added a reviewer: Plasma. hein added a comment. ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8525 To: hein, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8524: Add a signal notifying a change in the names of running activities.

hein added a comment. ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8524 To: hein, #plasma Cc: ivan, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8723: When used by QML, only populate after component is complete

hein created this revision. hein added reviewers: Plasma, davidedmundson, mart. Restricted Application added a project: Plasma. REVISION SUMMARY This introduces the use of QQmlParserStatus to delay populating the model until all properties have been set, to avoid delegate churn.

D8598: FolderView: position files at drop event target position

hein added a comment. This looks quite good to me now - the fact that it's much shorter than my old attempt feels pretty nice ;) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8598 To: mwolff, hein, amantia Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D8598: WIP: position files at drop target position in folder

hein added a comment. IRC talk for posterity: [17:32] from the notes you sent mlaurent, and from what I remember form our past discussion, it is not clear to me how you envisioned (or even implemented) the mapping of drop action -> new file [17:33] first of all, what happens when

D8611: Kicker: Use QtLoggingRules

hein accepted this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D8611 To: davidedmundson, #plasma, apol, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked

hein added a comment. > What would you propose? To be honest - dropping the patch. > But is the dragging around into external applications of .desktop files a feature that we want? Sure. The URL to the .desktop file is the exchange-ready representation for an app, which the

D8596: Fix memory leak in FolderModel::drop

hein added a comment. It's not necessary to delete connections. When a QObject is destroyed this is done already. Patch rejected sorry :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8596 To: mwolff, #plasma Cc: hein, ngraham, broulik, anthonyfieroni,

D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked

hein added a comment. I still don't like it, sorry - the patch also feels technically and semantically wrong to me. "If widgets are locked, stop adding a certain kind of data to the drag" is a pretty bad hack. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked

hein added a comment. As-is I would not accept this patch, I'm sorry. Task Manager items are not widgets, it's content, and the widget mutability state should not affect content drags. This particular drag is used for workspace features some people do rely on, e.g.: - moving a

D8563: Folder View icons properties: Improve visual layout

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Lovely, again thanks so much for tackling this, it's long overdue. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8563 To: marten, #plasma, hein Cc: hein,

D8549: We use Q_DECL_OVERRIDE or override.

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH use_override REVISION DETAIL https://phabricator.kde.org/D8549 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8516: Emit signal when we change PerStripe

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. One more newline after the emit line please, otherwise GTG. REPOSITORY R119 Plasma Desktop BRANCH fix_missing_emit_signal REVISION DETAIL https://phabricator.kde.org/D8516 To:

D8517: Test enable status change and perStripe change

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH add_more_autotest REVISION DETAIL https://phabricator.kde.org/D8517 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8524: Add a signal notifying a change in the names of running activities.

hein added a comment. In https://phabricator.kde.org/D8524#161438, @ivan wrote: > Also, not sure adding a signal that has one user only to a shared library is the best approach, especially since .h says this: > > 37 * @NOTE: This is a placeholder, to be moved into KActivities

D8524: Add a signal notifying a change in the names of running activities.

hein added a dependent revision: D8525: Refresh when the names of the running activities change.. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8524 To: hein, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8525: Refresh when the names of the running activities change.

hein created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG:384001 Depends on https://phabricator.kde.org/D8524. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D8524: Add a signal notifying a change in the names of running activities.

hein created this revision. hein added a reviewer: Plasma. Restricted Application added a project: Plasma. REVISION SUMMARY CCBUG:384001 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D8524 AFFECTED FILES libtaskmanager/activityinfo.cpp

D8513: Use emit as all other code use emit and not Q_EMIT

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH use_emit_keyword REVISION DETAIL https://phabricator.kde.org/D8513 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8447: Add unit tests for Folder View

hein accepted this revision. hein added a comment. Please don't extend already-accepted review requests with new code without requesting more review. Otherwise the status stays "Accepted" on code that hasn't actually been reviewed, which is confusing and holds things up :) New test

D8473: Modernize code. Use nullptr where it's possible

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH modernize_folderplugin REVISION DETAIL https://phabricator.kde.org/D8473 To: mlaurent, hein Cc: broulik, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,

D8476: qPort to new connect api + use const'ref

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH port_to_new_connect_api REVISION DETAIL https://phabricator.kde.org/D8476 To: mlaurent, hein Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8488: Clean forward declaration

hein accepted this revision. REPOSITORY R119 Plasma Desktop BRANCH clean_forward_declaration REVISION DETAIL https://phabricator.kde.org/D8488 To: mlaurent, hein, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8489: Clean includes

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH clean_includes REVISION DETAIL https://phabricator.kde.org/D8489 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8447: Add unit tests for Folder View

hein accepted this revision. hein added a comment. Thanks for working on this! We really need better test coverage in Plasma bits. I'm a little bit unhappy about littering headers with FOLDERPLUGIN_TESTS_EXPORT, but I guess it's the lesser evil of statically linking and building the

D7181: [Task Manager] Elide context menu entries

hein added a comment. Kai, ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7181 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7481: RFC: Batch window changes events on XCB

hein added a comment. David, ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7481 To: davidedmundson, #plasma Cc: ngraham, cfeck, broulik, hein, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D6880: [Folder View] Indicate cut items

hein added a comment. Kai, ping? IIRC we determined KDirModel does this already and this is misguided somehow? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6880 To: broulik, #plasma, hein, #vdg, emmanuelp, dfaure Cc: plasma-devel, ZrenBot, progwolff,

D8424: Folder View location properties: Improve visual layout

hein added a comment. kk, go for it then :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8424 To: marten, #plasma, hein Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8424: Folder View location properties: Improve visual layout

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Thanks for the patch! Can you push this or do you need someone to push for you? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8424 To: marten, #plasma,

D8258: [Task Tools] Treat applications: and respective absolute path equal in launcherUrlsMatch

hein added a comment. Let's merge this for now to have a fix for 5.11.1. I'll look into speeding things up next week. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8258 To: broulik, #plasma, hein, ngraham, mvourlakos Cc: davidedmundson, plasma-devel,

D8258: [Task Tools] Treat applications: and respective absolute path equal in launcherUrlsMatch

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8258 To: broulik, #plasma, hein, ngraham, mvourlakos Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8257: [StartupTasksModel] Try resolving startup application id to applications: URL

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8257 To: broulik, #plasma, hein, ngraham, mvourlakos Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8178: Fix editing items in SimpleFavoritesModel

hein added a comment. Please make sure the spam is gone (console.log), etc. The "this crashes Qt" comment": That was written by Ivan originally. Please make sure and test that this patch works with both kinds of favorites. I'm travelling and am indisposed currently. REPOSITORY

D7481: RFC: Batch window changes events on XCB

hein added a comment. Yes it is, pending rework. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7481 To: davidedmundson, #plasma Cc: ngraham, cfeck, broulik, hein, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8136: Silence warning.

This revision was automatically updated to reflect the committed changes. Closed by commit R169:e3586f1bba10: Silence warning. (authored by hein). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8136?vs=20333=20339 REVISION DETAIL

D8137: Silence warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R858:f375e212db9e: Silence warnings (authored by hein). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8137?vs=20334=20340 REVISION DETAIL

D8137: Silence warnings

hein created this revision. hein added a reviewer: mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH master REVISION DETAIL https://phabricator.kde.org/D8137 AFFECTED

D8136: Silence warning.

hein created this revision. hein added a reviewer: mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D8136 AFFECTED FILES

D7941: use Kirigami Theme for colors

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH mart/kirigamiintegration REVISION DETAIL https://phabricator.kde.org/D7941 To: mart, #plasma, #kirigami, hein Cc: davidedmundson, plasma-devel, ZrenBot,

D7939: ColorSet concept in Theme

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH mart/colorcontext REVISION DETAIL https://phabricator.kde.org/D7939 To: mart, #kirigami, hein Cc: plasma-devel, apol, davidedmundson, mart, hein

D8009: [Containment Interface] Don't add containment actions to applet actions on desktop

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8009 To: broulik, #plasma, hein Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8008: [Folder View] Turn MenuHelper into a singleton type

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8008 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7830: Use a separate config value for Wayland font DPI

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH randa/accessibility REVISION DETAIL https://phabricator.kde.org/D7830 To: davidedmundson, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7831: Use a different key for font DPI on X and Wayland

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH randa/accessibility REVISION DETAIL https://phabricator.kde.org/D7831 To: davidedmundson, #plasma, hein Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7831: Use a different key for font DPI on X and Wayland

hein added a comment. The patch makes sense, but doesn't this indicate we screwed up something conceptually because the user now needs to set font dpi in awareness they'll be scaled after instead of set directly? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D7798: [Folder View] Fix supported drag actions

hein accepted this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7798 To: broulik, #plasma, hein, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7807: When cloning a config also clone supportedFeatures

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D7807 To: davidedmundson, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

Re: kwin_wayland and setWindowIcon()

Note that even if this is added, the Task Manager is just going to ignore it. The Task Manager is written to try and identify the app that owns a window and use the icon from the .desktop file, to enable consistent theming (not all apps load icon assets the same way and set it well on the window

D7769: [Task Manager] Use Grid for grouped and single tooltips

hein accepted this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7769 To: subdiff, #plasma, davidedmundson, hein Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7768: [Task Manager] On containsMouse change always reset toolTipDelegate data

hein added a comment. Yeah this one looks odd to me too as per David ... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7768 To: subdiff, #plasma Cc: hein, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D7733: [Folder View Icons Config] Fix initial index of ComboBox

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7733 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D3805: Per-activity favorites (Final, again?)

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. So I assume the bug was that I was getting too many favorites? Limit::all is now unlimited I assume? Otherwise it needs to be integrated with the maxFavorites stuff to disable the actions.

D3805: Per-activity favorites (Final, again?)

hein added a comment. Test failure using Kicker: 1. Right-click menu entry -> Show favorite in -> All activities 2. Verify it's shown on both activities 3. Be in activity 1, right-click the favorite, click the checkbox item for activity 2, favorite disappears from activity 1 as

D7705: [Task Manager] Strip applications: scheme from launcher URL in MPris source

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7705 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

<    5   6   7   8   9   10   11   12   13   14   >