D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

epopov added a comment. Ohhh, okay, thanks anyway REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29818 To: epopov, ngraham, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham,

D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

epopov added a comment. Right, but they can be cherry-picked the the **Plasma 5.19**. In truth, I'm tired of editing these files after every Plasma update☹️ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29818 To: epopov, ngraham, mart Cc: plasma-devel,

D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

epopov added a comment. In D29818#672942 , @ngraham wrote: > was landed on master, not 5.19 Can it be moved to Plasma 5.19? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29818 To: epopov, ngraham,

D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

epopov created this revision. epopov added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. epopov requested review of this revision. REVISION SUMMARY In D29652 , I made an annoying mistake: I removed the check if

D29652: Automatically close Clipboard applet after clearing history or deleting the last element

epopov updated this revision to Diff 82816. epopov added a comment. You're right. Fixed. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29652?vs=82565=82816 REVISION DETAIL https://phabricator.kde.org/D29652 AFFECTED FILES

D29652: Automatically close Clipboard applet after clearing history or deleting the last element

epopov added a comment. Currently, the Notifications applet closes itself when the last element (notification) is removed (or all elements are removed by pressing "Clear History" button in the top-right corner). But also it closes itself, even if the applet is pinned, and I guess that this

D29651: [applets/notifications] Remain visible after removing all notifications while tray popup is pinned open

epopov updated this revision to Diff 82594. epopov added a comment. Fixed. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29651?vs=82563=82594 REVISION DETAIL https://phabricator.kde.org/D29651 AFFECTED FILES

D29652: Automatically close Clipboard applet after clearing history or deleting the last element

epopov added a comment. I believe that there is a better solution, but I did not come up with it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29652 To: epopov, ngraham, plasma-devel Cc: Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D29652: Automatically close Clipboard applet after clearing history or deleting the last element

epopov created this revision. epopov added reviewers: ngraham, plasma-devel. Herald added a project: Plasma. epopov requested review of this revision. REVISION SUMMARY It would be correct to close the Clipboard applet after clearing the history or deleting the last element, since there is

D29651: Notifications applet closes itself after removing all notifications while the system tray popup is pinned open

epopov created this revision. epopov added reviewers: ngraham, plasma-devel. Herald added a project: Plasma. epopov requested review of this revision. REVISION SUMMARY When I pin a Notifications applet and then remove all notifications, the Notifications applet closes itself. BUG: 421344

D28483: [applets/clipboard] Don't close when clicking history item if pop-up was pinned open by another applet

epopov added a comment. Is it normal that I can close pinned applet by pressing ESC? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28483 To: epopov, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D28483: [applets/clipboard] Don't close when clicking history item if pop-up was pinned open by another applet

epopov added a comment. Thanks! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28483 To: epopov, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,

D28483: Updated patch that fixes the issue of closing a pinned the Clipboard applet

epopov updated this revision to Diff 79046. epopov added a comment. Rebase on **master** REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28483?vs=79045=79046 REVISION DETAIL https://phabricator.kde.org/D28483 AFFECTED FILES

D28483: Updated patch that fixes the issue of closing a pinned the Clipboard applet

epopov created this revision. epopov added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. epopov requested review of this revision. REVISION SUMMARY The previous patch updates the pinned state only for the active applet. For instance, if you open

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

epopov added a comment. The previous patch updates the pinned state only for the active applet. For instance, if you open the Networks applet and pin it, then switch to the Clipboard applet and click on the history item, then the Clipboard applet closes. This is because we need to use

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

epopov updated this revision to Diff 79034. epopov added a comment. Unfortunately, the previous patch doesn't solve the problem completely, but this one should. Can you check it and if everything works well, then replace it with the previous one? REPOSITORY R120 Plasma Workspace CHANGES

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

epopov updated this revision to Diff 78992. epopov added a comment. Rebase on **master**, second edition. Can you try this patch? REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28408?vs=78926=78992 REVISION DETAIL

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

epopov added a comment. I have no idea how to test code from **master** branch REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28408 To: epopov, ngraham, #plasma Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

epopov updated this revision to Diff 78926. epopov added a comment. Rebase on **master** REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28408?vs=78827=78926 REVISION DETAIL https://phabricator.kde.org/D28408 AFFECTED FILES

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

epopov added a comment. In **Plasma/5.18** branch there was a `Containment.onAppletAdded` handler that took the `applet` as a parameter, but can't find this handler in **master** branch. Unfortunately, I don’t have enough knowledge of Plasma API to know if I can add this handler manually.

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

epopov added a comment. Can't be rebased on master REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28408 To: epopov, ngraham, #plasma Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D28354: [applets/digital-clock] Fix calendar events not being shown at first

epopov added inline comments. INLINE COMMENTS > broulik wrote in CalendarView.qml:154 > Can't you do `date1.getTime() == date2.getTime()` (`time` returns the msecs > since epoch) How can I compare only the date using your expression? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28354: [applets/digital-clock] Fix calendar events not being shown at first

epopov updated this revision to Diff 78853. epopov added a comment. Rebase to `master` REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28354?vs=78715=78853 REVISION DETAIL https://phabricator.kde.org/D28354 AFFECTED FILES

D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

epopov updated this revision to Diff 78827. epopov added a comment. Use `hideOnWindowDeactivate` property instead of `configuration.pin` REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28408?vs=78805=78827 REVISION DETAIL

D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

epopov added a comment. In D28408#637476 , @davidedmundson wrote: > As a question, rather than a researched proposal, is it better to check for the pin in? > > systemtray / PlasmoidItem.qml > > Connections { > target: applet

D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

epopov created this revision. epopov added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. epopov requested review of this revision. REVISION SUMMARY When I pin a Klipper widget and then click on a history item, the Klipper widget closes. To

D28354: [applets/digital-clock] Fix calendar events not being shown at first

epopov updated this revision to Diff 78715. epopov added a comment. Put the `dateEquals` function outside the `onAgendaUpdated` handler, so it can be used elsewhere. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28354?vs=78694=78715 REVISION

D28354: [applets/digital-clock] Fix calendar events not being shown at first

epopov updated this revision to Diff 78694. epopov added a comment. Make a function that compares dates inline. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28354?vs=78670=78694 REVISION DETAIL https://phabricator.kde.org/D28354 AFFECTED

D28354: Bug 395956: calendar events are not shown at first

epopov created this revision. epopov added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. epopov requested review of this revision. REVISION SUMMARY I noticed that on the first time I bring up the calendar by clicking the clock on my Plasma panel,

D28306: [applets/taskmanager] Make the hover state clarifying, but not main

epopov added a comment. Thank you, guys! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28306 To: epopov, davidedmundson, #vdg Cc: broulik, ngraham, epopov, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D28306: Make the hover state clarifying, but not main

epopov updated this revision to Diff 78599. epopov added a comment. Fix hover state for pinned launchers REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28306?vs=78580=78599 REVISION DETAIL https://phabricator.kde.org/D28306 AFFECTED FILES

D28306: Make the hover state clarifying, but not main

epopov marked 2 inline comments as done. epopov added inline comments. INLINE COMMENTS > broulik wrote in Task.qml:331 > We can use ECMAScript 6 now, use spread syntax: > > return [ > ...TaskTools.taskPrefix(etc), > ...foo, > ...bar > ]; > > Note the `...`

D28306: Make the hover state clarifying, but not main

epopov updated this revision to Diff 78580. epopov added a comment. Use ES6 spread syntax instead of Array.concat() REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28306: Make the hover state clarifying, but not main

epopov updated this revision to Diff 78568. epopov added a comment. Create a new function in TasksTools to make the code more readable. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28306?vs=78540=78568 REVISION DETAIL

D28306: Make the hover state clarifying, but not main

epopov created this revision. epopov added reviewers: davidedmundson, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. epopov requested review of this revision. REVISION SUMMARY I'm trying to make a custom appearance of the Task Manager by creating a new theme, but