Re: Review Request 122392: Fix Klipper Performance issues

2017-02-08 Thread Filip Wieladek
ing --- File Attachments A screencast with foreground processing vs background processing https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/1d998fd9-57fd-4997-92f8-11b8e038e795__screencast.mp4 Thanks, Filip Wieladek

Re: Review Request 122382: [klipper] Sync history to disk after each change

2015-02-16 Thread Filip Wieladek
skip passwords). But setting the file to 600 is certainly a good idea. Martin Gräßlin wrote: But setting the file to 600 is certainly a good idea. this seems already to be the case (though I don't find the code for it) Filip Wieladek wrote: FYI: I happened to see cross

Re: Review Request 122382: [klipper] Sync history to disk after each change

2015-02-09 Thread Filip Wieladek
On Feb. 3, 2015, 7:36 a.m., Martin Gräßlin wrote: David E. just pointed out that this could become quite heavy for the system as the history size can be large (up to 2048 items). Martin Gräßlin wrote: Unfortunately I couldn't find out why we support up to 2048 items. Commit

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-09 Thread Filip Wieladek
is the part which needs most thought, so having that in a dedicated review would certainly help :-) Filip Wieladek wrote: Yes, I can do that once I get home. If you really believe that the popup is going away anyway, then I would however prefer to work on the new way, so

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-08 Thread Filip Wieladek
processing vs background processing https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/1d998fd9-57fd-4997-92f8-11b8e038e795__screencast.mp4 Thanks, Filip Wieladek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-08 Thread Filip Wieladek
is the part which needs most thought, so having that in a dedicated review would certainly help :-) Filip Wieladek wrote: Yes, I can do that once I get home. If you really believe that the popup is going away anyway, then I would however prefer to work on the new way, so

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-02 Thread Filip Wieladek
/historyfilter.cpp PRE-CREATION klipper/klipperpopup.h 6f7b30747562b5e7227504b8c53be2863686072b klipper/klipperpopup.cpp 0b2f11d6d6d95e96ece0ac7b386fae2492ad0efd Diff: https://git.reviewboard.kde.org/r/122392/diff/ Testing --- Thanks, Filip Wieladek

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-02 Thread Filip Wieladek
completly and just build up on the model? That's something I didn't look into as I only wanted to get the dataengine running and not touching the legacy way. If there is no development on the legacy way, it might be better to go that road. Filip Wieladek wrote: Hi Martin

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-02 Thread Filip Wieladek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122392/#review75255 --- On Feb. 3, 2015, 6:27 a.m., Filip Wieladek wrote

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-02 Thread Filip Wieladek
. - Filip --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122392/#review75260 --- On Feb. 3, 2015, 6:27 a.m., Filip Wieladek wrote

Review Request 122392: Fix the infinite event recursion in the klipper popup. See Bug 342947

2015-02-02 Thread Filip Wieladek
/historyfilter.h PRE-CREATION klipper/historyfilter.cpp PRE-CREATION klipper/klipperpopup.h 6f7b30747562b5e7227504b8c53be2863686072b klipper/klipperpopup.cpp 0b2f11d6d6d95e96ece0ac7b386fae2492ad0efd Diff: https://git.reviewboard.kde.org/r/122392/diff/ Testing --- Thanks, Filip Wieladek

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-02 Thread Filip Wieladek
--- Thanks, Filip Wieladek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122106: Fix the infinite event recursion in the klipper popup. See Bug 342947

2015-01-17 Thread Filip Wieladek
--- Thanks, Filip Wieladek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122106: Fix the infinite event recursion in the klipper popup. See Bug 342947

2015-01-17 Thread Filip Wieladek
/122106/#review74174 --- On Jan. 17, 2015, noon, Filip Wieladek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122106

Re: Review Request 122106: Fix the infinite event recursion in the klipper popup. See Bug 342947

2015-01-17 Thread Filip Wieladek
56c6421b33dd5a28b3a5b5eef54147acaee6dfbc Diff: https://git.reviewboard.kde.org/r/122106/diff/ Testing --- Thanks, Filip Wieladek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122106: Fix the infinite event recursion in the klipper popup. See Bug 342947

2015-01-17 Thread Filip Wieladek
klipper/klipperpopup.cpp 56c6421b33dd5a28b3a5b5eef54147acaee6dfbc Diff: https://git.reviewboard.kde.org/r/122106/diff/ Testing --- Thanks, Filip Wieladek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo