D23799: Get rid of khtml usage (kill classic mode)

gladhorn accepted this revision. gladhorn added a comment. This revision is now accepted and ready to land. Based on all the +1s, this should clearly go in. Go for it :) REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D23799 To: svuorela,

D23043: Include xkb.h

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:5ea41a794f68: Include xkb.h (authored by gladhorn). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D23042: When implementing assignment, also implement copy ctor

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:937a0cedf227: When implementing assignment, also implement copy ctor (authored by gladhorn). REPOSITORY R119 Plasma

D14764: Simplify XRandR::outputChanged

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:cc8f88d93821: Simplify XRandR::outputChanged (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE

D23056: RFC: Don't auto-restart KRunner when crashed

gladhorn added a comment. I like the idea, I have krunner crashing every so often, but usually it manages to restart, so I never look into that. Getting a backtrace would make fixing it much more likely. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D23043: Include xkb.h

gladhorn created this revision. gladhorn added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY I don't see why the header cannot be included. I guess this is some old legacy, this change

D23042: When implementing assignment, also implement copy ctor

gladhorn created this revision. gladhorn added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY /plasma-desktop/kcms/keyboard/xkb_rules.cpp: In static member function ‘static

D22522: Fix build, include QTime

This revision was automatically updated to reflect the committed changes. Closed by commit R119:18001c2926dc: Fix build, include QTime (authored by gladhorn). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22522?vs=61952=61956 REVISION DETAIL

D22522: Fix build, include QTime

gladhorn created this revision. gladhorn added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY The type is used, but was not directly included. Fixes build with Qt 5.13. REPOSITORY R119

D22208: Fix toolTipDelegate.virtualDesktopParent

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b7affafa425b: Fix toolTipDelegate.virtualDesktopParent (authored by gladhorn). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22208?vs=60987=60990 REVISION

D22207: Silence qml error message

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d80d3aaebadf: Silence qml error message (authored by gladhorn). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22207?vs=60986=60989 REVISION DETAIL

D22208: Fix toolTipDelegate.virtualDesktopParent

gladhorn created this revision. gladhorn added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY The logic tried to do an early return, but that doesn't work with ||, so use && and check if

D22207: Silence qml error message

gladhorn created this revision. gladhorn added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY model.AppPid is documented to not always exist, so use the same check that is used in othere

Re: Accessibility in Plasmas new notification system

On torsdag 6. juni 2019 13.55.49 CEST Samuel Thibault wrote: > Hello, > > ch...@linux-a11y.org, le jeu. 06 juin 2019 13:45:14 +0200, a ecrit: > > maybe a nice side notice for you (and others). We currently work on an > > accessibility HIG for KDE. > > https://hig.kde.org/accessibility/index.html

D17533: Make the button's purpose more clear

gladhorn added a comment. I also find the text rather confusing (thank you for working on this!). What is AccessX? And why should I care as a user? I need the feature... On the other hand, this patch is simple, self-contained, and in my opinion a clear improvement, so I'd vote for

D14428: Define ownership of edid in output and do not leak it

This revision was automatically updated to reflect the committed changes. Closed by commit R110:e6b197b47b8a: Define ownership of edid in output and do not leak it (authored by gladhorn). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14428?vs=38600=46182#toc REPOSITORY R110 KScreen

D16988: [Kickoff] Make the visible search field unfocused by default

gladhorn added a comment. In D16988#362104 , @rooty wrote: > @gladhorn More food for thought by the way: in this patch (and the master) the search field is focused while searching and while navigating the search results - it still accepts input

D16988: [Kickoff] Make the visible search field unfocused by default

gladhorn added a comment. In D16988#361980 , @ngraham wrote: > There are a lot of good changes in here, like those keyboard navigation improvements! And I appreciate all the work that clearly went into this. However, the problem with huge

Re: Plasma Accessibility: Kickoff Application starter and Focus handling

On søndag 18. november 2018 18:08:27 CET David Edmundson wrote: > I started a patch a while ago in a branch: > D7780: Make Kickoff expose items to accessibility > > Which rewrote a lot as the focus handling was all over the place. > > However, in the meantime there was another big patch to

D16638: Add accessibility and set focus on the actual items in the window switcher

gladhorn closed this revision. gladhorn added a comment. This is in I'm unsure why "arc land" didn't close it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16638 To: gladhorn, davidedmundson, chempfling, kwin Cc: plasma-devel, ragreen, Pitel, ZrenBot,

D16638: Add accessibility and set focus on the actual items in the window switcher

gladhorn updated this revision to Diff 44926. gladhorn retitled this revision from "Set focus on the actual items in the window switcher" to "Add accessibility and set focus on the actual items in the window switcher". gladhorn added a comment. Changed it to be more pleasant by using client

D16638: Set focus on the actual items in the window switcher

gladhorn updated this revision to Diff 44925. gladhorn retitled this revision from "Handle focus in the window switcher" to "Set focus on the actual items in the window switcher". gladhorn edited the summary of this revision. gladhorn edited the test plan for this revision. gladhorn edited

D16638: Handle focus in the window switcher

gladhorn added a comment. It looks like I need either forceActiveFocus or to remove the window manager bypass hint. Or find some other way to get the focus on the window... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16638 To: gladhorn, davidedmundson,

D16638: Handle focus in the window switcher

gladhorn updated this revision to Diff 44856. gladhorn added a comment. Removed Qt.X11BypassWindowManagerHint which makes everything work Thanks for encouraging this. If anyone has any ideas why the window manager hint was set, I'd be interested to learn. REPOSITORY R120 Plasma

D16638: Handle focus in the window switcher

gladhorn added inline comments. INLINE COMMENTS > broulik wrote in WindowSwitcher.qml:48 > Doesn't the `focus: true` imply that already? It would if the window did end up having the focus in some form. As far as I can tell it doesn't ever get the focus (since kwin decided that it shouldn't).

D16638: Handle focus in the window switcher

gladhorn created this revision. gladhorn added reviewers: davidedmundson, kwin, chempfling. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY KWin does not actually give proper window focus to the tabbox. But

D16309: Add accessibility information to desktop icons

gladhorn added a comment. I guess we can go with this for now, let's be pragmatic. Qt doesn't have icon or desktop_icon at the moment. I can add, if Joanie suggests doing that on the Orca mailing list. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16309

D16309: Add accessibility information to desktop icons

gladhorn accepted this revision. gladhorn added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > FolderItemDelegate.qml:45 > +Accessible.name: name > +Accessible.role: Accessible.Canvas > function openPopup() { Is Canvas what Gnome uses for

D14855: Add applet with screen layouts and presentation mode

gladhorn accepted this revision. gladhorn added a comment. This revision is now accepted and ready to land. OK, let's do it :) REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14855 To: broulik, #plasma, #vdg, fischbach, harmathy, gladhorn Cc: anthonyfieroni,

D14950: Add screen to the keyword of kscreen KCM

gladhorn accepted this revision. gladhorn added a comment. Yes please :) REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.kde.org/D14950 To: davidedmundson, #plasma, ngraham, gladhorn Cc: gladhorn, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D14855: Add applet with screen layouts and presentation mode

gladhorn added a comment. This looks generally nice, I like it. Since we're short on people maintaining this stuff, I'd like more of the code to be shared though. INLINE COMMENTS > daemon.h:66 > +// DBus > +void applyLayoutPreset(const QString ); > Q_SIGNALS: Could

D14549: EDID parsing: replace non-printable characters with '-'

This revision was automatically updated to reflect the committed changes. Closed by commit R110:13bc5bcd4bf4: EDID parsing: replace non-printable characters with - (authored by gladhorn). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14549?vs=38934=39612#toc REPOSITORY R110 KScreen

D14764: Simplify XRandR::outputChanged

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL

D14548: testedid: make sure to use uint consistently

This revision was automatically updated to reflect the committed changes. Closed by commit R110:c9955376ed2d: testedid: make sure to use uint consistently (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14548?vs=38933=38960

D14549: EDID parsing: replace non-printable characters with '-'

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY Simplify first to not have zero terminators suddenly replaced

D14548: testedid: make sure to use uint consistently

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY It seems like compilation was broken with some configurations,

D14514: Install the OSD icons to hicolor

gladhorn added a comment. In D14514#301328 , @broulik wrote: > Why are they not in the Plasma theme, though? What does that mean? "the plasma theme" ? I'm happy to move these to wherever it makes sense. Currently they are big

D14476: QMLScreen: do not declare the engine a member

This revision was automatically updated to reflect the committed changes. Closed by commit R104:a6929de88b89: QMLScreen: do not declare the engine a member (authored by gladhorn). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14476?vs=38857=38860#toc REPOSITORY R104 KScreen CHANGES

D14476: QMLScreen: do not declare the engine a member

gladhorn updated this revision to Diff 38857. gladhorn added a comment. Remove more cruft REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14476?vs=38745=38857 BRANCH arcpatch-D14476 REVISION DETAIL https://phabricator.kde.org/D14476 AFFECTED FILES

D14514: Install the OSD icons to hicolor

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY These icons were only in breeze-icons and would not be found

D14353: Improve alignment of types

gladhorn abandoned this revision. gladhorn added a comment. seems like this is not wanted REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14353 To: gladhorn, #plasma, romangg Cc: zzag, romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D14478: Do not leak all instances of QMLOutput when QMLScreen is destroyed

This revision was automatically updated to reflect the committed changes. Closed by commit R104:ff717c0a9c4c: Do not leak all instances of QMLOutput when QMLScreen is destroyed (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D14476: QMLScreen: do not declare the engine a member

gladhorn added inline comments. INLINE COMMENTS > broulik wrote in qmlscreen.h:109 > This entire custom engine handling could be removed, with `QMLScreen` using > `qmlEngine(this)` when creating an `QMLOutput` I had briefly tried and got a nullptr from qmlEngine, but I didn't really spend

D14477: Do not leak Widget::ui

This revision was automatically updated to reflect the committed changes. Closed by commit R104:749ab17d5e48: Do not leak Widget::ui (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14477?vs=38746=38749 REVISION DETAIL

D14478: Do not leak all instances of QMLOutput when QMLScreen is destroyed

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY In practice this is most likely only a leak on exit which does

D14477: Do not leak Widget::ui

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14477

D14476: QMLScreen: do not declare the engine a member

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY There is no need for this, the only use of the engine is when

D14428: Define ownership of edid in output and do not leak it

gladhorn added a comment. The alternative would be to deprecate this and add a new function. I think this is nonetheless sensible. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14428 To: gladhorn, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot,

D14368: Let edidDecodeFraction return float

This revision was automatically updated to reflect the committed changes. Closed by commit R110:15aa08f36561: Let edidDecodeFraction return float (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14368?vs=38593=38623 REVISION

D14353: Improve alignment of types

gladhorn added a comment. In D14353#299282 , @zzag wrote: > I suggest to describe in the summary why data members are ordered from largest to smallest. OK, this should be the default for everyone. To have structures packed tight. Then

D14405: Use short pnp id as fallback when the DB file is not found

gladhorn added a comment. I think the qml code should not do logic fiddling with the EDID :) but needs investigation. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14405 To: gladhorn, davidedmundson Cc: davidedmundson, plasma-devel, ragreen, Pitel,

D14418: Add test for edid parsing and fix reading gamma

This revision was automatically updated to reflect the committed changes. Closed by commit R110:b80bbeb2e419: Add test for edid parsing and fix reading gamma (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38594=38604

D14428: Define ownership of edid in output and do not leak it

gladhorn updated this revision to Diff 38600. gladhorn added a comment. Messed up merge :( REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14428?vs=38599=38600 REVISION DETAIL https://phabricator.kde.org/D14428 AFFECTED FILES src/output.cpp

D14428: Define ownership of edid in output and do not leak it

gladhorn updated this revision to Diff 38599. gladhorn added a comment. Add note about the edid pointer becoming invalid REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14428?vs=38598=38599 REVISION DETAIL https://phabricator.kde.org/D14428

D14428: Define ownership of edid in output and do not leak it

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY Valgrind showed that in some cases we were leaking the edid in

D14353: Improve alignment of types

gladhorn updated this revision to Diff 38596. gladhorn added a comment. initializer order fixed REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14353?vs=38595=38596 BRANCH arcpatch-D14353 REVISION DETAIL https://phabricator.kde.org/D14353

D14353: Improve alignment of types

gladhorn updated this revision to Diff 38595. gladhorn added a comment. Move two more members to the right spot REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14353?vs=38379=38595 BRANCH arcpatch-D14353 REVISION DETAIL

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38594. gladhorn added a comment. arc messup, it squashed another patch into this one REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38592=38594 REVISION DETAIL https://phabricator.kde.org/D14418

D14368: Let edidDecodeFraction return float

gladhorn updated this revision to Diff 38593. gladhorn edited the summary of this revision. gladhorn added a comment. arc mangled two patches again :( REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14368?vs=38421=38593 BRANCH arcpatch-D14368

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38592. gladhorn edited the summary of this revision. gladhorn added a subscriber: romangg. gladhorn added a comment. Updated commit message and rebased. REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38590. gladhorn added a comment. Sort edids in test rows. I still think this is completely pointless and a waste of time. REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38588=38590 BRANCH

D14405: Use short pnp id as fallback when the DB file is not found

gladhorn added a comment. Good catch, I'll have to look into it, right now I get an empty string for both. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14405 To: gladhorn, davidedmundson Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot,

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38588. gladhorn added a comment. Removed xfail, it was fixed by the string parsing fix REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38565=38588 BRANCH arcpatch-D14418_1 REVISION DETAIL

D14361: Remove unused function

This revision was automatically updated to reflect the committed changes. Closed by commit R104:ed42cf46ae2c: Remove unused function (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14361?vs=38404=38586 REVISION DETAIL

D14350: Make sure for loop does not detach

This revision was automatically updated to reflect the committed changes. Closed by commit R110:7cbccda5a273: Make sure for loop does not detach (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14350?vs=38426=38584 REVISION

D14359: Create m_saveTimer lazily

This revision was automatically updated to reflect the committed changes. Closed by commit R104:f4b0d85fe061: Create m_saveTimer lazily (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14359?vs=38517=38585 REVISION DETAIL

D14369: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone

This revision was automatically updated to reflect the committed changes. Closed by commit R110:106251461674: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE

D14369: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone

gladhorn updated this revision to Diff 38582. gladhorn added a comment. Moved Q_REQUIRED_RESULT to the front REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14369?vs=38422=38582 BRANCH arcpatch-D14369 REVISION DETAIL

D14369: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone

gladhorn added a comment. It's been there for ages, it's mentioned in the changelog at least... but actually it seems more common to put the attribute before the function, I'll update with that. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14369 To:

D14369: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone

gladhorn added a comment. I'll check, if it's not public API, I'll make it. Thanks for the pointer. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14369 To: gladhorn, #plasma, davidedmundson Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D14410: EDID parsing: strings are up to 13 bytes

gladhorn added a comment. Yes, my laptop screen uses all 13 bytes, that's how I noticed (the model had one character cut off and I happened to debug and see that it was there, so I did the math :)). REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14410 To:

D14410: EDID parsing: strings are up to 13 bytes

This revision was automatically updated to reflect the committed changes. Closed by commit R110:c66291ec8307: EDID parsing: strings are up to 13 bytes (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14410?vs=38532=38580

D14418: Add test for edid parsing and fix reading gamma

gladhorn added a comment. In D14418#299028 , @romangg wrote: > I'm not sure if you could really say that the current code is with a bug, since `data[GCM_EDID_OFFSET_GAMMA]` should be dividable by 100. I.e. the result is again an integer and

D14364: Test configId in TestSerializer

gladhorn added inline comments. INLINE COMMENTS > romangg wrote in serializertest.cpp:163 > Below we do some tests in regards to the current config id value. These tests > are unrelated to any changes of the config id value over time. Therefore it > should not reference the magic config id

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38565. gladhorn added a comment. Added one more edid REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38564=38565 BRANCH arcpatch-D14418 REVISION DETAIL https://phabricator.kde.org/D14418

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38564. gladhorn added a comment. Removed some extra parenthesis REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38553=38564 BRANCH arcpatch-D14418 REVISION DETAIL

D14371: Simplify Edid::Private::parse gamma

gladhorn abandoned this revision. gladhorn added a comment. D14418 is nicer REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14371 To: gladhorn Cc: romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D14422: Add edid converter

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY Make it convenient to work with various EDID formats by

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38553. gladhorn added a comment. Remove extra newline REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38550=38553 BRANCH autotest REVISION DETAIL https://phabricator.kde.org/D14418 AFFECTED

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38550. gladhorn added a comment. Minor cleanup REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38549=38550 BRANCH autotest REVISION DETAIL https://phabricator.kde.org/D14418 AFFECTED FILES

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38549. gladhorn added a comment. Simplify gamma parsing code REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38548=38549 BRANCH autotest REVISION DETAIL https://phabricator.kde.org/D14418

D14418: Add test for edid parsing and fix reading gamma

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY The bug in reading the gamma value was there from the start (2012), dividing the number by 100

D14326: Fix layout of resolution selection

This revision was automatically updated to reflect the committed changes. Closed by commit R104:5b6e9767a73e: Fix layout of resolution selection (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14326?vs=38515=38543 REVISION DETAIL

D14410: EDID parsing: strings are up to 13 bytes

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY The descriptor blocks with strings come every 18 bytes, 5

D14405: Use short pnp id as fallback when the DB file is not found

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY At least on arch linux pnp.ids does not even exist (while usb.ids and pci.ids do). There seem

D14364: Test configId in TestSerializer

gladhorn updated this revision to Diff 38518. gladhorn edited the summary of this revision. gladhorn added a comment. Add more explanations REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14364?vs=38408=38518 BRANCH arcpatch-D14364 REVISION DETAIL

D14359: Create m_saveTimer lazily

gladhorn updated this revision to Diff 38517. gladhorn retitled this revision from "Use inintializers and only create m_saveTimer when needed" to "Create m_saveTimer lazily". gladhorn added a comment. Only touch saveTimer REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D14359: Use inintializers and only create m_saveTimer when needed

gladhorn updated this revision to Diff 38516. gladhorn added a comment. Initialize m_changeCompressor to nullptr REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14359?vs=38400=38516 BRANCH arcpatch-D14359 REVISION DETAIL

D14326: Fix layout of resolution selection

gladhorn updated this revision to Diff 38515. gladhorn added a comment. Fix the layout REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14326?vs=38317=38515 BRANCH arcpatch-D14326_1 REVISION DETAIL https://phabricator.kde.org/D14326 AFFECTED FILES

D14403: Change screen orientation label from Normal to No Rotation

This revision was automatically updated to reflect the committed changes. Closed by commit R104:6dd05a592d48: Change screen orientation label from Normal to No Rotation (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D14403: Change screen orientation label from Normal to No Rotation

gladhorn created this revision. gladhorn added reviewers: VDG, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R104 KScreen BRANCH master REVISION DETAIL

D14339: Change rotation icons to be a rotated preview icon

This revision was automatically updated to reflect the committed changes. Closed by commit R104:200cdd782e5f: Change rotation icons to be a rotated preview icon (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14339?vs=38486=38505

D14361: Remove unused function

gladhorn added inline comments. INLINE COMMENTS > broulik wrote in daemon.h:38 > Can this cause trouble with ABI since this class is exported? But it's > probably just exported as an entry point for KDED and not for use as a library Well, the header is not installed, so the export seems pretty

D14326: Fix layout of resolution selection

gladhorn added a comment. The alignment previous to this commit is also not given, it just happens to look a hint better. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14326 To: gladhorn, #plasma, #vdg, ngraham Cc: andreaska, abetts, ngraham, broulik, zzag,

D14353: Improve alignment of types

gladhorn added a comment. Of course it's questionable if this is worth it, it's unlikely that we'll have so many instances of it that it'll ever make a difference. INLINE COMMENTS > output.cpp:89 > +int id; > qreal scale; > +Type type; Actually scale should move up maybe,

D14353: Improve alignment of types

gladhorn added a comment. In D14353#298417 , @romangg wrote: > Why push id down? It should stay at the top imo (or alphabetically). Rest is fine. Because of padding. On 64 bit when int is usually 4 bit, there will be a hole of 4 bits in

D13871: Make TestInProcess skip out-of-process tests if D-Bus service uninstalled

gladhorn added a comment. Looks good, please finish up cleanup/indentation and I'll accept. INLINE COMMENTS > testinprocess.cpp:142 > +if (m_backendServiceInstalled) { > qDebug() << "TT xrandr out-of-process"; > // Load the xrandr backend out-of-process Please indent.

D14370: Simplify Edid::Private::edidParseString

This revision was automatically updated to reflect the committed changes. Closed by commit R110:2dfbe8d8a6cc: Simplify Edid::Private::edidParseString (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14370?vs=38423=38501 REVISION

D14339: Remove confusing icons from rotation combobox

gladhorn updated this revision to Diff 38486. gladhorn added a comment. Updated message hopefully REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14339?vs=38382=38486 BRANCH arcpatch-D14339 REVISION DETAIL https://phabricator.kde.org/D14339 AFFECTED

D14339: Remove confusing icons from rotation combobox

gladhorn added a comment. And I see that arc just threw away my updated commit message :(, that's just weird. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14339 To: gladhorn, #plasma, #vdg, ngraham Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot,

  1   2   3   >