[Differential] [Commented On] D2345: use a separate configuration per look and feel

ivan added inline comments. INLINE COMMENTS > containment.cpp:197 > +//addWidget("org.kde.plasma.analogclock", {"x": 0, "y": 100, > "width": 300, "height": 400}); > +const QVariantMap geom = > context->argument(1).toVariant().value(); > +geometry =

[Differential] [Closed] D2480: Serializing the desktop layout to a JavaScript object

ivan closed this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2480 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg,

[Differential] [Commented On] D2480: Serializing the desktop layout to a JavaScript object

ivan added inline comments. INLINE COMMENTS > mart wrote in shellcorona.cpp:392 > QByteArray and returning .toUtf8()? toJson is already utf8 byte array REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH ivan/separateLookAndFeelLayoutSerialization REVISION DETAIL

[Differential] [Updated, 1,979 lines] D2480: Serializing the desktop layout to a JavaScript object

ivan updated this revision to Diff 6028. ivan added a comment. - Dumping JS as a UTF8 byte array instead as a string REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2480?vs=6026=6028 BRANCH ivan/separateLookAndFeelLayoutSerialization

[Differential] [Request, 1,985 lines] D2480: Serializing the desktop layout to a JavaScript object

ivan created this revision. ivan added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY - Serializing the desktop layout for current activity - Support for different config groups - Introducing

Re: stylesheed folders

What does the window decoration have in common with a folder? This is my screenshot: https://share.kde.org/index.php/s/l1eQjahyNee0sbO Cheers, Ivan

Re: stylesheed folders

+1 (for sebas' comment, not for the rainbow folders) I don't mind the idea of being able to customize folder colours, but I don't think that it should be done like this - we do not have the 'folder colour' settings in the colour scheme settings, which means that some other colour will be used to

Re: Selecting a Plasma logo

Hi all, For anyone interested I've also posted the SVG file (Andreas asked for it): https://share.kde.org/index.php/s/0HRcGXCt6UCEWxp Cheers, Ivan

[Differential] [Commented On] D2345: use a separate configuration per look and feel

ivan added inline comments. INLINE COMMENTS > mart wrote in shellcorona.cpp:550 > I hate this method. > tough, i need a way from the kcm to reset the current layout to the default. > it's quite dangerous and exporting a dbus method that effectively destroys > the current config is evil... >

Re: Selecting a Plasma logo

Hi, When I said that I don't really find any of these fitting as a launcher icon, I obviously excluded the K-gear logo - was thinking about the new proposals. Though, the fact that K-gear looks better than the rest might be because we are all accustomed to that one. The same goes for the current

Re: Selecting a Plasma logo

Hi all, I've put a few of the ideas on a panel - both on a light theme, and on a dark one. Also without any icon background, and on the blue rectangle. It also has the current KDE logo for reference. https://share.kde.org/index.php/s/b9sMKE3Nl9whJiQ I'm a bit sad to say that I don't really

Re: Selecting a Plasma logo

Andreas, Do you have screenshots? Cheers, Ivan

[Differential] [Commented On] D2345: use a separate configuration per look and feel

ivan added a comment. All in all, seems ok. I think we need to start commenting code like this - what it is doing. I do realize it is popular for the code to be self-documenting, but that has not been working for us that well :) Can you write short instructions on how to test this?

Re: Selecting a Plasma logo

Just for completeness - Andy's response: > Hey Ivan, thanks for asking. At this time, I want to keep that logo as is, > without drastic modifications. Maybe one can make the argument that > including more elements has a background and a reason. But at this > point, I want to keep this logo the

Re: Selecting a Plasma logo

Thomas: > The VDG is fine with his proposal as is, but the Plasma team did > not seem to 100% happy with it. As far as I'm concerned, 'not 100% happy' is an understatement. It has nice visuals, but it is not a brand, nor is it recognizable. Ken: > With all due respect to Anditosan, I think he

Re: Selecting a Plasma logo

@Sebas We asked him whether he would allow changes to his proposal - mainly since we are here mostly considering Ken's modifications of Alex's and his work.* He seems not to like the idea of anyone altering his work - that he considered different modifications already, but stayed with the

Re: Selecting a Plasma logo

> The disadvantages of the second one are that the gears become a bit > muddled in small sizes and it resembles the gear which is often used > as a settings icon, This 'disadvantage' is a bit artificial. I agree the gears would not be visible on small icon sizes. But small icons do not need to

Plasma 5.7 scripting

Hi all, Unfortunately, since the new multiscreen code landed, we had a few really big issues regarding plasma scripting - namely with the execution of the the layout.js. The bugs were both in the scripting engine, and both in our upstream layout.js and the custom ones shipped by the distros.

[Differential] [Accepted] D2298: allow for lnf packages to override templates

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. Seems ok REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH phab/paneltemplate REVISION DETAIL https://phabricator.kde.org/D2298 EMAIL PREFERENCES

[Differential] [Requested Changes To] D2283: patch from https://bugs.kde.org/show_bug.cgi?id=365989

ivan requested changes to this revision. ivan added a reviewer: ivan. ivan added a comment. This revision now requires changes to proceed. Cool :) @mart Can you close this review? REVISION DETAIL https://phabricator.kde.org/D2283 EMAIL PREFERENCES

Re: Selecting a Plasma logo

On Tue, Jul 26, 2016 at 4:01 PM, Dan Leinir Turthra Jensen wrote: > On Tuesday, 26 July 2016 15:52:41 BST Sebastian Kügler wrote: >> > bridge to the current logo. >> >> I quite like that one indeed. > > Quite keen on that one, yes :) It is one of my other favs, behind

Re: Selecting a Plasma logo

> I kind of like it as is more smoother than the harsh usual gear. > however, I'm quite concerned that it looks very, very generic, not really much > recognizable This is my problem with it as well. The one that stands out for me is one of the Kver's mesh-ups. The one with a part of the current

[Differential] [Closed] D2288: Properly registering existing activities before loading layout.js

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE475bed737314: Properly registering existing activities before loading layout.js (authored by ivan). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D2286: allow lnf package to specify a default cont

ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH arcpatch-D2286 REVISION DETAIL https://phabricator.kde.org/D2286 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart,

[Differential] [Commented On] D2286: allow lnf package to specify a default cont

ivan added a comment. Otherwise, seems ok. Does it work as well as it looks? :) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2286 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, ivan Cc:

[Differential] [Commented On] D2286: allow lnf package to specify a default cont

ivan added a comment. Otherwise, seems ok. Does it work as well as it looks? :) INLINE COMMENTS > plasma-packagestructure-lookandfeel.desktop:19 > Name[gl]=Aparencia e comportamento > -Name[he]=מראה והרגשה > +Name[he]=מראה ותחושה > Name[hu]=Megjelenés You should probably skip this :)

[Differential] [Commented On] D2283: patch from https://bugs.kde.org/show_bug.cgi?id=365989

ivan added a comment. p.s. The step `4` will be made a bit different with Marco's upcoming patch, but it is the only way ATM to set the default containment plugin. REVISION DETAIL https://phabricator.kde.org/D2283 EMAIL PREFERENCES

[Differential] [Commented On] D2283: patch from https://bugs.kde.org/show_bug.cgi?id=365989

ivan added a comment. @abondrov Yes, it is a backport of a patch that will be reverted once we deal with 5.7 stuff. We didn't put it in 5.7 branch because it is not really a good patch - it was supposed to cover the cases when kactivitymanagerd is not installed, but we need

[Differential] [Updated] D2283: patch from https://bugs.kde.org/show_bug.cgi?id=365989

ivan added a comment. @abondrov Since you are really helpful and active, I have a couple of things for you to test :) (please do not kill me) 1. Remove david's patch backported from master (the one that checks against kamd status being Unknown -

[Differential] [Commented On] D2283: patch from https://bugs.kde.org/show_bug.cgi?id=365989

ivan added a comment. @abondrov Thanks. This one needs to go away, along with making kactivitymanagerd a hard runtime requirement: > https://abf.rosalinux.ru/import/plasma5-workspace/blob/rosa2014.1/plasma-workspace-5.7.2-layout-initialization-2.patch The load-order one

[Differential] [Request, 13 lines] D2288: Properly registering existing activities before loading layout.js

ivan created this revision. ivan added reviewers: Plasma, mart, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.7 REVISION DETAIL

[Differential] [Commented On] D2283: patch from https://bugs.kde.org/show_bug.cgi?id=365989

ivan added a comment. @mart The reason why this change fixes the scripting problem I'm working on is that loadLayout actually calls loadDefaultLayout and this tells the scripting engine which activities exist, and which are present. That is why adding this above loadLayout was working

[Differential] [Updated] D2286: allow lnf package to specify a default cont

ivan added a comment. Maybe we should have a mechanism for this (like config cascading) because I guess we will have this in a few places - check in lnf, then in global. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2286 EMAIL PREFERENCES

[Differential] [Commented On] D2283: patch from https://bugs.kde.org/show_bug.cgi?id=365989

ivan added a comment. @abondrov Have you applied any patch other than this one to plasma? I'm asking since neither Marco nor I can replicate this on our systems (with empty-config users) Another question, do you have a repository of what changes your distro is doing during

Re: [plasma-workspace/Plasma/5.7] shell: don't try to load layout before kamd starts

> It can also be simply not installed. > That was the case for the Neon/Netrunner reports. Yes, Bhushan covered that part - not starting or crashing. I just specified the cases where kamd is 'expected' to crash. >> One of the things that we could try is for kactivities to return >> 'Unknown' as

[Differential] [Accepted] D2268: Fix loading if KActivities is in state NotRunning

ivan accepted this revision. ivan added a reviewer: ivan. ivan added a comment. This revision is now accepted and ready to land. Accepting until something else breaks :/ REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2268 EMAIL

Re: Properly fixing the containment scripting issue

> so it can just change stuff in that one "activity"? (i'm fine with that, just > asking) Exactly. When Plasma starts for the first time, it knows (it is guaranteed) that at least one activity will exist. - Why not allow its containments to be customized. > then, as soon and if kamd comes

Properly fixing the containment scripting issue

Hi all, As we have seen in this past period, there are quite a few issues with the layout.js plasma script and its execution. Most the issues stem from the fact that the scripting code was created in the era where each screen, each virtual desktop was able to have a different containment in it

[Differential] [Commented On] D2275: loop trough screens only once

ivan added a comment. In https://phabricator.kde.org/D2275#42317, @davidedmundson wrote: > > we are already looping through screens > > Where? ShellCorona::loadDefaultLayout() (which runs this) is only called once - from load() and that's not per screen. var

Re: [plasma-workspace/Plasma/5.7] shell: don't try to load layout before kamd starts

The only reasons for kamd to crash are inability to create WAL sqlite database (it will return an assert with a detailed message), and to crash on *exit* due to the QSql bug related to driver deinit. Other than that, I haven't had any crashes reported for quite a long time now. Are there any

[Differential] [Accepted] D2275: loop trough screens only once

ivan accepted this revision. ivan added a reviewer: ivan. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH phab/layoutjsloop REVISION DETAIL https://phabricator.kde.org/D2275 EMAIL PREFERENCES

[Differential] [Closed] D2251: Missing method for activity deletion from plasma script added

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE5d5f37798e9f: Missing method for activity deletion from plasma script added (authored by ivan). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Updated, 18 lines] D2251: Missing method for activity deletion from plasma script added

ivan updated this revision to Diff 5421. ivan added a comment. Just renamed a variable REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2251?vs=5402=5421 BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D2251 AFFECTED

[Differential] [Request, 18 lines] D2251: Missing method for activity deletion from plasma script added

ivan created this revision. ivan added reviewers: mart, garg. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We have a method to add an activity in plasma script, but not to remove it. This patch fixes this situation.

[Differential] [Commented On] D2242: [ksplash] Better support for Wayland with multiple screens

ivan added inline comments. INLINE COMMENTS > graesslin wrote in splashapp.cpp:155 > yes that's on my todo list since last Akademy... - in pretty much exactly the > way you just outlined here. Please do, I have grepped plasma codebases, and we have platformName() calls in quite a few places.

[Differential] [Commented On] D2242: [ksplash] Better support for Wayland with multiple screens

ivan added inline comments. INLINE COMMENTS > graesslin wrote in splashwindow.cpp:151 > well tricky then. I need to get to the kwayland integration done in > KSplashApp. I need a way to get to that. And if it's not using KSplashApp > that needs to be done somewhere else. If you have ideas how

[Differential] [Commented On] D2242: [ksplash] Better support for Wayland with multiple screens

ivan added inline comments. INLINE COMMENTS > graesslin wrote in splashapp.cpp:155 > nah, if at all to KWindowSystem. Ok, to KWindowSystem then. It could be a method with inner cached static result so that the consecutive calls to it do not need to perform any string comparisons. This is not

[Differential] [Commented On] D2242: [ksplash] Better support for Wayland with multiple screens

ivan added a comment. Mostly looks ok, though I can not comment on wayland-specific things. INLINE COMMENTS > splashapp.cpp:155 > +{ > +if > (!QGuiApplication::platformName().startsWith(QLatin1String("wayland"), > Qt::CaseInsensitive)) { > +return; Maybe it would be a good

[frameworks-kactivities-stats] [Bug 362198] Plasma Crashes

https://bugs.kde.org/show_bug.cgi?id=362198 --- Comment #5 from Ivan Čukić <ivan.cu...@kde.org> --- Great that we got to the bottom of it. Issues like these are always the worst ones to catch since you do not expect them. :) -- You are receiving this mail because: You are on the C

[Differential] [Commented On] D2173: WIP: New System Settings delegate design

ivan added a comment. > Is that different to how it was before? Before, we had the icon and the text - and the whole are was one-clickable thing. Having different sub-areas with bigger differences in behaviour, and not having them visually separated is a problem (the thing

[Differential] [Closed] D2211: Switching activity while creating it from PlasmaScript

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEa566273eb80d: Switching activity while creating it from PlasmaScript (authored by ivan). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Updated] D2211: Switching activity while creating it from PlasmaScript

ivan updated the test plan for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2211 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, #plasma, mart Cc: plasma-devel, jensreuterberg, abetts,

[Differential] [Request, 67 lines] D2211: Switching activity while creating it from PlasmaScript

ivan created this revision. ivan added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Containment creation relies on the current activity, so we need to change the current activity when

[plasmashell] [Bug 360339] Plasma Crash on startup

https://bugs.kde.org/show_bug.cgi?id=360339 Ivan Čukić <ivan.cu...@kde.org> changed: What|Removed |Added Version|5.19.0 |master

[frameworks-kactivities-stats] [Bug 362198] Plasma Crashes

https://bugs.kde.org/show_bug.cgi?id=362198 --- Comment #3 from Ivan Čukić <ivan.cu...@kde.org> --- Which file-system is on /Data? are you able to edit .config/katerc file (for example, in vim or something) and save it. Then confirm the data has been written? Having 92% of a partitio

[Differential] [Closed] D2187: ScriptEngine exports the list of activities known to Plasma

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE3af24524702e: ScriptEngine exports the list of activities known to Plasma (authored by ivan). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D2173: WIP: New System Settings delegate design

ivan added a comment. The last one - when closing the SySett, this is written a few dozen times: User of KWidgetItemDelegate should not delete widgets created by createItemWidgets! REPOSITORY rSYSTEMSETTINGS System Settings REVISION DETAIL https://phabricator.kde.org/D2173 EMAIL

[Differential] [Changed Subscribers] D2173: WIP: New System Settings delegate design

ivan added subscribers: jensreuterberg, colomar. ivan added a comment. @colomar @jensreuterberg There is one strange thing regarding the behaviour - the sub-item links. The first problem is that it is not obvious what is clickable and what is not - the only hint is a slight change

[Differential] [Commented On] D2173: WIP: New System Settings delegate design

ivan added a comment. There is a problem with the dark colour scheme - the view now has white borders on the sides: F182088: systemsettings.png The second thing, I think that the items would benefit from more padding. The third is that the

[Differential] [Closed] D2176: Removing the Activity wrapper class from the Shell

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE4275d8eb4b09: Removing the Activity wrapper class from the Shell (authored by ivan). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Request, 380 lines] D2176: Removing the Activity wrapper class from the Shell

ivan created this revision. ivan added reviewers: Plasma, mart, davidedmundson, bshah. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY After the previous patch which removed the unused Activity class related events, it

[Differential] [Closed] D2174: Removing dead code - activity-event-handling private slots

This revision was automatically updated to reflect the committed changes. ivan marked an inline comment as done. Closed by commit rPLASMAWORKSPACEada43d447ccf: Removing dead code - activity-event-handling private slots (authored by ivan). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES

[Differential] [Updated] D2174: Removing dead code - activity-event-handling private slots

ivan marked an inline comment as done. ivan added inline comments. INLINE COMMENTS > davidedmundson wrote in shellcorona.cpp:1588 > we use this one > > you've even updated the line that's using it in this very patch. It is using activityRemoved(QString), not activityRemoved(), It would not

[Differential] [Updated] D2174: Removing dead code - activity-event-handling private slots

ivan updated the summary for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2174 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, #plasma, mart, sebas, davidedmundson Cc: plasma-devel,

[Differential] [Request, 37 lines] D2174: Removing dead code - activity-event-handling private slots

ivan created this revision. ivan added reviewers: Plasma, mart, sebas, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY A few private slots handling the events of Activity objects have been lingering

[Differential] [Closed] D2162: Memory-optimizing Activity object not to keep duplicate data

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE2e40cf776db2: Memory-optimizing Activity object not to keep duplicate data (authored by ivan). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Updated, 145 lines] D2162: Memory-optimizing Activity object not to keep duplicate data

ivan updated this revision to Diff 5153. ivan added a comment. Removing the mutex since Activity objects should reside in the same thread REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2162?vs=5151=5153 BRANCH master REVISION

[Differential] [Request, 142 lines] D2162: Memory-optimizing Activity object not to keep duplicate data

ivan created this revision. ivan added reviewers: mart, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Activity object kept all the data that KActivities::Info keeps, and an instance of

Re: Which applications does the Plasma team recommend to use with Plasma?

I also find Cantata a strange choice (even though I do use it :) ). Was Clementine-qt5 considered? I do not think VLC is a suitable replacement for a proper music player. (if we took that claim, we could easily say everything here is irrelevant since the web browser is all the user needs...) As

[Differential] [Closed] D1963: Guarding the X11 calls not to appear in a wayland session

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP7a0522ca224b: Guarding the X11 calls not to appear in a wayland session (authored by ivan). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Updated] D1963: Guarding the X11 calls not to appear in a wayland session

ivan marked an inline comment as done. ivan added a comment. In https://phabricator.kde.org/D1963#36110, @gladhorn wrote: > Guaring seems like a typo to me. Yes, thanks! REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1963 EMAIL

[Differential] [Updated] D1963: Guarding the X11 calls not to appear in a wayland session

ivan retitled this revision from "Guaring the X11 calls not to appear in a wayland session" to "Guarding the X11 calls not to appear in a wayland session". REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1963 EMAIL PREFERENCES

[Differential] [Updated] D1963: Guaring the X11 calls not to appear in a wayland session

ivan marked an inline comment as done. ivan added inline comments. INLINE COMMENTS > bshah wrote in switcherbackend.cpp:197 > cache this value, as it is string comparison and impossible to change at > runtime. Anyone asked Qt guys whether they would like this cached in Qt? REPOSITORY

[Differential] [Updated, 51 lines] D1963: Guaring the X11 calls not to appear in a wayland session

ivan updated this revision to Diff 4649. ivan added a comment. Caching the value for 'are we on X11' REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1963?vs=4645=4649 BRANCH master REVISION DETAIL https://phabricator.kde.org/D1963

[Differential] [Request, 45 lines] D1963: Guaring the X11 calls not to appear in a wayland session

ivan created this revision. ivan added reviewers: sebas, graesslin, bshah. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY All x11 methods got the x11_ prefix to be more obvious which parts are x11-only. Added default

Re: New idea for Plasma's logo

Hi Alex, The things I like about the proposal: - It retains the connection to the old logo (a huge plus in my book) - I like the idea of the Sun with Plasma - It would still be easy to recognize it even from the distance The problems I see with it (if it is meant to be used as the menu icon

Re: RFC: plasma logo as start menu icon and ksplash logo

> Your argument above exactly shows to me why this _is_ related to the > rebranding: You seeing Plasma's launcher specifically as an "entrance to Rebranding was about KDE is the community, not the software. It is *not* about "Plasma works as well with non-KDE software as with the KDE-software".

Re: RFC: plasma logo as start menu icon and ksplash logo

Hi all, There are two main reasons why I'm against this (regardless of what ends up being plasma logo, and regardless of whether it will be pretty or not - the KDE logo would not win any beauty pageants :) ): - (as previously mentioned) the gear-logo is a recognizable brand (easy to spot on on

[kio-extras] [Bug 363048] File conflicts with kio_activities

https://bugs.kde.org/show_bug.cgi?id=363048 Ivan Čukić <ivan.cu...@kde.org> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Reso

Re: KDED deadlock in statusnotifierwatcher

They told me they are aware of the issue - the patch will be shipped with qt 5.6. Cheers, Ivan On Sun, May 1, 2016 at 11:58 AM, David Edmundson wrote: > Could you poke the Debian packagers towards that email please. > > David > > >

[frameworks-kactivities] [Bug 360339] Plasma Crash on startup

https://bugs.kde.org/show_bug.cgi?id=360339 Ivan Čukić <ivan.cu...@kde.org> changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Ever confi

[frameworks-kactivities] [Bug 361658] kactivitymanage segfault (libQt5Sql.so.5.4.2) when running nomachines in KDE (other desktops work)

https://bugs.kde.org/show_bug.cgi?id=361658 Ivan Čukić <ivan.cu...@kde.org> changed: What|Removed |Added Resolution|--- |INVALID

Re: KDED deadlock in statusnotifierwatcher

Thanks, this happens when I try stuff from debian/experimental :) Cheers, Ivan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

KDED deadlock in statusnotifierwatcher

Hi all, I've done a clean build and install on Qt 5.6. I'm now getting kded locks from the statusnotifierwatcher. It blocks on dbus connections - namely when it tries to check isServiceRegistered - for some reason, the call dead-locks. I've tried to switch to asynchronous calls (just hides the

[Differential] [Closed] D1348: Testing whether m_lastCreatedSettings is not null before calling its method

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN1fef4760bf1d: Testing whether m_lastCreatedSettings is not null before calling its method (authored by ivan). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1347: Checking whether the m_textTexture is not null before dereferencing it

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINf06dff3390b6: Checking whether the m_textTexture is not null before dereferencing it (authored by ivan). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1346: Checking whether m_topLevel is not null before getting its property

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN2c95a4e6b9ad: Checking whether m_topLevel is not null before getting its property (authored by ivan). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D1347: Checking whether the m_textTexture is not null before dereferencing it

ivan added a comment. That is what static analysis is for - to catch bugs that have not been exposed yet :) REPOSITORY rKWIN KWin BRANCH ivan/null-check-2 REVISION DETAIL https://phabricator.kde.org/D1347 EMAIL PREFERENCES

[Differential] [Request, 4 lines] D1348: Testing whether m_lastCreatedSettings is not null before calling its method

ivan created this revision. ivan added a reviewer: graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It looks like something was forgotten here - there is a completely empty body for an if statement that checks

[Differential] [Request, 18 lines] D1347: Checking whether the m_textTexture is not null before dereferencing it

ivan created this revision. ivan added a reviewer: graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It can be null even after updateTextTexture() if there is not text to generate the texture from: if

[Differential] [Request, 4 lines] D1346: Checking whether m_topLevel is not null before getting its property

ivan created this revision. ivan added a reviewer: graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY From the rest of this method, it is obvious that m_topLevel can be null in any part of the method - we are

[Differential] [Abandoned] D1345: Checking whether m_topLevel is not null before getting its property

ivan abandoned this revision. ivan added a comment. Damn, arc merged these two, will recreate REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1345 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, graesslin Cc: plasma-devel,

[Differential] [Updated, 13 lines] D1345: Checking whether m_topLevel is not null before getting its property

ivan updated this revision to Diff 3195. ivan added a comment. - m_textTexture can be null even after updateTextTexture() REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1345?vs=3194=3195 BRANCH master REVISION DETAIL https://phabricator.kde.org/D1345

[Differential] [Request, 4 lines] D1345: Checking whether m_topLevel is not null before getting its property

ivan created this revision. ivan added a reviewer: graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This method checks whether m_topLevel is not null in a couple of places, but misses this one. p.s. If

Re: Review Request 127575: Plasma 5.7 "Skylight" Wallpaper

> On April 5, 2016, 10:47 a.m., Sebastian Kügler wrote: > > Can we also get something more flashy and colorful? > > > > My favorite Plasma 5 wallpaper was the 5.3 one ( > > https://www.kde.org/announcements/plasma-5.3/plasma-5.3.png ), since then, > > they're too toned down for my taste. It's

Re: Review Request 127575: Plasma 5.7 "Skylight" Wallpaper

> On April 5, 2016, 8:47 a.m., Marco Martin wrote: > > nice :) (and nice to see how they keep improving one after another!) > > one thing i am not sure is that particular tonality of green for that > > diagonal line. > > could be tried with a warmer orange/yellow-i

Re: Review Request 127575: Plasma 5.7 "Skylight" Wallpaper

> On April 5, 2016, 8:47 a.m., Marco Martin wrote: > > nice :) (and nice to see how they keep improving one after another!) > > one thing i am not sure is that particular tonality of green for that > > diagonal line. > > could be tried with a warmer orange/yellow-ish instead? > could be tried

Re: Review Request 127575: Plasma 5.7 "Skylight" Wallpaper

the intel-glitch variant as well :) - Ivan Čukić On April 5, 2016, 12:27 a.m., Ken Vermette wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

[Differential] [Commented On] D1283: ASCII-art output platform

ivan added a comment. You just created an excuse for NVidia not to support wayland-proper-opengl in their future driver releases. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1283 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

Re: Sunsetting khotkeys?

> Input macro recorders/editors have fairly large userbase on competing > systems (e.g. enthusiast gamers on Windows, who easily outnumber +1 When I read Martin's post, I expected 'kwin will do it', not 'we don't need it'. Cheers, Ivan ___

<    1   2   3   4   5   6   7   8   9   10   >