Re: Review Request: big revamp of Device Notifier

2009-08-30 Thread Jacopo De Simoi
On 2009-08-29 21:00:29, Jacopo De Simoi wrote: /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp, line 204 http://reviewboard.kde.org/r/1370/diff/4/?file=10494#file10494line204 We probably need to change this; Either show every time %i actions

Re: Review Request: big revamp of Device Notifier

2009-08-29 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2179 --- In general I like it quite a lot! Nice nice nice! I've a few

Re: Review Request: big revamp of Device Notifier

2009-08-29 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2180 --- - Jacopo On 2009-08-21 19:26:43, Giulio Camuffo wrote:

Re: Review Request: big revamp of Device Notifier

2009-08-29 Thread Jacopo De Simoi
The last mounted tooltip is of questionable usefulness. I would like very much to get rid of it, also the information it shows is (mostly) redundant and if the applet is not in a panel it looks plain awful. The last plugged in device is usually the one on top of all the others. There is an

Re: Review Request: Patch to add free space indicator into device notifier plasmoid

2009-08-25 Thread Jacopo De Simoi
I've not been connected to the internet for a few days, so please disregard this message if it is outdated. The problem is in fact in the solid plasma engine; the patch works as expected (*) with the following patch in soliddeviceengine.cpp Index: soliddeviceengine.cpp

Re: Review Request: big revamp of Device Notifier

2009-08-25 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2143 --- Hi there, thanks for working on this, I've been mostly disconnected

Re: plasmoidviewer patch

2009-08-13 Thread Jacopo De Simoi
On Thursday 13 August 2009 20:36:04 Marco Martin wrote: On Tuesday 11 August 2009, Jacopo De Simoi wrote: On Tuesday 11 August 2009 19:39:01 Chani wrote: On August 11, 2009 06:23:44 Jacopo De Simoi wrote: Taking inspiration from a number of wishes on bko i've come up with a trivial

plasmoidviewer patch

2009-08-11 Thread Jacopo De Simoi
Taking inspiration from a number of wishes on bko i've come up with a trivial patch for plasmoidviewer which adds a commandline option which sets the background of the window to be translucent. This in principle allows to have a plasmoid floating around on the desktop as a real window, and

plasmoidviewer patch

2009-08-11 Thread Jacopo De Simoi
[..] be basically harmless. (note to self: never hit ctrl-enter in kmail) Let me know what you think about it; Thanks --J ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: plasmoidviewer patch

2009-08-11 Thread Jacopo De Simoi
On Tuesday 11 August 2009 19:39:01 Chani wrote: On August 11, 2009 06:23:44 Jacopo De Simoi wrote: Taking inspiration from a number of wishes on bko i've come up with a trivial patch for plasmoidviewer which adds a commandline option which sets the background of the window

Re: Device Notifier suggestion

2009-08-06 Thread Jacopo De Simoi
On Thursday 06 August 2009 12:16:00 Kevin Ottens wrote: On Thursday 6 August 2009 06:19:20 Axel Masok wrote: no idea who maintains the Device Notifier in KDE4 I'm afraid it's currently: no one. Otherwise I'd like to know, because IIRC all its bugs are affected to Alexis who doesn't feel

Re: Device Notifier suggestion

2009-08-06 Thread Jacopo De Simoi
On Thursday 06 August 2009 13:13:48 Kevin Ottens wrote: On Thursday 6 August 2009 12:58:55 Jacopo De Simoi wrote: On Thursday 06 August 2009 12:16:00 Kevin Ottens wrote: I'm more in the libsolid field, I'd love to have someone to collaborate with for the device notifier. I'd be quite

Re: Tokamak 3 for those who won't be there

2009-07-31 Thread Jacopo De Simoi
On Friday 31 July 2009 10:09:27 Aaron J. Seigo wrote: On Thursday 30 July 2009, Shawn Starr wrote: On Thursday 30 July 2009 19:28:53 Nuno Pinheiro wrote: Please sort out meetings I can attend or should attend with skype or something like that. This would be cool if we could have a

4.4 call for runners (ideas)

2009-07-23 Thread Jacopo De Simoi
Dear Plasma-devs, krunner has received quite some attention in the past six months, the default interface has been nicely revamped (aseigo touch) and a few nasty bugs have been fixed (some are still there, most probably either libs or qt issues); in one word krunner is now much more

Re: 4.4 call for runners (ideas)

2009-07-23 Thread Jacopo De Simoi
Kmix -- why would I want to control that from krunner. I think that the panel applet does the trick more than adequately. Would I really want to put up krunner and type in mute or volume=75? Anything else that is manageable with a click or two which would require more than trivial

Re: Review Request: Krunner default interface doesn't display centered when the user have more than one screen (desktop extended).

2009-07-20 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1089/#review1674 --- What does exactly happen when the user have more than one screen?

Re: Reworking the kwin tabbox

2009-07-17 Thread Jacopo De Simoi
On Friday 17 July 2009 10:32:32 Martin Gräßlin wrote: Am Donnerstag 16 Juli 2009 21:49:24 schrieb Thomas Lübking: now my 2¢ on the whole suggestion: imho there two different approaches to switch windows. - one is on the fly - which is good if you've got 2 up to 4 open

Re: Review Request: Fix scrolling with mouse (without wheel) in krunner

2009-07-16 Thread Jacopo De Simoi
, Jacopo De Simoi wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/948/ --- (Updated 2009-07-15 09:49:09) Review request

Re: Reworking the kwin tabbox

2009-07-16 Thread Jacopo De Simoi
On Thursday 16 July 2009 19:32:14 Chani wrote: * Why do we have to hold the alt key while switching? Can't we break with the concept? (get rid of the keyboard grab) - here I need input from the usability experts. Would it be ok to break with such a concept although all other plattforms

Re: Review Request: Fix scrolling with mouse (without wheel) in krunner

2009-07-16 Thread Jacopo De Simoi
--- On 2009-07-15 09:49:09, Jacopo De Simoi wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/948

Re: Review Request: Fix scrolling with mouse (without wheel) in krunner

2009-07-15 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/948/ --- (Updated 2009-07-15 09:49:09.569362) Review request for Plasma. Changes

Re: Review Request: Fix scrolling with mouse (without wheel) in krunner

2009-07-11 Thread Jacopo De Simoi
On Friday 10 July 2009 15:23:24 Aaron J. Seigo wrote: On Friday 10 July 2009, Jacopo De Simoi wrote: foreground is the same used to draw the background of the widget, therefore putting 0 alpha would make the dialog as well transparent. that completely depends on the composition mode

Re: Review Request: Fix scrolling with mouse (without wheel) in krunner

2009-07-10 Thread Jacopo De Simoi
On Thursday 09 July 2009 13:31:10 Jacopo De Simoi wrote: On Wednesday 08 July 2009 23:49:43 Aaron J. Seigo wrote: On Wednesday 08 July 2009, Jacopo De Simoi wrote: On Wednesday 08 July 2009 19:41:30 Aaron J. Seigo wrote: On Wednesday 08 July 2009, you wrote: QPainter from paintEvent

Re: Review Request: Fix scrolling with mouse (without wheel) in krunner

2009-07-09 Thread Jacopo De Simoi
On Wednesday 08 July 2009 23:49:43 Aaron J. Seigo wrote: On Wednesday 08 July 2009, Jacopo De Simoi wrote: On Wednesday 08 July 2009 19:41:30 Aaron J. Seigo wrote: On Wednesday 08 July 2009, you wrote: QPainter from paintEvent.. here is the result: http://imagebin.ca/view/TFWmBq.html

Re: Review Request: Fix scrolling with mouse (without wheel) in krunner

2009-07-08 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/948/#review1485 --- On 2009-07-07 10:12:01, Jacopo De Simoi wrote

Re: Review Request: Fix scrolling with mouse (without wheel) in krunner

2009-07-08 Thread Jacopo De Simoi
that, i think this is ready to go, and yes, should be backported for 4.3 Jacopo De Simoi wrote: Uhm, I have troubles using drawForeground, as I had by using directly the QPainter from paintEvent.. here is the result: http://imagebin.ca/view/TFWmBq.html Perhaps I should use

Re: Review Request: Fix scrolling with mouse (without wheel) in krunner

2009-07-08 Thread Jacopo De Simoi
On Wednesday 08 July 2009 19:41:30 Aaron J. Seigo wrote: On Wednesday 08 July 2009, you wrote: QPainter from paintEvent.. here is the result: http://imagebin.ca/view/TFWmBq.html to be clear, the problem we're seeing in that screenshot is what exactly? the colouring of the fade out or the

Review Request: Fix scrolling with mouse (without wheel) in krunner

2009-07-07 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/948/ --- Review request for Plasma. Summary --- Krunner does not have a vertical

Review Request: Fix resizing issues in krunner

2009-07-01 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/911/ --- Review request for Plasma and Aaron Seigo. Summary --- This patch attempts

Re: air backgrounds - a little too translucent?

2009-06-26 Thread Jacopo De Simoi
Nuno++ On Friday 26 June 2009 02:17:46 Nuno Pinheiro wrote: A Friday 26 June 2009 01:05:16, Aaron J. Seigo escreveu: hi all ... is it just me or are the widget, dialog and panel backgrounds in Air just a little too translucent, making it hard to read text and see fine details? should

Re: Review Request: Allow DataEngines to force update all sources, regardless of timers

2009-06-26 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/892/#review1393 --- Yay! Excellent! Minor remark: don't forget the @since's - Jacopo On

Re: default plasma theme and fallback

2009-06-25 Thread Jacopo De Simoi
b) and c) do not rule out each other, indeed: we could have c) as an optional entry which defaults to oxygen which would be the default fallback option. To me this seems the sanest option, since many themes around, being incomplete as Nuno said, rely on the fact that they are fallbacked by

Review Request: Fix Plasma clocks not being aware of timezone changes until next plasma-desktop restart

2009-06-25 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/889/ --- Review request for Plasma. Summary --- The plasma timeengine reacts to

Re: Review Request: Fix Plasma clocks not being aware of timezone changes until next plasma-desktop restart, alt patch

2009-06-25 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/891/#review1384 --- Much better than mine! It would be excellent if we could trigger an

Re: air backgrounds - a little too translucent?

2009-06-25 Thread Jacopo De Simoi
Nuno++ On Friday 26 June 2009 02:17:46 Nuno Pinheiro wrote: A Friday 26 June 2009 01:05:16, Aaron J. Seigo escreveu: hi all ... is it just me or are the widget, dialog and panel backgrounds in Air just a little too translucent, making it hard to read text and see fine details? should

Re: Review Request: Progress Widget in krunner

2009-06-02 Thread Jacopo De Simoi
On 2009-06-02 03:43:16, Jacopo De Simoi wrote: The idea is quite nice, however I see a problem here: connect(runnerManager, SIGNAL(matchesChanged(const QListPlasma::QueryMatch )), SLOT(stopProgressWidget())); in fact matchesChanged might be called several times during a query

Re: Suggestion request for krunner

2009-05-31 Thread Jacopo De Simoi
without some way of asking a match if it still matches i don't see a way around that, either and you're probably right that tab completion will have to just die. In this case, we probably should notify users of the change, but being in string freeze, I don't see an easy way to do it.

Suggestion request for krunner

2009-05-30 Thread Jacopo De Simoi
Dear devs, I've recently made a commit to fix the inconsistent behavior of the TAB key in krunner; unfortunately the fix does not work as we (aseigo and I) expected on paper, so I'd like to know if there are suggestions you could provide, so that we can define a behavior before 4.3.0 The

Review Request:

2009-05-28 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/775/ --- Review request for Plasma and Aaron Seigo. Summary --- Krunner has some

Re: Review Request: Fix krunner issues with TAB

2009-05-28 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/775/ --- (Updated 2009-05-28 09:07:51.068321) Review request for Plasma and Aaron Seigo.

Patch krunner stragglers

2009-03-13 Thread Jacopo De Simoi
as per communication in irc with aseigo, here is a patch (**against 4.2 branch**) for better handling of stragglers in krunner. Please note that the patch in libs is actually quite noisy because there's also the backport of part of aseigo improvements for the oldMatchesJob stuff. the only relevant

<    1   2