Re: Review Request 106911: ksmserver should ignore non-executable files under ~/.kde4/Autostart

2016-09-24 Thread Jekyll Wu
g/r/106911/diff/ Testing --- Thanks, Jekyll Wu

Re: Review Request 107868: Rename krunner plugin konquerorsessions to konquerorprofiles to match what it really does

2016-09-22 Thread Jekyll Wu
runners/konquerorsessions/konquerorsessions.desktop df81780 runners/konquerorsessions/konquerorsessions.h 957f976 Diff: https://git.reviewboard.kde.org/r/107868/diff/ Testing --- Thanks, Jekyll Wu

Re: Review Request 107869: Add a real konquerorsessions plugin for krunner

2016-09-22 Thread Jekyll Wu
. Diffs - Diff: https://git.reviewboard.kde.org/r/107869/diff/ Testing --- File Attachments the patch https://git.reviewboard.kde.org/media/uploaded/files/2012/12/23/0002-Add-a-real-konquerorsessions-plugin_1.patch Thanks, Jekyll Wu

Re: [RFC] Disable bug reporting till Bugzilla situation is improved

2013-05-26 Thread Jekyll Wu
于 2013年05月26日 18:05, Martin Graesslin 写道: Hi all, this is probably a controversial proposal: Let's disable bug reporting for Plasma until the current situation is improved. Reason: the bugtracker in it's current state gets flooded by new incoming reports and we are not able to get the

Re: Review Request 110633: Don't report crashes if version is disabled in Bugzilla

2013-05-25 Thread Jekyll Wu
On May 24, 2013, 9:44 p.m., Jekyll Wu wrote: Bugzilla itself (since 4.2.5) already rejects any attempt against disabled versions. So even without this patch, DrKonqi users won't be able to create crash report against disabled versions in the end. From developers POV, you don't need

Re: Review Request 110633: Don't report crashes if version is disabled in Bugzilla

2013-05-25 Thread Jekyll Wu
On May 24, 2013, 9:44 p.m., Jekyll Wu wrote: Bugzilla itself (since 4.2.5) already rejects any attempt against disabled versions. So even without this patch, DrKonqi users won't be able to create crash report against disabled versions in the end. From developers POV, you don't need

Re: [RFC] Closing outdated crash reports

2013-05-25 Thread Jekyll Wu
On 2013年05月25日 15:19, Martin Graesslin wrote: Hi all, Plasma has many open crash reports for outdated versions [1]. I would suggest to close them all as: a) Stack traces most likely do not match any more b) It's quite likely that it's a duplicate c) Users can easily reopen if it's still valid

Re: Review Request 110633: Don't report crashes if version is disabled in Bugzilla

2013-05-25 Thread Jekyll Wu
On May 24, 2013, 9:44 p.m., Jekyll Wu wrote: Bugzilla itself (since 4.2.5) already rejects any attempt against disabled versions. So even without this patch, DrKonqi users won't be able to create crash report against disabled versions in the end. From developers POV, you don't need

Re: Fwd: [Bugsquad] Something for the bugsquad :)

2013-05-25 Thread Jekyll Wu
On 2013年05月24日 17:55, Aaron J. Seigo wrote: If instead we look for people who might be motivated to do some meaningful triaging, things could improve. I'm sorry, but I really don't think that would work (so easily) . It is not that there were no such motivated contributors in the past. In

Re: Fwd: [Bugsquad] Something for the bugsquad :)

2013-05-25 Thread Jekyll Wu
On 2013年05月25日 20:59, Martin Graesslin wrote: My aims are: * get the number of bugs down without having humans looking at the reports * reduce the number of bugs coming in Now that plasma-desktop uses KDE_VERSION_STRING (since 4.10.3) instead of the never changing stone 0.4 version, we can

Re: Review Request 110633: Don't report crashes if version is disabled in Bugzilla

2013-05-24 Thread Jekyll Wu
] https://bugs.kde.org/show_bug.cgi?id=315073#c3 [2] https://bugs.kde.org/show_bug.cgi?id=318769#c1 - Jekyll Wu On May 24, 2013, 2:54 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http

Review Request 109906: Make plasma-desktop and krunner use KDE_VERSION_STRING instead of some never changing version.

2013-04-08 Thread Jekyll Wu
- krunner/main.cpp c3dd560 plasma/desktop/shell/main.cpp 225eec2 Diff: http://git.reviewboard.kde.org/r/109906/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma

Re: Review Request: Rename krunner plugin konsolesessions to konsoleprofiles

2013-01-07 Thread Jekyll Wu
, 2012, 6:58 p.m., Jekyll Wu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107881/ --- (Updated Dec. 31, 2012, 6:58 p.m

Re: Review Request: Rename krunner plugin konsolesessions to konsoleprofiles

2012-12-31 Thread Jekyll Wu
/konsolesessions/konsolesessions.desktop 7d9ce5a runners/konsolesessions/konsolesessions.h a98c253 Diff: http://git.reviewboard.kde.org/r/107881/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request: Rename krunner plugin konquerorsessions to konquerorprofiles to match what it really does

2012-12-31 Thread Jekyll Wu
/konquerorsessions.desktop df81780 runners/konquerorsessions/konquerorsessions.h 957f976 Diff: http://git.reviewboard.kde.org/r/107868/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https

Review Request: Rename krunner plugin konsolesessions to konsoleprofiles

2012-12-24 Thread Jekyll Wu
--- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Rename krunner plugin konquerorsessions to konquerorprofiles to match what it really does

2012-12-23 Thread Jekyll Wu
/konquerorsessions/Messages.sh 0720e1e runners/konquerorsessions/konquerorsessions.cpp f2e437a runners/konquerorsessions/konquerorsessions.desktop df81780 runners/konquerorsessions/konquerorsessions.h 957f976 Diff: http://git.reviewboard.kde.org/r/107868/diff/ Testing --- Thanks, Jekyll Wu

Review Request: Add a real konquerorsessions plugin for krunner

2012-12-23 Thread Jekyll Wu
the patch in https://git.reviewboard.kde.org/r/107868/ and that one has not be committed. See the attached file below. This addresses bug 188494. http://bugs.kde.org/show_bug.cgi?id=188494 Diffs - Diff: http://git.reviewboard.kde.org/r/107869/diff/ Testing --- Thanks, Jekyll Wu

Re: Review Request: Make sure ksmserver ignores excluded apps when saving session

2012-12-09 Thread Jekyll Wu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107276/#review21816 --- On Dec. 9, 2012, 7:50 a.m., Jekyll Wu wrote

Re: Review Request: Make sure ksmserver ignores excluded apps when saving session

2012-12-08 Thread Jekyll Wu
combinations . This addresses bug 242760. http://bugs.kde.org/show_bug.cgi?id=242760 Diffs (updated) - ksmserver/server.cpp a65b35a Diff: http://git.reviewboard.kde.org/r/107276/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma

Review Request: [rssnow] Revert the commit of merging left right arrows into one

2012-12-02 Thread Jekyll Wu
--- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Bug 310611] Missing accelerators in QML lock screen

2012-11-29 Thread Jekyll Wu
https://bugs.kde.org/show_bug.cgi?id=310611 Jekyll Wu adap...@gmail.com changed: What|Removed |Added Component|ui |locker-qml Version|git

[Bug 310871] Screen always locks (requires password) even if not supposed to

2012-11-29 Thread Jekyll Wu
https://bugs.kde.org/show_bug.cgi?id=310871 Jekyll Wu adap...@gmail.com changed: What|Removed |Added Version|unspecified |4.9.80 Beta1 -- You

[Bug 310611] Missing accelerators in QML lock screen

2012-11-29 Thread Jekyll Wu
https://bugs.kde.org/show_bug.cgi?id=310611 Jekyll Wu adap...@gmail.com changed: What|Removed |Added Assignee|plasma-devel@kde.org|plasma-b...@kde.org -- You

[Bug 310871] Screen always locks (requires password) even if not supposed to

2012-11-29 Thread Jekyll Wu
https://bugs.kde.org/show_bug.cgi?id=310871 Jekyll Wu adap...@gmail.com changed: What|Removed |Added Assignee|plasma-devel@kde.org|plasma-b...@kde.org -- You

Review Request: Make sure ksmserver ignores excluded apps when saving session

2012-11-10 Thread Jekyll Wu
--- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Make sure ksmserver ignores excluded apps when saving session

2012-11-10 Thread Jekyll Wu
=242760 Diffs (updated) - ksmserver/server.cpp eb3ac18 Diff: http://git.reviewboard.kde.org/r/107276/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: ksmserver should ignore non-executable files under ~/.kde4/Autostart

2012-10-16 Thread Jekyll Wu
or incidental feature. This addresses bug 286658. http://bugs.kde.org/show_bug.cgi?id=286658 Diffs - ksmserver/startup.cpp d99ce4c Diff: http://git.reviewboard.kde.org/r/106911/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel

Re: Review Request: Do not trigger krunner when the Space key is pressed in desktop

2012-08-14 Thread Jekyll Wu
/105989/#review17368 --- On Aug. 12, 2012, 8:28 a.m., Jekyll Wu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105989

Re: Review Request: Do not trigger krunner when the Space key is pressed in desktop

2012-08-14 Thread Jekyll Wu
e5e02c0 Diff: http://git.reviewboard.kde.org/r/105989/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Do not trigger krunner when the Space key is pressed in desktop

2012-08-14 Thread Jekyll Wu
) - plasma/desktop/containments/desktop/desktop.cpp e5e02c0 Diff: http://git.reviewboard.kde.org/r/105989/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Do not trigger krunner when the Space key is pressed in desktop

2012-08-12 Thread Jekyll Wu
similar to bug 285350, so the proposed patch is similar and simple . This addresses bug 304805. http://bugs.kde.org/show_bug.cgi?id=304805 Diffs - Diff: http://git.reviewboard.kde.org/r/105989/diff/ Testing --- Thanks, Jekyll Wu

Review Request: Make sure kmenuedit use predictable order for showing Name and Description between various invocations

2012-07-28 Thread Jekyll Wu
- kmenuedit/treeview.cpp 54feff7 Diff: http://git.reviewboard.kde.org/r/105769/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Do not disable the Delete action after deleting one item

2012-07-28 Thread Jekyll Wu
. Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Fix the wrong usage of Keywords in one .dekstop file

2012-07-14 Thread Jekyll Wu
., Jekyll Wu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/ --- (Updated July 13, 2012, 2:49 p.m.) Review request

Review Request: Fix the wrong usage of Keywords in some .dekstop files

2012-07-13 Thread Jekyll Wu
/generic/applets/lock_logout/metadata.desktop 6d90856 Diff: http://git.reviewboard.kde.org/r/105553/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Fix the wrong usage of Keywords in one .dekstop file

2012-07-13 Thread Jekyll Wu
-microblog.desktop b8d3864 Diff: http://git.reviewboard.kde.org/r/10/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: DrKonqi should report the crashes of kactivitymanagerd to the kactivities product in BKO

2012-07-09 Thread Jekyll Wu
of kactivitymanagerd to the kactivies product. Diffs - drkonqi/data/mappings 147bcdc Diff: http://git.reviewboard.kde.org/r/105483/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Review Request: ksysguard.deskstop shoud not use generic name System Monitor for its Name key

2012-06-24 Thread Jekyll Wu
-keys Diffs - ksysguard/gui/ksysguard.desktop 7e8ff32 Diff: http://git.reviewboard.kde.org/r/105338/diff/ Testing --- Thanks, Jekyll Wu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel