D28127: Add some new battery sensors : energy_now, energy_full and power_now.

jjorge added a comment. In D28127#647747 , @ahiemstra wrote: > Seems fine to me now. You didn't have a developer account right? Yes, I don't. REPOSITORY R106 KSysguard BRANCH acpi-energy REVISION DETAIL

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

jjorge added a comment. I have finished my corrections. Is it nice now? Thanks. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D28127 To: jjorge, #plasma, davidedmundson, ahiemstra Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

jjorge updated this revision to Diff 79665. jjorge added a comment. - A better cast to float REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28127?vs=79655=79665 BRANCH acpi-energy REVISION DETAIL https://phabricator.kde.org/D28127 AFFECTED FILES

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

jjorge updated this revision to Diff 79655. jjorge added a comment. I should learn to better use arc... - typo REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28127?vs=79653=79655 BRANCH acpi-energy REVISION DETAIL

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

jjorge updated this revision to Diff 79653. jjorge added a comment. - Oops fix bad named functions REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28127?vs=79629=79653 BRANCH acpi-energy REVISION DETAIL https://phabricator.kde.org/D28127 AFFECTED

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

jjorge added a comment. Hem, you are right, I missed it because I was testing old binary. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D28127 To: jjorge, #plasma, davidedmundson, ahiemstra Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

jjorge updated this revision to Diff 79629. jjorge added a comment. - fix pointer REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28127?vs=79321=79629 BRANCH acpi-energy REVISION DETAIL https://phabricator.kde.org/D28127 AFFECTED FILES

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

jjorge updated this revision to Diff 79321. jjorge added a comment. - Follow ahiemstra suggestions : - cast to float directly - move 2 repeated lines to initAcpiBattery REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28127?vs=77923=79321 BRANCH

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

jjorge created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jjorge requested review of this revision. REVISION SUMMARY Depending on hardware, Linux kernel exports battery state in different files. Previously only charge_now, charge_full and

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge added a comment. In D25018#562834 , @ahiemstra wrote: > Do you have a developer account to push the changes? Otherwise I can do that for you. I don't, so yes please do the push. REPOSITORY R106 KSysguard BRANCH

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge added a comment. How will this be merged? Will it be in time for Kde 19.12 ? REPOSITORY R106 KSysguard BRANCH acpi-move-battery-to-sysfs REVISION DETAIL https://phabricator.kde.org/D25018 To: jjorge, davidedmundson, #plasma, ahiemstra Cc: alexde, plasma-devel, LeGast00n,

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge added a comment. > How can you interpret these weird charge_now values correctly? If the range is [1/1000, 901] Wh, while the real range is [0, 45] Wh, how does the charge curve look like while charging or discharging? Are there (continues) values in [46, 901] Wh? Do you assume all

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge marked an inline comment as done. jjorge added a comment. > Are states > 100 or < 0 really well defined? Is it save to assume that a state > 100 can be associated with 100? Yes : this is a percentage. States out of this value are bad hardware : I have a travel battery which shows

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge added a comment. Thanks. Just some thoughts : designcharge is usefull if you want to see the percentage of charge you reach against what it should be with a new battery. For some adicional sensors, of course, even if I dont see what ones you are thinking about. REPOSITORY R106

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge updated this revision to Diff 69357. jjorge marked 6 inline comments as done. jjorge added a comment. - hopefully correct all problems found in nice ahiemstra's revision - - indentation corrected to 4 chars - - function braces in newline - - We can calculate charge even if current

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge added a comment. In D25018#558503 , @ahiemstra wrote: > Hmm, I would like to see some smarter sys file handling for this. Right now, multiple calls to getSysFileValue result in the same file being read from disk over and over. While the

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge requested review of this revision. jjorge added a comment. So asking again for feedback, if I understand well how phabricator works ... REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D25018 To: jjorge, davidedmundson, #plasma, ahiemstra Cc: plasma-devel,

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jjorge requested review of this revision. REVISION SUMMARY Since kernel 2.6.24 in 2008, the /proc/acpi/battery interface is deprecated. There is for years no updated kernel which wouldn't

D24998: Fix ksysguard acpi cooling devices

jjorge added a comment. How to test : just add an ACPI cooling device to ksysguard, it would always show 0% before this patch. To find one cooling device that actually changes, you can use the 'acpi -V' command REPOSITORY R106 KSysguard REVISION DETAIL

D24998: Fix ksysguard acpi cooling devices

jjorge created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jjorge requested review of this revision. REVISION SUMMARY The cooling devices state never changed from zero. It was wrongly calculated as a fraction from 0 to 1, instead of a percentage.