D25936: [Desktop Containment] Hide tooltip while rotating the widget

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The tooltip doesn't follow along and looks quite awkward when it's stuck in its original

D25935: [Notifications] Add hint for showing a notification even in do not disturb mode

broulik added a comment. How is it, though? It is an internal hint on some DBus method no user will ever see. Internally it's all things like notificationsInhibitedUntil, even the (public) DBus API says "Inhibited" REPOSITORY R120 Plasma Workspace REVISION DETAIL

D25935: [Notifications] Add hint for showing a notification even in do not disturb mode

broulik added a comment. Internally it uses "inhibited" for that everywhere REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25935 To: broulik, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D25935: [Notifications] Add hint for showing a notification even in do not disturb mode

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This can be useful for notifications that confirm direct user interaction, such as successful

D25910: [Notifications] Add support for global do not disturb toggle shortcut

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e793d6437225: [Notifications] Add support for global do not disturb toggle shortcut (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25910?vs=71324=71393#toc REPOSITORY

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

This revision was automatically updated to reflect the committed changes. Closed by commit R119:96f485db411c: [Notifications KCM] Show hint if notifications arent available or provided by… (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25932: [Task Manager] Better align badge in tooltip

broulik created this revision. broulik added reviewers: Plasma, VDG, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Centers it vertically around the close button rather than the combined height TEST

D25917: [Notifications] Show hint if notifications aren't available or provided by someone else

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When Plasma notification service isn't available or provided by someone else, disable the

D25916: [Notifications] Provide better feedback when copying a single file

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D25916 AFFECTED FILES

D25772: [Notifications] Add ServerInfo class

This revision was automatically updated to reflect the committed changes. Closed by commit R120:147debe3758f: [Notifications] Add ServerInfo class (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25772?vs=71345=71348 REVISION

D25772: [Notifications] Add ServerInfo class

broulik updated this revision to Diff 71345. broulik added a comment. - Drop `Q_INVOKABLE` - Rename slot - Add missing `ServerInfo` file REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25772?vs=70976=71345 REVISION DETAIL

D25910: [Notifications] Add support for global do not disturb toggle shortcut

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It enables do not disturb until turned off and allows disabling it. TEST PLAN It doesn't

D25874: [Task Manager] Consider parent PID for audio stream

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY For modern web browsers, the audio stream isn't owned by the same process as the window,

D25861: [Notifications] Fix crash accessing ViewTransition attached property

This revision was automatically updated to reflect the committed changes. Closed by commit R120:34ca49210ff4: [Notifications] Fix crash accessing ViewTransition attached property (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D25861: [Notifications] Fix crash accessing ViewTransition attached property

broulik updated this revision to Diff 71219. broulik added a comment. - remove leftover debugging REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25861?vs=71217=71219 REVISION DETAIL https://phabricator.kde.org/D25861 AFFECTED FILES

D25861: [Notifications] Fix crash accessing ViewTransition attached property

broulik created this revision. broulik added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY There's something really funky going on in this... Avoid using `ViewTransition`

D25860: [plasmoid] Show device battery percentage

broulik created this revision. broulik added reviewers: Plasma, VDG, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY While it is typically shown in Battery Monitor, it can still be useful to have it in

D25851: [Notifications] Add quick reply feature

broulik added a comment. I'm not sure. `TextArea` is a lot more annoying to work with, and the replies typically are short. I think Android also only has single line. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25851 To: broulik, #plasma, #vdg Cc:

D24070: Don't use toolTipMainText to show info, rather use the second line

broulik added a comment. You can just do something like var parts = []; if (powerManagementDisabled) { parts.push(i18n("Powermanagement disabled")); } if (pmSource.data["AC Adapter"] && pmSource.data["AC Adapter"]["Plugged in"]) { parts.push(blabla); }

D25851: [Notifications] Add quick reply feature

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This adds a quick reply feature with a text field inline in the notification popup. An

D25740: Add item spacing to size hint

This revision was automatically updated to reflect the committed changes. Closed by commit R31:74285aea999c: Add item spacing to size hint (authored by broulik). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25740?vs=70903=71189 REVISION DETAIL

D25840: [Icons KCM] Use help-browser icon

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0381ed06a07a: [Icons KCM] Use help-browser icon (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25840?vs=71177=71186 REVISION DETAIL

D25844: Add grouping options in Icons-only Task Manager

broulik added a comment. So you want to be able to not group apps in IOTM, that is literally what IOTM is about, isnt it? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25844 To: gvgeo, #plasma, #vdg Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D25840: [Icons KCM] Use help-browser icon

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `system-help` appears to be an action icon and not available in larger size in Adwaita, add

D25837: [Style KCM] Fit widget style preview better

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4b444eb2031a: [Style KCM] Fit widget style preview better (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25837?vs=71170=71176

D25837: [Style KCM] Fit widget style preview better

broulik updated this revision to Diff 71170. broulik retitled this revision from "[Style KCM] Horizontally center widget style preview" to "[Style KCM] Fit widget style preview better". broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a

D25837: [Style KCM] Horizontally center widget style preview

broulik added a comment. In D25837#574591 , @ngraham wrote: > Could we scale the previews within the delegates down a bit instead? Oooh, good idea. I bet I could just use `scale` and everything should magically work. Not sure how blurry

D25837: [Style KCM] Horizontally center widget style preview

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY In case the widget style is too wide. The delegates are already quite large as they is so

D24070: Don't use toolTipMainText to show info, rather use the second line

broulik added a comment. Probably: > MainText: Battery at X% > SubText: Powermanagement disabled\n > HH:MM left REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma, broulik, ndavis Cc: ndavis, broulik,

D24070: Don't use toolTipMainText to show info, rather use the second line

broulik requested changes to this revision. broulik added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > broulik wrote in batterymonitor.qml:56 > You can probably just return `plasmoid.title` in the default case. > Also, what's the reason for not showing

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

broulik updated this revision to Diff 71137. broulik edited the test plan for this revision. broulik added a comment. - Disable controls which won't affect other notification services - Job tracking is independent of notification service REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D25772: [Notifications] Add ServerInfo class

broulik added a comment. In D25772#574317 , @nicolasfella wrote: > I would like to have something like this in KNotifications to be able to check which features/hints the server supports without doing the DBus stuff myself This is

D23021: [Image Wallpaper] Use layer.enabled during transition to avoid background glimpsing through

broulik planned changes to this revision. broulik added a comment. I think we need to measure the performance impact somewhat REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23021 To: broulik, #plasma, ngraham Cc: ngraham, plasma-devel, LeGast00n,

D25772: [Notifications] Add ServerInfo class

broulik added inline comments. INLINE COMMENTS > broulik wrote in server_p.cpp:93 > Just noticed I can probably reuse the inhibition service watcher rather than > do a wildcard watch here? Actually not, I misread the code and documentation: > This signal is emitted by the D-Bus server when

D25803: [Purpose Plugin] Reset pending reply serial when aborting

This revision was automatically updated to reflect the committed changes. Closed by commit R856:364603950258: [Purpose Plugin] Reset pending reply serial when aborting (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D25803: [Purpose Plugin] Reset pending reply serial when aborting

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When the `QMenu` is closed or the Purpose job finishes, we make sure to send a reply out

D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme

broulik added a comment. That double tooltip looks a bit unpolished but not sure what to do about it. Perhaps instead sow that as tooltip for the icon theme? so it shows "Breeze (This theme follows your system color scheme)"`? Alternatively, maybe we need a second line of label text? so

D25782: [Notifications] Add draggable file icon when single file job finishes

broulik added inline comments. INLINE COMMENTS > ngraham wrote in notificationapplet.h:73 > maybe use one of the standard sizes instead of a hardcoded int? That's the default, there's a `Binding` to `units.iconSizes.large` in `main.qml` REPOSITORY R120 Plasma Workspace REVISION DETAIL

D25782: [Notifications] Add draggable file icon when single file job finishes

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This adds a file icon to a finished job for a single total file which can be dragged

D25780: [Notifications] Set total amount to processed amount if no total and no error

broulik created this revision. broulik added reviewers: Plasma, nicolasfella. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Some jobs only set a processed amount and no total. This patch ensures when the job

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

broulik added a comment. 1. Windows has those entries by default and they probably know what they're doing 2. It introduces the user to the fact that you can actually pin apps to the task bar REPOSITORY R119 Plasma Desktop BRANCH some-apps-by-default (branched from master) REVISION

D25772: [Notifications] Add ServerInfo class

broulik added inline comments. INLINE COMMENTS > server_p.cpp:93 > if (!master) { > -connect(dbusIface, ::serviceUnregistered, > this, [=](const QString ) { > -if (serviceName == notificationService) { > -qCDebug(NOTIFICATIONMANAGER) << "Lost ownership

D25462: [Colors KCM] Use Kirigami.SearchField

broulik planned changes to this revision. broulik added a comment. I'd prefer if the translation were fixed, but I can override `placeholderText` REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25462 To: broulik, #plasma, #vdg, ngraham Cc: ngraham,

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

broulik updated this revision to Diff 70981. broulik added a comment. - Use `NotificationManager.ServerInfo` from D25772 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25097?vs=69123=70981 REVISION DETAIL

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

broulik added a comment. +1! I remember seeing this in Plasma 4 times and also always pin those two on my setup. Windows has browser first, then file manager. I don't really mind either order, though. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25773

D25772: [Notifications] Add ServerInfo class

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It can be used to query information about the current notification server (vendor, name,

D25751: [Notifications] Split draggable thumbnail area into its own component

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d1d9a2c7b37f: [Notifications] Split draggable thumbnail area into its own component (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D25762: Don't bother serializing window icon pixmap for known services

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY A service usually has a proper icon somewhere on disk. `QIcon::name()` only works with

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

broulik added inline comments. INLINE COMMENTS > startplasma-wayland.cpp:88 > +args.reserve(argc); > +for(int i=1; i +args << QString::fromLocal8Bit(argv[i]); Coding style, please. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D22506: Read BAMF_DESKTOP_FILE_HINT from environment

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:31c75e48c833: Read BAMF_DESKTOP_FILE_HINT from environment (authored by broulik). CHANGED PRIOR TO COMMIT

D25751: [Notifications] Split draggable thumbnail area into its own component

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY I'm planning to use it in job notifications, too. This should also make it easier to migrate

D25740: Add item spacing to size hint

broulik created this revision. broulik added reviewers: ndavis, hpereiradacosta. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This is what Adwaita Qt does [1] and it fixes the popup text being elided in

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

broulik added a comment. I never noticed that line before but now that I did, I can't unsee it. It looks quite bad with dark Breeze title bar, where it is quite superfluous. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25728 To: filipf, #plasma, #vdg Cc:

D25690: [Style KCM] Forward geometryChanged to parent class

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9fe2562af12c: [Style KCM] Forward geometryChanged to parent class (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25690?vs=70768=70821

D25688: [Style KCM] Set implicit size after show

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1c56622f05db: [Style KCM] Set implicit size after show (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25688?vs=70766=70820 REVISION

D25691: [KDecoration] Use QIcon::paint

This revision was automatically updated to reflect the committed changes. Closed by commit R113:4afa55e27433: [KDecoration] Use QIcon::paint (authored by broulik). REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25691?vs=70772=70786 REVISION DETAIL

D25691: [KDecoration] Use QIcon::paint

broulik created this revision. broulik added reviewers: Plasma, hpereiradacosta. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Properly takes into account device pixel ratio. It's what Breeze decoration code

D25690: [Style KCM] Forward geometryChanged to parent class

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Required so properties `width` and `height` are correct. TEST PLAN Tried to `anchors.fill:

D25688: [Style KCM] Set implicit size after show

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Most of the widgets used in the preview initialize only on show, making the size hint invalid

D25672: Port to std::sort

broulik added a comment. Does this not need an `#include `? REPOSITORY R122 Powerdevil BRANCH qsort REVISION DETAIL https://phabricator.kde.org/D25672 To: nicolasfella, #plasma, apol Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D25614: [System Tray] Clean up popup code

broulik added inline comments. INLINE COMMENTS > filipf wrote in ExpandedRepresentation.qml:103 > @broulik? Both are fine I guess but `onToggled` is indeed more correct REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25614 To: filipf, #plasma, broulik Cc:

D25670: Synchronize decorations buttons order in GTK headerbars

broulik added a comment. > It would be sensible to use an individual signal. I would like to hear an advice about its naming. Alternatively you could have the KWin decoration KCM use `writeEntry` with `Notify` flag and then use a `KConfigWatcher` here instead of connecting to KWin's

D25566: [Notifications] Move out of the way of dialog rather than just hiding

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:24900b334788: [Notifications] Move out of the way of dialog rather than just hiding (authored by broulik). CHANGED

D25593: [kdecoration] Use QVariantAnimation instead of QPropertyAnimation

broulik closed this revision. broulik added a comment. https://cgit.kde.org/breeze.git/commit/?id=6fe549361b4301efddb358989af45ad44d4ae7a8 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D25593 To: broulik, #vdg, hpereiradacosta, davidedmundson, ndavis Cc:

D25594: [Style KCM] Force active palette on widgets

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d3b1163f8f2b: [Style KCM] Force active palette on widgets (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25594?vs=70502=70504

D25594: [Style KCM] Force active palette on widgets

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Since there isn't a real window, the widgets think they're inactive, leading to dull appearance.

D25593: [kdecoration] Use QVariantAnimation instead of QPropertyAnimation

broulik created this revision. broulik added reviewers: VDG, hpereiradacosta. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY We don't need to go through the property system to update a value, just use a

D25581: [TabBar] Use window color instead of button color

broulik added a comment. Can you verify how the widgets `QTabBar` behaves in this scenario? REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH right-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D25581 To: filipf, #plasma, #vdg, ngraham Cc: broulik,

D25584: [TabBar] Add a border property

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. I don't think the style is the right approach. What happens if you run the KCM with a different style, will it refuse to load? And `border` is quite a non-descript property,

D25569: Also overwrite document.createElement using exportFunction

broulik created this revision. broulik added reviewers: fvogt, davidedmundson, ognarb. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Ensures it works in Firefox on sites with content security policy like

D25566: [Notifications] Move out of the way of dialog rather than just hiding

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When e.g. connecting to a network with captive portal, it leaves you sitting there wondering

D25540: Add default value for cursor theme

This revision was automatically updated to reflect the committed changes. Closed by commit R99:4090e899eddd: Add default value for cursor theme (authored by broulik). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25540?vs=70331=70431

D25540: Add default value for cursor theme

broulik added a comment. Yes, when setting "Breeze" (not snow) as cursor theme, it will delete the key from the kcminputrc because it is the default. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D25540 To: broulik, gikari Cc: plasma-devel,

D25540: Add default value for cursor theme

broulik added a comment. Hmm, somehow still doesn't apply the cursors on login REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D25540 To: broulik, gikari Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D25540: Add default value for cursor theme

broulik created this revision. broulik added a reviewer: gikari. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When using the default cursors, no `cursorTheme` entry is written into the config file, leading

D25539: KScreen KCM: Add a revert timer to the settings page

broulik added a comment. One of the key ideas of KScreen was that it will *not* have a revert timer. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D25539 To: liushuyu, #vdg, #plasma Cc: broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25526: KCM launch feedback : take into account immutable properties

broulik added inline comments. INLINE COMMENTS > main.qml:45 > > +enabled: formLayout.cursorImmutable > Kirigami.FormData.label: i18n("Cursor:") Imho this is confusing. The property should be `readonly property bool cursorImmutable: kcm.setings.immutable && ..` and

D25519: Fix broken multimedia control on lockscreen

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e2cbf51aa516: Fix broken multimedia control on lockscreen (authored by ajyotirmay, committed by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D25519: Fixes bugzilla bug-414487 broken multimedia control on lockscreen

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Perfect! I'll need an email address from you in order to merge this. REPOSITORY R120 Plasma Workspace BRANCH media-control-layout-constraint REVISION DETAIL

D25514: Simpler theme deletion

broulik added a comment. I read the bug the other way round: instead of passing a full path (which would allow arbitrarily deleting folders as root?), pass a theme name and then do the lookup in the helper REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL

D25486: [Greeter] Add a onSuspend() signal to Authenticator

broulik added a comment. Have you had a look at the libkworkspace2 stuff? It should have that signal in it and is ready to be made a qml import iirc REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D25486 To: meven, #plasma Cc: broulik, plasma-devel, LeGast00n,

D25369: Shorten POTD provider names and remove description that is not used anywhere

broulik added a comment. How about we fix the size or the combo instead? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25369 To: guoyunhe, #plasma, ngraham Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D25466: Add Captive Portal auto-refresh handling

broulik created this revision. broulik added reviewers: Plasma, bcooksley, fvogt, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When configured to detect captive portals, NetworkManager prompts the

D25462: [Colors KCM] Use Kirigami.SearchField

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Gets rid of some code duplication. TEST PLAN - Filtering works - Clear button works

D25406: [ToolTip] Base timeout on text length

This revision was automatically updated to reflect the committed changes. Closed by commit R858:5ca508bd6adc: [ToolTip] Base timeout on text length (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D25404: Just return applicationDisplayName in MPRIS Identity

This revision was automatically updated to reflect the committed changes. Closed by commit R856:78347989fca8: Just return applicationDisplayName in MPRIS Identity (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D25406: [ToolTip] Base timeout on text length

broulik added a comment. > I would prefer that we use a hardcoded timeout and them change the QWidgets tooltips duration to follow that. That requires a behavior change in Qt to something that has been like this for decades. REPOSITORY R858 Qt Quick Controls 2: Desktop Style

D25406: [ToolTip] Base timeout on text length

broulik created this revision. broulik added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This mimics `QToolTip` behavior and ensures the tooltip is actually readable. The

D25404: Just return applicationDisplayName in MPRIS Identity

broulik updated this revision to Diff 7. broulik added a comment. - Drop now unused include REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25404?vs=6=7 REVISION DETAIL https://phabricator.kde.org/D25404 AFFECTED FILES

D25404: Just return applicationDisplayName in MPRIS Identity

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Avoids some code duplication. TEST PLAN "Firefox Web Browser" is now "Mozilla Firefox"

D25403: Drop Position change signal and support Seeked signal

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When user seeks, emit `Seeked` signal. The signal is periodically emitted while seeking

D25374: [ResultDelegate] Fix bad text legiblity with certain 3rd party themes

broulik added a comment. This makes it quite hard to read on a dark background here F7771184: Screenshot_20191119_092956.png REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D25374 To: filipf, #plasma, #vdg Cc: broulik,

D25368: connect groupbox toggles to change signal

broulik added a comment. Don't you have to connect to the `QGroupBox` children? Right now you only connect the `QGroupBox` itself (which can be checkable) but not the checkboxes within? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D25368

D25362: Don't add and remove player element if it is already in the page

This revision was automatically updated to reflect the committed changes. Closed by commit R856:47a2790188bf: Dont add and remove player element if it is already in the page (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D24070: Don't use toolTipMainText to show info, rather use the second line

broulik added inline comments. INLINE COMMENTS > batterymonitor.qml:72 > +if (powermanagementDisabled) { > +return i18n("Power management is disabled"); > +} This early return still hasn't been addressed. When I keep the screen on I still want to see my remaining

D25362: Don't add and remove player element if it is already in the page

broulik created this revision. broulik added reviewers: Plasma, fvogt, tasossahanidis. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY In case the player has genuinely been added to the website as visible

D25351: [Style KCM] Change name to KDE/Qt Application Style

broulik added a comment. Do we really want the user having to be aware there's something like different toolkits? Not a fan of this change. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D25351 To: ndavis, #plasma, #vdg, ngraham Cc: broulik,

D25324: Display a warning, if xsettingsd is not found

broulik added a comment. I think you would want to make that a `RUNTIME` dependency. This stuff is mostly for packagers, telling them to install something isn't what we want. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D25324 To: gikari Cc:

D25320: Show startup error in popup as well

This revision was automatically updated to reflect the committed changes. Closed by commit R856:7b033c52e1bc: Show startup error in popup as well (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25320?vs=69789=69792

D25320: Show startup error in popup as well

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When the host crashes, the error message is shown to the user. When startup fails, only a

<    3   4   5   6   7   8   9   10   11   12   >