cryptodude added a comment.
> Why don't you set up the preferred size for the dialogue, and allow the
label to be multi-line?
My laptop is 260 DPI, all the places where preferred size is used are really
not usable for this display. I'm thinking the same goes for people with a
non-standa
cryptodude edited the test plan for this revision.
REPOSITORY
R845 Plasma Vault
REVISION DETAIL
https://phabricator.kde.org/D8787
To: cryptodude, #plasma, ivan
Cc: ngraham, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
cryptodude updated this revision to Diff 23122.
REPOSITORY
R845 Plasma Vault
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8787?vs=22636&id=23122
REVISION DETAIL
https://phabricator.kde.org/D8787
AFFECTED FILES
kded/CMakeLists.txt
kded/service.cpp
kded/ui/mountdialog.cpp
cryptodude added a comment.
Welcome back :)
> Replace the text in the 'error' label with 'Failed to open: %1'
Ah, that is an improvement indeed. Will do.
> Replace the two labels with a single one
Let me explain why I separated them, then you can decide if it was a good
cal
cryptodude added a comment.
Updated to fix the issues.
The leading space was intended, indeed. It makes things look a bit nicer.
I also clarified the description, and as to the question if its still
valuable.
The main change is that the original code was intended to not close the
cryptodude updated this revision to Diff 22636.
cryptodude edited the summary of this revision.
REPOSITORY
R845 Plasma Vault
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8787?vs=22262&id=22636
REVISION DETAIL
https://phabricator.kde.org/D8787
AFFECTED FILES
kded/CMakeLists.txt
cryptodude added a comment.
> What's the status of this patch?
The status is that I don't have a developer account and am waiting on someone
to merge this.
As this change is practically not doing anything more than making the dialog
react to the distro/packagers, I can't think of a
cryptodude added a comment.
Hmm, api.kde.org certainly fooled me. Seems there are two classes with
the same name in different packages!
Either way, one has a bug, not sure which was linked in.
Still, it apart from the incorrect commit message, I stand by the patch as it
makes error
cryptodude created this revision.
cryptodude added reviewers: Plasma, ivan.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Replace kde4support dep with specialized pwd diag
BUG:385985
BUG:385445
Drop usage of
