Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread Lasse Liehu
files. For example: ```shell $XGETTEXT `find . -name *.cpp -o -name *.qml` -o $podir/kcmmousetheme.pot ``` - Lasse Liehu On huhti 23, 2015, 8:39 ap, Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 123435: Fix vertical alignment of entry names in system tray configuration

2015-04-20 Thread Lasse Liehu
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 64a341612efe6c2e41c85d5c1a47e18647165566 by Lasse Liehu to branch Plasma/5.3. Repository: plasma-workspace Description --- Summarized. Also see screenshots. Diffs - applets/systemtray

Re: Review Request 123416: Set i18n domain where it was missing

2015-04-19 Thread Lasse Liehu
marked as submitted. Review request for Plasma. Changes --- Submitted with commit d7525011d356d573941ad3d54f110a2b23673868 by Lasse Liehu to branch Plasma/5.3. Repository: kde-cli-tools Description --- Summarized. Diffs - kdesu/kdesu.cpp 483d805 kioclient/kioclient.cpp

Review Request 123435: Fix vertical alignment of entry names in system tray configuration

2015-04-19 Thread Lasse Liehu
/files/2015/04/20/0a6eea4d-2b06-4fc5-8fe2-d0dff385e47e__before.png After https://git.reviewboard.kde.org/media/uploaded/files/2015/04/20/2e0fc3a9-7808-4d79-a81f-e0d449daa429__after.png Thanks, Lasse Liehu ___ Plasma-devel mailing list Plasma-devel

Review Request 123416: Set i18n domain where it was missing

2015-04-18 Thread Lasse Liehu
of them look translated now. Thanks, Lasse Liehu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123377: Fix i18n catalog connections in comic applet

2015-04-16 Thread Lasse Liehu
marked as submitted. Review request for Plasma. Changes --- Submitted with commit db778e2c9315b53dde153cbfeb24d996d48e5dcb by Lasse Liehu to branch Plasma/5.3. Repository: kdeplasma-addons Description --- Changing the catalog name to this and setting translation domain for C

Review Request 123386: Fix i18n catalog connection of a string in shortcuts config

2015-04-16 Thread Lasse Liehu
://git.reviewboard.kde.org/r/123386/diff/ Testing --- Checked that the translation of the string was displayed correctly. Thanks, Lasse Liehu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123386: Fix i18n catalog connection of a string in shortcuts config

2015-04-16 Thread Lasse Liehu
marked as submitted. Review request for Plasma. Changes --- Submitted with commit e13991417cc80ef110176b70256b6518b162a007 by Lasse Liehu to branch Plasma/5.3. Repository: plasma-desktop Description --- This is a bit ugly and prone to breaking if the catalog is ever renamed, but I

Re: Review Request 123387: Fix i18n in desktop containment

2015-04-16 Thread Lasse Liehu
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 85a6b09fb105b4ad00bf58ce40dff91255655025 by Lasse Liehu to branch Plasma/5.3. Repository: plasma-desktop Description --- This adds 36 messages of which many were translatable before 5.3

Review Request 123387: Fix i18n in desktop containment

2015-04-16 Thread Lasse Liehu
that previously untranslated context menu entries now displayed as translated. Thanks, Lasse Liehu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 123377: Fix i18n catalog connections in comic applet

2015-04-15 Thread Lasse Liehu
that UI translations are now displayed. Thanks, Lasse Liehu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122824: [kickoff] Rename Recently Used tab to History and Applications to Apps

2015-03-05 Thread Lasse Liehu
On maalis 5, 2015, 10:47 ap, Martin Klapetek wrote: I would like to point out that Apps is cool in English but does not work at all in other languages (well at least for sure not Czech). Plus I think the HIG does not allow for shorten forms in main UIs...? So -1 for Apps, +2 for

[Powerdevil] [Bug 343903] Crash when opening power management settings

2015-02-07 Thread Lasse Liehu
https://bugs.kde.org/show_bug.cgi?id=343903 Lasse Liehu lasse.li...@gmail.com changed: What|Removed |Added Assignee|unassigned-b...@kde.org |plasma-devel@kde.org

Re: Review Request 119738: Port Fuzzy Clock to Plasma 5

2014-08-14 Thread Lasse Liehu
On elo 14, 2014, 4:58 ip, David Edmundson wrote: applets/fuzzy-clock/package/contents/ui/FuzzyClock.qml, line 118 https://git.reviewboard.kde.org/r/119738/diff/1/?file=304020#file304020line118 we don't need the i18n here, we'd be trying to translate an already translated string.

Re: Review Request 119738: Port Fuzzy Clock to Plasma 5

2014-08-14 Thread Lasse Liehu
] magic. How does that work? eins|/|$[Eigenschaft stunde+1 zwei] $[Eigenschaft vollestunde ein] ?! So I guess here lies the trick. Lasse Liehu wrote: This is scripting translations using Transcript, https://techbase.kde.org/Localization/Concepts/Transcript A property stunde+1

Re: Review Request 118382: [klipper] Fix i18n

2014-05-29 Thread Lasse Liehu
On May 29, 2014, 2:20 p.m., David Edmundson wrote: I'm not very happy giving a ship it to something that is ported but completely untested. We end up with code we think works, but doesn't work properly; which is worse than not touching it at all. It should be possible to download

Review Request: Translate strings in Global Keyboard Shortcuts component KDE Keyboard Layout Switcher

2012-09-11 Thread Lasse Liehu
/diff/ Testing --- Looked at the settings with a new and an existing user. The strings were translated (with a test kxkb.po installed). Also didn't notice anything being wrong. Didn't try changing any settings. Thanks, Lasse Liehu ___ Plasma

Re: Review Request: Improve formatting of the events display on the calendar (applet)

2011-08-17 Thread Lasse Liehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102293/ --- (Updated Aug. 17, 2011, 7:03 a.m.) Review request for Plasma. Summary

Re: Review Request: Improve formatting of the events display on the calendar (applet)

2011-08-17 Thread Lasse Liehu
--- On Aug. 17, 2011, 7:03 a.m., Lasse Liehu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102293

Review Request: Improve formatting of the events display on the calendar (applet)

2011-08-15 Thread Lasse Liehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102293/ --- Review request for Plasma. Summary --- QDate::toString()'s date

Re: Review Request: Make condition icons work in NOAA when conditions are translated

2011-02-10 Thread Lasse Liehu
://git.reviewboard.kde.org/r/100589/#review1301 --- On Feb. 7, 2011, 8:26 p.m., Lasse Liehu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org

Re: Review Request: Make condition icons work in NOAA when conditions are translated

2011-02-07 Thread Lasse Liehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100589/ --- (Updated Feb. 7, 2011, 8:26 p.m.) Review request for Plasma. Changes

Re: Review Request: Plasma::ScrollWidget: ignore() key press event for keys not handled

2011-02-07 Thread Lasse Liehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100586/ --- (Updated Feb. 7, 2011, 9:11 p.m.) Review request for Plasma. Changes

Review Request: Plasma::ScrollWidget: ignore() key press event for keys not handled

2011-02-06 Thread Lasse Liehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100586/ --- Review request for Plasma. Summary --- I was just wondering if this

Review Request: Make condition icons work in NOAA when conditions are translated

2011-02-06 Thread Lasse Liehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100589/ --- Review request for Plasma. Summary --- The condition icons didn't