D6785: Move bitCount from utils to GlxBackend

2017-07-19 Thread Martin Flöser
graesslin added a dependency: D6784: Move bitCount from utils to GlxBackend. REVISION DETAIL https://phabricator.kde.org/D6785 To: graesslin, #kwin, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6784: Move bitCount from utils to GlxBackend

2017-07-19 Thread Martin Flöser
graesslin added a dependent revision: D6785: Move bitCount from utils to GlxBackend. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6784 To: graesslin, #plasma, #kwin Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D6785: Move bitCount from utils to GlxBackend

2017-07-19 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Make bitCount constexpr BRANCH bitcount-constexpr REVISION DETAIL https://phabricator.kde.org/D6785 AFFECTED FILES

D6657: [krunner] First set panel behavior than as panel

2017-07-19 Thread Martin Flöser
graesslin added a comment. ping! Anything speaking against this simple patch to make the situation better? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6657 To: graesslin, #plasma Cc: mart, apol, plasma-devel, ZrenBot, progwolff, lesliezhai,

D6784: Move bitCount from utils to GlxBackend

2017-07-19 Thread Martin Flöser
graesslin updated this revision to Diff 16918. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Fix arc stupidity REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6784?vs=16917=16918 BRANCH bitCount-glxbackend

D6783: Replace Workspace::slotWindowQuickTileFoo by a quickTileWindow with argument

2017-07-19 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Thanks to std::bind we don't need that many different slots to setup the global shortcut connections. Instead we can have one shared

D6754: [server] Send pointer leave if focused surface gets unbound

2017-07-18 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R127:a00a5d5e1c97: [server] Send pointer leave if focused surface gets unbound (authored by graesslin). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D6776: Don't perform wayland specific fixes when on X

2017-07-18 Thread Martin Flöser
graesslin added a comment. Your commit message has a typo where X is written but Wayland is meant. INLINE COMMENTS > dialog.cpp:1160 > > -if (ee->region().isNull()) { > +if (ee->region().isNull() || KWindowSystem::isPlatformX11()) { > return

D6411: [platforms/x11] Use a GlxContextAttributeBuilder

2017-07-17 Thread Martin Flöser
graesslin updated this revision to Diff 16830. graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. Restricted Application added a subscriber: kwin. Rebased to master REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D6754: [server] Send pointer leave if focused surface gets unbound

2017-07-17 Thread Martin Flöser
graesslin created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As https://phabricator.kde.org/R127:98e5d269a110dca9cae1e4ed2bb3051f02a69bff just for pointer. REPOSITORY R127

D6734: [qpa] Use the new OpenGLContextAttributeBuilder to create Qt's OpenGL context

2017-07-17 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:73fa7b21a187: [qpa] Use the new OpenGLContextAttributeBuilder to create Qt's OpenGL context (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D6634: Require C++14

2017-07-17 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:ea5d611de1bc: Require C++14 (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6634?vs=16530=16827 REVISION DETAIL

D6708: Properly swap the quick tile side when pressing the shortcut again

2017-07-17 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:139b4dc82a94: Properly swap the quick tile side when pressing the shortcut again (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D6719: [aurorae] Add support for shaded windows

2017-07-17 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:bf0e0f071ceb: [aurorae] Add support for shaded windows (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6719?vs=16774=16825 REVISION DETAIL

D6735: [platforms/x11] Quit the OpenGL Freeze protection thread on shutdown

2017-07-17 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:06a558e3de65: [platforms/x11] Quit the OpenGL Freeze protection thread on shutdown (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D6726: [aurorae] Mark the render QQuickWindow as frameless

2017-07-17 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:5cb91762be43: [aurorae] Mark the render QQuickWindow as frameless (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6726?vs=16757=16824

D6741: [client] Properly track enteredSurface in Keyboard

2017-07-16 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R127:bea87753629e: [client] Properly track enteredSurface in Keyboard (authored by graesslin). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6741?vs=16786=16797

D6719: [aurorae] Add support for shaded windows

2017-07-16 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > cfeck wrote in aurorae.cpp:407 > Do you remember why the other connection needed to be queued? Yes, when maximizing it can happen that the deco gets destroyed. It would act like a delete this without the queued connection. With shade this

D6734: [qpa] Use the new OpenGLContextAttributeBuilder to create Qt's OpenGL context

2017-07-16 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D6734#125925, @davidedmundson wrote: > Sort of offtopic: are you aware of the new(ish) QOpenGLContext::setNativeHandle() theoretically we can just wrap kwin's existing OpenGL context and not have to actually switch contexts. >

D6630: [kstyle] Do not delete the Surface for a QWindow

2017-07-16 Thread Martin Flöser
graesslin closed this revision. graesslin added a comment. https://commits.kde.org/breeze/e02fef0883af3d3b33ce8a9ea8677c82c1973975 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D6630 To: graesslin, #plasma, mart, davidedmundson Cc: plasma-devel, ZrenBot, progwolff,

D6741: [client] Properly track enteredSurface in Keyboard

2017-07-16 Thread Martin Flöser
graesslin created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY ASAN found a heap-use-after-free when deleting the focused keyboard surface in the client library. Keyboard did not

D6735: [platforms/x11] Quit the OpenGL Freeze protection thread on shutdown

2017-07-16 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Weird NVIDIA behavior fixup part 2. Now that we do no longer freeze when NVIDIA decides to create an OpenGL error on startup

D6734: [qpa] Use the new OpenGLContextAttributeBuilder to create Qt's OpenGL context

2017-07-16 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Introduces a few more attributes needed for creating the OpenGL context used by the QPA. TEST PLAN Extended test and run

D6727: Destroy all kwayland objects created by registry when it is destroyed

2017-07-16 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D6727#125900, @davidedmundson wrote: > We still need https://phabricator.kde.org/D6571, with my proposed change. That's a special case where we delete the connection before the QPA. It might be that we don't need it. Also

D6683: [server] Send keyboard leave when client destroys the focused surface

2017-07-16 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R127:98e5d269a110: [server] Send keyboard leave when client destroys the focused surface (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6683?vs=16755=16775#toc REPOSITORY

D6719: [aurorae] Add support for shaded windows

2017-07-16 Thread Martin Flöser
graesslin updated this revision to Diff 16774. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. New approach to the problem REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6719?vs=16748=16774 BRANCH

D6727: Destroy all kwayland objects created by registry when it is destroyed

2017-07-16 Thread Martin Flöser
graesslin added a comment. I like the idea! That would basically allow us to abandon https://phabricator.kde.org/D6571 and would also solve the issues we see with the kwayland-integration plugin which can crash applications on exit. May I ask for a small unit test for the new

D6571: Delete all Wayland connections by plugins prior to own Wayland connection

2017-07-15 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in wayland_server.cpp:99 > Alternative. > > Instead of deleting qobjects > > emit c->connectionDied(); > > Clients then call destroy() on whatever objects. > They can then delete the QObjects whenever they were going to.

D6719: [aurorae] Add support for shaded windows

2017-07-15 Thread Martin Flöser
graesslin planned changes to this revision. graesslin added a comment. Unfortunately there are still themes which cause glitches. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6719 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai,

D6726: [aurorae] Mark the render QQuickWindow as frameless

2017-07-15 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY On Wayland aurorae was creating a lot of stress for the system and basically turning the system unusable in a short time. This was due

D6683: [server] Send keyboard leave when client destroys the focused surface

2017-07-15 Thread Martin Flöser
graesslin planned changes to this revision. graesslin added a comment. Causes crash in KWayaland when closing a window. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6683 To: graesslin, #frameworks, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D6719: [aurorae] Add support for shaded windows

2017-07-15 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Aurorae did not render correctly. This change addresses the problem for both maximized and restored windows. BUG: 373319

[kio-extras] [Bug 364642] 16.04.3: kio_sftp is broken

2017-07-15 Thread Martin Flöser
https://bugs.kde.org/show_bug.cgi?id=364642 Martin Flöser <mgraess...@kde.org> changed: What|Removed |Added Summary|16.04.3: kio_sftp is fully |16.04.3: kio_sftp is

D6708: Properly swap the quick tile side when pressing the shortcut again

2017-07-15 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The quick tile shortcuts have a feature of moving the window to the next screen if one presses the same shortcut again. E.g. if a

D6634: Require C++14

2017-07-13 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D6634#124880, @lbeltrame wrote: > openSUSE Leap 42.3 uses GCC 4.8 as default, although 5 and 6 are available as well. @lbeltrame does it mean it would create problems for openSUSE or would it be fine? REPOSITORY R108

D6683: [server] Send keyboard leave when client destroys the focused surface

2017-07-13 Thread Martin Flöser
graesslin created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is a change inspired by https://bugreports.qt.io/browse/QTBUG-61930. When Qt closes a window due to a key press

D6569: [client] Track all created ConnectionThreads and add API to access them

2017-07-13 Thread Martin Flöser
graesslin updated this revision to Diff 16660. graesslin added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. Make this compile. Looks like kdevelop fooled me and compiled KWin instead of KWayland (that happens all the time to me) REPOSITORY

D6657: [krunner] First set panel behavior than as panel

2017-07-13 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D6657#124801, @mart wrote: > does this overridex/fixes https://phabricator.kde.org/D6654? kind of orthogonal. https://phabricator.kde.org/D6654 would be nicer if it worked. But as long as https://phabricator.kde.org/D6654

D6657: [krunner] First set panel behavior than as panel

2017-07-12 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D6657#124685, @apol wrote: > Seems like this API is extremely brittle, would it be possible to make sure this is dealt with on the library side? See my long explanation mail. REPOSITORY R120 Plasma Workspace REVISION

D6657: [krunner] First set panel behavior than as panel

2017-07-12 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If a PlasmaShellSurface for an already mapped window is created and set to panel it affects other windows by adjusting the maximized area.

D6654: [krunner] Perform Wayland integration in show not expose event

2017-07-12 Thread Martin Flöser
graesslin planned changes to this revision. graesslin added a comment. doesn't work REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6654 To: graesslin, #plasma, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

Re: KRunner Wayland issues on Qt 5.9

2017-07-12 Thread Martin Flöser
Am 2017-07-12 19:02, schrieb Marco Martin: On Wednesday 12 July 2017 18:45:54 Martin Flöser wrote: > Any ideas or advice? So played with the KRunner code, resulted in: https://phabricator.kde.org/D6654 Summary, don't use expose event, use show event uh, this means we have to get the r

Re: KRunner Wayland issues on Qt 5.9

2017-07-12 Thread Martin Flöser
Am 2017-07-12 18:35, schrieb David Edmundson: On Wed, Jul 12, 2017 at 4:02 PM, Martin Flöser <mgraess...@kde.org> wrote: Hi all, I had a look at the issues of KRunner on Wayland with Qt 5.9 and want to share my findings. What we see is KRunner working fine on first invokation, but afte

Re: KRunner Wayland issues on Qt 5.9

2017-07-12 Thread Martin Flöser
Am 2017-07-12 17:02, schrieb Martin Flöser: Hi all, I had a look at the issues of KRunner on Wayland with Qt 5.9 and want to share my findings. What we see is KRunner working fine on first invokation, but afterwards everything is messed up: * maximized windows shortly change their size

D6654: [krunner] Perform Wayland integration in show not expose event

2017-07-12 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Expose is too late, everything breaks in KWin, see [1]. With show event we get the integration working correctly. No idea what the comment

KRunner Wayland issues on Qt 5.9

2017-07-12 Thread Martin Flöser
Hi all, I had a look at the issues of KRunner on Wayland with Qt 5.9 and want to share my findings. What we see is KRunner working fine on first invokation, but afterwards everything is messed up: * maximized windows shortly change their size * KRunner opens behind other windows With

Re: Topics for Plasma BoF at Akademy 2017

2017-07-11 Thread Martin Flöser
Am 2017-07-12 06:19, schrieb Bhushan Shah: Hello, On Mon, Jul 10, 2017 at 3:58 PM, Bhushan Shah wrote: Currently room information is not available so we can't book slot but at least we can collect ideas and topics :-) Now room information is available and I've booked a

D6634: Require C++14

2017-07-11 Thread Martin Flöser
graesslin added a reviewer: lbeltrame. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6634 To: graesslin, #plasma, lbeltrame Cc: plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D6634: Require C++14

2017-07-11 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY KWin already used C++14 constructs in a conditional way. This doesn't make much sense today, it's better to just require C++14.

D6572: [kstyle] Change ownership of Wayland objects so that KWin can delete them

2017-07-11 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R31:5328a253ccdc: [kstyle] Change ownership of Wayland objects so that KWin can delete them (authored by graesslin). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE

D6630: [kstyle] Do not delete the Surface for a QWindow

2017-07-11 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D6630#124201, @davidedmundson wrote: > Whilst this does make sense based on the current design we are effectively building up dead objects during the lifespan of a window doing show/hide/show. Well it was designed when Qt

D6611: Implement support for restricted move area on Wayland

2017-07-11 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:672cae9a7d36: Implement support for restricted move area on Wayland (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6611?vs=16456=16522

D6562: Restrict move resize area only on the screen the strut window is on

2017-07-11 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:14c8440f11f9: Restrict move resize area only on the screen the strut window is on (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D6455: position the shellsurface immediately

2017-07-11 Thread Martin Flöser
graesslin added a comment. What I don't like about it is that KWin will get and react on two events with one having invalid coordinates. We get an event for the change of x and at that point y might be invalid. KWin will position the window there and that can result in mess (e.g. all

D6630: [kstyle] Do not delete the Surface for a QWindow

2017-07-11 Thread Martin Flöser
graesslin edited the test plan for this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D6630 To: graesslin, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6630: [kstyle] Do not delete the Surface for a QWindow

2017-07-11 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Surface::fromWindow are shared! By deleting the Surface pointer copies in other areas are getting deleted as well. This breaks e.g. KWin

D6630: [kstyle] Do not delete the Surface for a QWindow

2017-07-11 Thread Martin Flöser
graesslin added a reviewer: mart. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D6630 To: graesslin, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6572: [kstyle] Change ownership of Wayland objects so that KWin can delete them

2017-07-11 Thread Martin Flöser
graesslin updated this revision to Diff 16518. graesslin added a comment. Undo arc mess REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6572?vs=16517=16518 BRANCH wayland-shadow-parent REVISION DETAIL https://phabricator.kde.org/D6572 AFFECTED FILES

D6572: [kstyle] Change ownership of Wayland objects so that KWin can delete them

2017-07-11 Thread Martin Flöser
graesslin updated this revision to Diff 16517. graesslin added a comment. - [kstyle] Do not delete the Surface for a QWindow REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6572?vs=16350=16517 BRANCH shadow-no-delete-surface REVISION DETAIL

D6581: Fix crash in KCMKeyboardWidget::populateWithCurrentXkbOptions on Wayland

2017-07-10 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R119:5cd48d672782: Fix crash in KCMKeyboardWidget::populateWithCurrentXkbOptions on Wayland (authored by graesslin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D6611: Implement support for restricted move area on Wayland

2017-07-10 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change implements a missing TODO to generate the restricted move area for windows with struts (aka panel) on Wayland. BRANCH

D6569: [client] Track all created ConnectionThreads and add API to access them

2017-07-09 Thread Martin Flöser
graesslin updated this revision to Diff 16406. graesslin added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. Use mutex to protect the potentially shared data structure REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D6581: Fix crash in KCMKeyboardWidget::populateWithCurrentXkbOptions on Wayland

2017-07-09 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Prevents a call into X11 which will crash. This needs to be fixed properly by defining a way to get the options from the Wayland

D6569: [client] Track all created ConnectionThreads and add API to access them

2017-07-09 Thread Martin Flöser
graesslin added a comment. @davidedmundson if you have another idea how to tackle the problem I'm absolutely open to it. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6569 To: graesslin, #frameworks, #plasma, #kwin Cc: davidedmundson, dfaure, plasma-devel,

Re: KWin 5.10.3.1 update

2017-07-09 Thread Martin Flöser
Am 2017-07-09 11:00, schrieb Maximiliano Curia: ¡Hola Martin! El 2017-07-08 a las 14:45 +0200, Martin Flöser escribió: Am 2017-07-07 15:54, schrieb Maximiliano Curia: El 2017-07-03 a las 17:26 +0100, Jonathan Riddell escribió: KWin has received an update to the 5.10.3 release. 5.10.3.1

D6569: [client] Track all created ConnectionThreads and add API to access them

2017-07-08 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D6569#123081, @davidedmundson wrote: > I don't think this is necessary. > > The only times we want need to delete the connection ourselves is when client code is creating it via ConnectionThread::fromApplication. If they

D6572: [kstyle] Change ownership of Wayland objects so that KWin can delete them

2017-07-08 Thread Martin Flöser
graesslin added a dependency: D6571: Delete all Wayland connections by plugins prior to own Wayland connection. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D6572 To: graesslin, #kwin, #plasma, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D6569: [client] Track all created ConnectionThreads and add API to access them

2017-07-08 Thread Martin Flöser
graesslin added a dependent revision: D6571: Delete all Wayland connections by plugins prior to own Wayland connection. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6569 To: graesslin, #frameworks, #plasma, #kwin Cc: dfaure, plasma-devel, ZrenBot, progwolff,

D6572: [kstyle] Change ownership of Wayland objects so that KWin can delete them

2017-07-08 Thread Martin Flöser
graesslin added a reviewer: hpereiradacosta. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D6572 To: graesslin, #kwin, #plasma, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6571: Delete all Wayland connections by plugins prior to own Wayland connection

2017-07-08 Thread Martin Flöser
graesslin added a dependency: D6569: [client] Track all created ConnectionThreads and add API to access them. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6571 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening,

D6572: [kstyle] Change ownership of Wayland objects so that KWin can delete them

2017-07-08 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KWin has a problem that breeze crashes it on tear down if the shadow was created. This is due to breeze destroying the Wayland connection

D6571: Delete all Wayland connections by plugins prior to own Wayland connection

2017-07-08 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Some libraries loaded into KWin (e.g. breeze) also have a Wayland connection. If KWin destroyes it's own Wayland connection before the

[Powerdevil] [Bug 382114] Screen not locking on lid close

2017-07-08 Thread Martin Flöser
https://bugs.kde.org/show_bug.cgi?id=382114 Martin Flöser <mgraess...@kde.org> changed: What|Removed |Added Product|kscreenlocker |Powe

D6566: Do not leak XVisualInfo (X11 EGL path)

2017-07-08 Thread Martin Flöser
graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. An alternative could be to use QScopedPointer or std::unique_ptr with XFree as the deleter. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D6566 To:

D6565: Query supported OpenGL core profile version on X11, GLX

2017-07-08 Thread Martin Flöser
graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. I highly suggest to use the new context attribute builder I created for KWin. See https://phabricator.kde.org/D6411 INLINE COMMENTS > opengl.cpp:778 > + } else { > +

Re: KWin 5.10.3.1 update

2017-07-08 Thread Martin Flöser
Am 2017-07-07 15:54, schrieb Maximiliano Curia: ¡Hola Jonathan! El 2017-07-03 a las 17:26 +0100, Jonathan Riddell escribió: KWin has received an update to the 5.10.3 release. 5.10.3.1 contains a fix for https://bugs.kde.org/show_bug.cgi?id=381870 Freeze in KWin::checkGLError on startup which

D6569: [client] Track all created ConnectionThreads and add API to access them

2017-07-08 Thread Martin Flöser
graesslin created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is change needed by KWin. KWin has the problem that it destroys its internal Wayland connection (KWin as client

D6562: Restrict move resize area only on the screen the strut window is on

2017-07-08 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY By allowing panels between screens in 5.8 to have a strut we created a "regression" in KWin. KWin always was wrong, just we didn't

D6533: [qpa] Prevent crash due to Surface getting null

2017-07-06 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:962a2e39ee7a: [qpa] Prevent crash due to Surface getting null (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6533?vs=16258=16268 REVISION

D6462: Raise minimum required Mesa version to 10.0

2017-07-06 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:88e56f630b7e: Raise minimum required Mesa version to 10.0 (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6462?vs=16085=16266 REVISION DETAIL

D6468: [effects/slideback] Ignore windows which are not in visible area

2017-07-06 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:24ff93854ddc: [effects/slideback] Ignore windows which are not in visible area (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D6467: [platforms/x11] Fix incorrect screen edge approaching with switch desktop on window move

2017-07-06 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:4e9456a85723: [platforms/x11] Fix incorrect screen edge approaching with switch desktop on… (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D6533: [qpa] Prevent crash due to Surface getting null

2017-07-06 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This is a regression due to changes in Breeze to support Qt 5.8+ behavior change. KWin's own QPA operates like < Qt 5.7 and breeze was

D6523: check Buffer validity

2017-07-06 Thread Martin Flöser
graesslin added a comment. Erm why was this pushed although it was in state changes requested? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6523 To: mart, #plasma, davidedmundson, graesslin Cc: graesslin, davidedmundson, plasma-devel, #frameworks, ZrenBot,

D6523: check Buffer validity

2017-07-06 Thread Martin Flöser
graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. please add a test case for the problem. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6523 To: mart, #plasma, davidedmundson, graesslin Cc:

Re: [plasma-devel] Requesting an emergency Plasma 5.10.3.1 release

2017-07-03 Thread Martin Flöser
Am 2017-07-02 17:12, schrieb Jonathan Riddell: On Sat, Jul 01, 2017 at 07:15:42PM +0200, Martin Flöser wrote: This is a severe issue and thus I request an emergency release as soon as I have the patch ready. Yes can do, let me know when it should be done I just pushed: https

D6464: Prevent endless loop in checkGLError due to GL_CONTEXT_LOST

2017-07-03 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:aefb5f4dd9d4: Prevent endless loop in checkGLError due to GL_CONTEXT_LOST (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6464?vs=16088=16137

D6468: [effects/slideback] Ignore windows which are not in visible area

2017-07-02 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The PresentWindows effect does not hide the window to close the selected window. Instead it moves it outside the visible area. As this

D6467: [platforms/x11] Fix incorrect screen edge approaching with switch desktop on window move

2017-07-02 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY There is a regression in WindowBasedEdge::soStopApproaching. Due to only operate when the edge activates for pointer it is possible

D6464: Prevent endless loop in checkGLError due to GL_CONTEXT_LOST

2017-07-01 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The GL_CONTEXT_LOST flag is not reset when calling glGetError. This of course bites with: "Thus, glGetError should always be called in

Requesting an emergency Plasma 5.10.3.1 release

2017-07-01 Thread Martin Flöser
Hi all, the fix we did for NVIDIA in Plasma 5.10.3 introduced a regression which can result in a freeze on startup. The bug is https://bugs.kde.org/show_bug.cgi?id=381767 The problem is that we perform a checkGLError in the initialization code. The robustness extension has the unfortunate

D6462: Raise minimum required Mesa version to 10.0

2017-07-01 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The currently minimum required Mesa version was 8.0 and KWin had special caseing for Mesa 9.1. This is no longer realistic, no

D6323: Remove roundtrip to XServer from Workspace::xStackingOrderIntroduce a method Workspace::markXStackingOrderAsDirty

2017-07-01 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:630514d52ab7: Remove roundtrip to XServer from Workspace::xStackingOrder Introduce a method… (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6323?vs=15707=16076#toc

D6401: [platforms/x11] Request OpenGL 2.1 instead of 1.2

2017-07-01 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:be89c16b3884: [platforms/x11] Request OpenGL 2.1 instead of 1.2 (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6401?vs=15901=16075 REVISION

D6420: Restore active client after ending showing desktop

2017-07-01 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:113be5fac81a: Restore active client after ending showing desktop (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6420?vs=15964=16074 REVISION

D6426: Skip Shader self test for Mesa >= 17

2017-07-01 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:43816119e9ec: Skip Shader self test for Mesa >= 17 (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6426?vs=15967=16073 REVISION DETAIL

D6456: [lookandfeel/lockscreen] Fix state handling when clicking the keyboard's own hide button

2017-07-01 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R120:5004afe62d16: [lookandfeel/lockscreen] Fix state handling when clicking the keyboard's own… (authored by graesslin). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D6456: [lookandfeel/lockscreen] Fix state handling when clicking the keyboard's own hide button

2017-06-30 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When clicking the hide button provided by the virtual keyboard, the keyboard hides, but the state is not updated. This means the animation

D6426: Skip Shader self test for Mesa >= 17

2017-06-28 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY We are getting reports about the shader self test failing in a false positive way on Mesa 17. We already have such false positve

D6420: Restore active client after ending showing desktop

2017-06-28 Thread Martin Flöser
graesslin updated this revision to Diff 15964. graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. I'm too stupid for arc (or git), no really removed REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6420?vs=15955=15964

<    7   8   9   10   11   12   13   14   >