D8345: [QPA] Implement Screen on top of internal Screens API

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The test DontCrashUseractionsMenu (Waylandonly) found an issue in our screen handling

D8344: Add physicalSize to the Screens API

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Allows to share the implementation in a better way and is a requirement to get the Screen

D8338: Set transient parent for system tray menus

graesslin accepted this revision. graesslin added inline comments. INLINE COMMENTS > apol wrote in systemtray.cpp:216 > This looks wrong... nah, it's the common trick to create the windowHandle. Without the next line of code would crash. Don't ask me why Qt doesn't have proper API for it...

D8321: Only check for legacy system tray icons if we're going to make one

graesslin added a comment. I'm sorry but it still deadlocks, see https://bugs.kde.org/show_bug.cgi?id=385867 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D8321 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, #frameworks, ZrenBot, progwolff,

D8166: Add DBus protocol to virtual keyboard

graesslin added a comment. I'm sorry, but the deadlock is not fixed. I just compiled the latest knotifications, logged out and in and still had the freeze. REPOSITORY R108 KWin BRANCH virt-keyboard-dbus REVISION DETAIL https://phabricator.kde.org/D8166 To: graesslin, #kwin, #plasma,

D8338: Set transient parent for system tray menus

graesslin added a comment. Looks good! INLINE COMMENTS > startplasma.cmake:31 > +Xft.dpi: $QT_WAYLAND_FORCE_DPI > EOF > This looks unrelated. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8338 To: davidedmundson, #plasma Cc: graesslin, plasma-devel,

D8065: Ensure libinput connection thread uses real time scheduling

graesslin added inline comments. INLINE COMMENTS > anthonyfieroni wrote in main_wayland.cpp:91 > static Could you please explain why you think that this function should be static? Please keep in mind that main_wayland.cpp is it's own translation unit. REPOSITORY R108 KWin REVISION DETAIL

D8016: Ensure leave event is send to decoration when a window maximizes

This revision was automatically updated to reflect the committed changes. Closed by commit R108:507d83fb08ad: Ensure leave event is send to decoration when a window maximizes (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D8177: Implement Apply desktop rule for ShellClient

graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8177 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D8169: Support user fullscreen for XdgShellSurfaces

graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8169 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D8095: Support updating deco for changes of borderless maximize windows config

graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8095 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D8016: Ensure leave event is send to decoration when a window maximizes

graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8016 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D8065: Ensure libinput connection thread uses real time scheduling

graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8065 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D8331: Require Qt 5.9

graesslin added a comment. Request for update of FreeBSD image in: https://phabricator.kde.org/T7210 REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8331 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8331: Require Qt 5.9

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REPOSITORY R108 KWin BRANCH require-qt5.9 REVISION DETAIL https://phabricator.kde.org/D8331 AFFECTED FILES

D7955: Move X11-only specific part of EffectsHandlerImpl to x11 platform plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R108:7ef8409157c0: Move X11-only specific part of EffectsHandlerImpl to x11 platform plugin (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7955?vs=19835=20857#toc

D8321: Only check for legacy system tray icons if we're going to make one

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D8321 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

D8316: Add a pure virtual method to Platform to describe the supported compositors

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY So far KWin does not know which Compositors the platform actually supports. This results in

D8268: Fix placement of KSplash

This revision was automatically updated to reflect the committed changes. Closed by commit R108:afe0a5c04116: Fix placement of KSplash (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8268?vs=20657=20796#toc REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D8145: Update pointer position whenever a window gets (un)minimized

This revision was automatically updated to reflect the committed changes. Closed by commit R108:1b01f1b30094: Update pointer position whenever a window gets (un)minimized (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8145?vs=20356=20795

D8304: Don't position a Dialog if it's of type OSD

This revision was automatically updated to reflect the committed changes. Closed by commit R242:ecd00a565a99: Dont position a Dialog if its of type OSD (authored by graesslin). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin added a comment. @davidedmundson The CI image is updated, you can push this now. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8050 To: davidedmundson, #plasma, graesslin, bcooksley Cc: bcooksley, graesslin, plasma-devel, #frameworks, ZrenBot,

D8304: Don't position a Dialog if it's of type OSD

graesslin created this revision. graesslin added reviewers: Frameworks, Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The OSDs are positioned by the Wayland compositor. This fixed the issue found in

D8268: Fix placement of KSplash

graesslin added a comment. Addressed the other problem in https://phabricator.kde.org/D8304. As that is only master I would retarget this change here for master as well instead of 5.11. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8268 To: graesslin, #kwin,

D8268: Fix placement of KSplash

graesslin added a comment. And yes, that's a bug in Plasma: [1117495.024] -> org_kde_plasma_surface@210.set_position(0, 0) [1117495.036] -> org_kde_kwin_slide_manager@105.unset(wl_surface@88) [1117495.041] -> wl_surface@88.commit() [1117495.051] ->

D8268: Fix placement of KSplash

graesslin added a comment. In https://phabricator.kde.org/D8268#154753, @graesslin wrote: > This needs additional testing for "normal" OSD windows. I'm not sure whether it affects them. It shouldn't or better said: if they are it's a bug somewhere else. So tried this again: it

D8284: Don't duplicate connect to wl_display_flush

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. Ahhh. That's of course tricky to spot in this change ;-) REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D8284 To: davidedmundson,

D8285: Unload poller's connection thread earlier in teardown

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R130 Frameworks integration plugin using KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D8285 To: davidedmundson, graesslin Cc: anthonyfieroni, plasma-devel, ZrenBot,

D8287: Default X font DPI to 96 on wayland

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D8287 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8284: Don't duplicate connect to wl_display_flush

graesslin added a comment. I don't see in the change what you describe. This seems to be just a refactoring. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8284 To: davidedmundson Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff,

D8268: Fix placement of KSplash

graesslin added a comment. This needs additional testing for "normal" OSD windows. I'm not sure whether it affects them. It shouldn't or better said: if they are it's a bug somewhere else. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8268 To: graesslin, #kwin,

D8268: Fix placement of KSplash

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY In a bug report there was a reference that on multi-screen KSplash is not placed correctly. I

Re: Linux Pro Magazine article about Wayland adoption

Hi Bruce, sorry for the late reply, I only spotted your note right now. I'm the Wayland maintainer in Plasma. Am 2017-10-09 23:43, schrieb Bruce Byfield: Hi: I'm preparing an article on distros' adoption of Wayland. I was hoping to have answers to a few questions: - What is the state of

Re: Wayland showstoppers wiki page

Am 2017-10-12 17:33, schrieb Martin Flöser: Am 2017-10-12 13:48, schrieb David Edmundson: I've added some things, that I think are essential. I think we should track assignment on the existing phabricator tasks list. Note there's also the bugzilla keyword "wayland" for searching ov

D7369: Wayland foreign protocol

graesslin accepted this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7369 To: mart, #plasma, #kwin, davidedmundson, graesslin Cc: davidedmundson, graesslin, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed,

Re: Wayland showstoppers wiki page

Am 2017-10-12 13:48, schrieb David Edmundson: I've added some things, that I think are essential. I think we should track assignment on the existing phabricator tasks list. Note there's also the bugzilla keyword "wayland" for searching over all our software. I'm glad you're more on the fence

Wayland showstoppers wiki page

Hi all, I just created a wiki page to track the showstoppers: https://community.kde.org/Plasma/Wayland_Showstoppers I decided for wiki instead of bugzilla as I want to track issues all over the stack and not just those in our software. Please add as you find issues which you think are a

D7369: Wayland foreign protocol

graesslin added a comment. There is still quite some documentation missing. Especially the server side is not yet documented enough that I would know how to use the new API and what it does. It's totally fine to copy and adapt the documentation from the Wayland xml protocol. INLINE

D8252: Make calendar pin persistent across sessions

graesslin added a comment. I agree on the consistent part. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8252 To: davidedmundson, #plasma Cc: graesslin, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D8251: Fix DRM EGL crash regression

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. whoops. Thanks for fixing. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D8251 To: davidedmundson, #plasma, graesslin Cc: graesslin,

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin added a comment. In https://phabricator.kde.org/D8050#154356, @davidedmundson wrote: > I'm not resubmitting something just for the purpose of you two winding each other up. Eh, it was not meant like that. I just wanted to point out that this does not need any changes

Re: Notes from QtCS that will affect Plasma.

Am 2017-10-10 22:18, schrieb David Edmundson: Most notes are about boring internal things and I quietly stayed at the back. For the wayland session I had a lot of questions/comments and was a general nuisance. Wayland: xdg_positioner: We need to pass data to the window from from QComboBox

D8250: [client] Drop the checks for platformName being "wayland"

graesslin created this revision. graesslin added reviewers: Frameworks, KWin, Flatpak. Restricted Application added a subscriber: plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. REVISION SUMMARY There are also QPA's which are "wayland" but have a different

Re: Plasma 5.12 goal: let's get Wayland ready!

Am 2017-10-11 11:53, schrieb Marco Martin: On martedì 10 ottobre 2017 21:40:14 CEST Martin Flöser wrote: Hi all, I want to put out a development goal for the Plasma team for the upcoming 5.12 cycle: let's get Wayland ready! The last two weeks I saw two blog posts by two different Plasma

Re: Plasma 5.12 goal: let's get Wayland ready!

Am 2017-10-11 12:30, schrieb David Edmundson: I want to put out a development goal for the Plasma team for the upcoming 5.12 cycle: let's get Wayland ready! Sure, but being an LTS, the "do LTS stuff" goal also needs to remain in full effect. I think that goes hand in hand and is actually why

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin accepted this revision. graesslin added a comment. I'm accepting this revision again. The CI system needs to have the PPA activated again as the old CI system had. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8050 To: davidedmundson, #plasma,

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin added a comment. In https://phabricator.kde.org/D8050#154207, @bcooksley wrote: > Please remedy the Wayland dependency incompatibility. > > In the event the relevant package is not available in the distribution in question, you'll need to contact it's packagers and make the

Re: [RFC] Fixing the QT_QPA_PLATFORM dilemma

Am 2017-10-11 11:23, schrieb David Edmundson: On Wed, Oct 11, 2017 at 11:01 AM, Marco Martin <notm...@gmail.com> wrote: On martedì 10 ottobre 2017 19:35:43 CEST Martin Flöser wrote: Based on that we can detect whether we are on Wayland and could pick the Wayland platform (and should

Plasma 5.12 goal: let's get Wayland ready!

Hi all, I want to put out a development goal for the Plasma team for the upcoming 5.12 cycle: let's get Wayland ready! The last two weeks I saw two blog posts by two different Plasma members showing screenshots running X. That disappointed me. I hoped that we all are running Wayland already

Re: [RFC] Fixing the QT_QPA_PLATFORM dilemma

Am 2017-10-10 20:07, schrieb David Edmundson: On the "fix Qt" side. Discussed in QtCS yesterday (I have more notes to type up): QtWayland client will be moving into QtBase. When this happens, neat and tidy autodection is do-able. Also those bundled apps would have wayland. Realistically we're

D7369: Wayland foreign protocol

graesslin added a comment. In https://phabricator.kde.org/D7369#153978, @mart wrote: > In https://phabricator.kde.org/D7369#152358, @graesslin wrote: > > > Documentation is still missing, Unstable suffix is still in two many API calls. > > > i think the

D7521: Make use of foreign protocol

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH mart/foreign REVISION DETAIL https://phabricator.kde.org/D7521 To: mart, #plasma, graesslin Cc: luebking, graesslin, davidedmundson, plasma-devel, kwin, #kwin, ZrenBot,

[RFC] Fixing the QT_QPA_PLATFORM dilemma

Hi Plasmates, on Wayland we use QT_QPA_PLATFORM=wayland to force all Qt applications to use the Wayland QPA instead of the XCB QPA. This has a huge problem: Qt does not ship Wayland in their installers. So any application which bundles Qt itself is not going to start on a Plasma/Wayland

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin added a comment. One of our CI jobs is no longer happy: 13:02:41 -- The following REQUIRED packages have not been found: 13:02:41 13:02:41 * Wayland (required version >= 1.13) , C library implementation of the Wayland protocol: a protocol for a compositor to talk to

D8039: Support software QtQuickRendering in Aurorae

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in aurorae.cpp:354 > Changing the rendering doesn't block making calls to any of the openGL calls > in QtBase. > The only changes are purely inside QtQuick > > So: > creating a context still works fine > creating an FBO

D8039: Support software QtQuickRendering in Aurorae

graesslin added a comment. Ah sorry, I had my comment here for weeks, just unsubmitted :-( REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8039 To: davidedmundson, #plasma Cc: graesslin, apol, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8152: [platforms/drm] Use a shared pointer for gbm_surface

This revision was automatically updated to reflect the committed changes. Closed by commit R108:47343fb8f759: [platforms/drm] Use a shared pointer for gbm_surface (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8152?vs=20375=20532

Re: recap on failing plasma-frameworks tests on CI

Am 2017-10-09 16:53, schrieb Marco Martin: On Mon, Oct 9, 2017 at 2:45 PM, David Edmundson wrote: The "breaking" change in p-f is the one that bumps the version. It then enables 7af93dd23873d0b9cdbac192949e7e5114940aa6 in extra-cmake-modules Set

Re: Plasma Team Communication & Development Practices [MUST READ]

Am 2017-10-08 11:38, schrieb Ben Cooksley: On Sun, Oct 8, 2017 at 10:02 PM, Martin Flöser <mgraess...@kde.org> wrote: Am 2017-10-08 10:22, schrieb Ben Cooksley: On Sun, Oct 8, 2017 at 9:00 PM, Martin Flöser <mgraess...@kde.org> wrote: Am 2017-10-07 22:00, schrieb Ben Cooksle

Re: Plasma Team Communication & Development Practices [MUST READ]

Am 2017-10-08 10:22, schrieb Ben Cooksley: On Sun, Oct 8, 2017 at 9:00 PM, Martin Flöser <mgraess...@kde.org> wrote: Am 2017-10-07 22:00, schrieb Ben Cooksley: On Sat, Oct 7, 2017 at 11:57 PM, Martin Flöser <mgraess...@kde.org> wrote: Am 2017-10-07 11:22, schrieb Ben Cooksley:

Re: Plasma Team Communication & Development Practices [MUST READ]

Am 2017-10-07 22:00, schrieb Ben Cooksley: On Sat, Oct 7, 2017 at 11:57 PM, Martin Flöser <mgraess...@kde.org> wrote: Am 2017-10-07 11:22, schrieb Ben Cooksley: *Pulls up a chair* We need to have a talk. The way things are proceeding currently in regards to how you (the Plasma folks

D8177: Implement Apply desktop rule for ShellClient

graesslin added a dependent revision: D8182: Support initial minimize rule in ShellClient. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8177 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening,

D8182: Support initial minimize rule in ShellClient

graesslin added a dependency: D8177: Implement Apply desktop rule for ShellClient. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8182 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg,

D8182: Support initial minimize rule in ShellClient

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Honors the rules for minimizing a window on initial show. REPOSITORY R108 KWin BRANCH

D8177: Implement Apply desktop rule for ShellClient

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This change sets up ShellClient for supporting window rules by reading in the rules once it

Re: Plasma Team Communication & Development Practices [MUST READ]

Am 2017-10-07 11:22, schrieb Ben Cooksley: *Pulls up a chair* We need to have a talk. The way things are proceeding currently in regards to how you (the Plasma folks) work with the rest of us is severely and fundamentally broken. Which means we need to fix it. Lets start with development

D8159: Add API for setting server decoration palettes

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D8159 To: davidedmundson, #plasma, graesslin Cc: graesslin, broulik, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin,

D8094: Port RuleBook::discardUsed from Client to AbstractClient

This revision was automatically updated to reflect the committed changes. Closed by commit R108:35bcc9fc3519: Port RuleBook::discardUsed from Client to AbstractClient (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8094?vs=20205=20423

D8169: Support user fullscreen for XdgShellSurfaces

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY So far ShellClient did not support that the user can set a window to fullscreen. This was

D8094: Port RuleBook::discardUsed from Client to AbstractClient

graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8094 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D8090: Move WindowRules from Client to AbstractClient

This revision was automatically updated to reflect the committed changes. Closed by commit R108:0372fdaf9275: Move WindowRules from Client to AbstractClient (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8090?vs=20204=20416 REVISION

D8145: Update pointer position whenever a window gets (un)minimized

graesslin added a comment. yep, I actually checked whether we can use the stacking order changed for that, but it's clearly documented as only when the actual layering changes. And I fear it would cause problems in other areas where code reacts on stacking order changes and gets confused if

D8163: Move StatusNotifierItem for VirtualKeyboard into a helper process

graesslin added a comment. Just the DBus protocol is in https://phabricator.kde.org/D8166 REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8163 To: graesslin, #kwin, #plasma, mart Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,

D8166: Add DBus protocol to virtual keyboard

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This change adds a DBus API to query whether the virtual keyboard is currently enabled and

D8163: Move StatusNotifierItem for VirtualKeyboard into a helper process

graesslin added a comment. In https://phabricator.kde.org/D8163#152777, @davidedmundson wrote: > Immediately going for a workaround is.. (and I don't want to use this term as you've clearly made a huge patch) lazy. Hey, I discussed this with Marco yesterday afternoon ;-) If

D8163: Move StatusNotifierItem for VirtualKeyboard into a helper process

graesslin created this revision. graesslin added reviewers: KWin, Plasma, mart. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY During startup the StatusNotifierItem can cause a freeze as it might do a blocking DBus

D8159: Add API for setting server decoration palettes

graesslin added inline comments. INLINE COMMENTS > broulik wrote in server_decoration_interface.h:147 > I think we support both (doing a KService lookup if no complete path given), > imho "name" would also be consistent with what KConfig uses Nothing better than looking into the source:

D8159: Add API for setting server decoration palettes

graesslin added a comment. I'm fine with the change, but when I thought about it, I was wondering whether it would be better to have a dedicated interface. There is at least one other Wayland compositor out there which implements the protocol and I got several requests about upstreaming it.

D8152: [platforms/drm] Use a shared pointer for gbm_surface

graesslin added a comment. In https://phabricator.kde.org/D8152#152540, @davidedmundson wrote: > > FIXED-IN: 5.11.0 > > I'm afraid it won't be. Tag was today. Yeah, I already noticed. Basically I arc diffed, opened up my mails and saw that it was tagged. REPOSITORY R108

D8152: [platforms/drm] Use a shared pointer for gbm_surface

graesslin updated this revision to Diff 20375. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Added test case for new class REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8152?vs=20373=20375 BRANCH

D8152: [platforms/drm] Use a shared pointer for gbm_surface

graesslin added a comment. I have no idea why git think I copied from drm_buffer_gbm.h|cpp. I created the files from scratch. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8152 To: graesslin, #kwin, #plasma, subdiff Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff,

D8152: [platforms/drm] Use a shared pointer for gbm_surface

graesslin created this revision. graesslin added reviewers: KWin, Plasma, subdiff. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The gbm_surface is owned by the EglGbmBackend, but it's not the only one using it.

D8145: Update pointer position whenever a window gets (un)minimized

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This fixes the following problem: 1. Have two windows maximized 2. Click minimize button

D7369: Wayland foreign protocol

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Documentation is still missing, Unstable suffix is still in two many API calls. INLINE COMMENTS > registry.h:527-528 > + > +zxdg_exporter_v2

D8100: Workaround crash on lockscreen close

graesslin accepted this revision. graesslin added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > greeterapp.cpp:127 > +//will be fixed when themes port to QQC2 > +for(auto view: m_views) { > +if (QQuickItem *focusItem =

D8086: Reload VirtualDesktop settings after passing RootInfo on VirtualDesktopManager

This revision was automatically updated to reflect the committed changes. Closed by commit R108:f988a5f6547b: Reload VirtualDesktop settings after passing RootInfo on VirtualDesktopManager (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D8095: Support updating deco for changes of borderless maximize windows config

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY So far only updated the Clients, now also ShellClient. REPOSITORY R108 KWin BRANCH

D8094: Port RuleBook::discardUsed from Client to AbstractClient

graesslin added a dependency: D8090: Move WindowRules from Client to AbstractClient. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8094 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg,

D8090: Move WindowRules from Client to AbstractClient

graesslin added a dependent revision: D8094: Port RuleBook::discardUsed from Client to AbstractClient. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8090 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8094: Port RuleBook::discardUsed from Client to AbstractClient

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Prepares the Rules update on reconfigure for Wayland windows. REPOSITORY R108 KWin BRANCH

D8090: Move WindowRules from Client to AbstractClient

graesslin updated this revision to Diff 20204. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. I noticed I hadn't removed the variable from Client... That turned into another round of refactoring and moving things from Client to

D8086: Reload VirtualDesktop settings after passing RootInfo on VirtualDesktopManager

graesslin updated this revision to Diff 20199. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. New try: found some more code which syncs the rootinfo. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D8086: Reload VirtualDesktop settings after passing RootInfo on VirtualDesktopManager

graesslin added a comment. In https://phabricator.kde.org/D8086#151206, @fvogt wrote: > I gave it a try, it's slightly better but not enough: The virtual desktop pager is not visible by default as there's only a single virtual desktop now instead of two by default. How does

D8090: Move WindowRules from Client to AbstractClient

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY So far window rule specific functionality was only implemented in Client and in ShellClient

D8086: Reload VirtualDesktop settings after passing RootInfo on VirtualDesktopManager

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The load method and updateLayout ensure the virtual desktop information is synced to RootInfo

D8082: Also send Wayland clients to a new desktop if their desktop was removed

This revision was automatically updated to reflect the committed changes. Closed by commit R108:0d96e60b79a7: Also send Wayland clients to a new desktop if their desktop was removed (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D8082: Also send Wayland clients to a new desktop if their desktop was removed

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY So far the method only operated on X11 clients. So when the last desktop got removed Wayland

D7740: Move SceneOpenGL into a dedicated plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R108:8ae37c420bd3: Move SceneOpenGL into a dedicated plugin (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7740?vs=19319=20142#toc REPOSITORY R108 KWin CHANGES SINCE

D7924: Support starting kwin_wayland without XWayland support

This revision was automatically updated to reflect the committed changes. Closed by commit R108:343d8c9b626a: Support starting kwin_wayland without XWayland support (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7924?vs=19755=20141

D7897: Move X11 specific Workspace initialization code into dedicated method

This revision was automatically updated to reflect the committed changes. Closed by commit R108:5cbd28f9a0d4: Move X11 specific Workspace initialization code into dedicated method (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

<    2   3   4   5   6   7   8   9   10   11   >