[Powerdevil] [Bug 357045] New: Remember brigthness level between logins

2015-12-22 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=357045 Bug ID: 357045 Summary: Remember brigthness level between logins Product: Powerdevil Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity:

Review Request 126463: Allow applets to set full ToolTip item

2015-12-21 Thread Martin Klapetek
ll have correct tooltips. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

2015-12-21 Thread Martin Klapetek
expected. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126461: Use the SkipGrouping flag for the "widget deleted" notification

2015-12-21 Thread Martin Klapetek
failures will ensue) Diffs (updated) - CMakeLists.txt a27b3ac src/plasma/private/applet_p.cpp 511b451 Diff: https://git.reviewboard.kde.org/r/126461/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@

Re: Review Request 126460: Honor SkipGrouping hint from KNotification

2015-12-21 Thread Martin Klapetek
346622 and possibly also a multiscreen thing. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126460/#review89855 ------- On Dec

Review Request 126461: Use the SkipGrouping flag for the "widget deleted" notification

2015-12-21 Thread Martin Klapetek
ma/private/applet_p.cpp 511b451 Diff: https://git.reviewboard.kde.org/r/126461/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126460: Honor SkipGrouping hint from KNotification

2015-12-21 Thread Martin Klapetek
/126460/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 356940] kalarm crash on start up

2015-12-21 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356940 Martin Klapetek changed: What|Removed |Added Assignee|plasma-devel@kde.org|hugo.pere...@free.fr Component

Re: Review Request 126373: change the taskbar color from blue to gray

2015-12-20 Thread Martin Klapetek
> On Dec. 20, 2015, 9:24 p.m., andreas kainz wrote: > > ok so please vote for > > 1. leave it as it is > > 2. as it is now but with white text for selected task > > 3. add blue boarder as all other tasks have (see first line in taskbar3.png) > > 4. better idea 3) is good. Keeps the color meaning

Re: Review Request 126408: [notifications] Refactor the screen handling code

2015-12-18 Thread Martin Klapetek
can test real multi-screen stuff, all works fine here. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126408/#review89682 -------

Re: Noto fonts screw my system, please stop forcing fonts upon me!

2015-12-17 Thread Martin Klapetek
a second try to acknowledge that you might have a local system issue instead of covering your ears and kicking&screaming, we're happy to help you figure it out. In the meantime, good luck with your demonstrative endeavor I guess. PS: I was able to change my system font in under 8 s

Re: Noto fonts screw my system, please stop forcing fonts upon me!

2015-12-17 Thread Martin Klapetek
whatever font you want. Nobody is forcing anything "down your throat". Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126408: [notifications] Refactor the screen handling code

2015-12-17 Thread Martin Klapetek
26408/diff/ Testing --- I've been testing all sorts of im/possible combinations of multi-screen setups, panel movements on screen, between screens, screen movements etc. Worked as expected in all situations. Einar77 also confirms things are working correctly after a quick test. Thanks,

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-12-16 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #81 from Martin Klapetek --- > Also I notice that after do `sudo gdb --pid` cpu usage slightly decrease and > after quit this back to 25%. Yes, attaching gdb to it makes the process actually stop, quitting gdb makes the process co

Re: Evolving Appdash

2015-12-16 Thread Martin Klapetek
h powerful machines. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-12-16 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #79 from Martin Klapetek --- Can you check if you have 2 kded5 processes running? Your backtrace again shows no activity at all. -- You are receiving this mail because: You are the assignee for the bug

Re: notification plasmoid for desktop

2015-12-16 Thread Martin Klapetek
t a grey blob sitting on your desktop. As for the sidebar usecase Andreas mentioned, well, I did propose that two months ago, nobody liked it. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126373: change the taskbar color from blue to gray

2015-12-16 Thread Martin Klapetek
" to white Could probably be solved by combination of the task manager using colors from theme color palette (if it doesn't already) and adjusting the color palette to use white text in selected items. - Martin Klapetek On Dec. 1

Re: Evolving Appdash

2015-12-16 Thread Martin Klapetek
1920x1280 then takes less than 3 seconds. I'm not sure how well is gimp's blurring optimized and/or gpu powered, but 3 seconds really doesn't sound bad for one-time generation in the background. Of course there are different activities and different wallpapers but s

Re: Review Request 126373: change the taskbar color from blue to gray

2015-12-15 Thread Martin Klapetek
. Please let's not introduce more visual regressions. - Martin Klapetek On Dec. 16, 2015, 1:06 a.m., andreas kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: notification plasmoid for desktop

2015-12-15 Thread Martin Klapetek
overview of the > notification history on the desktop too. > Possible, sure. Good idea, not entirely sure. What would be the use case? Why would the user want to have that on the desktop? What good would it bring? Cheers -- Martin Klapetek | KDE Developer ___

Re: Evolving Appdash

2015-12-15 Thread Martin Klapetek
to do the same thing (launching an app plus much more duplicated functionality) that not everybody uses/needs and yet has it loaded by default. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126356: change minimum size of clipboard

2015-12-14 Thread Martin Klapetek
applet can barely fit 5 entries[1], making the minimum height any smaller does not seem like an improvement. [1] http://paste.opensuse.org/view/raw/2bea1130 - Martin Klapetek On Dec. 15, 2015, 1:24 a.m., andreas kainz wrote: > > ---

Re: Review Request 126333: [Keyboard KCM] Use getShortText for OSD as well

2015-12-14 Thread Martin Klapetek
tps://git.reviewboard.kde.org/r/126333/#comment61238> Looks like getDisplayName() could/should be improved then? I mean if it's not "good enough" for displaying it... - Martin Klapetek On Dec. 14, 2015, 12:49 p.m.,

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

2015-12-14 Thread Martin Klapetek
marked as submitted. Review request for KDE Frameworks, Plasma and Alex Richardson. Changes --- Submitted with commit 54602237fd018a7212cadea5210a1908584ee110 by Martin Klapetek to branch master. Repository: plasma-framework Description --- plasma-scriptengine.desktop defines the

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

2015-12-14 Thread Martin Klapetek
to QStringList? Yes. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126320/#review89459 --- On Dec. 11, 2015,

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

2015-12-11 Thread Martin Klapetek
a strong reminescence of that plus the "rainbow noise" going on at the lower-right diagonal part of the image). - Martin Klapetek On Dec. 11, 2015, 8:04 p.m., Ken Vermette wrote: > > --- > This is an automatically

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-12-11 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #75 from Martin Klapetek --- Thanks, pasting it here. Always please either attach the file here or paste it directly here, pastebins tend to disappear. That said, your backtrace looks absolutely normal, there's nothing wrong going o

Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

2015-12-11 Thread Martin Klapetek
- src/plasma/scripting/scriptengine.cpp 1b132de Diff: https://git.reviewboard.kde.org/r/126320/diff/ Testing --- Plasma would get stuck on startup, now I can run Plasma again. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-deve

Re: Review Request 124962: Fix CMAKE_INSTALL_LIBDIR not respecting installation prefix

2015-12-11 Thread Martin Klapetek
n Kubuntu: cmake ../../src/kwallet-pam/ -DCMAKE_INSTALL_PREFIX=/ ...that installs it into /lib/security. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124962: Fix CMAKE_INSTALL_LIBDIR not respecting installation prefix

2015-12-10 Thread Martin Klapetek
eg. "libpam_kwallet.so", but will instead name it "pam_kwallet.so". It has nothing to do with install paths. If you want to have it installed in /lib, just set CMAKE_INSTALL_PREFIX to "/", then it should install into /lib correctly. Cheers -- Martin Klapetek | KDE

Re: Review Request 126275: Make the "Plasma (Wayland)" xsession file actually say "Plasma (Wayland)"

2015-12-10 Thread Martin Klapetek
> Plasma (wayland) (wayland) > > Rex Dieter wrote: > If need be, yes. > > Aleix Pol Gonzalez wrote: > AFAIR, SDDM is the only one officially supported by Plasma. It's not > really acceptable that it has visual regressions. > > Martin Klapetek wr

Re: Review Request 126275: Make the "Plasma (Wayland)" xsession file actually say "Plasma (Wayland)"

2015-12-09 Thread Martin Klapetek
rated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126275/#review89286 ------- On Dec. 8, 2015, 3:09 p.m., Martin Klapetek wrote: > > --- > This is an automatical

Re: Review Request 126275: Make the "Plasma (Wayland)" xsession file actually say "Plasma (Wayland)"

2015-12-08 Thread Martin Klapetek
ake c5d5757 Diff: https://git.reviewboard.kde.org/r/126275/diff/ Testing --- Sddm now clearly shows which "Plasma" is Waylandplasma. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126275: Make the "Plasma (Wayland)" xsession file actually say "Plasma (Wayland)"

2015-12-08 Thread Martin Klapetek
t: https://git.reviewboard.kde.org/r/126275/#review89234 --- On Dec. 8, 2015, 6 a.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To repl

Review Request 126275: Make the "Plasma (Wayland)" xsession file actually say "Plasma (Wayland)"

2015-12-07 Thread Martin Klapetek
early shows which "Plasma" is Waylandplasma. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-12-07 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #73 from Martin Klapetek --- Please follow the steps from Comment #8. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 126237: make comment role searchable in timezone selection

2015-12-04 Thread Martin Klapetek
severly undertasked? - Martin Klapetek On Dec. 4, 2015, 2:12 a.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

2015-12-04 Thread Martin Klapetek
but part of KDE Applications. Will a dependency like that be ok? - Martin Klapetek On Nov. 18, 2015, 1:33 a.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

Re: 5.5 video

2015-12-03 Thread Martin Klapetek
simple fade-in/panning, perhaps with a logo, would be just enough. This reminds me of wordarts :) Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126221: Rework the notifications positioning a bit

2015-12-02 Thread Martin Klapetek
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 4a6f7db0018a2a7366ac7f2ad61fc33f31566c03 by Martin Klapetek to branch Plasma/5.5. Bugs: 355069 https://bugs.kde.org/show_bug.cgi?id=355069 Repository: plasma-workspace Description --- The

[Plasma Workspace Wallpapers] [Bug 354379] Wallpaper fails to rotate 90 on dual screen with external scr. on left. Stays horiz. and spills over onto right scr.

2015-12-02 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=354379 Martin Klapetek changed: What|Removed |Added CC||mklape...@kde.org Status

Re: Review Request 126221: Rework the notifications positioning a bit

2015-12-02 Thread Martin Klapetek
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126221/#review89064 --- On Dec. 2, 2015, 8:32 p.m., Martin Klapetek wrote: > > -

Re: Review Request 126221: Rework the notifications positioning a bit

2015-12-02 Thread Martin Klapetek
ications/plugin/notificationshelper.cpp 7c0dd99 applets/notifications/lib/notificationsapplet.h dc31e1d Diff: https://git.reviewboard.kde.org/r/126221/diff/ Testing --- I can no longer reproduce notifications flying across the screen. Thanks, Martin Klapetek _

Re: Review Request 126221: Rework the notifications positioning a bit

2015-12-02 Thread Martin Klapetek
ault, the applet follows the panel and resolves the value to one of the actual values (Top* or Bottom*). - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126221/#review8

Re: 5.5 video

2015-12-02 Thread Martin Klapetek
er the widgets/menus. Also, fwiw, Gnome release video: https://www.youtube.com/watch?v=WxRLa5hTGkg Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126221: Rework the notifications positioning a bit

2015-12-02 Thread Martin Klapetek
de.org/r/126221/diff/ Testing --- I can no longer reproduce notifications flying across the screen. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: 5.5 video

2015-12-02 Thread Martin Klapetek
On Wed, Dec 2, 2015 at 9:05 AM, Jonathan Riddell wrote: > Lucas has made a 5.5 video and is after comments for any changes > > https://youtu.be/rYUqgFiY5Go Is this going to be an official video or something like that? Cheers -- Martin Klapetek | KDE

Re: Review Request 126126: kicker: always show arrows for items with children

2015-12-01 Thread Martin Klapetek
> On Nov. 30, 2015, 2:50 p.m., Marco Martin wrote: > > ping? what's the status of this? > > Eike Hein wrote: > I was waiting for Pino, but here's a shot of the proposed variant: > > ![All arrows everywhere](http://i.imgur.com/FwAmgGZ.png) > > Marco Martin wrote: > it looks aa b

[Breeze] [Bug 356004] No distinction between the different states applications with breeze-dark with the icons-only task manager

2015-11-27 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356004 Martin Klapetek changed: What|Removed |Added CC||mklape...@kde.org Status

Re: RFC: New KWin effect for notifications

2015-11-26 Thread Martin Klapetek
On Thu, Nov 26, 2015 at 12:43 PM, Marco Martin wrote: > On Thursday 26 November 2015, Martin Klapetek wrote: > > I've considered the slide effect but it has number of short- > > comings for the notifications usecase and would have to > > be modified heavily to re

RFC: New KWin effect for notifications

2015-11-26 Thread Martin Klapetek
nly for the notifications. Can you think of other usecases that could/should be considered for this effect? Any other input? Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Reminder: your window animations belong to KWin

2015-11-25 Thread Martin Klapetek
On Wed, Nov 25, 2015 at 1:10 PM, Marco Martin wrote: > On Wednesday 25 November 2015, Martin Klapetek wrote: > > - The KWindowEffects::slideWindow() docs say "Desktop and Floating > >won't have effect". What is that referring to? The location argument > >

Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

2015-11-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126160/#review88841 --- Ship it! Ok, I'll trust you. - Martin Klapetek On No

Re: Reminder: your window animations belong to KWin

2015-11-25 Thread Martin Klapetek
On Wed, Nov 25, 2015 at 12:34 PM, David Edmundson < da...@davidedmundson.co.uk> wrote: > it's in QWindow which you inherit from > Oh, my qt-assistant tricked me; I thought it's a top-level class. http://paste.opensuse.org/view/raw/33270855 Cheers -- Martin Kl

Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

2015-11-25 Thread Martin Klapetek
izard - can you be sure that QWizard::sizeHint() will always return sensible value? As an alternative, you could just scale the font to always fit the wizard. That would also help with resizing the window (for whatever reason). - Martin Klapetek On Nov. 25, 2015, 6:03 p.m., David Rosca

Re: Reminder: your window animations belong to KWin

2015-11-25 Thread Martin Klapetek
at Floating? Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 355860] Toggle Push-Buttons are indistinguishable

2015-11-24 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355860 Martin Klapetek changed: What|Removed |Added Assignee|plasma-devel@kde.org|hugo.pere...@free.fr CC

Re: Review Request 126150: Ensure the spinboxes in image slideshow are wide enough

2015-11-24 Thread Martin Klapetek
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 4d0d55e4a2910ab8b50d98c2f2fd377b6f2af83c by Martin Klapetek to branch Plasma/5.5. Bugs: 33 https://bugs.kde.org/show_bug.cgi?id=33 Repository: plasma-workspace Description --- Should fix

Review Request 126150: Ensure the spinboxes in image slideshow are wide enough

2015-11-23 Thread Martin Klapetek
. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[plasmashell] [Bug 355799] Icons-only task manager has glitches with Breeze Dark theme

2015-11-23 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355799 Martin Klapetek changed: What|Removed |Added Assignee|plasma-devel@kde.org|visual-des...@kde.org CC

Re: release cycle

2015-11-21 Thread Martin Klapetek
anned properly. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [kde-promo] 5.5 announcement

2015-11-18 Thread Martin Klapetek
" with the > 5.5 icons? > I've tried but I a) don't have spotify and b) other issues https://www.dropbox.com/s/7g1sm39k5dqcv4n/new_snapshot14_calendar.png?dl=0 Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing li

[plasmashell] [Bug 355563] Taskbar is cluttered and colorfull

2015-11-18 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355563 Martin Klapetek changed: What|Removed |Added Assignee|plasma-devel@kde.org|visual-des...@kde.org Product

Re: Release plasma-framework + kdeclarative beta with plasma 5.5beta?

2015-11-18 Thread Martin Klapetek
On Wed, Nov 18, 2015 at 9:38 AM, David Edmundson wrote: > > On Wed, Nov 18, 2015 at 2:25 PM, Martin Klapetek < > martin.klape...@gmail.com> wrote: > >> Hi, >> >> so there's a plasma 5.5 beta release in the following days >> and there is some st

[plasmashell] [Bug 355561] Breeze themes look a bit inconsistent after recent update

2015-11-18 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355561 Martin Klapetek changed: What|Removed |Added CC||mklape...@kde.org

[Breeze] [Bug 355560] Missing Breeze Cursor themes after update

2015-11-18 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355560 Martin Klapetek changed: What|Removed |Added CC||mklape...@kde.org --- Comment #1 from Martin

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

2015-11-18 Thread Martin Klapetek
> On Nov. 18, 2015, 10:14 a.m., Kai Uwe Broulik wrote: > > plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp, line 37 > > <https://git.reviewboard.kde.org/r/125862/diff/2/?file=417230#file417230line37> > > > > Add context this > > M

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-11-18 Thread Martin Klapetek
marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit 6f3fed77d59227a9b3ec85d343ffb2443086f7fa by Martin Klapetek to branch master. Bugs: 353715 http://bugs.kde.org/show_bug.cgi?id=353715 Repository: plasma-framework Description

Re: Review Request 126018: Use the plural form for "Notification" category

2015-11-18 Thread Martin Klapetek
> On Nov. 10, 2015, 10:57 p.m., Martin Klapetek wrote: > > > should I change also X-KDE-System-Settings-Category=notification to > > > notifications > > > > I don't think so, it would require changing everywhere. Unless there is > > nothing actua

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

2015-11-18 Thread Martin Klapetek
"this" caputred implicitly? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125862/#review88512 ------- On

Release plasma-framework + kdeclarative beta with plasma 5.5beta?

2015-11-18 Thread Martin Klapetek
alf-broken calendar. Could we therefore release plasma-fw + kdeclarative betas alongside plasma 5.5 beta? Also I'm not in release-team, please CC me. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

2015-11-17 Thread Martin Klapetek
.kde.org/r/125862/diff/ Testing --- Holidays are properly listed in calendar applet. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125864: Add back the Agenda part of the Calendar

2015-11-17 Thread Martin Klapetek
-8bd9-726f0fc54ce8__snapshot30.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-11-17 Thread Martin Klapetek
> On Oct. 28, 2015, 9:44 p.m., Martin Klapetek wrote: > > So...any word on this? > > Albert Astals Cid wrote: > Re-reading your comment, if i understand it correctly, you claim it is a > bug in Qt that it does obey LC_DATE for month names when according to you >

Re: [kde-promo] 5.5 announcement

2015-11-17 Thread Martin Klapetek
Hmm, that one actually cannot be resized so that scrollbars are not visible. But maybe I should just not show them in the window and they should get a separate screenshot. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-deve

Re: [kde-promo] 5.5 announcement

2015-11-17 Thread Martin Klapetek
n we can just ship the same screenshot for every release because the default never changes, except the wallpaper. Which is fine I guess but gets boring and repetitive quickly. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-d

Re: Review Request 126092: Konqui based Emotion pack named eKspression

2015-11-16 Thread Martin Klapetek
taly). Imo same could go for -smile-big, -laughing and -XD...especially the -XD which to me looks like a "rage" face rather than laughing :) - Martin Klapetek On Nov. 16, 2015, 11:38 p.m., andreas kainz wrote: > > ---

Re: Review Request 126010: [digital-clock] Split the Calendar config stuff to it's own category + load the plugins configs

2015-11-16 Thread Martin Klapetek
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 4b631f8c5c99957313ce2a1953b7975836fcef46 by Martin Klapetek to branch master. Repository: plasma-workspace Description --- Two commits. Creates separate category for Calendar config, currently only

Re: Review Request 125991: [Widget Explorer] Allow uninstalling user-installed applets

2015-11-16 Thread Martin Klapetek
> On Nov. 8, 2015, 4:37 p.m., Thomas Pfeiffer wrote: > > Showing it always does make sense as long as it affects only a few > > Plasmoids, yes. > > About the undo: I'm wondering if it might make sense - for consistency's > > sake - to do the undo mechanism similar to undoing the removal of a >

Re: Review Request 125817: Add plugin system for Calendar events

2015-11-16 Thread Martin Klapetek
marked as submitted. Review request for KDE Frameworks, Plasma and Daniel Vrátil. Changes --- Submitted with commit fe0384f0d4152e622b203385bd968657a3650d2c by Martin Klapetek to branch master. Repository: plasma-framework Description --- This adds a simple plugin interface that

Re: Review Request 125966: Allow adding config categories dynamically

2015-11-16 Thread Martin Klapetek
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 8349a786af99a7adf5add84d911982bc579f3e78 by Martin Klapetek to branch master. Repository: plasma-framework Description --- This allows to add custom config categories from JS dynamically. This is

Re: Review Request 125951: [calendar] Move the plugins handling to a separate class

2015-11-16 Thread Martin Klapetek
marked as submitted. Review request for Plasma. Changes --- Submitted with commit d0d0a27bac0ff9ee84320dff1ff8b42d9696dccf by Martin Klapetek to branch master. Repository: plasma-framework Description --- This is also made a QML singleton that will be used for the applet config

Re: RFC: Disable DrKonqi

2015-11-16 Thread Martin Klapetek
uld have a timeout for let's say a minute so if you don't act on it, it would just go away. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126079: Keep drag and drop in range on both sides

2015-11-15 Thread Martin Klapetek
useful. - Martin Klapetek On Nov. 16, 2015, 12:48 a.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126036: Update wallpaper package with plasma 5.5 wallpaper contest

2015-11-11 Thread Martin Klapetek
us the low quality). Discard (from me). * Group discards/By the water - I believe that's the a submission? It's not bad, has a bit of noise in it which could be reduced, but other than that, I'd bring it back. * Discarded by Uri/Darkest hour - if we could tweak that photo, I thin

Re: Review Request 126010: [digital-clock] Split the Calendar config stuff to it's own category + load the plugins configs

2015-11-11 Thread Martin Klapetek
g page https://git.reviewboard.kde.org/media/uploaded/files/2015/11/09/52e2e536-4e98-4272-8a48-1d4fafc17548__snapshot41.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125951: [calendar] Move the plugins handling to a separate class

2015-11-11 Thread Martin Klapetek
vents are still correctly displayed Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126018: Use the plural form for "Notification" category

2015-11-10 Thread Martin Klapetek
ngs-Category=notification to > notifications I don't think so, it would require changing everywhere. Unless there is nothing actually using it, in which case, yes. - Martin Klapetek On Nov. 10, 2015, 10:12 p.m., Luigi Toscano wrote: > > -

Re: Review Request 125951: [calendar] Move the plugins handling to a separate class

2015-11-10 Thread Martin Klapetek
t: https://git.reviewboard.kde.org/r/125951/#review88206 ------- On Nov. 9, 2015, 8:56 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-

Re: Review Request 125973: Remove completely duplicated function

2015-11-09 Thread Martin Klapetek
(int x, int y)? That one has only two args and is missing the "run associated application" action, which I'm not entirely sure what's it used for. The rest indeed looks about the same (though the showMenu could really use some commentary) - Martin Klapetek On Nov. 9, 201

Re: Plasma 5.5 Release Anouncements

2015-11-09 Thread Martin Klapetek
Isn't the beta release in 10 days? I would probably wait till next Monday to not having to redo the screenshots once some other things get in. Is that ok? Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org h

Review Request 126010: [digital-clock] Split the Calendar config stuff to it's own category + load the plugins configs

2015-11-09 Thread Martin Klapetek
bels, dunno why. File Attachments Calendar config page https://git.reviewboard.kde.org/media/uploaded/files/2015/11/09/52e2e536-4e98-4272-8a48-1d4fafc17548__snapshot41.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasm

Re: Review Request 125951: [calendar] Move the plugins handling to a separate class

2015-11-09 Thread Martin Klapetek
/calendar/eventpluginsmanager.cpp PRE-CREATION src/declarativeimports/calendar/qml/MonthView.qml f698934f850ef3a917b9611c9f9a40c369b23f6c Diff: https://git.reviewboard.kde.org/r/125951/diff/ Testing --- Calendar events are still correctly displayed Thanks, Martin Klapetek

Re: Review Request 125951: [calendar] Move the plugins handling to a separate class

2015-11-09 Thread Martin Klapetek
hanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.5 Release Anouncements

2015-11-09 Thread Martin Klapetek
K, can you make screenshots again? Ideally by the end of Monday so > we have room for a round of emergency bug fixes on them. > Absolutely. Which Monday do you mean? Today? Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list P

[Powerdevil] [Bug 354623] Full charge not trigger notification

2015-11-07 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=354623 --- Comment #8 from Martin Klapetek --- But upower -d does report fully-charged. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org

[Powerdevil] [Bug 354623] Full charge not trigger notification

2015-11-07 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=354623 --- Comment #7 from Martin Klapetek --- Fwiw I'm using kubuntu ci and recently stuff in /opt like kcms and kded modules stopped being found by the system, I think it has to do with the sycoca changes and I haven't figured out which paths need

Review Request 125966: Allow adding config categories dynamically

2015-11-05 Thread Martin Klapetek
- src/plasmaquick/configmodel.h dad8a6f src/plasmaquick/configmodel.cpp c452bb4 Diff: https://git.reviewboard.kde.org/r/125966/diff/ Testing --- Plugin's config file is correctly displayed in the applet's config window. Thanks, Marti

Re: Review Request 125951: [calendar] Move the plugins handling to a separate class

2015-11-04 Thread Martin Klapetek
del. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125951/#review88031 --- On Nov. 4, 2015, 8:24 p.m., Martin

<    1   2   3   4   5   6   7   8   9   10   >