Review Request 125864: Add back the Agenda part of the Calendar

/uploaded/files/2015/10/29/d453a01e-f9cf-4da3-8f6a-fac5aa6aadf5__snapshot18.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125864: Add back the Agenda part of the Calendar

ences. {} == {} ? false ...javascript. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125864/#review87678 ---

Re: Review Request 125817: Add plugin system for Calendar events

wasn't sure where to put it, but unless we put it in its own repo, plasma-framework seems like the best-of-the-bad place, so I went with that. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.

Re: Review Request 125838: [screenlocker] Turn kscreenlocker in to shared library from static

> On Oct. 28, 2015, 3:45 p.m., Martin Gräßlin wrote: > > ksmserver/screenlocker/CMakeLists.txt, line 46 > > > > > > I thought we got rid of that one in the other review request... > > Bhushan Shah wrote: >

Re: Review Request 125743: Keep aspect ratio in default KSplash background

-- On Oct. 21, 2015, 8:51 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125743/ >

Re: Review Request 125743: Keep aspect ratio in default KSplash background

> On Oct. 21, 2015, 11:05 p.m., David Edmundson wrote: > > Makes sense for the default behaviours to match > > Martin Klapetek wrote: > Match what? Do we have similar code elsewhere? Btw Hrvoje reported that > this is less than ideal as it "letterboxes" th

Re: Review Request 125817: Add plugin system for Calendar events

ting --- I have a simple KHolidays based plugin written (patch should be up later today) and patches in the Calendar applet. Everything works as expected: * the days are marked as containing an event * the agenda part displays details of that event (name) Than

Re: Review Request 125770: Emit correct signal for notifications expiring

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125770/#review87610 --- Ship it! Ship It! - Martin Klapetek On Oct. 25, 2015, 6

Re: Review Request 125770: Emit correct signal for notifications expiring

> On Oct. 28, 2015, 7:09 p.m., Martin Klapetek wrote: > > Ship It! ...though don't put that gnome link in the commit please. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.

Re: Review Request 125705: Use LANG for month names in calendar applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125705/#review87617 --- So...any word on this? - Martin Klapetek On Oct. 20, 2015

Re: Review Request 125705: Use LANG for month names in calendar applet

> On Oct. 28, 2015, 9:44 p.m., Martin Klapetek wrote: > > So...any word on this? > > Albert Astals Cid wrote: > Re-reading your comment, if i understand it correctly, you claim it is a > bug in Qt that it does obey LC_DATE for month names when according to y

Re: Review Request 125817: Add plugin system for Calendar events

members here should be hidden in PIMPL. > > > > 1) it would prevent ABI breakage (you can reoder members easilly when > > adding new ones) > > 2) it reduced copying and memory use when inserting/retrieving the > > objects from the QHash as well as passi

Re: Review Request 125817: Add plugin system for Calendar events

-- I have a simple KHolidays based plugin written (patch should be up later today) and patches in the Calendar applet. Everything works as expected: * the days are marked as containing an event * the agenda part displays details of that event (name) Thanks, Marti

Re: Review Request 125817: Add plugin system for Calendar events

of that event (name) Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125817: Add plugin system for Calendar events

he enum as Q_ENUM to access it from QML? In > > that case you probably need your own enum in `EventDataDecorator` and map > > to it from `EventData::EventType`... Ah yes, adding. - Martin --- This is an automaticall

Re: Review Request 125817: Add plugin system for Calendar events

hing works as expected: * the days are marked as containing an event * the agenda part displays details of that event (name) Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125817: Add plugin system for Calendar events

y generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/#review87550 ------- On Oct. 27, 2015, 10:10 p.m., Martin Klapetek wrote: > > --- > This is an autom

Re: Review Request 125817: Add plugin system for Calendar events

his is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/#review87556 --- On Oct. 27, 2015, 10:10 p.m., Martin Klapetek wrote: > > ---

Re: Review Request 125817: Add plugin system for Calendar events

it would update. But that didn't consider cases like calendar on desktop, so I'll have to think about that as well. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/#review87492

Review Request 125817: Add plugin system for Calendar events

vent (name) Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125817: Add plugin system for Calendar events

* the days are marked as containing an event * the agenda part displays details of that event (name) Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

> On Oct. 25, 2015, 11:05 p.m., Thomas Pfeiffer wrote: > > As always: If you want design or usability input, please provide a > > screenshot. We cannot read the code. Thanks. > > Eike Hein wrote: > Thomas, all this does is not grey out the text in Task Manager button > labels when a

Re: Review Request 125817: Add plugin system for Calendar events

uot;description" IMO. "Comment" in the context of > > events/todos means something different (see RFC2445, part 4.8.1.4) Good point. - Martin --- This is an automatically generated e-mail. To reply, visit: https:

Re: Review Request 125770: Emit correct signal for notifications expiring

rrect even wrt the Galago spec. - Martin Klapetek On Oct. 24, 2015, 2:40 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: RFC: Put notifications in sidepanel like widget explorer

On Tue, Oct 20, 2015 at 4:34 PM, kainz.a <kain...@gmail.com> wrote: > 2015-10-20 22:16 GMT+02:00 Marco Martin <notm...@gmail.com>: > > On Tuesday 20 October 2015, Martin Klapetek wrote: > >> Basically the idea is to reinvent the notifications in Plasma a bit > >

Re: Review Request 125739: Don't connect to signals which don't exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125739/#review87219 --- Ship it! Ship It! - Martin Klapetek On Oct. 21, 2015, 6

Re: Review Request 125709: Ensure correct timezone is displayed when the selected ones change

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 11473e62c4c91f1302ff2303f732827422b88eb8 by Martin Klapetek to branch Plasma/5.4. Bugs: 353996 https://bugs.kde.org/show_bug.cgi?id=353996 Repository: plasma-workspace Description --- When

Review Request 125743: Keep aspect ratio in default KSplash background

/contents/splash/Splash.qml fdeb1ea Diff: https://git.reviewboard.kde.org/r/125743/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: Put notifications in sidepanel like widget explorer

n some way what they did > I haven't seen that in Win10 before, but yeah, looks like something I had in mind, just better (of course). Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125743: Keep aspect ratio in default KSplash background

. the distro ships 1920x1200 wallpaper and on 1024x768 the crop would be quite big (the image would still be centered so cropped on the sides) Diffs - lookandfeel/contents/splash/Splash.qml fdeb1ea Diff: https://git.reviewboard.kde.org/r/125743/diff/ Testing --- Thanks, Martin

Re: RFC: Put notifications in sidepanel like widget explorer

e as > well (but the desktop/phone specific parts can be isolated in sprcific > platform specific files) > I think I'd leave the current applet untouched and create a whole new thing, based on that applet. I think it could become part of the desktop shell itself. Cheers -- Martin Klape

Re: RFC: Put notifications in sidepanel like widget explorer

widgets so the user should say I > want that widget and fine. > The current Notifications applet would still be available. If the user wishes, he can recreate that kind of thing. You can have that with current panels even. But I don't want a hidden panel. I want this to be a core part o

Re: Review Request 125709: Ensure correct timezone is displayed when the selected ones change

be able to handle that - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125709/#review87094 --- On Oct. 19, 2015,

Re: Review Request 125709: Ensure correct timezone is displayed when the selected ones change

/DigitalClock.qml c644bfe applets/digital-clock/package/contents/ui/main.qml 310a049 Diff: https://git.reviewboard.kde.org/r/125709/diff/ Testing --- * Select UTC+14:00 timezone * Deselect Local timezone * Press Apply * Panel clock now has UTC+14:00 timezeon Thanks, Martin Klapetek

Re: Review Request 125705: Use LANG for month names in calendar applet

67a08e5 Diff: https://git.reviewboard.kde.org/r/125705/diff/ Testing --- LC_DATE=cs_CZ LANG=en_US Month names in calendar applet are now english. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Review Request 125705: Use LANG for month names in calendar applet

-mail. To reply, visit: https://git.reviewboard.kde.org/r/125705/#review87113 ------- On Oct. 19, 2015, 6:13 p.m., Martin Klapetek wrote: > > --- > This is an automatically gene

RFC: Put notifications in sidepanel like widget explorer

, but clicking it would open that panel. Basically the idea is to reinvent the notifications in Plasma a bit and create a kind of notification center. My plan would be to get a VDG design and then work on it for Plasma 5.6. Thoughts? Cheers -- Martin Klapetek | KDE Developer

Re: RFC: Put notifications in sidepanel like widget explorer

On Tue, Oct 20, 2015 at 4:16 PM, Marco Martin <notm...@gmail.com> wrote: > On Tuesday 20 October 2015, Martin Klapetek wrote: > > Basically the idea is to reinvent the notifications in Plasma a bit > > and create a kind of notification center. > > > > My

Re: Review Request 125720: set default theme to breeze rather than oxygen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125720/#review87132 --- +1 - Martin Klapetek On Oct. 20, 2015, 11:52 a.m., Harald

Review Request 125705: Use LANG for month names in calendar applet

in calendar applet are now english. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125709: Ensure correct timezone is displayed when the selected ones change

/git.reviewboard.kde.org/r/125709/#review87092 --- On Oct. 19, 2015, 7:40 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Review Request 125709: Ensure correct timezone is displayed when the selected ones change

://git.reviewboard.kde.org/r/125709/diff/ Testing --- * Select UTC+14:00 timezone * Deselect Local timezone * Press Apply * Panel clock now has UTC+14:00 timezeon Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Review Request 125709: Ensure correct timezone is displayed when the selected ones change

) - applets/digital-clock/package/contents/ui/DigitalClock.qml c644bfe Diff: https://git.reviewboard.kde.org/r/125709/diff/ Testing --- * Select UTC+14:00 timezone * Deselect Local timezone * Press Apply * Panel clock now has UTC+14:00 timezeon Thanks, Martin Klapetek

Re: Review Request 125248: Display name of process which blocks umount / eject

g from it and moving the items in the list. dataengines/devicenotifications/ksolidnotify.cpp (line 162) <https://git.reviewboard.kde.org/r/125248/#comment59808> This should say "Could not safely remove.." to match the applet action description - Martin Klapetek On Sept. 16,

Re: Review Request 125662: mangonel: Initial port to Qt5/KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125662/#review86929 --- Screenshots? ;) - Martin Klapetek On Oct. 16, 2015, 5:42

Re: 5.5 module review

to be frameworks and should be out soon, let's not mix them into our releases. > kpeoplevcard > screenshotapp ^These are not very useful for desktop, no need for a release imho. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list

Re: Review Request 125648: Add method to run a script from DBus directly

tps://git.reviewboard.kde.org/r/125648/#comment59756> Should there be at least some basic input treatment to prevent malicious activity? Running arbitrary data without any checking seems dangerous. - Martin Klapetek On Oct. 15, 2015, 7:22 p.m., David Edmundson

Re: Review Request 125625: digitalclock: Use Text.HorizontalFit for date label in vertical panel

drag that panel to be a horizontal panel? - Martin Klapetek On Oct. 13, 2015, 6:20 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

ther than vice-versa as it is now. > > Martin Klapetek wrote: > I agree with the icon. I feel like it's changing every release or so. > > Uri Herrera wrote: > Yeah, the shadows.. I was intending on having the shadows the same way > they're in the actual windows but I f

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

ther than vice-versa as it is now. > > Martin Klapetek wrote: > I agree with the icon. I feel like it's changing every release or so. > > Uri Herrera wrote: > Yeah, the shadows.. I was intending on having the shadows the same way > they're in the actual windows but I f

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

ther than vice-versa as it is now. > > Martin Klapetek wrote: > I agree with the icon. I feel like it's changing every release or so. > > Uri Herrera wrote: > Yeah, the shadows.. I was intending on having the shadows the same way > they're in the actual windows but I f

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

ther than vice-versa as it is now. > > Martin Klapetek wrote: > I agree with the icon. I feel like it's changing every release or so. > > Uri Herrera wrote: > Yeah, the shadows.. I was intending on having the shadows the same way > they're in the actual windows but I f

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

> On Oct. 9, 2015, 12:40 p.m., Kai Uwe Broulik wrote: > > Finally new sticky notes \o/ > > > > I'm a bit sad about the loss of shadows around widgets. Also, I liked > > Plasma's configure icon much better and wish that one was put into the > > Breeze theme rather than vice-versa as it is now.

Re: Review Request 125376: KNotification: don't update notification twice

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125376/#review86200 --- Ship it! Ship It! - Martin Klapetek On Sept. 24, 2015, 5

Re: Review Request 125395: Mutex around usage of m_connectedEvents which may be called from any thread

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125395/#review85928 --- +1, looks good! - Martin Klapetek On Sept. 25, 2015, 5:10

Re: Review Request 125376: KNotification: don't update notification twice

? Also, can you point me to the ktp code in question? Thanks src/knotification.cpp (lines 429 - 430) <https://git.reviewboard.kde.org/r/125376/#comment59290> {}s around ifs - Martin Klapetek On Sept. 24, 2015, 5:49 p.m., Igor Poboiko

Re: Review Request 125248: Display name of process which blocks umount / eject

idnotify.cpp (lines 149 - 150) <https://git.reviewboard.kde.org/r/125248/#comment59068> {}s (same in the other block) - Martin Klapetek On Sept. 15, 2015, 11:41 p.m., Igor Poboiko wrote: > > --- > This is

Re: Review Request 125248: Display name of process which blocks umount / eject

nction and then just call that function in both places Y - Martin Klapetek On Sept. 15, 2015, 10:50 p.m., Igor Poboiko wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 125200: Don't overflow action buttons in notification

to do with the width computation in the style, I'm not sure exactly, but my guess is line 115, the "Math.max(theme.mSize(theme.defaultFont).width*12, style.minimumWidth);". So does this fix the linked bug when you use Arial font? - Martin Klapetek On Sept. 12, 2015, 8:10 p.m., David R

Re: Review Request 125200: Don't overflow action buttons in notification

> On Sept. 12, 2015, 9:29 p.m., Martin Klapetek wrote: > > The text is elided in the Plasma button style, but it has to do with the > > width computation in the style, I'm not sure exactly, but my guess is line > > 115, the "Math.max(theme.mSize(t

Re: Review Request 125174: Plasma 5 Quicklaunch applet

and adding launchers in there? It seems like this applet would do exactly the same minus the task switching, so perhaps some portions of the code could be shared? - Martin Klapetek On Sept. 11, 2015, 9:48 p.m., David Rosca wrote

Re: Review Request 125135: show screenshots in the widget explorer

it > - hides the background > - uses correct size > - saves it with a standardized name > > Kickoff exposes another problem: some applets will need KWin help. Taking > the screenshot without a background won't work for them, though the > bac

Re: Review Request 125135: show screenshots in the widget explorer

it > - hides the background > - uses correct size > - saves it with a standardized name > > Kickoff exposes another problem: some applets will need KWin help. Taking > the screenshot without a background won't work for them, though the > bac

Re: Review Request 125135: show screenshots in the widget explorer

> On Sept. 10, 2015, 1:43 p.m., Kai Uwe Broulik wrote: > > First of all, I like the idea. > > > > However, I think we should go with PNG with alpha channel rather than > > having the Breeze default wallpaper there which changes every release. > > Showing a fully working Plasmoid is probably

Re: Review Request 125063: fix for Bug 260869

> On Sept. 9, 2015, 9:26 p.m., Martin Klapetek wrote: > > > > Martin Klapetek wrote: > Btw. do you have commit access? > > Raphael Kugelmann wrote: > I haven't tried it yet. > But I think I have no further access rights for the repo. > >

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

> On Sept. 9, 2015, 8:11 p.m., Martin Klapetek wrote: > > kcms/baloo/kcm.cpp, lines 174-177 > > <https://git.reviewboard.kde.org/r/125117/diff/1/?file=402363#file402363line174> > > > > This can also stay like it was, just do > > > >

Re: Review Request 125117: Moved check for all mount points excluded out of widget class

the result of that comparison. Or even return m_excludeFolders_FSW->excludeFolders().toSet() == mountPoints.toSet(); to simplify it completely. - Martin Klapetek On Sept. 9, 2015, 8:04 p.m., Ovidiu-Florin BOGDAN wrote: > > ---

Re: Review Request 125063: fix for Bug 260869

) <https://git.reviewboard.kde.org/r/125063/#comment58826> You might want to add that "open() opens the dialog modaly (ie. blocks the parent window)", it might be better understood why open - Martin Klapetek On Sept. 9, 2015, 9:09 p.m., Raphael

Re: Review Request 125063: fix for Bug 260869

> On Sept. 9, 2015, 9:26 p.m., Martin Klapetek wrote: > > Btw. do you have commit access? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125063/#re

Re: Review Request 125111: Change system settings toolbar

not being the last thing looks strange...? - Martin Klapetek On Sept. 9, 2015, 12:59 a.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 125111: Change system settings toolbar

> On Sept. 9, 2015, 1:08 a.m., Martin Klapetek wrote: > > +1 for the icon change, but I dunno, "Help" not being the last thing looks > > strange...? > > andreas kainz wrote: > Hi the help icon was changed yesterday in master (by me without > review

[Powerdevil] [Bug 352442] extremely slow response on brightness hotkeys

https://bugs.kde.org/show_bug.cgi?id=352442 Martin Klapetek <mklape...@kde.org> changed: What|Removed |Added Ever confirmed|0 |1

Re: Review Request 125105: Simplify getting associated apps list in AssociatedApplicationManager

ve it out. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125105/#review85017 --- On Sept. 8, 2015, 5:05 p.m.,

Re: Review Request 125105: Simplify getting associated apps list in AssociatedApplicationManager

marked as submitted. Review request for Plasma and David Faure. Changes --- Submitted with commit e07778d97bafffe503c00ad7de4a26cb1ae1e159 by Martin Klapetek to branch master. Repository: plasma-framework Description --- As per dfaure's comment in https://git.reviewboard.kde.org/r

Re: Review Request 123779: Include the mimetype itself when querying for KFileItemActions::associatedApplications

cally generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123779/#review84938 ------- On May 13, 2015, 7:05 p.m., Martin Klapetek wrote: > > --- > This is an

Review Request 125105: Simplify getting associated apps list in AssociatedApplicationManager

--- The original bug (https://bugs.kde.org/show_bug.cgi?id=340326) remains fixed with this. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125028: Monitor for the clock changes from the kernel

tps://git.reviewboard.kde.org/r/125028/#comment58770> Tiny nitpick - this include is not used when not Q_OS_LINUX, so probably should go to the ifdefd block below - Martin Klapetek On Sept. 7, 2015, 2:10 p.m., David Edmundson

Re: Review Request 125058: Cleanup and Add directories to index list

> On Sept. 5, 2015, 8:49 p.m., Vishesh Handa wrote: > > kcms/baloo/folderselectionwidget.cpp, line 373 > > > > > > `QStringLiteral` > > Ovidiu-Florin BOGDAN wrote: > I didn't change that part. > >

Re: Review Request 125028: Monitor for the clock changes from the kernel

TFD_NONBLOCK? To avoid blocking calls? - Martin Klapetek On Sept. 3, 2015, 11:36 a.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revi

Re: [plasma-framework] src/plasma: plasma: Fix applet actions might be nullptr

rash, I don't think it's the correct fix. It would certainly help if Leslie provided some explanation for this patch. Leslie? Can we also please ask to have patches submitted to reviewboard first? Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125029: Monitor timezone changing from timedated rather than our clock KCM

various files which timedate modifies and then sends that signal. Does ktimezoned not work in that case (it did when I last test it)? I think better place for this signal watcher would be in ktimezoned itself actually. - Martin Klapetek On Sept. 2, 2015, 12:33 p.m., David Edmundson wrote

Re: Review Request 125029: Monitor timezone changing from timedated rather than our clock KCM

> On Sept. 2, 2015, 4:35 p.m., Martin Klapetek wrote: > > But the ktimezoned should do exactly that; it monitors various files which > > timedate modifies and then sends that signal. Does ktimezoned not work in > > that case (it did when I last test it)?

Re: Plasma Mobile Design (a new attempt)

and iOS and make it more popular than the once already > available. > It should be something in and off itself unique, not unique because Plasma > Mobile doesn't have that kind off app - but rethinking the way we see > applications. > Yes to this. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124962: Fix CMAKE_INSTALL_LIBDIR not respecting installation prefix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124962/#review84650 --- Ship it! Ship It! - Martin Klapetek On Aug. 28, 2015, 9

Re: Review Request 124962: Fix CMAKE_INSTALL_LIBDIR not respecting installation prefix

On Aug. 28, 2015, 7:33 p.m., Martin Klapetek wrote: CMakeLists.txt, line 38 https://git.reviewboard.kde.org/r/124962/diff/1/?file=399442#file399442line38 Shouldn't this be ${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR} then? Also, are pam modules actually supported

Re: Review Request 124962: Fix CMAKE_INSTALL_LIBDIR not respecting installation prefix

/124962/#comment58516 Shouldn't this be ${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR} then? Also, are pam modules actually supported outside of the default dir (I have no clue)? - Martin Klapetek On Aug. 28, 2015, 9:39 a.m., Pinak Ahuja wrote

[Powerdevil] [Bug 350676] Need to press key twice to decrease brightness

https://bugs.kde.org/show_bug.cgi?id=350676 --- Comment #2 from Martin Klapetek mklape...@kde.org --- Max Screen Brightness for me says 100. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma

[Powerdevil] [Bug 350676] Need to press key twice to decrease brightness

https://bugs.kde.org/show_bug.cgi?id=350676 Martin Klapetek mklape...@kde.org changed: What|Removed |Added CC||mklape...@kde.org

Re: Review Request 124944: Fix a crash.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124944/#review84436 --- Ship it! Ship It! - Martin Klapetek On Aug. 27, 2015, 1

Re: Breeze-icons and Plasma Breeze-theme-icons

-breeze and Breeze-breeze? I'd like to think there shouldn't be one. Ideally the icons should be the same/similar in both Plasma and Breeze, that way you don't have to learn two different icons for the same thing. Cheers -- Martin Klapetek | KDE Developer

Re: Plasma 5.4 beta out now

-- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [kubuntu-devel] Re: git moves

-- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.4 branched

modules have been pushed to kdereview too close to the release. Fwiw, kwallet-pam does not have any i18n and will never have, it's just a pam module, so it has no user facing strings. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list

Re: Review Request 124634: Filter applets by formFactor

On Aug. 6, 2015, 1:51 p.m., Mark Gaiser wrote: applets/systemtray/plugin/protocols/plasmoid/plasmoidprotocol.cpp, line 153 https://git.reviewboard.kde.org/r/124634/diff/1/?file=390499#file390499line153 qCDebug perhaps? I would even throw it out altogether, it's useful while

[Breeze] [Bug 350500] Glassified Plasma theme has unreadable logout/reboot/poweroff dialog

https://bugs.kde.org/show_bug.cgi?id=350500 Martin Klapetek mklape...@kde.org changed: What|Removed |Added Summary|I can't read white text on |Glassified Plasma theme has

[Breeze] [Bug 350500] I can't read white text on white background.

https://bugs.kde.org/show_bug.cgi?id=350500 --- Comment #13 from Martin Klapetek mklape...@kde.org --- Unfortunately we do not control kde-look.org or its content, so there is nothing we can do about that. Sorry. (if you register/login to kde-look.org, you can open the author's profile

Re: Review Request 124453: [digital-clock] Provide a simple option for 24h clock

marked as submitted. Review request for Plasma and Thomas Pfeiffer. Changes --- Submitted with commit 1fc66aabb2e597fb4b2432a80d4acaa41f305197 by Martin Klapetek to branch master. Bugs: 345378 https://bugs.kde.org/show_bug.cgi?id=345378 Repository: plasma-workspace Description

Re: Review Request 123877: [digital-clock] Bring back font family option

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123877/#review83457 --- Ship it! Ship It! - Martin Klapetek On Aug. 3, 2015, 8:12

[Breeze] [Bug 350500] I can't read white text on white background.

https://bugs.kde.org/show_bug.cgi?id=350500 --- Comment #11 from Martin Klapetek mklape...@kde.org --- Ah ok. This looks like a problem of the Glassified theme. I would suggest contacting the author and asking him to update the theme for Plasma 5 (if he hasn't already). Can you confirm

Re: Review Request 124453: [digital-clock] Provide a simple option for 24h clock

--- On Aug. 3, 2015, 7:24 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124453

<    1   2   3   4   5   6   7   8   9   10   >