T8066: Fix Bug 390830 = Prevent indexing of Plasma vaults and other fuse filesystems

2018-03-16 Thread Michael Heidelbach
michaelh renamed this task from "Fix BUG:390830" to "Fix Bug 390830 = Prevent indexing of Plasma vaults and other fuse filesystems". TASK DETAIL https://phabricator.kde.org/T8066 To: michaelh Cc: nicolasfella, ivan, plasma-devel, alexeymin, michaelh, ashaposhnikov, astippich, spoorun

T8066: Fix BUG:390830

2018-03-16 Thread Michael Heidelbach
michaelh added a comment. General strategy: 1. Have a config with black- or white-listed filesystems (`fuse.*`) 2. Connect to Solid to receive a signal when `/etc/mtab` changes 3. On mounts add mountpoint to baloo's `excludedFolders` cache 4. On unmounts do nothing Status quo:

D10807: fileindexerconfig: Exclude Vaults by default

2018-03-09 Thread Michael Heidelbach
michaelh added a comment. In D10807#222173 , @rkflx wrote: > Did you already look at which approach Tracker uses regarding filesystems? Are they just indexing everything? Nope, good you reminded me. Made a note for myself T8066

T8066: Fix BUG:390830

2018-03-09 Thread Michael Heidelbach
michaelh added a comment. How does tracker handle file systems? TASK DETAIL https://phabricator.kde.org/T8066 To: michaelh Cc: nicolasfella, ivan, plasma-devel, alexeymin, michaelh, ashaposhnikov, spoorun

D10807: fileindexerconfig: Exclude Vaults by default

2018-03-09 Thread Michael Heidelbach
michaelh abandoned this revision. michaelh added a comment. Too naive approach REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham, #plasma Cc: rkflx, alexeymin, plasma-devel, ivan, nicolasfella, ashaposhnikov, michaelh,

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-25 Thread Michael Heidelbach
michaelh added a comment. In D10807#213250 , @rkflx wrote: > What about users who manually create and mount FUSE-type encrypted directories? Plasma Vault is just a nice interface for this workflow, after all. Good point. > A more

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Michael Heidelbach
michaelh added a comment. I was thinking in the same direction. When the mountpoint of a vault is changed (or new) a warning message about baloo's activity should be displayed. The message should be displayed regardless of baloo's enabled state. There's plenty of space for that in the

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Michael Heidelbach
michaelh added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham, #plasma Cc: plasma-devel, ivan,

D10623: INFORMATIONAL: Make plasma-workspace compile

2018-02-18 Thread Michael Heidelbach
michaelh abandoned this revision. michaelh added a comment. @apol: It compiles now. But something is strange. This is what I did for D10624 : `$ kdesrc-build plasma-workspace' did not compile `$ zypper si -d plasma-workspace` did not compile error

D10624: baloosearchrunner: Add 3 search types

2018-02-18 Thread Michael Heidelbach
This revision was automatically updated to reflect the committed changes. Closed by commit R120:de16179f0ded: baloosearchrunner: Add 3 search types (authored by michaelh). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10624?vs=27446=27447 REVISION

D10624: baloosearchrunner: Add 3 search types

2018-02-18 Thread Michael Heidelbach
michaelh created this revision. michaelh added a reviewer: Plasma: Workspaces. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. michaelh requested review of this revision. REVISION SUMMARY baloo can also handle the following types -

D10623: INFORMATIONAL: Make plasma-workspace compile

2018-02-18 Thread Michael Heidelbach
michaelh edited the summary of this revision. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10623 To: michaelh, #plasma, #plasma_workspaces Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10623: INFORMATIONAL: Make plasma-workspace compile

2018-02-18 Thread Michael Heidelbach
michaelh created this revision. michaelh added reviewers: Plasma, Plasma: Workspaces. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. michaelh requested review of this revision. REVISION SUMMARY This diff is purely informational.

D10079: [Draft] Port baloo krunner plugin to KDBusRunner

2018-02-17 Thread Michael Heidelbach
michaelh added inline comments. INLINE COMMENTS > baloosearchrunner.cpp:103 > +matchInternal(m_searchTerm, QStringLiteral("Video"), i18n("Video")); > +matchInternal(m_searchTerm, QStringLiteral("Folder"), i18n("Folder")); > +finishMatching(); Baloo can also handle these types -

D10316: [Folder View] Let Alt+Enter open properties dialog

2018-02-05 Thread Michael Heidelbach
michaelh added a comment. Confusion vanished. :-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10316 To: broulik, #plasma, hein Cc: michaelh, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10316: [Folder View] Let Alt+Enter open properties dialog

2018-02-05 Thread Michael Heidelbach
michaelh added a comment. I'm confused. On my system dolphin already behaves exactly like you described. What did I miss? I also observed when >1 items are selected on Ctrl+Return folders open in new tabs, files open in default application. Can be mixed. With 1 item selected there is no

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2018-01-08 Thread Michael Heidelbach
michaelh added a comment. Sorry, we were overlapping. I should have hit the update page link in the lower left. BTW: Mind to explain this "Restricted Application added a project:" to me? Please. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D4614

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2018-01-08 Thread Michael Heidelbach
michaelh added inline comments. INLINE COMMENTS > broulik wrote in baloofilepropertiesplugin.desktop:3 > I don't think this icon is visible in the UI anywhere, certainly not in the > properties dialog That's was also my first thought. Not sure, but it might appear in dolphin settings >

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2018-01-08 Thread Michael Heidelbach
michaelh added inline comments. INLINE COMMENTS > broulik wrote in baloofilepropertiesplugin.desktop:9 > The widget is primarily for showing additional file metadata (such as image > sizes), there's no such extra information for folders, so I chose not to show > it in this case. I tag and

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2018-01-08 Thread Michael Heidelbach
michaelh added inline comments. INLINE COMMENTS > baloofilepropertiesplugin.desktop:3 > +Type=Service > +Icon=baloo > +Name=File Meta Data Properties Page The baloo icon has a magnifying glass in it which is associated with searching. The tag-properties icon may be more appropriate. REPOSITORY

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2018-01-08 Thread Michael Heidelbach
michaelh added inline comments. INLINE COMMENTS > baloofilepropertiesplugin.desktop:9 > +X-KDE-ServiceTypes=KPropertiesDialog/Plugin > +MimeType=application/octet-stream MimeType=inode/directory;application/octet-stream ? REPOSITORY R824 Baloo Widgets REVISION DETAIL