T13927: Pop!_os style window tiling

gikari added a comment. Please, excuse me for shameless plug, but I am currently working on a "new" tiling script extension to KWin here . I've observed, that the other tiling extensions' development was stale over the year and decided to fork one of them

kde-gtk-config repository name change

to integrate GTK applications into the Plasma Desktop". What do people think of that change? Does anyone have any suggestions to improve the renaming? Best regards, Mikhail Zolotukhin

D29749: [GTK Integration] Deprecate GTK2 (Hide GUI)

gikari abandoned this revision. gikari added a comment. OK, let's wait a bit more until GIMP transitions. Still I would like to combine the GTK2 and GTK3 themes selection into one combobox or a list. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29749 To:

D29748: [GTK Integration] Deprecate GTK2 (Hide backend interface)

gikari abandoned this revision. gikari added a comment. See D29749 REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D29748 To: gikari, cblack, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

gikari abandoned this revision. gikari added a comment. https://invent.kde.org/plasma/kde-gtk-config/-/merge_requests/2 REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28623 To: gikari, #breeze, #plasma, cblack Cc: trmdi, ngraham, plasma-devel,

D26777: [App Style KCM] Port away from QDBusInterface

gikari abandoned this revision. gikari added a comment. I have a better idea of how to get rid of the dbus calls entirely in the future. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26777 To: gikari, #plasma Cc: apol, plasma-devel, Orage, LeGast00n,

D29749: [GTK Integration] Deprecate GTK2 (Hide GUI)

gikari added a comment. In D29749#671032 , @ngraham wrote: > 1. There's still GIMP (and IIRC Audacity) when it comes to major GTK2 apps. I'm not saying don't do this, but maybe it's a bit premature? Yes. That's why i only hide the UI.

D29749: [GTK Integration] Deprecate GTK2 (Hide GUI)

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Since Inkscape is finally moved to GTK3, it's time to start GTK2 deprecation process. What this does is just a hiding GUI for

D29748: [GTK Integration] Deprecate GTK2 (Hide backend interface)

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Since Inkscape is finally moved to GTK3, it's time to start GTK2 deprecation process. What this does is just a hiding direct

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

gikari added a comment. In D28623#666890 , @trmdi wrote: > Just a question, SierraBreezeEnhanced has a feature called "Unison hovering". Does this support it? Also, I think, that to support that you actually need to do a lot of upstream

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

gikari added a comment. In D28623#666890 , @trmdi wrote: > Just a question, SierraBreezeEnhanced has a feature called "Unison hovering". Does this support it? No. That's because it is the GTK, who is responsible for hovering behavior. I

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

gikari updated this revision to Diff 82365. gikari added a comment. - Add support for aurorae themes - Plastic does not work, but in that case decoration buttons in GTK apps are Breeze REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

gikari added a comment. In D28623#666400 , @cblack wrote: > While this is neat, I'm fairly sure that creating the CSS for this in a manner that works across themes is going to be hard if not impossible. I'm not completely sure about this

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

gikari updated this revision to Diff 82294. gikari added a comment. Export buttons with fixed geometry (Now all buttons are exported with the same size) REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28623?vs=82266=82294 BRANCH

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

gikari updated this revision to Diff 82266. gikari added a comment. Support the maximize button in the checked state REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28623?vs=82206=82266 BRANCH decorations-appearance (branched from

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

gikari updated this revision to Diff 82206. gikari added a comment. - Render buttons to SVGs REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28623?vs=82167=82206 BRANCH decorations-appearance (branched from master) REVISION DETAIL

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

gikari updated this revision to Diff 82167. gikari added a comment. - Make buttons work with Breeze theme by respecting pallete. REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28623?vs=82143=82167 BRANCH decorations-appearance

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

gikari updated this revision to Diff 82143. gikari edited the summary of this revision. gikari edited the test plan for this revision. gikari added a comment. - Use unique_ptr for buttons - Propagate events to buttons Things to do: - Figure out why does this only work with some

D29466: [applets/appmenu] Add search to global application menu

gikari added a comment. Is it possible to integrate the search into the help menu, if it exists already or create an entry for it. Much like macOS does. F8290151: Screenshot_20200506_214642.png REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

gikari updated this revision to Diff 82124. gikari added a comment. - Export decorations as png images Global things to do: - Export decorations in 3 different states: normal, clicked and hovered - Consider exporting in SVG - Write CSS into custom gtk css file REPOSITORY R99

D29176: [GTK Subpage] Hide Breeze Dark for GTK3

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fd6f3bacc91e: [GTK Subpage] Hide Breeze Dark for GTK3 (authored by gikari). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29176?vs=81166=81178 REVISION

D29176: [GTK Subpage] Hide Breeze Dark for GTK3

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Given, that Breeze GTK grabs its colors from color scheme and Breeze Dark doesn't do that creating by that confusion within the

D28072: [GTK Config] Apply color scheme to GTK3 applications

This revision was automatically updated to reflect the committed changes. Closed by commit R99:a5d4ddb3b1a2: [GTK Config] Apply color scheme to GTK3 applications (authored by gikari). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D28070: [KRDB] Remove GTK3 color export

This revision was automatically updated to reflect the committed changes. Closed by commit R119:23aeddc99ad6: [KRDB] Remove GTK3 color export (authored by gikari). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28070?vs=9=80165 REVISION DETAIL

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. So, is it ok to land? If so, approve please. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ndavis, ngraham, davidre, plasma-devel, Orage, LeGast00n,

D28658: [krdb] Drop GTK2 colour exporting

gikari resigned from this revision. gikari added a comment. No objections from me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28658 To: cblack, #plasma, ngraham, davidedmundson Cc: gikari, fvogt, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28658: [krdb] Drop GTK2 colour exporting

gikari added a comment. We also need to remove the remaining GTK stuff from here once D28070 and D28072 are landed. Does anyone else wants to test the later? INLINE COMMENTS > krdb.cpp:642 >// Export colors to

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. Hm, this is bizarre. I've tested once again and now the bug I mentioned before is gone. @ngraham Did you launch system settings (colors section) **after applying** D28070 to plasma-desktop? Without that patch it won't work

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. In D28072#638800 , @gikari wrote: > I also noticed a **dynamic** recoloration bug: it doesn't work if the app is launched with the color scheme, that it was using in the previous launch. To make it work I have to change

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. In D28072#643693 , @ngraham wrote: > Still doesn't work for me: > > gnome-chess --gtk-module /home/nate/kde/usr/lib64/gtk-3.0/modules/libcolorreload-gtk-module.so > Gtk-Message: 08:49:51.962: Failed to load

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

gikari updated this revision to Diff 79488. gikari added a comment. - Add missed Licence header - Remove unnecessary CMake commands REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28623?vs=79485=79488 BRANCH decorations-appearance

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Currently GTK applications with Client Side Decoration always use decorations from the respected GTK CSS theme. Because of CSS

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari updated this revision to Diff 79263. gikari added a comment. - Rebase on master REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28072?vs=78823=79263 BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. @ngraham Did you manage to load the recoloration module into the GTK app by one or another way? REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ngraham, davidre,

D27100: [GTK Config] Parameterise GTK config editing

This revision was automatically updated to reflect the committed changes. Closed by commit R99:0580098ab4cd: [GTK Config] Parameterise GTK config editing (authored by gikari). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D27100: [GTK Config] Parameterise GTK config editing

gikari updated this revision to Diff 79089. gikari marked 2 inline comments as done. gikari added a comment. - Remove `explicit` QVariant wrappers REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27100?vs=77909=79089 BRANCH

D27100: [GTK Config] Parameterise GTK config editing

gikari added a comment. Ping REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27100 To: gikari, #plasma, cblack Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf,

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. In D28072#638514 , @ngraham wrote: > Same error about not being able to find the module. Sorry for not being clear. Does the specified path contain (`/home/nate/kde/usr/lib64/gtk-3.0/`) `modules` directory with

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. In D28072#638356 , @ngraham wrote: > The path would be `/home/nate/kde/usr/lib64/gtk-3.0/` on my system, but nonetheless there is no effect. :( Is the GTK application throwing the same error, that the module is

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. In D28072#638170 , @ngraham wrote: > Hmm, when following those instructions, I get the following console error: > > Gtk-Message: 08:50:13.086: Failed to load module "colorreload-gtk-module" > > > And the color

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. In D28072#638173 , @cblack wrote: > GTK™ isn't too fond of trying to load stuff from outside the standard directories. How can this be fixed? REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari updated this revision to Diff 78823. gikari marked an inline comment as done. gikari added a comment. - Rebase on master - Add recoloration module check REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28072?vs=77860=78823 BRANCH

D28360: cmake: make xsettingsd check an option

gikari added a comment. In D28360#636687 , @kossebau wrote: > Edit: and yes, I agree CMake has awful flaws here when it comes to our needs to properly communicate dependencies to fellow developers & packagers. I am trying to give you best

D28086: Improve CMake handling of GNOME libraries

gikari added a comment. Everything is fine on CI. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28086 To: cblack, #plasma, gikari, apol Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D28360: cmake: make xsettingsd check an option

gikari added a comment. In D28360#636610 , @kossebau wrote: > Edit: The proposed solution to make it simply required only forces packagers to add that and all what it pulls in as build-time dependency to their package creation, even if not

D28360: cmake: make xsettingsd check an option

gikari added a comment. In D28360#636435 , @eszlari wrote: > In D28360#636418 , @gikari wrote: > > > But the option is enabled by default and needs to be explicitly disabled. This seems to be an

D28360: cmake: make xsettingsd check an option

gikari added a comment. But the option is enabled by default and needs to be explicitly disabled. This seems to be an overengineered solution. It basically says, that XSettingsd is an optional dependency, which already is. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

D28360: cmake: make xsettingsd check an option

gikari added a comment. In D28360#636404 , @eszlari wrote: > I would like to have this in 5.18 We cannot add mandatory dependencies to the stable branches/releases. Currently it's an optional dependency. If you want to make it mandatory,

D28360: cmake: make xsettingsd check an option

gikari added a comment. Why just not make xsettingsd required? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28360 To: eszlari, gikari Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari added inline comments. INLINE COMMENTS > CMakeLists.txt:1 > +include(GNUInstallDirs) > + May be this could be moved to parent CMakeLists with other includes? REPOSITORY R99 KDE Gtk Configuration Tool BRANCH arcpatch-D28076 REVISION DETAIL https://phabricator.kde.org/D28076 To:

D28086: Improve CMake handling of GNOME libraries

gikari accepted this revision. gikari added a comment. This revision is now accepted and ready to land. Ok, let's keep our eyes on CI now. Everything should be fine, since the dependencies didn't change. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH arcpatch-D28086 REVISION DETAIL

D28086: Improve CMake handling of GNOME libraries

gikari added inline comments. INLINE COMMENTS > CMakeLists.txt:22 > +pkg_check_modules(GIO REQUIRED IMPORTED_TARGET gio-2.0) > +pkg_check_modules(giomm REQUIRED IMPORTED_TARGET giomm-2.4) > + If I understand correctly this line is redundant. > CMakeLists.txt:7 >

D28086: Improve CMake handling of GNOME libraries

gikari added a comment. See https://invent.kde.org/sysadmin/ci-tooling/-/merge_requests/49 for possible resolution REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28086 To: cblack, #plasma, gikari, apol Cc: apol, plasma-devel, Orage, LeGast00n,

D28086: Improve CMake handling of GNOME libraries

gikari added a comment. This has been reverted. @cblack, please take a look at what has happened. Seems like CI is missing some dependency. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

D27100: [GTK Config] Parameterise GTK config editing

gikari updated this revision to Diff 77909. gikari added a comment. Rebase on master REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27100?vs=77185=77909 BRANCH parameterise-gtk-config-io (branched from master) REVISION DETAIL

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari added inline comments. INLINE COMMENTS > CMakeLists.txt:3 > + > +enable_language(C) > + Why is this needed? Aren't the CMake default languages in project (parent CMakeLists) both `CXX` and `C`? > reloader.c:35 > +__attribute__((visibility("default"))) void gtk_module_init(gint *argc,

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

gikari updated this revision to Diff 77860. gikari edited the summary of this revision. gikari added a comment. - Remove the recolor module. It is D28076 now REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. In D28072#629441 , @cblack wrote: > In D28072#629439 , @gikari wrote: > > > > You simply test the recolouration like how it's been up until now—restart the applications. >

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. > You simply test the recolouration like how it's been up until now—restart the applications. It doesn't work. This is what I was talking about: > It seems like it applies randomly whenever the GTK app would like to update the colors, but with that module

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

gikari planned changes to this revision. gikari added a comment. - I should add the recoloration module to autoload with GTK applications In D28072#629422 , @cblack wrote: > The GTK+ module shouldn't be in this patch, as it and the functions

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

gikari updated this revision to Diff 77855. gikari added a comment. - Rebase on master - Add recoloration module REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28072?vs=77723=77855 BRANCH set-colors REVISION DETAIL

D28086: Improve CMake handling of GNOME libraries

gikari accepted this revision. gikari added a comment. This revision is now accepted and ready to land. Fine. It builds. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH better-gtk-glib-etc-usage (branched from master) REVISION DETAIL https://phabricator.kde.org/D28086 To: cblack,

D28086: Improve CMake handling of GNOME libraries

gikari requested changes to this revision. gikari added a comment. This revision now requires changes to proceed. I reverted the commits ( R99:306e01d86ab9a891ec70219802ce01572b0d4025 and

D28086: Improve CMake handling of GNOME libraries

gikari added a comment. It builds, but why aren't you using that stuff inside of `FingGTK3.cmake` module? It actually uses it inside already, but with some bugs, that prevents from building last patch. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH better-gtk-glib-etc-usage (branched

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari added a comment. I tried to change these ones to `GTK3_LIBRARY` and `GLIB2_LIBRARY`, but now it throws this: /home/gikari/kde/src/kde-gtk-config/color-reload-module/reloader.c:37: undefined reference to `g_type_check_instance_cast' INLINE COMMENTS > CMakeLists.txt:10 > +

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari added a comment. Seems like I've made a mistake. This does not build. /home/gikari/kde/src/kde-gtk-config/color-reload-module/reloader.c:21:10: fatal error: gtk/gtk.h: No such file or directory 21 | #include | ^~ REPOSITORY R99 KDE Gtk Configuration

D28070: [KRDB] Remove GTK3 color export

gikari updated this revision to Diff 9. gikari added a comment. Fix "forgetting to pull local master" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28070?vs=7=9 BRANCH remove-gtk3-color-export-from-krdb (branched from master)

D28070: [KRDB] Remove GTK3 color export

gikari updated this revision to Diff 7. gikari added a comment. Diff against master REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28070?vs=6=7 BRANCH remove-gtk3-color-export-from-krdb (branched from master) REVISION DETAIL

D28070: [KRDB] Remove GTK3 color export

gikari updated this revision to Diff 6. gikari added a comment. Rebase on master REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28070?vs=77720=6 BRANCH remove-gtk3-color-export-from-krdb (branched from master) REVISION DETAIL

D27100: [GTK Config] Parameterise GTK config editing

gikari added a comment. Ping REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27100 To: gikari, #plasma, cblack Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf,

D27957: [GTK Config] Port all settings to KConfigWatcher

This revision was automatically updated to reflect the committed changes. Closed by commit R99:702607595599: [GTK Config] Port all settings to KConfigWatcher (authored by gikari). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D27956: [Various KCMs] Notify about changes in GTK related settings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:eede3025c84b: [Various KCMs] Notify about changes in GTK related settings (authored by gikari). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

This revision was automatically updated to reflect the committed changes. Closed by commit R99:a581035b3f47: [GTK Config] Construct font style by hand instead of relying on Qt function (authored by gikari). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari added a comment. > GTK needs to be configured to load the GTK module `colorreload-gtk-module`. You mean we need to add `gtk-modules=colorreload-gtk-module` to settings.ini? And how to add this module to autoload in Wayland? REPOSITORY R99 KDE Gtk Configuration Tool

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari added inline comments. INLINE COMMENTS > CMakeLists.txt:3 > set(PROJECT_VERSION "5.17.80") > -cmake_minimum_required(VERSION 2.8.12) > +cmake_minimum_required (VERSION 3.4) > Extra space REPOSITORY R99 KDE Gtk Configuration Tool BRANCH color-reload-module (branched from master)

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari accepted this revision. gikari added a comment. This revision is now accepted and ready to land. Nice! Does it need to be manually passed to GTK apps when testing D28072 ? REPOSITORY R99 KDE Gtk Configuration Tool BRANCH color-reload-module

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari added inline comments. INLINE COMMENTS > CMakeLists.txt:1 > +project(libcolorreload C) > + Why is this needed? > CMakeLists.txt:3 > + > +find_package(PkgConfig REQUIRED) > +include(GNUInstallDirs) Move to parent CMakeLists.txt > CMakeLists.txt:4 > +find_package(PkgConfig REQUIRED) >

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari added inline comments. INLINE COMMENTS > CMakeLists.txt:9 > + > +add_library( > +colorreload-gtk-module SHARED add_library(colorreload-gtk-module SHARED reloader.c ) > CMakeLists.txt:14 > + > +target_link_libraries( > +colorreload-gtk-module PRIVATE Sorry, this is a

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari requested changes to this revision. gikari added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:1 > +cmake_minimum_required ( VERSION 3.14 ) > +project ( libcolorreload C ) Would you mind setting this at the parent CMakeLists.txt? >

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

gikari added inline comments. INLINE COMMENTS > configeditor.cpp:107 > +modifyColorsCssFile(colorsDefinitions); > +// FIXME Find a way to update colors on the fly > +} Also, I would like to move D24275 to kde-gtk-config repo too with autoloading the

D28072: [WIP][GTK Config] Apply color scheme to GTK3 application

gikari created this revision. gikari added a reviewer: cblack. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Move from krdb (see D28070 ) with some refactorings.

D28070: [KRDB] Remove GTK3 color export

gikari created this revision. gikari added a reviewer: cblack. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY This will be moved to kde-gtk-config module, once ready. REPOSITORY R119 Plasma Desktop BRANCH

D25324: [GTK Config] Add XSettingsd as a runtime dependency

gikari closed this revision. gikari added a comment. https://phabricator.kde.org/R99:b6e7c6f056740e936adc94b7a843f6448f6830ab REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D25324 To: gikari, #plasma, cblack, apol, jgrulich, ngraham Cc: cfeck,

D27957: [GTK Config] Port all settings to KConfigWatcher

gikari updated this revision to Diff 77320. gikari added a comment. - Add forgotten toolbar style REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27957?vs=77317=77320 BRANCH port-all-to-kconfigwatcher (branched from master) REVISION

D27107: [GTK Config] Remove redundant reparse configuration call

gikari abandoned this revision. gikari added a comment. In favor of D27957 REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27107 To: gikari, #plasma Cc: davidedmundson, plasma-devel, Orage, LeGast00n,

D27957: [GTK Config] Port all settings to KConfigWatcher

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Also remove redundant reparse configuration calls and change the ways of reading some settings accordingly. Depend on: D27956

D27956: [Various KCMs] Notify about changes in GTK related settings

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Also save colors before saving colorScheme name, so that we can correctly use heuristic in GTK Config, after the moment we know,

D27943: [Gtk Config] Port cursor theme sync to KConfigWatcher

This revision was automatically updated to reflect the committed changes. Closed by commit R99:715e497d94b9: [Gtk Config] Port cursor theme sync to KConfigWatcher (authored by gikari). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D27942: [Cursors KCM] Notify about cursor change

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1fb3c36496cf: [Cursors KCM] Notify about cursor change (authored by gikari). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27942?vs=77275=77303 REVISION

D27943: [Gtk Config] Port fonts sync to KConfigWatcher

gikari updated this revision to Diff 77293. gikari marked an inline comment as done. gikari added a comment. Update function name REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27943?vs=77276=77293 BRANCH cursors-to-config-watcher

D27943: [Gtk Config] Port fonts sync to KConfigWatcher

gikari added inline comments. INLINE COMMENTS > ngraham wrote in gtkconfig.h:89 > `onKcmInputSettingsChange` (capitalize the I in Input) > > Maybe also capitalize KCM? > > Or maybe call it `onCursorSettingsChange` This name comes from configuration file name and this function (theoretically)

D27943: [Gtk Config] Port fonts sync to KConfigWatcher

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Port from deprecated dbus signal to KConfigWatcher. Depends on: D27942 TEST PLAN 1.

D27942: [Cursors KCM] Notify about cursor change

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Notify all users of `KConfigWatcher` about cursor theme change. REPOSITORY R119 Plasma Desktop BRANCH

D27107: [GTK Config] Remove redundant reparse configuration call

gikari added a comment. Ping! After D27904 this should be working. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27107 To: gikari, #plasma Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D26777: [App Style KCM] Port away from QDBusInterface

gikari added a comment. Ping! Do I sound reasonable? Any suggestions how can it be simplified without depending on `kde-gtk-config`? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26777 To: gikari, #plasma Cc: apol, plasma-devel, Orage, LeGast00n,

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

gikari added a comment. Ping! Does it work for everybody? For me everything is OK. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27380 To: gikari, #plasma, ervin, bport, meven, davidedmundson Cc: chauvin, davidre, davidedmundson, cfeck, ngraham,

D25324: [GTK Config] Add XSettingsd as a runtime dependency

gikari added a comment. Ok. So, can I land it or should I wait for other reviewers? Also, should I make the dependency `REQUIRED` or leave it optional? REPOSITORY R99 KDE Gtk Configuration Tool BRANCH xsettingsd-dependency (branched from master) REVISION DETAIL

D25324: [GTK Config] Add XSettingsd as a runtime dependency

gikari added a comment. In D25324#624229 , @eszlari wrote: > This bug is not fixed by this patch. `xsettingsd` needs to be started in `plasma-workspace/startkde/startplasma.cpp` (or by systemd in the future). `xsettingsd` is started by

D25324: [GTK Config] Add XSettingsd as a runtime dependency

gikari added a comment. Ping! REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D25324 To: gikari, #plasma, cblack, apol, jgrulich Cc: eszlari, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27100: [GTK Config] Parameterise GTK config editing

gikari updated this revision to Diff 77185. gikari added a comment. Use `arg` instead of + + + + + + REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27100?vs=74855=77185 BRANCH parameterise-gtk-config-io (branched from master) REVISION

  1   2   3   >