D7648: Fix ksysguard not starting on plasmoid click

2017-09-07 Thread Mladen Milinkovic
maxrd2 added a comment. In https://phabricator.kde.org/D7648#142638, @davidedmundson wrote: > Thanks, but do you know why the apps datasource doesn't have that entry after a while? I've managed to get some more insight into original problem. It seems that after some system updat

Adding existing project to KDE incubator

2017-09-04 Thread Mladen Milinkovic
Hi everyone, am looking into adding a project i develop/maintain (https://github.com/maxrd2/subtitlecomposer) into KDE incubator. Have read through wiki on incubator and whole process and it says this: > Candidate >  - provide description of the project to be incubated >  - must include the peop

D7648: Fix ksysguard not starting on plasmoid click

2017-09-03 Thread Mladen Milinkovic
maxrd2 added a comment. I don't have full developer account so i can't land this one. It also needs https://phabricator.kde.org/D7676 for this to work. REPOSITORY R114 Plasma Addons BRANCH launch-change REVISION DETAIL https://phabricator.kde.org/D7648 To: maxrd2, #plasma, davidedmun

D7648: Fix ksysguard not starting on plasmoid click

2017-09-03 Thread Mladen Milinkovic
maxrd2 added a dependency: D7676: Added openService() method to KRunProxy. REPOSITORY R114 Plasma Addons BRANCH launch-change REVISION DETAIL https://phabricator.kde.org/D7648 To: maxrd2, #plasma, davidedmundson Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai

D7648: Fix ksysguard not starting on plasmoid click

2017-09-03 Thread Mladen Milinkovic
maxrd2 added a comment. There it goes... updated the qml and added KRunProxy changes here: https://phabricator.kde.org/D7676 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D7648 To: maxrd2, #plasma Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwo

D7648: Fix ksysguard not starting on plasmoid click

2017-09-03 Thread Mladen Milinkovic
maxrd2 updated this revision to Diff 19136. maxrd2 added a comment. Plasmoid uses KRun::openService() to launch ksysguard REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7648?vs=19134&id=19136 BRANCH launch-change REVISION DETAIL https://phabrica

D7648: Fix ksysguard not starting on plasmoid click

2017-09-03 Thread Mladen Milinkovic
maxrd2 updated this revision to Diff 19134. maxrd2 edited the summary of this revision. maxrd2 added a comment. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. Added KRun::openService() method REPOSITORY R296 KDeclarative CHANGES SI

D7648: Fix ksysguard not starting on plasmoid click

2017-09-03 Thread Mladen Milinkovic
maxrd2 added a comment. Also seems KService::serviceByName() was removed from KF5.. so it's ok just to re-add it? https://github.com/KDE/kservice/blob/master/src/services/kservice.h REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D7648 To: maxrd2, #plasma Cc:

D7648: Fix ksysguard not starting on plasmoid click

2017-09-03 Thread Mladen Milinkovic
maxrd2 added a comment. Great will make those changes/additions then. Do you know why was KService::serviceByName() deprecated in KDE 4? (https://api.kde.org/4.x-api/kdelibs-apidocs/kdecore/html/classKService.html#a2c5b00fd381b9843b6ba99da692c90ae) REPOSITORY R114 Plasma Addons REVISION

D7648: Fix ksysguard not starting on plasmoid click

2017-09-03 Thread Mladen Milinkovic
maxrd2 removed a reviewer: sars. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D7648 To: maxrd2, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7648: Fix ksysguard not starting on plasmoid click

2017-09-03 Thread Mladen Milinkovic
maxrd2 added a comment. Am not sure why apps.data["org.kde.ksysguard.desktop"] becomes undefined. Think it might be a bug in PlasmaCore.DataSource? I haven't noticed any log messages apart that TypeError. Will try to see if sourceDisconnected/Removed is signaled at some point. It will

D7648: Fix ksysguard not starting on plasmoid click

2017-09-03 Thread Mladen Milinkovic
maxrd2 added a reviewer: sars. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D7648 To: maxrd2, #plasma, sars Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7648: Fix ksysguard not starting on plasmoid click

2017-09-01 Thread Mladen Milinkovic
maxrd2 created this revision. maxrd2 added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY After plasmoid has been running for some time (several hours, maybe days), clicking it would produce error: "file:///usr/share/plasma/plasmoids/org.kde.plas