D13148: Allow Kirigami build without KWin tablet mode dependency

2018-05-31 Thread Murillo Bernardes
murillobernardes added a comment. Sorry, first time contributing to kde-related project. I’m not sure what I need to do next? Send a pull request somewhere? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13148 To: murillobernardes, mart, davidedmundson Cc:

D13148: Allow Kirigami build without KWin tablet mode dependency

2018-05-29 Thread Murillo Bernardes
murillobernardes updated this revision to Diff 35133. murillobernardes added a comment. Update based on your comments. The MacOS elif is the same as the else, so I removed. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13148?vs=35049=35133 REVISION

D13148: Allow Kirigami build without KWin tablet mode dependency

2018-05-28 Thread Murillo Bernardes
murillobernardes updated this revision to Diff 35049. murillobernardes added a comment. Add option to disable dbus dependency (build time). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13148?vs=34970=35049 REVISION DETAIL

D13148: Allow Kirigami build without KWin tablet mode dependency

2018-05-28 Thread Murillo Bernardes
murillobernardes added a comment. In D13148#269556 , @mart wrote: > In D13148#269233 , @murillobernardes wrote: > > > I did not patch CMakeLists.txt because I can't test it. I could not get a

D13148: Allow Kirigami build without KWin tablet mode dependency

2018-05-27 Thread Murillo Bernardes
murillobernardes added a comment. In D13148#269205 , @davidedmundson wrote: > This doesn't achieve anything useful. It does for projects that have their own build system. > You're not changing any dependencies as you still link

D13148: Allow Kirigami build without KWin tablet mode dependency

2018-05-27 Thread Murillo Bernardes
murillobernardes created this revision. murillobernardes added a reviewer: mart. murillobernardes added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. murillobernardes requested review of this revision. REVISION SUMMARY Even on linux it might be the case to not