D27282: [Applet]Correct raise max volume functions for mic

This revision was automatically updated to reflect the committed changes. Closed by commit R115:06e9e3eebf18: [Applet]Correct raise max volume functions for mic (authored by gvgeo, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D27205: [Applet]Always get valid device and stream name

This revision was automatically updated to reflect the committed changes. Closed by commit R115:830bded4d30b: [Applet]Always get valid device and stream name (authored by gvgeo, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D27469: Made a new variable called 'baseSize' for use by both itemSize value possibilities

ngraham added a comment. Seems like this was created by accident. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27469 To: The-Feren-OS-Dev Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D26660: [Applets/Task Manager] Fix and improve behavior tab layouts

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c32b5a85cae6: [Applets/Task Manager] Fix and improve behavior tab layouts (authored by gvgeo, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27453: [Applet]Update toolbar's checkbox spacing

This revision was automatically updated to reflect the committed changes. Closed by commit R116:88b8ce5e50b7: [Applet]Update toolbars checkbox spacing (authored by gvgeo, committed by ngraham). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D27391: [Applet]Fix dimensions of traffic Monitor

This revision was automatically updated to reflect the committed changes. Closed by commit R116:4ca1e7e34fd6: [Applet]Fix dimensions of traffic Monitor (authored by gvgeo, committed by ngraham). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D27391: [Applet]Fix dimensions of traffic Monitor

ngraham accepted this revision. ngraham added a comment. LGTM! REPOSITORY R116 Plasma Network Management Applet BRANCH monitor (branched from master) REVISION DETAIL https://phabricator.kde.org/D27391 To: gvgeo, #plasma, #vdg, jgrulich, ngraham Cc: ngraham, broulik, plasma-devel,

D27199: [Applet]Update layout based on T10470

ngraham added a comment. In D27199#612689 , @jgrulich wrote: > This is probably not related to the UI, it might be issue in the internals. Can you open a bug for it? Ideally if you can restart plasmashell and enable plasma-nm debug Will

D27393: [Applet]Fix details layout.

This revision was automatically updated to reflect the committed changes. Closed by commit R116:2efaecee8874: [Applet]Fix details layout. (authored by gvgeo, committed by ngraham). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D27392: [Applet]Add info messages.

This revision was automatically updated to reflect the committed changes. Closed by commit R116:387609d10ac7: [Applet]Add info messages. (authored by gvgeo, committed by ngraham). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D27424: Add missing cursors for Chromium-based apps

ngraham added a comment. Landed for Plasma 5.18.1! Very nice patch. May it be the first of many! :) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27424 To: guilhermesilva, #breeze, broulik, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27424: Add missing cursors for Chromium-based apps

This revision was automatically updated to reflect the committed changes. Closed by commit R31:3944c5f74d04: Add missing cursors for Chromium-based apps (authored by guilhermesilva, committed by ngraham). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

ngraham added inline comments. INLINE COMMENTS > main.qml:44 > property bool vertical: plasmoid.formFactor === PlasmaCore.Types.Vertical > -readonly property int itemSize: > units.roundToIconSize(Math.min(Math.min(width, height), >

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

ngraham added inline comments. INLINE COMMENTS > main.qml:47 > +// Set the tray items' clickable areas on the panel to be bigger > than normal to allow for easier touchability > +return units.roundToIconSize(Math.min(Math.min(width, height), >

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

ngraham added inline comments. INLINE COMMENTS > CMakeLists.txt:1 > +cmake_minimum_required ( VERSION 3.14 ) > +project ( libcolorreload C ) As noticed by @The-Feren-OS-Dev, this is too high. REPOSITORY R98 Breeze for Gtk BRANCH arcpatch-D24275_1 REVISION DETAIL

D27438: Increase System Tray Plasmoid spacing value slightly

ngraham added a comment. https://community.kde.org/Infrastructure/Phabricator#Marking_patches_as_dependent_on_other_patches It would probably be simplest do just do this though: 1. Abandon this patch 2. Submit a patch to refactor that logic to use a nested multi-line function for

D27438: Increase System Tray Plasmoid spacing value slightly

ngraham added a comment. This should probably be two patches at this point: one to increase the spacing when using tablet mode (which IMO is an uncontroversial no-brainer) and another to increase the spacing when in desktop mode. INLINE COMMENTS > main.qml:45 > +// If

D27407: Breeze widgetStyle value is Breeze

ngraham added a comment. Separate commit is probably fine, but if this lands on the stable branch, it should come soon. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27407 To: crossi, ervin, bport, meven, mart, davidedmundson, ngraham Cc: ngraham,

D27449: [applets/mediacontroller] Fix Playback button icon sizes

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Same as D27260 . Following D27396

D24375: [kcms/colors] Generate colored GTK2 assets based off of user's colorscheme

ngraham added a comment. Can you update the text plan with detailed instructions for how to make this work? It is not working for me, and with no such text plan, I don't know why. REPOSITORY R119 Plasma Desktop BRANCH colors-kcm-recolor-gtk2 (branched from master) REVISION DETAIL

D24324: [GTK2] Add program to libexec for GTK2 recoloration

ngraham added a comment. The program is created non-executable, FYI. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24324 To: cblack, #breeze Cc: ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27448: [kcms/feedback] Improve default kcmshell window size

This revision was automatically updated to reflect the committed changes. Closed by commit R120:285155fad1f3: [kcms/feedback] Improve default kcmshell window size (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27448: [kcms/feedback] Improve default kcmshell window size

ngraham added a comment. In D27448#612644 , @apol wrote: > Okay. > > I wonder if we should be launching systemsettings rather than kcmshell... Please place relevant thoughts and opinions in

D27448: [kcms/feedback] Improve default kcmshell window size

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 417747 FIXED-IN: 5.18.1 TEST PLAN Better default size when showing the most info:

D26813: Have user-manager write to SDDM's new config file

ngraham added a comment. +1, we can to the refactoring on master. REPOSITORY R128 User Manager BRANCH write-autologin-right (branched from master) REVISION DETAIL https://phabricator.kde.org/D26813 To: filipf, #plasma, davidedmundson, ngraham Cc: plasma-devel, Orage, LeGast00n,

D27391: [Applet]Fix dimensions of traffic Monitor

ngraham added inline comments. INLINE COMMENTS > TrafficMonitor.qml:64 > top: parent.top > -topMargin: units.gridUnit > +topMargin: Math.round(labels.labelHeight / 2) > } We could probably just use a smaller predefined unit, like `largeSpacing`,

D27438: Increase System Tray Plasmoid spacing value slightly

ngraham accepted this revision as: ngraham. ngraham added a comment. Hopefully people won't murder us over one pixel. :) IMO time to finish the bikeshedding if VDG people are happy with it and everyone else can tolerate it. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D27438: Increase System Tray Plasmoid spacing value slightly

ngraham added a comment. 2*0.7 rounded down is going to be 1. Just divide `units.smallSpacing` by two if you want 1. But then I have to wonder... is it really worth it to add one pixel of spacing? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

ngraham added a comment. Also, it's like to have the "after" versions right after each corresponding "before" version so you can more easily compare them by clicking on one and navigating between them with the arrow keys. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL

D27442: fix(kcm): Use explicit Kirigami.Units over singleton from a theme

ngraham added a comment. More generally, should we be porting towards `Kirigami.Units` everywhere? REPOSITORY R104 KScreen BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D27442 To: davidedmundson, #plasma, apol Cc: ngraham, plasma-devel, Orage, LeGast00n,

D27189: Created a top area based on widgets/toparea.svg

ngraham added a comment. Can you submit the patch that adds `widgets/toparea` so I can play around with this here? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27189 To: niccolove, #vdg, #plasma, ngraham Cc: ngraham, ndavis, plasma-devel, Orage,

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

ngraham resigned from this revision. ngraham added a comment. I have a vertical panel and use large tray icons but intentionally minimize their number, and the result looks fine to me IMO: F8107338: Screenshot_20200216_115030.png However I'll admit

D27422: [KCM]Update Device item layout based on applet

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Don't use PlasmaComponents in KCMs; it's for Applets and other elements of the Plasma shell itself. Kirigami is the correct choice for a KCM. REPOSITORY R115 Plasma Audio

D27438: Set System Tray Plasmoid spacing value from 0 to 3

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.qml:290 > id: tasksRow > -spacing: 0 > +spacing: 3 > height: parent.height - (vertical && expander.visible ? >

D26111: Runner: make recentdocument use KActivityStats data

ngraham accepted this revision. ngraham added a comment. Works for me with documents on my samba share. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26111 To: meven, #plasma, ivan, ngraham, broulik Cc: broulik, plasma-devel, Orage, LeGast00n,

D27420: [Applet]Improvements for unavailable port.

ngraham added inline comments. INLINE COMMENTS > gvgeo wrote in ListItemBase.qml:357 > I wanted to do this change, but this is old code from 5.17. I believe that > translated history must exist, and will automatically be used. Better to change it now to avoid the string puzzle entirely IMO

D27436: Use task rather than tabs

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This is more semantically correct and a visual improvement IMO. Looks fine to me with Breeze dark and light but we should probably wait for confirmation from heavy Breeze Dark users.

D27420: [Applet]Improvements for unavailable port.

ngraham added a comment. Or has the code diverged between 5.18 and master too much? REPOSITORY R115 Plasma Audio Volume Applet BRANCH freeThePort (branched from master) REVISION DETAIL https://phabricator.kde.org/D27420 To: gvgeo, #plasma, drosca, ngraham Cc: plasma-devel, Orage,

D27420: [Applet]Improvements for unavailable port.

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. That's a clever fix. Very nice how it solves the reporter's problem without changing the UI at all for everyone else who doesn't need it. No regressions found in testing. What do

D27424: Add missing cursors for Chromium-based apps

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks for the patch! Hope the process wasn't too tough to get through for the first time. LGTM! @broulik, does this look good to you too? REPOSITORY R31 Breeze BRANCH

D27422: [KCM]Always allow port selection

ngraham added a comment. In D27422#612019 , @gvgeo wrote: > If default button can leave, personally I would prefer this layout (ignore the margins). > F8105190: Screenshot_20200215_173638.png > And

D27346: emojier: Improve resizing performance

ngraham added a comment. What's the status of this? Is it ready? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27346 To: apol, #plasma Cc: ngraham, Zren, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D26726: [Breeze Cursors] Add some more cursor names

ngraham added a comment. Thanks! Our documentation can be found at: - https://community.kde.org/Get_Involved/development (setting up a development environment) - https://community.kde.org/Infrastructure/Phabricator (submitting the patch) If you run into trouble, feel free to ask

D27418: Don't let the Advanced tab's spacers expand all they want

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. `dont-stretch-it` REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH dont-stretch-it (branched from master) REVISION DETAIL https://phabricator.kde.org/D27418 To: filipf,

D27418: Don't let the Advanced tab's spacers expand all they want

ngraham added a comment. probably stable branch REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH dont-stretch-it (branched from master) REVISION DETAIL https://phabricator.kde.org/D27418 To: filipf, #vdg, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27088: [applets/SystemTray] Implement sorting in the model

ngraham accepted this revision. ngraham added a subscriber: mart. ngraham added a comment. This revision is now accepted and ready to land. LGTM but let's make sure one of our model experts (@davidedmundson, @broulik, @mart) gets a chance to make sure I'm not smoking crack by approving this.

D26726: [Breeze Cursors] Add some more cursor names

ngraham added a comment. In D26726#610446 , @guilhermesilva wrote: > Hello, > > I'm the person the reported this issue to the Chromium team. The fix they made will probably

D27407: Breeze widgetStyle value is Breeze

ngraham added a comment. Could we maybe ship a kconfig update script to change the string in the config file for people who don't ever change their global theme? Or is the problem moot because the global theme gets automatically applied on upgrade or something? REPOSITORY R120 Plasma

D27402: Make it possible to change the sorting when searching

ngraham added a comment. I'm on Tumbleweed and everything is up to date, but hmm, I see that libappstream is still at 0.12.7, not 0.12.10, the current release. I wonder why that is. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D27402 To: apol,

D27402: Make it possible to change the sorting when searching

ngraham added a comment. Being able to sort search results in different ways is a nice feature for sure. But the desire for it arises from dissatisfaction with the default "relevance" search results. We might want to still do this, but the pressure for it could be reduced if the relevance

D27407: Breeze widgetStyle value is Breeze

ngraham added a comment. So this is clearly a correct fix, but I'm not sure it's sufficient to fully resolve 417515. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27407 To: crossi, ervin, bport, meven, mart, davidedmundson Cc: ngraham, plasma-devel,

D27407: Breeze widgetStyle value is Breeze

ngraham added a comment. This doesn't fix the problem for me until I actually apply a Global Theme. Until I do that, the current widget style remaing un-highlighted in the Style KCM. It does fix the issue for that use case though. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D27393: [Applet]Fix details layout.

ngraham added a comment. Might be nice to port to `ColumnLayout` while we're at it REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27393 To: gvgeo, #plasma, #vdg, jgrulich Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n,

D27392: [Applet]Add info messages.

ngraham added a comment. Both labels should have `enabled: false` set to lighten the text in a consistent way. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27392 To: gvgeo, #plasma, #vdg, jgrulich Cc: ngraham, broulik, plasma-devel,

D27199: [Applet]Update layout based on T10470

ngraham added a comment. In D27199#611308 , @gvgeo wrote: > I made 3 smaller patches, to decrease this patch's size. D27391 D27392 D27393

D27394: [applets/notes] Only show configure button when focussed

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. stable branch? REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27394 To: davidedmundson, #plasma, ngraham Cc: ngraham, plasma-devel,

D27402: Make it possible to change the sorting when searching

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. When you switch from relevance to something else, that entry *disappears entirely* from the menu! That's rather odd. You should be able to return to sorting by relevance if you

D27398: [desktoppackage] Fix layout when an applet has no custom config modules

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. In D27398#611564 , @davidedmundson wrote: > >> This patch fixes the issue, but I do still see the sidebar > > I meant to phrase that

D27397: Align name displayed for wayland session with sddm

ngraham added a comment. Didn't this just get fixed with D27358 ? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D27397 To: meven, ervin, crossi, bport Cc: ngraham, plasma-devel, Orage, LeGast00n,

D27260: [applets/systemtray] Set pin button's size correctly

ngraham added a comment. In D27260#611545 , @davidedmundson wrote: > It still sounds like you're saying "we've just made a breaking change in frameworks " I mean... yeah. :/ It's kind of a lousy situation since the Frameworks change

D27398: [desktoppackage] Fix layout when an applet has no custom config modules

ngraham added a comment. This patch fixes the issue, but I do still see the sidebar with only one category in it: F8103697: Screenshot_20200214_073711.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27398 To:

D27260: [applets/systemtray] Set pin button's size correctly

ngraham added a subscriber: mart. ngraham added a comment. @mart, @davidedmundson So the PC3 ToolButton change just went in anyway via D27396 . So we now need to fix this somehow or else it'll be mega broken looking. If we fix it by landing this patch

D27386: Set toolbox to invisble when it's invisible

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice find! Fixes the bug and makes sense to me. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D27386 To: davidedmundson, #plasma,

D27380: [GTK Config] Write Font without style name

ngraham added a comment. *groan* I guess we need to fix it Qt then. I don't know much about fonts but maybe it could display the localized string in the UI but write an un-localized version to the config file? Would that work? And then maybe we can somehow finally fix

D27381: [sidebar] Resolve changes in module before switching

ngraham accepted this revision. ngraham added a comment. ^^ same REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D27381 To: davidedmundson, #plasma, bport, ngraham Cc: ngraham, bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27380: [GTK Config] Write Font without style name

ngraham added a comment. In D27380#611146 , @gikari wrote: > In D27380#611132 , @ngraham wrote: > > > Is the problem that the style name is already localized by the time we get it from the Fonts

D27360: Go back to saving to sddm.conf

ngraham added a comment. Maybe @davidedmundson can help you fix it so we don't need to revert stuff? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D27360 To: filipf, davidedmundson, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n,

D27358: Sync ("Wayland") appending to match SDDM

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Wasn't this something that SDDM was going to stop doing in its next release? REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH master REVISION DETAIL

D27380: [GTK Config] Write Font without style name

ngraham added a comment. In D27380#611031 , @IlyaBizyaev wrote: > I don't understand the problem in-depth, but isn't it possible to write non-localized style name instead? Indeed. Is the problem that the style name is already

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

ngraham added a comment. I was not able to reproduce the issue, but this patch causes no regressions for me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27384 To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson, The-Feren-OS-Dev

D27199: [Applet]Update layout based on T10470

ngraham added a comment. Can reproduce; it's consistent. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D27199: [Applet]Update layout based on T10470

ngraham added a comment. Hmm, now I see my currently connected network twice: F8100139: Screenshot_20200212_131124.png REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma,

D26861: [Applet/Task Manager] Move audio indicator to the corner

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a35d2b9adf40: [Applet/Task Manager] Move audio indicator to the corner (authored by gvgeo, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26861: [Applet/Task Manager] Move audio indicator to the corner

ngraham added a comment. Landing on master to be safe, but if Plasma people take a look later and like what they see, we can backport this to the stable branch. REPOSITORY R119 Plasma Desktop BRANCH pos2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26861 To:

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham added a comment. Hmm, in this case it doesn't seem appropriate to me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson Cc: mmustac, davidedmundson, astippich, plasma-devel, hurikhan77,

D26861: [Applet/Task Manager] Move audio indicator to the corner

ngraham added a comment. No response, assuming that means it's good. :) REPOSITORY R119 Plasma Desktop BRANCH pos2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26861 To: gvgeo, #vdg, #plasma, hein, ngraham Cc: broulik, Fuchs, ndavis, filipf, cblack,

D27344: [Notifications] Only let details label grow, never shrink

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ah, this was mildly annoying me recently. Nice fix. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27344 To: broulik, #plasma, ngraham Cc: ngraham,

D27348: Port to use level 1 Heading instead of Title

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY `PlasmaExtras.Title` is literally identical to a level 1 Heading. Let's port to that so we

D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

ngraham added a comment. Thanks! Companion changes: plasma-framework: a9ea008b8d6fab00fdeee029e685a9fc3b4061c8 kwidgetsaddons: 2157e258721be0c81477b2e305e6d697cafb597d

D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

This revision was automatically updated to reflect the committed changes. Closed by commit R169:fc8c0fc8cd50: [RFC] Reduce size of Level 1 headings and increase left padding on page titles (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham added a comment. That turned out to be an unrelated Baloo bug that was recently fixed by D27326 . This is ready for re-review. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To: ngraham, #vdg, #plasma,

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham updated this revision to Diff 75508. ngraham added a comment. Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25447?vs=73775=75508 BRANCH suspend-and-resume-and-monitor-indexing-from-the-kcm (branched from master) REVISION DETAIL

D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

ngraham added a comment. @mart ping REPOSITORY R169 Kirigami BRANCH smaller-and-more-left-padded-page-titles (branched from master) REVISION DETAIL https://phabricator.kde.org/D27198 To: ngraham, #vdg, #kirigami, manueljlin, mart Cc: alexde, ahiemstra, plasma-devel, fbampaloukas,

D27271: [kcms/colors] RFC: Accent Colours

ngraham added a comment. Looks like plasma doesn't respect the accent color. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27271 To: cblack, #plasma, #vdg Cc: ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus,

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ExpandedRepresentation.qml:261 > +} > +PlasmaExtras.Heading { // Song Album > +color:

D27282: [Applet]Correct raise max volume functions for mic

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Everyone else good with this? REPOSITORY R115 Plasma Audio Volume Applet BRANCH mic (branched from master) REVISION DETAIL https://phabricator.kde.org/D27282 To: gvgeo, #plasma,

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

ngraham added a comment. Overall looks much better I think! However the minimum height seems to be a bit tall now: F8098822: Screenshot_20200211_203232.png Also I have a hard time putting my finger on why, but somehow the scrubber not filling the

D27199: [Applet]Update layout based on T10470

ngraham added a comment. Pretty nice. If the list items are no longer going to have a selection highlight but still open up/unfold when single-clicked, then the cursor should change to a pointing hand when hovering over them. REPOSITORY R116 Plasma Network Management Applet REVISION

D27337: [Emojier] Optimize performance

ngraham added reviewers: apol, Plasma. ngraham added a comment. Very nice. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27337 To: Zren, apol, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D27078: Drag-and-drop files at the right coordinates

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, nice fix. #plasma folks, y'all good with this? 5.18 branch? REVISION DETAIL https://phabricator.kde.org/D27078 To:

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

ngraham added a comment. That's better, though I dunno, I can't shake the feeling that the album art is still too compressed: F8098251: Screenshot_20200211_113432.png Maybe I'm just being crotchety though. #VDG

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Okay, seeing this in action, I don't hate it. However I feel like my concern with the album art being squeezed too much is valid: F8098196: Screenshot_20200211_104708.png

D27325: improve some previously recycled strings

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. In that case, with kio-fuse, "Mounted shares" is probably more accurate and just fine. REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL

D27325: improve some previously recycled strings

ngraham added a comment. "Accessed shares"? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D27325 To: sitter, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin,

D27303: [applets/taskmanager] Add a bit more padding around album/artist info in tooltip

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7a0c4f86530f: [applets/taskmanager] Add a bit more padding around album/artist info in tooltip (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27316: [Folder view]Make shadow scale aware

ngraham added a comment. Oh gosh, are shadows not scale-aware anywhere? We'd have to replicate this code in a lot of places... might it make more sense to fix this in Qt itself? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27316 To: gvgeo, #plasma Cc:

D27261: [Folder view] Fix binding loop on width

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6b1cc98f0959: [Folder view] Fix binding loop on width (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27261?vs=75470=75471 REVISION

D27261: [Folder view] Fix binding loop on width

ngraham updated this revision to Diff 75470. ngraham added a comment. One more REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27261?vs=75469=75470 BRANCH fix-folderview-binding-loop (branched from master) REVISION DETAIL

D27261: [Folder view] Fix binding loop on width

ngraham updated this revision to Diff 75469. ngraham added a comment. Use identical margins; don't change the visuals at all (should be done in another patch if necessary) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27261?vs=75427=75469 BRANCH

D27261: [Folder view] Fix binding loop on width

ngraham updated this revision to Diff 75427. ngraham added a comment. Re-add margins, and also add missing bottomMargin REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27261?vs=75285=75427 BRANCH fix-folderview-binding-loop (branched from master)

<    7   8   9   10   11   12   13   14   15   16   >