D15418: Dim application icon when it is not playing anything

ngraham added a comment. @broulik Ping. :) REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15418 To: broulik, #plasma, #vdg Cc: gvgeo, squeakypancakes, meven, mart, svenmauch, acrouthamel, abetts, ngraham, plasma-devel, Orage, LeGast00n,

D26574: [Applet]Hide hamburger menu when empty

This revision was automatically updated to reflect the committed changes. Closed by commit R115:10ab204a62cf: [Applet]Hide hamburger menu when empty (authored by gvgeo, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D26418: [Applet]Add global mute function

This revision was automatically updated to reflect the committed changes. Closed by commit R115:681e1c8faaaf: [Applet]Add global mute function (authored by gvgeo, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D26256: [Applet] Make 'raise maximum volume' global

This revision was automatically updated to reflect the committed changes. Closed by commit R115:d0c753c188e8: [Applet] Make raise maximum volume global (authored by gvgeo, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D26271: [Applet]Update layout based on T10470

This revision was automatically updated to reflect the committed changes. Closed by commit R115:8ada15ad8e5b: [Applet]Update layout based on T10470 (authored by gvgeo, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D27047: Make the api docs reflect that Kirigami is not only a mobile toolkit

ngraham added a comment. In D27047#604091 , @apol wrote: > We made an effort to not use "convergence", as it seems like it's hard to understand. How about "adaptable"? +1, that's a better word. REPOSITORY R169 Kirigami REVISION

D27061: replace samba module with data that works

ngraham added reviewers: Localization, Plasma, VDG. ngraham added a comment. Very nice. Looks much better and seems to work quite well. While we're already breaking proposing breaking the string freeze, instead of "Exports" and "Imports", how about "Exported Shares" and "Mounted shares"

D27041: fix incorrect parsing of "at foo.so" and empty function name

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice find. REPOSITORY R871 DrKonqi BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D27041 To: sitter, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n,

D27045: [wallpapers] Use more high-quality JPEGs for Next

ngraham added a comment. Agreed. Perhaps for the next contest, we should explicitly require that the 5K version be under 6 MB, and provide a few recommendations for how to achieve this. REPOSITORY R31 Breeze BRANCH more-hq-next (branched from master) REVISION DETAIL

D27045: [wallpapers] Use more high-quality JPEGs for Next

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Noticeably less JPEG-compression-artifacty. If this lands, make sure it's on the `Plasma/5.18` branch. REPOSITORY R31 Breeze BRANCH more-hq-next (branched from master) REVISION

D26640: [applets/weather] Port weather station picker to QQC2+ListView

This revision was automatically updated to reflect the committed changes. Closed by commit R114:8861250b2e47: [applets/weather] Port weather station picker to QQC2+ListView (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D26845: [context menu] Remove last traces of "Lock Widgets" action from UI

This revision was automatically updated to reflect the committed changes. Closed by commit R120:66940389d66b: [context menu] Remove last traces of Lock Widgets action from UI (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26882: [Applets/Folder] Re-arrange positioning of "Arrange in" and "Align" submenus

This revision was automatically updated to reflect the committed changes. Closed by commit R119:37a8d5945ec7: [Applets/Folder] Re-arrange positioning of Arrange in and Align submenus (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26884: [Folder View] Fix text label color in pop-up

This revision was automatically updated to reflect the committed changes. Closed by commit R119:78eccc8bda2c: [Folder View] Fix text label color in pop-up (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26884?vs=74274=74703

D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line

ngraham updated this revision to Diff 74702. ngraham added a comment. "Battery may be damaged" -> "Not charging" (it's more accurate) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=73554=74702 BRANCH arcpatch-D24070 REVISION DETAIL

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

ngraham added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27019 To: meven, #plasma, broulik, ngraham, ervin Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin,

D27027: Clip the flickable parent item

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yeah the cut-off is a pre-existing issue. This fixes the visual issue I've been seeing with the System Tray configuration view and the Notifications KCM's applications list. +1.

D26739: [applets/Task Manager] Refine tooltip highlight effect

ngraham added a comment. Nice find. Fixed in 093e2d917ff386e627a062f3337c9ff23294e95c . Hopefully that's done it! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26739 To:

D26739: [applets/Task Manager] Refine tooltip highlight effect

ngraham added a comment. Argh, now I can see it too: F8008546: weird margin.webm No idea what's causing this. The code seems conceptually right to me. Maybe something's getting rounded up instead of down or something. REPOSITORY R119 Plasma

D26889: Change notification button text to "View Updates"

This revision was automatically updated to reflect the committed changes. Closed by commit R134:7126e11498ac: Change notification button text to View Updates (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D24070: [WIP] Don't use toolTipMainText to show info, rather use the second line

ngraham added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: ngraham, #vdg, #plasma, ndavis, mthw Cc: GB_2, ndavis, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot,

D26640: [applets/weather] Port weather station picker to QQC2+ListView

ngraham added a comment. Ping. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D26640 To: ngraham, #vdg, #plasma, broulik Cc: fvogt, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin,

D26845: [context menu] Remove last traces of "Lock Widgets" action from UI

ngraham added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26845 To: ngraham, mart, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D26882: [Applets/Folder] Re-arrange positioning of "Arrange in" and "Align" submenus

ngraham added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26882 To: ngraham, hein, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D26884: [Folder View] Fix text label color in pop-up

ngraham added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26884 To: ngraham, #vdg, #plasma, hein, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D26271: [Applet]Update layout based on T10470

ngraham added a comment. I applied the patches in this series and tested and went through the code again and everything looks good to me. Shall we start landing them for 5.19? We can always tweak things later; there's loads of time before the next release. REPOSITORY R115 Plasma Audio

D26972: Work around an issue with changing the wallpaper's filetype

ngraham added a comment. I didn't have the cache patch installed, but I probably forgot to delete the wallpapers from one of the several on-disk locations where they live. :/ reverted in bfe2152c5ef73e9f5b7ad03313f3a4ccef440a22

D21225: set the wallpaper when applying look and feel

ngraham added a comment. I have a feeling we'll get user complaints and bug reports if we unconditionally reset the wallpaper when applying a global theme. Before we do this, I think we need to add a mechanism to allow the user to choose which parts get applied, per the discussion in

D26842: Fix fonts KCM button state

ngraham added a comment. We are getting duplicates of https://bugs.kde.org/show_bug.cgi?id=416358, so I guess it would be nice if this made it into 5.18. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26842 To: bport, #plasma, ervin, crossi, meven Cc:

D26977: Fix setting of initial passwords for new users

ngraham added a comment. Oh gosh, every time someone touches that KCM to fix a bug, it breaks something else. :/ It's so fragile. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D26977 To: davidedmundson, #plasma, meven Cc: ngraham, plasma-devel, Orage,

D26739: [applets/Task Manager] Refine tooltip highlight effect

This revision was automatically updated to reflect the committed changes. Closed by commit R119:84182a554588: [applets/Task Manager] Refine tooltip highlight effect (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26972: Work around an issue with changing the wallpaper's filetype

This revision was automatically updated to reflect the committed changes. Closed by commit R31:8f4ea0a93ffb: Work around an issue with changing the wallpapers filetype (authored by ngraham). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26972?vs=74527=74530

D26972: Work around an issue with changing the wallpaper's filetype

ngraham created this revision. ngraham added reviewers: davidedmundson, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Because of the issue described in T12611 ,

D26954: Add Ice Cold wallpaper

This revision was automatically updated to reflect the committed changes. Closed by commit R131:7a69dcc37c93: Add Ice Cold wallpaper (authored by ngraham). REPOSITORY R131 Plasma Wallpapers CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26954?vs=74463=74521 REVISION DETAIL

D26953: Replace Ice Cold with Volna for Plasma 5.18

This revision was automatically updated to reflect the committed changes. Closed by commit R31:e920200e29bb: Replace Ice Cold with Volna for Plasma 5.18 (authored by ngraham). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26953?vs=74510=74520 REVISION DETAIL

D26953: Replace Ice Cold with Volna for Plasma 5.18

ngraham added a comment. VDG folks approved in the chatroom; landing it! REPOSITORY R31 Breeze BRANCH icecold-to-volna (branched from Plasma/5.18) REVISION DETAIL https://phabricator.kde.org/D26953 To: ngraham, #vdg, #plasma, davidedmundson Cc: raveomelette, IlyaBizyaev, Luwx,

D26946: Changed leftMargins to smallSpacing to be consistent

ngraham added a comment. What I care about is that the margins are consistent and things are properly left-aligned by default. That is to say, nothing should have to override the default margins to have everything perfectly aligned. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D26953: Replace Ice Cold with Volna for Plasma 5.18

ngraham added a subscriber: IlyaBizyaev. ngraham added a comment. @IlyaBizyaev suggested using the MozJPEG encoder at https://squoosh.app/ and the results are fantastic. I can detect no difference in appearance whatsoever from normal viewing distances (i.e. not zoomed in to 500%) and the

D26953: Replace Ice Cold with Volna for Plasma 5.18

ngraham updated this revision to Diff 74510. ngraham added a comment. This revision is now accepted and ready to land. Replace those lousy dithered PNGs with JPEGs created using the MozJPEG encoder at https://squoosh.app REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE

D26665: Switch to KNSQuick for getting new wallpapers

ngraham added a comment. In D26665#601715 , @leinir wrote: > In D26665#601713 , @IlyaBizyaev wrote: > > > What about the "Get New Plugins" button in the same dialog? It still uses the old style.

D26965: [Emojier] Copy Emoji also into selection clipboard

ngraham added a comment. Now could we just blindly send a middle-click event after you select an emoji to have it paste the emoji into the focused text field, if any? >:D REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26965 To: broulik, #plasma, apol Cc:

D26739: [applets/Task Manager] Refine tooltip highlight effect

ngraham added a comment. In D26739#601762 , @trmdi wrote: > Not yet looked at the code carefully, but I feel the top margin and the bottom one of the thumbnail are not identical. With the latest iteration of the patch, they should be.

D26739: [applets/Task Manager] Refine tooltip highlight effect

ngraham updated this revision to Diff 74475. ngraham added a comment. Correct comment; last change now :) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26739?vs=74474=74475 BRANCH tooltip-highlights-take-2 (branched from master) REVISION DETAIL

D26739: [applets/Task Manager] Refine tooltip highlight effect

ngraham updated this revision to Diff 74474. ngraham added a comment. Fix that and also make the code simpler and more sensible REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26739?vs=74465=74474 BRANCH tooltip-highlights-take-2 (branched from

D26953: Replace Ice Cold with Volna for Plasma 5.18

ngraham planned changes to this revision. ngraham added a comment. That's a good point. I'll try a high-quality-level JPEG and see how that looks. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26953 To: ngraham, #vdg, #plasma, davidedmundson Cc: Luwx, ndavis,

D26953: Replace Ice Cold with Volna for Plasma 5.18

ngraham updated this revision to Diff 74466. ngraham added a comment. Use https://www.imagesmaller.com/ to reduce total size to 22 Mb REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26953?vs=74461=74466 BRANCH icecold-to-volna (branched from Plasma/5.18)

D26739: [applets/Task Manager] Refine tooltip highlight effect

ngraham updated this revision to Diff 74465. ngraham added a comment. Tweak pixels once more and add explanatory comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26739?vs=74464=74465 BRANCH tooltip-highlights-take-2 (branched from master)

D26739: [applets/Task Manager] Refine tooltip highlight effect

ngraham updated this revision to Diff 74464. ngraham added a comment. That is nicer; let's do that instead REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26739?vs=74183=74464 BRANCH tooltip-highlights-take-2 (branched from master) REVISION

D26954: Add Ice Cold wallpaper

ngraham updated this revision to Diff 74463. ngraham added a comment. Actually add it lol REPOSITORY R131 Plasma Wallpapers CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26954?vs=74462=74463 BRANCH add-icecold (branched from Plasma/5.18) REVISION DETAIL

D26954: Add Ice Cold wallpaper

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Per tradition, we add the previous Plasma version's wallpaper to this repo when it gets

D26953: Replace Ice Cold with Volna for Plasma 5.18

ngraham added a comment. Outstanding concern: The full collection is much larger than Ice Cold; 46 Mb compared to 13 Mb for all the Ice Cold versions. The author already did some optimization, but everything is still quite a bit larger in total. Is there anyone in #VDG

D26953: Replace Ice Cold with Volna for Plasma 5.18

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Volna won the wallpaper competition, so time to add it to Breeze as the new default! TEST

D26924: [SystemTray] Remove scrolbar paddings

ngraham added a comment. No worries! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26924 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham, nicolasfella Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26947: Drop kconf_update module, handled by kde-gtk-config now

ngraham added a comment. 5.18 I suppose? REPOSITORY R98 Breeze for Gtk BRANCH nokconf_update REVISION DETAIL https://phabricator.kde.org/D26947 To: fvogt, #plasma, gikari, davidedmundson Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas,

D26945: Added smallSpacing to leftMargin

ngraham added a comment. Hmm, it almost seems like the header in the popup is over too far to the right, and we should fix that (and maybe increase the default margins in the theme: D21813 ) rather than adding extra margins in every plasmoid. REPOSITORY

D26946: Changed leftMargins to smallSpacing to be consistent

ngraham added a comment. Hmm, it almost seems like the header in the popup is over too far to the right, and we should fix that (and maybe increase the default margins in the theme: D21813 ) rather than adding extra margins in every plasmoid. REPOSITORY

D26941: [Task Manager] Remove strict URL handling

ngraham added a comment. Works for me with all my use cases. I think this makes sense to go into 5.18.0 with enough testing (so thanks for the new unit test!). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26941 To: broulik, #plasma, hein Cc: ngraham,

D26924: [SystemTray] Remove scrolbar paddings

ngraham added a comment. The scrollbar changes are in 5.18; shouldn't this go to the stable branch instead of master-only? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26924 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson,

D25273: Enable selecting all installed color schemes in Cuttlefish

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Bad combobox width strikes again (https://bugs.kde.org/show_bug.cgi?id=403153), worsened by adding an icon: F7939162: Screenshot_20200124_204922.PNG

D26902: Fix systemsettings5 crash if kscreenlocker shortcut is empty

ngraham added a comment. Wasn't this already fixed with D26772 ? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D26902 To: ahmadsamir, #plasma, davidedmundson, mart Cc: ngraham, plasma-devel, Orage, LeGast00n,

D26902: Fix systemsettings5 crash if kscreenlocker shortcut is empty

ngraham added a comment. Ah, looks like it landed on the stable branch but was never merged to master. Just did that. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D26902 To: ahmadsamir, #plasma, davidedmundson, mart Cc: ngraham, plasma-devel, Orage,

D26861: [Applet/Task Manager] Move audio indicator to the corner

ngraham accepted this revision. ngraham added a comment. Yeah, it won't be perfect for everything, but I think it's better than what we have right now and fixes the bug. Is everyone okay with this? REPOSITORY R119 Plasma Desktop BRANCH pos2 (branched from master) REVISION DETAIL

D26896: Kill the KinfoCenter binary

ngraham added a comment. In D26896#600258 , @broulik wrote: > Would it make sense to keep a `kinfocenter` script that just launchers `systemsettings5 -i` for compat? > Does it still show up if you type "kinfocenter" into KRunner, not sure if

D26889: Change notification button text to "View Updates"

ngraham created this revision. ngraham added reviewers: VDG, Discover Software Store, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This is more accurate; "Update" inaccurately implies that updates will

D26884: [Folder View] Fix text label color in pop-up

ngraham created this revision. ngraham added reviewers: VDG, Plasma, hein, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Currently there's a top-level ColorScope that is almost entirely unused

D26861: [Applet/Task Manager] Move audio indicator to the corner

ngraham added a comment. In D26861#599957 , @Fuchs wrote: > - Icon wise, given that it can still overlap with the app icon, I would prefer something that has a contrasting border, so e.g. a dark audio indicator is still visible on a dark app

D26806: [Applets/Power Manager] Update layout based on T10470

ngraham added a comment. Thanks! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26806 To: gvgeo, #plasma, #vdg, davidedmundson Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26806: [Applets/Power Manager] Update layout based on T10470

ngraham added a reviewer: manueljlin. ngraham added a comment. Looking pretty good to me, UI-wise. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26806 To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin Cc: broulik, ngraham, manueljlin, davidedmundson,

D26882: [Applets/Folder] Re-arrange positioning of "Arrange in" and "Align" submenus

ngraham created this revision. ngraham added reviewers: hein, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Move the "Arrange in" and "Align" submenus below "Sort by" and "Icon size", which are more

D26880: [Task Manager] Draw audio icon highlight effect behind the icon, not in front of it

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM but let's wait for a #plasma review too to make sure this is the most technically correct way (I think it is but I'm not 100% sure).

D26881: [Applets/Folder View] Allow using a folder that ends with a space

ngraham created this revision. ngraham added reviewers: hein, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY `QUrl::fromLocalFile` is otherwise appropriate but automatically strips a trailing space,

D26806: [Applets/Power Manager] Update layout based on T10470

ngraham added inline comments. INLINE COMMENTS > PopupDialog.qml:76 > +visible: inhibitions.length > 0 > +iconSource: inhibitions.length > 0 ? inhibitions[0].Icon > || "" : "" > +text: { The icon is a bit small: F7923036:

D26861: [Applet/Task Manager] Move audio indicator to the corner

ngraham accepted this revision. ngraham added subscribers: cblack, filipf, ndavis, Fuchs, broulik. ngraham added a comment. This revision is now accepted and ready to land. I was working on a patch to improve things here and it was almost identical to this one. I think this is a good fix.

D26866: [Kickoff] Theme separators

ngraham added a comment. No objection. REPOSITORY R119 Plasma Desktop BRANCH themed-kickoff-separators (branched from master) REVISION DETAIL https://phabricator.kde.org/D26866 To: filipf, #plasma, #vdg, davidedmundson, ngraham Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n,

D26709: add gpu entry to about system

ngraham added a comment. Maybe the label should say "Graphics:" or "Graphics Processor" instead of using an acronym. We say "Memory" instead of "RAM" after all. REPOSITORY R102 KInfoCenter BRANCH gpu REVISION DETAIL https://phabricator.kde.org/D26709 To: sitter, davidedmundson Cc:

D26866: [Kickoff] Theme separators

ngraham accepted this revision. ngraham added a comment. Makes sense now. Let's land this and then fix the separator in another patch. REPOSITORY R119 Plasma Desktop BRANCH themed-kickoff-separators (branched from master) REVISION DETAIL https://phabricator.kde.org/D26866 To: filipf,

D26866: [Kickoff] Theme separators

ngraham added a comment. When using the Breeze style, the blue selection line no longer touches the separator line: F796: Screenshot_20200123_073450.png F7922231: Screenshot_20200123_073540.PNG

D26739: [applets/Task Manager] Refine tooltip highlight effect

ngraham added a comment. Hmm, I can't get that to happen on my machine. :/ REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26739 To: ngraham, #plasma, #vdg, filipf Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26640: [applets/weather] Port weather station picker to QQC2+ListView

ngraham updated this revision to Diff 74184. ngraham marked 5 inline comments as done. ngraham added a comment. More review comments REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26640?vs=73780=74184 BRANCH port-to-listview-in-scrollview

D26739: [applets/Task Manager] Refine tooltip highlight effect

ngraham updated this revision to Diff 74183. ngraham added a comment. Fix the margins for the window thumbnail too REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26739?vs=74180=74183 BRANCH tooltip-highlights-take-2 (branched from master)

D26739: [applets/Task Manager] Refine tooltip highlight effect

ngraham updated this revision to Diff 74180. ngraham added a comment. Fix the rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26739?vs=74179=74180 BRANCH tooltip-highlights-take-2 (branched from master) REVISION DETAIL

D26739: [applets/Task Manager] Refine tooltip highlight effect

ngraham updated this revision to Diff 74179. ngraham added a comment. Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26739?vs=73984=74179 BRANCH refine-tooltip-highlight-effects (branched from Plasma/5.18) REVISION DETAIL

D26806: [Applets/Power Manager] Update layout based on T10470

ngraham added a comment. Is there anything stopping a port away from the FlowLayout and using a GridLayout, or even just using one Rowlayout per row, all stuck in a ColumnLayout? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26806 To: gvgeo, #plasma,

D26849: Reorder Relevance of runner result

ngraham added a comment. This makes perfect sense to me. See also https://bugs.kde.org/show_bug.cgi?id=359627. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26849 To: meven, #plasma, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D26824: Consider empty email valid

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R128 User Manager BRANCH arcpatch-D26824 REVISION DETAIL https://phabricator.kde.org/D26824 To: meven, #plasma, ngraham Cc: plasma-devel, Orage, LeGast00n,

D26844: Warn user when changing selected user about potential data loss

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Lovely. I could have sworn we had a bug report about this, but I can't find it now. Regardless, nice fix. REPOSITORY R128 User Manager BRANCH arcpatch-D26844 REVISION DETAIL

D26844: Warn user when changing selected user about potential data loss

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > accountinfo.cpp:108 > +if (!m_infoToSave.isEmpty()) { > +if (KMessageBox::questionYesNo(this,i18n("You modified the > current user, do want to

D26824: Consider empty email valid

ngraham added inline comments. INLINE COMMENTS > accountinfo.cpp:364 > if (email.isEmpty()) { > -return false; > +return true; > } This seems like the only part of the patch that's actually about fixing the issue. The rest seems to be unrelated code cleanup that

D26845: [context menu] Remove last traces of "Lock Widgets" action from UI

ngraham created this revision. ngraham added reviewers: mart, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY In Plasma, 5.18, this ishn't a user-facing option anymore. It's still visible in the

D26806: [Applets/Power Manager] Update layout based on T10470

ngraham added subscribers: manueljlin, ngraham. ngraham added a comment. Nice! Couple of UI comments: - The icons are now blurry, presumably because the plasma theme doesn't supply versions for the size you're using. I would recommend increasing the size until you find a size that

D26842: Fix fonts KCM button state

ngraham added inline comments. INLINE COMMENTS > fontssettings.kcfg:77 >QFont windowTitleFont = QFont("Noto Sans", 10); > + windowTitleFont.setStyleName("Regular"); >#endif Won't this worsen https://bugs.kde.org/show_bug.cgi?id=378523? REPOSITORY R119 Plasma Desktop

D26824: Consider empty email valid, warn user when changing selected user about potential data loss

ngraham added a comment. Can't go in 5.18 because you added a new string. That part would need to go on master. So either this whole thing goes on master, or the bug gets fixed in 5.18 and the new messagebox goes on master. REPOSITORY R128 User Manager REVISION DETAIL

D26825: Bind gtk-enable-animations setting to global animation speed slider

ngraham added a comment. +1 for putting this in 5.18 once @gikari thinks it's ready. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D26825 To: broulik, #plasma, gikari Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

ngraham updated this revision to Diff 74052. ngraham marked an inline comment as done. ngraham added a comment. Use `setMinimumSize()` REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26695?vs=73657=74052 BRANCH standardshortcuts-minimum-size

D26813: Have user-manager write to SDDM's new config file

ngraham accepted this revision. ngraham added a comment. Sounds good, should we do that refactor in master and land this on the stable branch? REPOSITORY R128 User Manager BRANCH write-autologin-right (branched from master) REVISION DETAIL https://phabricator.kde.org/D26813 To:

D26797: KCM/Component Refactor UI to a single list of combobox

ngraham added a comment. In D26797#598030 , @meven wrote: > @ngraham I think I should wait for some feedback/review from #VDG or #Plasma to iron out issues if any.

D26783: Center only during drawing, not the hit rects

ngraham added a comment. There's some weirdness in System Settings too. However all of this just exposes when we have a scrollable view that should be reformatted to show everything without needing to be scrollable (e.g. Okular's settings window; see

D26580: Kicker/RecentDocuments display place's icon when resource matches one

ngraham added a comment. Yes please. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26580 To: meven, #plasma, ngraham, hein Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D26808: Credit Ken for his wallpapers

This revision was automatically updated to reflect the committed changes. Closed by commit R131:dceedef5184d: Credit Ken for his wallpapers (authored by ngraham). REPOSITORY R131 Plasma Wallpapers CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26808?vs=74022=74026 REVISION DETAIL

D26808: Credit Ken for his wallpapers

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Since D26531 landed, it's now very obvious who made

<    9   10   11   12   13   14   15   16   17   18   >