Re: Review Request 126348: Make it possible to provide the metadata in json

2015-12-14 Thread Nick Shaforostoff
tps://git.reviewboard.kde.org/r/126348/#comment61260> something more meaningful? - Nick Shaforostoff On Dec. 14, 2015, 5:11 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 126148: [plasma-framework] qstring optimizations

2015-11-27 Thread Nick Shaforostoff
marked as submitted. Review request for Plasma, Marco Martin and Martin Klapetek. Changes --- Submitted with commit c7c2980f1429e0b0972b8754c37a2c4cd4ef5233 by Nick Shaforostoff to branch master. Repository: plasma-framework Description --- also contains fix for clazy warning

Re: Review Request 126148: [plasma-framework] qstring optimizations

2015-11-23 Thread Nick Shaforostoff
/usr/include/ brings nothing ack QT_USE_QSTRINGBUILDER /usr/include/ brings real results On Nov. 23, 2015, 9:02 p.m., Nick Shaforostoff wrote: > > Regarding QStringLiteral vs QLatin1String for libraries: I read that > > thread, but then most of QStringLiterals here sould be dropped as well if

Re: Review Request 126148: [plasma-framework] qstring optimizations

2015-11-23 Thread Nick Shaforostoff
://git.reviewboard.kde.org/r/126148/diff/ Testing --- compiles fine Thanks, Nick Shaforostoff ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126148: [plasma-framework] qstring optimizations

2015-11-23 Thread Nick Shaforostoff
r/126148/#review88737 --- On Nov. 23, 2015, 10:19 p.m., Nick Shaforostoff wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Review Request 126148: [plasma-framework] qstring optimizations

2015-11-23 Thread Nick Shaforostoff
src/plasmaquick/appletquickitem.cpp efe8611 src/plasmaquick/shellpluginloader.cpp 2824760 Diff: https://git.reviewboard.kde.org/r/126148/diff/ Testing --- compiles fine Thanks, Nick Shaforostoff ___ Plasma-devel mailing list Plasma-devel

Re: Review Request 126127: [powerdevil] add missing initializations, minor string optimizations

2015-11-21 Thread Nick Shaforostoff
marked as submitted. Review request for Plasma, Kai Uwe Broulik and Xuetian Weng. Changes --- Submitted with commit 5b0faeb67e02edb22bf79699c4ef2217f248a945 by Nick Shaforostoff to branch master. Repository: powerdevil Description --- This patch fixes member variable initialization

Review Request 126127: [powerdevil] add missing initializations, minor string optimizations

2015-11-21 Thread Nick Shaforostoff
aemon/powerdevilpolicyagent.cpp 6b46c9c Diff: https://git.reviewboard.kde.org/r/126127/diff/ Testing --- compiles fine Thanks, Nick Shaforostoff ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125951: [calendar] Move the plugins handling to a separate class

2015-11-09 Thread Nick Shaforostoff
f() instead of left() and % instead of + three lines below (or make sure + is the same as % by adding define -DQT_USE_QSTRINGBUILDER) - Nick Shaforostoff On Nov. 9, 2015, 7:56 p.m., Martin Klapetek wrote: > > --- > This is an

Re: Review Request 125976: add an update() method

2015-11-06 Thread Nick Shaforostoff
tps://git.reviewboard.kde.org/r/125976/#comment60441> QLatin1String("/metadata.desktop") - Nick Shaforostoff On Nov. 6, 2015, 4:10 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 123131: Port kio_man away from kdelibs4support

2015-03-25 Thread Nick Shaforostoff
> On March 25, 2015, 9:54 p.m., Lukáš Tinkl wrote: > > man/kio_man.cpp, line 242 > > > > > > Not correct, this returns only user configured list of languages, > > whereas it previously returned the full list. p

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-01-30 Thread Nick Shaforostoff
https://bugs.kde.org/show_bug.cgi?id=337674 Nick Shaforostoff changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #66 from Nick

[kwrited] [Bug 343550] duplicated kwrited instances increasing with each system boot

2015-01-29 Thread Nick Shaforostoff
https://bugs.kde.org/show_bug.cgi?id=343550 --- Comment #2 from Nick Shaforostoff --- Created attachment 90803 --> https://bugs.kde.org/attachment.cgi?id=90803&action=edit ps aux | grep kwrited > b -- You are receiving this mail because: You are the assignee f

[kwrited] [Bug 343550] duplicated kwrited instances increasing with each system boot

2015-01-29 Thread Nick Shaforostoff
https://bugs.kde.org/show_bug.cgi?id=343550 --- Comment #1 from Nick Shaforostoff --- Created attachment 90802 --> https://bugs.kde.org/attachment.cgi?id=90802&action=edit ps aux | grep kwrited > a -- You are receiving this mail because: You are the assignee f

[kwrited] [Bug 343550] New: duplicated kwrited instances increasing with each system boot

2015-01-29 Thread Nick Shaforostoff
https://bugs.kde.org/show_bug.cgi?id=343550 Bug ID: 343550 Summary: duplicated kwrited instances increasing with each system boot Product: kwrited Version: 5.1.95 Platform: Ubuntu Packages OS: Linux

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-01-29 Thread Nick Shaforostoff
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #59 from Nick Shaforostoff --- yeah, generally kde5 became slower on my netbook. it takes 5 seconds for alt+f2 runner to start reacting to my input, it takes ~5 seconds for start menu and simple alt+tab switcher to appear, and it takes ~5

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-01-29 Thread Nick Shaforostoff
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #56 from Nick Shaforostoff --- are you this patch would really matter, taking into account the fact that i have /usr/share/dbus-1/system-services/org.kde.powerdevil.backlighthelper.service pointing to existing executable, which is linked

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-01-28 Thread Nick Shaforostoff
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #53 from Nick Shaforostoff --- i have updated packages to 5.2 version and the issue is still there. i can see it after screenlocker run as well. -- You are receiving this mail because: You are the assignee for the bug

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-01-28 Thread Nick Shaforostoff
https://bugs.kde.org/show_bug.cgi?id=337674 Nick Shaforostoff changed: What|Removed |Added CC||sha...@ukr.net --- Comment #50 from Nick

Re: Review Request: Make DBusMenuQt optional

2011-02-26 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4898/#review9913 --- Ship it! what's the status of this patch for KDE 4.6? it makes c

Re: dict plasma applet

2008-11-12 Thread Nick Shaforostoff
> for instance, keep the dict applet in kde's svn and keep the engine with > qstartdict. there's no reason for an applet dedicated to stardict when we > have another dictionary widget there. I improved applet part: it got configuration (enable/disable dictionaries, reorder them). The qstardict en

Re: dict plasma applet

2008-11-11 Thread Nick Shaforostoff
Please welcome qstardict plasmoid! http://qstardict.ylsoftware.com/svn.php http://qstardict.svn.sourceforge.net/viewvc/qstardict/trunk/ It uses QTextBrowser instead of QWebView (saves ~5 megs of ram) allows specifying order of dictionaries, loads plugins only when a definition requested by user a

Re: dict plasma applet

2008-11-10 Thread Nick Shaforostoff
2008/11/10 Nick Shaforostoff <[EMAIL PROTECTED]>: > What I will do now is just turn dict dataengine into wrapper around > qstardict plugins: > in addition to web (konqueror web-shortcuts-like), stardict and swac > (sounds fetching) plugins i'll create multitran and rpc plu

Re: dict plasma applet

2008-11-09 Thread Nick Shaforostoff
> the question you need to answer is: "Am I creating a web dictionary engine, > a stardict engine, etc. or am I creating an engine that returns > the meaning of words?" thanks, you've convinced me. What I will do now is just turn dict dataengine into wrapper around qstardict plugins: in addition t

Re: dict plasma applet

2008-11-09 Thread Nick Shaforostoff
> don't design from the "dataengine implementation details" POV, > but from the applet writer's POV. and what's the application of this rule in our case? what's your design suggestion? i can see no other ways of advanced interaction with dataengine aside from Plasma::Service > i can see it making

Re: dict plasma applet

2008-11-09 Thread Nick Shaforostoff
> would make most sense, obviously, if they were all in the same dataengine. Why? Plasma-related code is only 100 lines. On the other hand, multitran dataengine requires linking to external libraries (their size is several megs) Of course, this could be solved by having plugins loaded on demand, an

Re: dict plasma applet

2008-11-08 Thread Nick Shaforostoff
2008/11/8 Thomas Georgiou <[EMAIL PROTECTED]>: > Well, initially we used a qgraphicstextedit with html formatting to > make it look nicer, but we could not have scrolling with that, so when > 4.1 came along we switched to qwebview (to get scrolling support). > Then we switched dictionaries to wordn

Re: plasma doesn't start automatically since 4.1.71

2008-11-07 Thread Nick Shaforostoff
update: plasma autostarts fine after I press ctrl+alt+bksp then login into kde4 explicitly ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

plasma doesn't start automatically since 4.1.71

2008-11-07 Thread Nick Shaforostoff
I updated kde from 4.1.69 to 4.1.71 from opensuse repositories (11.0) and plasma stopped loading automatically (just blank white or black screen), so i have to alt+f2, enter 'konsole' then enter 'plasma' the problem stayed after i updated to 4.1.72. I tried removing .kde4 but this didn't help. an