D12481: Add dptr to models

2018-04-23 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: drosca, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Last exported classes without dptr TEST PLAN

D12356: Move volume constants into functions

2018-04-19 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R994:c102a76c9538: Move volume constants into functions (authored by nicolasfella). REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12356?vs=32583=32584

D12356: Move volume constants into functions

2018-04-19 Thread Nicolas Fella
nicolasfella added a comment. Weird, it did build for me so I didn't notice, sorry REPOSITORY R994 Pulseaudio Qt Bindings REVISION DETAIL https://phabricator.kde.org/D12356 To: nicolasfella, drosca, apol Cc: apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D12356: Move volume constants into functions

2018-04-19 Thread Nicolas Fella
nicolasfella updated this revision to Diff 32583. nicolasfella added a comment. - Fix names REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12356?vs=32573=32583 BRANCH nopulseheader REVISION DETAIL https://phabricator.kde.org/D12356

D12356: Move volume constants into functions

2018-04-19 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: drosca, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Get rid of pulse include in context.h TEST

D10032: Swap play/pause icons in mediacontroller plasmoid

2018-03-05 Thread Nicolas Fella
nicolasfella abandoned this revision. nicolasfella added a comment. Abandoning in favor of D11056 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10032 To: nicolasfella, #plasma, #vdg Cc: rizzitello, abetts,

D11021: [Media contoller] Add simple volume control

2018-03-04 Thread Nicolas Fella
nicolasfella added a comment. What about a volume slider in the applet? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11021 To: Pitel, #plasma Cc: nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10800: Plasma browser MPRIS canPlay shouldn't depend on the actual playing status

2018-02-24 Thread Nicolas Fella
nicolasfella added a comment. I can confirm that this fixes the glitch REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D10800 To: mtijink, #plasma, broulik Cc: nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10800: Plasma browser MPRIS canPlay shouldn't depend on the actual playing status

2018-02-24 Thread Nicolas Fella
nicolasfella added a comment. The glitch: F5728155: 20180222_130510_edited (1).mp4 REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D10800 To: mtijink, #plasma, broulik Cc: nicolasfella, plasma-devel,

D10148: KCM: Show only available device profiles

2018-02-04 Thread Nicolas Fella
nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Looks good to me REPOSITORY R115 Plasma Audio Volume Applet BRANCH arcpatch-D10148 REVISION DETAIL https://phabricator.kde.org/D10148 To: drosca, #plasma, nicolasfella

D10280: Fix output device context menu

2018-02-04 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R115:f5c2a04e8d87: Fix output device context menu (authored by nicolasfella). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10280?vs=26463=26492

D9671: Show only available profiles in Pulseaudio KCM

2018-02-03 Thread Nicolas Fella
nicolasfella added a comment. In https://phabricator.kde.org/D9671#200326, @broulik wrote: > This breaks the context menu of output devices: > > org.kde.plasma.volume/contents/ui/ListItemBase.qml:315: ReferenceError: Port is not defined > see

D10280: Fix output device context menu

2018-02-03 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: broulik, drosca. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Port QML type got wrongly removed. TEST

D10224: Give a default player name

2018-02-03 Thread Nicolas Fella
nicolasfella abandoned this revision. nicolasfella added a comment. Turns out i wasn't running the latest extension. Works fine now. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D10224 To: nicolasfella, broulik, apol Cc: apol, plasma-devel,

D10148: KCM: Show only available device profiles

2018-02-02 Thread Nicolas Fella
nicolasfella requested changes to this revision. nicolasfella added a comment. This revision now requires changes to proceed. This leads to the wrong profile being selected. Because some profiles are excluded from the model the indices don't match anymore. REVISION DETAIL

D10224: Give a default player name

2018-02-01 Thread Nicolas Fella
nicolasfella added a comment. Well, I am trying to fix PBI. The problem is that my Firefox (58.0.1) does not get recognized as such. Chrome works fine. I will try to dig into the underlying issue. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL

D10183: Adjust spacing between text and plotter line in Speed tab of nm applet

2018-02-01 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R116:e1673f18e942: Adjust spacing between text and plotter line in Speed tab of nm applet (authored by kamathraghavendra, committed by nicolasfella). REPOSITORY R116 Plasma Network Management Applet

D10224: Give a default player name

2018-02-01 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: broulik. nicolasfella added a project: Plasma. nicolasfella requested review of this revision. REVISION SUMMARY Default to "Plasma Browser Integration" as a default MPRIS player identity. This makes KDE Connect look prettier.

D9671: Show only available profiles in Pulseaudio KCM

2018-01-24 Thread Nicolas Fella
nicolasfella added a comment. Feel free to take over, I can't promise to finish it anytime soon REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D9671 To: nicolasfella, #plasma, drosca Cc: plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai,

D10032: Swap play/pause icons in mediacontroller plasmoid

2018-01-23 Thread Nicolas Fella
nicolasfella added a comment. Before F5671035: IMG_20180123_205152_958.jpg After F5671036: IMG_20180123_205201_049.jpg REPOSITORY R120 Plasma Workspace REVISION DETAIL

D10032: Swap play/pause icons in mediacontroller plasmoid

2018-01-22 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Plasma, VDG. nicolasfella added a project: Plasma. nicolasfella requested review of this revision. REVISION SUMMARY The play/pause status of the system tray icon appears inverse to the play/pause button in the plasmoid. This

D8449: Have a default backend (if one available)

2017-10-25 Thread Nicolas Fella
nicolasfella added a comment. https://community.kde.org/Infrastructure/Get_a_Developer_Account REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8449 To: cryptodude, ivan, #plasma Cc: nicolasfella, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,

D8146: Don't try to override label heights - PlasmaComponents

2017-10-05 Thread Nicolas Fella
nicolasfella abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8146 To: nicolasfella, #plasma Cc: mart, davidedmundson, plasma-devel, #frameworks, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8146: Don't try to override label heights - PlasmaComponents

2017-10-04 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: Plasma. nicolasfella added a project: Plasma. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY Same as https://phabricator.kde.org/D8129 but

<    1   2   3   4   5   6