D16365: share common values for both Breeze and Breeze-dark GTK themes

ohelin added a comment. Nada from here, I'd say go ahead. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D16365 To: ohelin, jackg, #breeze, #plasma Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D16365: Update diff against newest master

ohelin added a comment. I checked the both the diff_part files next to each other. All the other differences were quite easy to see, but this one bugs me a little: scrollbar.vertical button.down { -gtk-icon-source: -gtk-icontheme("pan-down-symbolic"); } scrollbar.vertical

D15786: share common values for both Breeze and Breeze-dark GTK themes

ohelin added a comment. Ok, I just dissected the thing. First, I made the updated diff file against the newest master: **diff_updated.diff**. Then I saved these files from Phabricator: - **Breeze-dark-gtk_gtk-3.20_gtk.css**: saved the left raw diff file -

D16365: Update diff against newest master

ohelin added a comment. Ok, I just dissected the thing. First, I made the updated diff file against the newest master: **diff_updated.diff**. Then I saved these files from Phabricator: - **Breeze-dark-gtk_gtk-3.20_gtk.css**: saved the left raw diff file -

D15786: share common values for both Breeze and Breeze-dark GTK themes

ohelin added a comment. Oh man I find Phabricator quite unintuitive to use. I clicked on the update diff to... update the diff, but ended up creating a new revision. Don't know if that was the correct way. Anyway, I attached the updated diff there and linked it as a child of this revision.

D16365: Update diff against newest master

ohelin created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ohelin requested review of this revision. REVISION SUMMARY Updated diff against newest master so that it applies again. REPOSITORY R98 Breeze for Gtk REVISION DETAIL

D15786: share common values for both Breeze and Breeze-dark GTK themes

ohelin added a comment. In D15786#346959 , @ngraham wrote: > @grmat Thank you very much for this patch. I'm sorry that nobody has reviewed it yet. I think people are just intimidated by the huge diff lol. I will make an effort to do so, but it

D16331: GTK theme treeview style typo/bug fix

ohelin added a comment. In D16331#346540 , @ngraham wrote: > Thanks, can you provide us with your real name and email address so we can land this with proper authorship information? > > On the subject of GTK theme fixes, we also have a very

D16331: GTK theme treeview style typo/bug fix

ohelin added a comment. In D16331#346191 , @broulik wrote: > Thanks, makes sense. Do you have commit access? I don't think so, I just created the KDE account for this. REPOSITORY R98 Breeze for Gtk REVISION DETAIL

D16331: GTK theme treeview style typo/bug fix

ohelin added a comment. In D16331#346192 , @broulik wrote: > I noticed there's a bunch more places where `seperator` is used, e.g. in `gtk-3.18` and dark, I guess these should be fixed as well? Yeah definitely, but... I'm not familiar

D16331: GTK theme typo/bug fix

ohelin created this revision. ohelin added a reviewer: Breeze. ohelin added a project: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ohelin requested review of this revision. REVISION SUMMARY Fixes a typo in the CSS files which resulted in GTK treeviews being