D29845: Added option to change grid thickness

piotrkakol added a comment. In D29845#674882 , @mart wrote: > please use gitlab on invent.kde.org for new review requests I logged in on that page and I don't know what to do. Why don't I just add reviewers from my previous Binary Clock

D29845: Added option to change grid thickness

piotrkakol added a comment. @ngraham It does scale smooth-ish-ly according to taskbar size. You can see that square size (dotSize in BinaryClock.qml) is calculated based on taskbar size (height for horizontal taskbar and width for vertical taskbar). When you change taskbar size, binary

D29845: Added option to change grid thickness

piotrkakol added a comment. This is probably the last diff from my initial Binary Clock rework from D13937 . REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D29845 To: piotrkakol Cc: gladhorn, ngraham, davidedmundson,

D29845: Added option to change grid thickness

piotrkakol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. piotrkakol requested review of this revision. REVISION SUMMARY Before these changes grid took a lot of space, especially for smaller taskbars. Even with grid disabled there were big

D15876: Fix copyrights in binary clock files

piotrkakol added a comment. Well, previously it looked like I claimed to be contributor to fuzzy-clock, analog-clock and version from KDE4. Now it's clear that I only contributed to the newest version of binary-clock. In the rest files my copyriht claim is in a correct position. So it

D15876: Fix copyrights in binary clock files

piotrkakol created this revision. piotrkakol added a reviewer: davidedmundson. Herald added a project: Plasma. piotrkakol requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH fix-copyrights (branched from master) REVISION DETAIL https://phabricator.kde.org/D15876

D14384: Renamed dot to square in variables and filenames

piotrkakol added a comment. Yes, but I forgeted to put them in the last diff. Do I really have to make a separate diff to change it? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D14384 To: piotrkakol, davidedmundson Cc: zzag, gladhorn, ngraham,

D14384: Renamed dot to square in variables and filenames

piotrkakol added a comment. I did change main.qml as you can see here: https://phabricator.kde.org/R114:9eae090a3038ebf97ffeee8c9b773a8610e13021 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D14384 To: piotrkakol, davidedmundson Cc: gladhorn, ngraham,

D14384: Renamed dot to square in variables and filenames

piotrkakol added a comment. Ping. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D14384 To: piotrkakol Cc: gladhorn, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14384: Renamed dot to square in variables and filenames

piotrkakol created this revision. Restricted Application added a project: Plasma. piotrkakol requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D14384 AFFECTED FILES

D14377: Changed variable type to int to display squares instead of rectangles

piotrkakol created this revision. Restricted Application added a project: Plasma. piotrkakol requested review of this revision. REVISION SUMMARY F6044411: squares fix.png On the left there's the old applet and on the right mine after only changing

D14307: Changed refresh time from 30 to 60 seconds

piotrkakol created this revision. Restricted Application added a project: Plasma. piotrkakol requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D14307 AFFECTED FILES

D14306: Changed refresh time from 30 to 60 seconds

piotrkakol created this revision. piotrkakol added a reviewer: ngraham. piotrkakol added a project: Plasma. piotrkakol requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH change-refresh-time (branched from master) REVISION DETAIL https://phabricator.kde.org/D14306

D14268: Changed refresh time from 30 to 60 seconds

piotrkakol added a comment. Thanks, David. Yeah, even though I followed the instructions you can see that the branch in this diff is "change-refresh-time (branched from master)" and it

D14268: Changed refresh time from 30 to 60 seconds

piotrkakol created this revision. Restricted Application added a project: Plasma. piotrkakol requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH change-refresh-time (branched from master) REVISION DETAIL https://phabricator.kde.org/D14268 AFFECTED FILES

D14267: Cleaned code for binary clock applet and added comments

piotrkakol created this revision. Restricted Application added a project: Plasma. piotrkakol requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH code-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D14267 AFFECTED FILES

D13937: Update formulas and add option to change grid thickness

piotrkakol added a comment. Thanks for the link! I'll check it out probably tomorrow and will make new diff(s). :-) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D13937 To: piotrkakol, #plasma Cc: gladhorn, ngraham, plasma-devel, ragreen, Pitel, ZrenBot,

D13937: Update formulas and add option to change grid thickness

piotrkakol added a comment. Wow, this is nice :) I wonder if it could be broken into smaller pieces though, this is quite a big change and thus hard to review. For example if the renaming from "dot" to "square" was independent of the rest, that would make it easier. Was it developed as

D13937: Update formulas and add option to change grid thickness

piotrkakol added a comment. I don't have KDE developer account so I cannot push this patch. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D13937 To: piotrkakol Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D13937: Update formulas and add option to change grid thickness

piotrkakol added a comment. F6044411: squares fix.png On the left there's the old applet and on the right mine after only changing dotSize (now squareSize) from real to int. All squares, not rectangles. F6044428: config.png

D13937: Update formulas and add option to change grid thickness

piotrkakol created this revision. Restricted Application added a project: Plasma. piotrkakol requested review of this revision. REVISION SUMMARY Cleaned code for binary clock applet and added comments. Changed refresh time from 30 to 60 seconds. Changed variable type to int to display

D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget

piotrkakol added a comment. I was instructed to give my contact details that will be included in the commit message. Piotr Kąkol piotrka...@pm.me REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10434 To: piotrkakol, davidedmundson Cc: davidedmundson, plasma

D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget

piotrkakol added a comment. Thank you for reviewing. No, I don't have commit access. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10434 To: piotrkakol, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget

piotrkakol updated this revision to Diff 27024. piotrkakol retitled this revision from "Changed hexadecimal system to decimal for Binary Clock widget" to "Allow users to change the format to BCD (decimal) in Binary Clock widget". piotrkakol edited the summary of this revision. piotrkakol added a

D10434: Changed hexadecimal system to decimal for Binary Clock widget

piotrkakol edited the summary of this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10434 To: piotrkakol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10434: Changed hexadecimal system to decimal for Binary Clock widget

piotrkakol edited the summary of this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10434 To: piotrkakol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10434: Changed hexadecimal system to decimal for Binary Clock widget

piotrkakol created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. piotrkakol requested review of this revision. REVISION SUMMARY Hours, minutes and seconds are in hexadecimal system. I don't know if it was intended or