D10541: make kdesu available in bindir and thus $PATH by default (opt-out)

2018-02-26 Thread Rohan Garg
garg added a comment. LGTM REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D10541 To: sitter Cc: garg, rdieter, asturmlechner, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10346: check for EGL_KHR_platform_gbm extension as well

2018-02-08 Thread Rohan Garg
garg added a comment. Restricted Application edited projects, added KWin; removed Plasma. BTW this patch works as tested on both the Rock64 and Pinebook, but kwin fails in another place now. Will continue investigating. REPOSITORY R108 KWin REVISION DETAIL

D6459: Fix the National Geographic PoTD dataengine

2017-07-04 Thread Rohan Garg
garg added a comment. Can this also go into the next 5.10 release? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D6459 To: garg, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart,

D6459: Fix the National Geographic PoTD dataengine

2017-07-03 Thread Rohan Garg
garg added a comment. You can checkout the XML on http://www.nationalgeographic.com/photography/photo-of-the-day/ by just viewing the source :) I'm not aware of a crash in bugzilla, got a bug number? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D6459

D6459: Fix the National Geographic PoTD dataengine

2017-07-01 Thread Rohan Garg
garg added a comment. Unfortunately I couldn't figure out a way to relax the XML parser, so if anyone has tips on how to achieve that, I'd highly appreciate them :) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D6459 To: garg, #plasma Cc: plasma-devel,

D6459: Fix the National Geographic PoTD dataengine

2017-07-01 Thread Rohan Garg
garg created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Ignore elements with the crossorigin attribute since these break the DOM causing QXmlStreamReader to stop processing the XML which leads to a

D6424: [Scripting] Throw a error from the Containment when the widget is not found

2017-06-28 Thread Rohan Garg
This revision was automatically updated to reflect the committed changes. Closed by commit R120:94aa4152937f: [Scripting] Throw a error from the Containment when the widget is not found (authored by garg). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D6424: [Scripting] Throw a error from the Containment when the widget is not found

2017-06-28 Thread Rohan Garg
garg updated this revision to Diff 15970. garg added a comment. Remove useless debug REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6424?vs=15969=15970 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6424 AFFECTED FILES

D6424: [Scripting] Throw a error from the Containment when the widget is not found

2017-06-28 Thread Rohan Garg
garg updated this revision to Diff 15969. garg added a comment. Remove accidentally commited file REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6424?vs=15968=15969 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6424 AFFECTED

D6424: [Scripting] Throw a error from the Containment when the widget is not found

2017-06-28 Thread Rohan Garg
garg updated this revision to Diff 15968. garg added a comment. Update as per David's comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6424?vs=15962=15968 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6424 AFFECTED FILES

D6424: [Scripting] Throw a error from the Containment when the widget is not found

2017-06-28 Thread Rohan Garg
garg updated this revision to Diff 15962. garg added a comment. Mention the name of the widget too REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6424?vs=15961=15962 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6424 AFFECTED

D6424: [Scripting] Throw a error from the Containment when the widget is not found

2017-06-28 Thread Rohan Garg
garg added a reviewer: Plasma. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6424 To: garg, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6424: [Scripting] Throw a error from the Containment when the widget is not found

2017-06-28 Thread Rohan Garg
garg created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Let's also move the applet pointer to right before it's used and remove duplicated declarations. REPOSITORY R120 Plasma Workspace BRANCH

[Differential] [Commented On] D4596: Figure out the GTK version instead of using a hardcoded one

2017-02-13 Thread Rohan Garg
garg added a comment. I would argue that breeze-gtk should already have had this change in order to not break on systems where GTK is >= 3.20 REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D4596 EMAIL PREFERENCES

[Differential] [Closed] D4596: Figure out the GTK version instead of using a hardcoded one

2017-02-13 Thread Rohan Garg
This revision was automatically updated to reflect the committed changes. Closed by commit R98:d25084c791d8: Figure out the GTK version instead of using a hardcoded one (authored by garg). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE

[Differential] [Updated, 12 lines] D4596: Figure out the GTK version instead of using a hardcoded one

2017-02-13 Thread Rohan Garg
garg updated this revision to Diff 11298. garg added a comment. Simplify setting up the variable REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4596?vs=11297=11298 BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4596 AFFECTED

[Differential] [Commented On] D4596: Figure out the GTK version instead of using a hardcoded one

2017-02-13 Thread Rohan Garg
garg added a comment. In https://phabricator.kde.org/D4596#85993, @lbeltrame wrote: > FTR, the reason this was not done at CMake time was to avoid depending on a development package (and associated dependencies like a compiler) to install something that's architecture-dependent. My

[Differential] [Updated, 13 lines] D4596: Figure out the GTK version instead of using a hardcoded one

2017-02-13 Thread Rohan Garg
garg updated this revision to Diff 11297. garg added a comment. Don't cache string, set a CMAKE_MODULE_PATH too REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4596?vs=11296=11297 BRANCH Plasma/5.9 REVISION DETAIL

[Differential] [Updated, 11 lines] D4596: Figure out the GTK version instead of using a hardcoded one

2017-02-13 Thread Rohan Garg
garg updated this revision to Diff 11296. garg added a comment. Make finding GTK required, move find_package calls together REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4596?vs=11286=11296 BRANCH Plasma/5.9 REVISION DETAIL

[Differential] [Commented On] D4596: Figure out the GTK version instead of using a hardcoded one

2017-02-13 Thread Rohan Garg
garg added a comment. This should ideally also be backported for Plasma 5.9 REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D4596 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: garg Cc: plasma-devel, lesliezhai,

[Differential] [Request, 7 lines] D4596: Figure out the GTK version instead of using a hardcoded one

2017-02-13 Thread Rohan Garg
garg created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Find the GTK3 pkg-config file and pick up a version using that. TEST PLAN - Do a clean rebuild - Picks up the right GTK3 version and

Re: Plasma mobile and Fairphone

2015-07-26 Thread Rohan Garg
The fairphone looks like a brilliant product to collaborate with btw. Cheers Rohan Garg On Sun, Jul 26, 2015 at 3:18 PM, Marco Martin notm...@gmail.com wrote: Most important, if anyone has any contact to anybody working there... brilliant and let's talk ;) On Sun, Jul 26, 2015 at 10:18 AM

Review Request 122446: libkscreen needs Qt = 5.4.0

2015-02-05 Thread Rohan Garg
--- Compiles fine. Thanks, Rohan Garg ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122446: libkscreen needs Qt = 5.4.0

2015-02-05 Thread Rohan Garg
- CMakeLists.txt a915140 Diff: https://git.reviewboard.kde.org/r/122446/diff/ Testing --- Compiles fine. Thanks, Rohan Garg ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 106911: ksmserver should ignore non-executable files under ~/.kde4/Autostart

2014-10-22 Thread Rohan Garg
On Oct. 17, 2012, 2:31 a.m., Kai Uwe Broulik wrote: Well, in KDE's Autostart config you can add .desktop files to autostart, so did I with e.g. Yakuake. They don't seem to be stored in .kde/Autostart, though. Jekyll Wu wrote: Yes, those .desktop files usually live under

Re: Review Request 119522: readlink fails whens the folder does not exist.

2014-07-31 Thread Rohan Garg
as expected. Thanks, Rohan Garg ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119175: Create internal copy of kxmlrpcclient to get drkonqi to report bugs

2014-07-29 Thread Rohan Garg
/internalkxmlrpcclient/KF5XmlRpcClientPrivateConfig.cmake.in PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119175/diff/ Testing --- Launched konsole killall -SEGV konsole Drkonqi comes up Report bug button is enabled Thanks, Rohan Garg

Review Request 119522: readlink fails whens the folder does not exist.

2014-07-28 Thread Rohan Garg
/ Testing --- Kubuntu Plasma 5 ISO's did not have the right cursor theme before this patch, after editing startkde by hand, the right files were being correctly written, and the cursor theme worked as expected. Thanks, Rohan Garg ___ Plasma-devel

Re: Review Request 119522: readlink fails whens the folder does not exist.

2014-07-28 Thread Rohan Garg
://git.reviewboard.kde.org/r/119522/#review63351 --- On July 28, 2014, 10:47 p.m., Rohan Garg wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 119329: return invalid for packages with Hidden=true in the metadata

2014-07-17 Thread Rohan Garg
for downstream to just override the desktop file as part of their customization package. - Rohan Garg On July 17, 2014, 3:20 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 119159: Add a internal copy of kxmlrpcclient to plasma-workspace

2014-07-10 Thread Rohan Garg
Diff: https://git.reviewboard.kde.org/r/119159/diff/ Testing --- Launched konsole killall -SEGV konsole Drkonqi comes up Report bug button is enabled Thanks, Rohan Garg ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Review Request 119160: Make sure the backtrace dialog isn't closed when the bug reporting assistant is launched

2014-07-10 Thread Rohan Garg
, Rohan Garg ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119175: Create internal copy of kxmlrpcclient to get drkonqi to report bugs

2014-07-09 Thread Rohan Garg
drkonqi/CMakeLists.txt 8224900 Diff: https://git.reviewboard.kde.org/r/119175/diff/ Testing --- Launched konsole killall -SEGV konsole Drkonqi comes up Report bug button is enabled Thanks, Rohan Garg ___ Plasma-devel mailing list Plasma

Re: Review Request 119175: Create internal copy of kxmlrpcclient to get drkonqi to report bugs

2014-07-09 Thread Rohan Garg
drkonqi/internalkxmlrpcclient/KF5XmlRpcClientPrivateConfig.cmake.in PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119175/diff/ Testing --- Launched konsole killall -SEGV konsole Drkonqi comes up Report bug button is enabled Thanks, Rohan Garg

Re: Review Request 119159: Add a internal copy of kxmlrpcclient to plasma-workspace

2014-07-08 Thread Rohan Garg
://git.reviewboard.kde.org/r/119159/diff/ Testing --- Launched konsole killall -SEGV konsole Drkonqi comes up Report bug button is enabled Thanks, Rohan Garg ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Copying over kxmlrpcclient into plasma-workspace

2014-07-08 Thread Rohan Garg
On Thu, Jul 3, 2014 at 6:47 PM, Rohan Garg rohan16g...@gmail.com wrote: Hi As it currently stands, Dr Konqi needs kxmlrpcclient ( which comes from kdepimlibs ) in order to talk with bugzilla to report crashes in Plasma 5. However, since kxmlrpcclient is not being split / released, would

Review Request 119160: Make sure the backtrace dialog isn't closed when the bug reporting assistant is launched

2014-07-07 Thread Rohan Garg
/drkonqidialog.cpp 7dc4021 Diff: https://git.reviewboard.kde.org/r/119160/diff/ Testing --- Launched konsole killall -SEGV konsole Clicked on report bug bug reported on bugs.kde.org succesfully Thanks, Rohan Garg ___ Plasma-devel mailing list Plasma

Review Request 119159: Add a internal copy of kxmlrpcclient to plasma-workspace

2014-07-07 Thread Rohan Garg
-SEGV konsole Drkonqi comes up Report bug button is enabled Thanks, Rohan Garg ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Copying over kxmlrpcclient into plasma-workspace

2014-07-03 Thread Rohan Garg
? Cheers Rohan Garg ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118977: KSMServer: Do not autostart files

2014-06-27 Thread Rohan Garg
On June 27, 2014, 8:40 p.m., Rohan Garg wrote: I applied it locally here and krunner still starts up twice. So, krunner starting twice is another bug in session management, but other apps like konsole only startup once after this patch - Rohan

Plasma 5: Roadmap post 5.0

2014-06-23 Thread Rohan Garg
will be between Plasma 5 releases ( I was told 3 months by some people, this doesn't seem to be written down in a wiki page). Would be awesome if someone could indicate what the roadmap is after the Plasma 5.0 release :) Cheers Rohan Garg ___ Plasma-devel

Re: Plasma 5: Roadmap post 5.0

2014-06-23 Thread Rohan Garg
I think that plasma releases can follow KF5, we could get at least 5.0.1 in August 15th and 5.0.2 in September 15th. As downstream, I would very much appreciate monthly bug fix releases :) Cheers Rohan Garg ___ Plasma-devel mailing list Plasma-devel

Review Request 118797: Port webshortcuts runner

2014-06-17 Thread Rohan Garg
to work with the kde: , qt: and youtube: keywords Thanks, Rohan Garg ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118797: Port webshortcuts runner

2014-06-17 Thread Rohan Garg
/webshortcutrunner.cpp cae2dec Diff: https://git.reviewboard.kde.org/r/118797/diff/ Testing --- Seems to work with the kde: , qt: and youtube: keywords Thanks, Rohan Garg ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 118137: Do not overwrite event mask in WindowThumbnailItem

2014-05-15 Thread Rohan Garg
-not-updating entries so far. - Rohan Garg On May 15, 2014, 11:31 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118137

Re: [RFC] Remove remote plasmoids in 4.11

2013-05-07 Thread Rohan Garg
Since Martin's email is not working, I'm just conveying what he wants : I suggest removing just the share item in the UI and not removing the all the actual code and disabling the notification by default Regards Rohan Garg On Tue, May 7, 2013 at 5:36 PM, Marco Martin notm...@gmail.com wrote

Combining the 4 notes plasmoids into 1

2011-08-12 Thread Rohan Garg
importantly, any volunteers to implement this idea? Rohan Garg ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QML and DBus in plasma

2011-07-19 Thread Rohan Garg
Hi Weng I've been looking into a solution for this myself as well, and the best way i could come up was using C++/Python and then using the setContextProperty to set the property of any QML objects, the code would be something like this [1][2]. I found these Qt docs [3] to be quite helpful in this

Re: Plasma-based presentation view for calligra-stage

2011-03-21 Thread Rohan Garg
guys as to why they are appending the process id, since it just makes dbus calls more cumbersome. Regards Rohan Garg On Mon, Mar 21, 2011 at 10:28 PM, Sinny Kumari ksi...@gmail.com wrote: Hi todd,    Can you please share your IRC nick? Thanks On 3/21/11, Sinny Kumari ksi...@gmail.com wrote

Re: where to download plasma-mobile solution for MeeGo?

2011-01-19 Thread Rohan Garg
Do meego repos even have those? Im not sure, but theres Kubuntu Mobile that you can use on a N900, theres also a ubuntu lucid chroot that you can boot on a Android device and then you can install plasma mobile on it :-) Found some stuff on youtube too.. On 2011 1 19 16:03, zhang peter

Re: Review Request: Extend FolderView::configChanged() to reload configuration values

2010-09-15 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5049/ --- (Updated 2010-09-15 17:24:39.880260) Review request for Plasma and Fredrik

Re: Review Request: Extend FolderView::configChanged() to reload configuration values

2010-09-15 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5049/ --- (Updated 2010-09-15 17:37:23.970844) Review request for Plasma and Fredrik

Re: Review Request: Extend FolderView::configChanged() to reload configuration values

2010-09-14 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5049/ --- (Updated 2010-09-14 16:39:31.059811) Review request for Plasma and Fredrik

Re: Review Request: Extend FolderView::configChanged() to reload configuration values

2010-09-14 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5049/ --- (Updated 2010-09-14 17:24:49.849536) Review request for Plasma and Fredrik

Re: Review Request: Extend FolderView::configChanged() to reload configuration values

2010-08-22 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5049/ --- (Updated 2010-08-22 17:05:40.407310) Review request for Plasma and Fredrik

Re: Review Request: Extend FolderView::configChanged() to reload configuration values

2010-08-22 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5049/ --- (Updated 2010-08-22 17:07:53.057046) Review request for Plasma and Fredrik

Review Request: Extend FolderView::configChanged() to reload configuration values

2010-08-17 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5049/ --- Review request for Plasma and Fredrik Höglund. Summary --- Extend

Re: Review Request: Extend FolderView::configChanged() to reload configuration values

2010-08-17 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5049/ --- (Updated 2010-08-16 18:13:06.548619) Review request for Plasma and Fredrik

Re: Review Request: Extend FolderView::configChanged() to reload configuration values

2010-08-17 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5049/ --- (Updated 2010-08-17 12:09:14.676873) Review request for Plasma and Fredrik

Re: Review Request: Extend FolderView::configChanged() to reload configuration values

2010-08-17 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5049/ --- (Updated 2010-08-17 12:12:32.350700) Review request for Plasma and Fredrik