Re: Clang Format Update

On Sat, Jan 2, 2021 at 2:07 AM David Edmundson wrote: > > It does. I've tried to collect some stats and provide some context on > the change. > > Taking just plasma-workspace, we have a lot of lines over 100 > characters at the moment. > 3817 lines to be exact. ~3.3% [1] > We also have 146 lines

Re: Clang Format Update

radiction with Frameworks recommendation. > Am 01.01.21 um 17:59 schrieb Roman Gilg: > > 160 chars column limit contradicts Frameworks recommendation of 100 > chars. > >

Re: Clang Format Update

On Fri, Jan 1, 2021 at 3:01 PM David Edmundson wrote: > > There has been lots of work on this lately, especially by Alexander Lonhau. > > Both in the clang-format file and with some custom changes, and some > changes throughout the code. > > If anyone has specific objections please be sure to

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added a comment. In D29024#669970 , @dvratil wrote: > If I may add my two cents here, Hi Daniel, sorry for the late reply. But I was busy as I had to kick things off now with the libkscreen fork. > I agree with David that

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added a comment. Oh I nearly forgot: great work that you ignore everything else I wrote and only reply to the most unimportant statement in all of that. That's a great rhetorical trick. Every good politician must know about this one for distraction. REPOSITORY R110 KScreen

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added a comment. In D29024#669718 , @davidedmundson wrote: > > Show me where the documentation for this QtWaylandClientExtension is and where you documented that we "agreed" on using that in Plasma exclusively and we can talk about

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added a comment. In D29024#668884 , @ngraham wrote: > In D29024#668383 , @romangg wrote: > > > Note that I need to have this plugin system or something similar in for 5.19 or I will be

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added a comment. These are not specific issues but some general complains about the overall concept chosen here without providing an alternative solution. I chose this plugin system because it allows robust extension to the current system. Plugins are well contained and reuse

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added a comment. Since this has now the structure with exported headers as requested in D29028#653150 and D29028#654526 I'll push later today if there are no more specific issues pointed out in

D29028: feat(wayland): add Wrapland plugin

romangg abandoned this revision. romangg added a comment. Will become an external plugin with libkscreen Wayland headers being exported now. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D29028 To: romangg, #plasma, davidedmundson, apol Cc: anthonyfieroni,

D29029: feat(wayland): add plugin for wlroots based compositors

romangg abandoned this revision. romangg added a comment. Will become an external plugin with libkscreen Wayland headers being exported now. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D29029 To: romangg, #plasma Cc: plasma-devel, Orage, LeGast00n,

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added a comment. A separate library KScreenWayland is installed additionally to the runtime plugin, so that library can be linked against to create nested plugins for a Wayland session. These plugins must be installed in a certain directory

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg updated this revision to Diff 82265. romangg added a comment. - refactor: export Wayland plugins headers REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29024?vs=80700=82265 BRANCH wayland-plugins-export REVISION DETAIL

D29340: fix(kcm): avoid recursive OpacityMask which leads to teardown crash

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. > Docs explicitly say this. When you reference some "docs" please take 20 seconds and directly link it. Every piece you write here and in git commit messages is potentially read by

D29028: feat(wayland): add Wrapland plugin

romangg added a comment. In D29028#654542 , @davidedmundson wrote: > A new dependency also needs to actually solve an actual problem. > > If we say we should support wl_roots' protocol for wlroots users. Fair enough. There are some parts of

D29028: feat(wayland): add Wrapland plugin

romangg added a comment. In D29028#654535 , @anthonyfieroni wrote: > In D29028#653194 , @romangg wrote: > > > In D29028#653192 , @apol wrote: > > > >

D29028: feat(wayland): add Wrapland plugin

romangg added a comment. In D29028#654526 , @tcanabrava wrote: > I understand David's point: Wrapland project has one developer and we don't know how successful it will be, while the other backends have developers. What would happen if you

D29080: [kcms/fonts] Guide users towards KScreen KCM for making things bigger on-screen

romangg added a comment. I like that. KCMs should be more inter-connected anyway. The message could just be shown all the time instead of making it dependent on the font size selected but no need to change that now. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D29028: feat(wayland): add Wrapland plugin

romangg added a comment. In D29028#653192 , @apol wrote: > I don't really see why we'd want to support something that is not offering ABI stability and doesn't push Plasma in any direction. It is offering in the same way ABI stability as

D29028: feat(wayland): add Wrapland plugin

romangg added a comment. In D29028#653150 , @davidedmundson wrote: > I don't see why we should have that in KDE code. Come on man, do you really want to make this ugly? I thought we would still treat each other with respect David. :(

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added a comment. In D29024#653096 , @davidedmundson wrote: > KScreen already is a plugin system. You mean libkscreen? It has a plugin system for differentiating between windowing systems, yes. > We don't need to go all

D29029: feat(wayland): add plugin for wlroots based compositors

romangg added a comment. Test on sway. - I noticed one issue with that. KScreen is not at all styled in a sway session. Kai helped me out with that. I needed to set the env var XDG_CURRENT_DESKTOP=KDE. I find this rather a broken

D29029: feat(wayland): add plugin for wlroots based compositors

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Adds a plugin that uses the Wrapland library to interact with compositors supporting the

D29028: feat(wayland): add Wrapland plugin

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Adds a plugin that uses the Wrapland library to interact with compositors supporting the

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg updated this revision to Diff 80700. romangg added a comment. Cleanup REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29024?vs=80698=80700 BRANCH wayland-plugins REVISION DETAIL https://phabricator.kde.org/D29024 AFFECTED FILES

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added inline comments. INLINE COMMENTS > CMakeLists.txt:28 > +TARGETS LibkscreenWaylandPluginKWayland > +DESTINATION ${PLUGIN_INSTALL_DIR}/org.kde.libkscreen.backends/wayland/ > +) That directory fine or are there other suggestions? I would like to centralize over time all

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg updated this revision to Diff 80698. romangg added a comment. Cleanup REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29024?vs=80695=80698 BRANCH wayland-plugins REVISION DETAIL https://phabricator.kde.org/D29024 AFFECTED FILES

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Besides the KWayland output-management protocol there exist other protocol extensions for

D28916: fix(kded): center action OSD on wayland

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Looks good to me. Also happy @davidedmundson ? INLINE COMMENTS > osd.cpp:33 > +#include > +#include > Correct lexicographical order on push. > osd.cpp:143 > if (auto

D28817: fix (kcm): correct output identifier position on wayland

romangg added a comment. Yes, please put the m_timer removal in a separate patch. And if you removed the m_timer the QTimer include in the header file can be removed as well I assume. Thanks. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D28817 To: bport,

D28817: fix (kcm): correct output identifier position on wayland

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Thanks. Some minor remaining nitpicks you can change on push. INLINE COMMENTS > output_identifier.cpp:28 > +#include > +#include > Lexicographical order. Also add an empty line to

D28818: fix(kcm): show output ids in reference to currently applied config

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. I changed up the description a bit more (line length!). Please make sure to push with arc so it fetches this description for the commit message. Code change makes sense. Thanks for

D28817: fix (kcm): correct output identifier position on wayland

romangg added a comment. Conceptually makes sense. +1 form me on that. Good solution. Thanks for outlining it in the summary. This patch can land with a fix for the view leak or without. I accept when my inline comments are fixed. @davidedmundson: can you give a quick accept on the

D28818: fix(kcm): Identify output according to current applied position, not an unapplied position

romangg added a comment. Header subject and commit message body must have shorter line length in line with message guideline. Also note regarding capitalization Angular's subject guideline

D28817: Fix KScreen output identifier position on wayland

romangg added a comment. Please explain your solution in the summary. I don't directly understand how this change fixes the bug. Thanks. INLINE COMMENTS > CMakeLists.txt:32 > KF5::QuickAddons > +KF5::PlasmaQuick > KF5::Screen lexicographic order > output_identifier.cpp:69 >

D28818: Identify output according to current applied position, not an unapplied position

romangg requested changes to this revision. romangg removed reviewers: meven, ervin. romangg added a comment. This revision now requires changes to proceed. Message guideline must be adhered. Summary must be more extensive. REPOSITORY R104 KScreen REVISION DETAIL

D28817: Fix KScreen output identifier position on wayland

romangg requested changes to this revision. romangg removed reviewers: meven, ervin. romangg added a comment. This revision now requires changes to proceed. Message guideline must be adhered. Summary must be more extensive. REPOSITORY R104 KScreen REVISION DETAIL

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

romangg accepted this revision. romangg added a comment. Add the `const` and push. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D28773 To: z3ntu, #plasma, bshah, nicolasfella, romangg Cc: romangg, nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

romangg added a comment. I'm not sure about the renaming. the lock... implies that the rotation stays the way it is at the moment (what it does). But I'm fine either way. These are normally two separate commits, one refactor and one feature addition. But since it's only a small change

D28389: Add support for logging categories

This revision was automatically updated to reflect the committed changes. Closed by commit R133:c103ceb1caf0: Add support for logging categories (authored by romangg). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28389?vs=78881=79092 REVISION DETAIL

D27677: refactor: incorporate prior libkscreen EDID changes

romangg added a comment. Oh, I just noticed: Please absolutely add a commit message body to this commit on push! Just a single line explaining what you do is enough. REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.kde.org/D27677 To: dvratil, #plasma,

D27675: feat: avoid duplicated text when assembling user-facing output names

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Sorry for late review. I didn't get notified by this bullshit platform (which might be because I disabled all notifications at one point to not get spammed constantly). INLINE COMMENTS

D10042: feat: parse EDID on the backend side

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. In D10042#629261 , @dvratil wrote: > Agreed. deviceId is not actually used (it's stored in KDED config files, but the value doesn't seem to

D28386: fix(kded): watch config also when known config is applied

This revision was automatically updated to reflect the committed changes. Closed by commit R104:3dced489d7c1: fix(kded): watch config also when known config is applied (authored by romangg). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28386?vs=78756=78882

D28389: Add support for logging categories

romangg added inline comments. INLINE COMMENTS > apol wrote in CMakeLists.txt:23 > Make sure the include() call is before the add_subdirectory(). > > That's why we usually put them together on top right under the find_package() > together with `include(ECMGenerateHeaders)`. Put the include on

D28389: Add support for logging categories

romangg updated this revision to Diff 78881. romangg added a comment. Include the cpp files REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28389?vs=78765=78881 BRANCH logging-categories REVISION DETAIL https://phabricator.kde.org/D28389

D28389: Add support for logging categories

romangg added inline comments. INLINE COMMENTS > CMakeLists.txt:23 > +Critical > +) > + Any idea how to reuse the declaration from the top-directory CMake file? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D28389 To: romangg, #plasma Cc: plasma-devel,

D28389: Add support for logging categories

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Adds category logging to the KScreenLocker daemon/library and the greeter. Replaces all

D28082: Take file descriptor only instead of whole KWayland Display

This revision was automatically updated to reflect the committed changes. Closed by commit R133:decf7c9d4f43: Take file descriptor only instead of whole KWayland Display (authored by romangg). Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REPOSITORY R133

D28081: Populate Greeter process exit stderr

This revision was automatically updated to reflect the committed changes. Closed by commit R133:c893e333b060: Populate Greeter process exit stderr (authored by romangg). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28081?vs=77784=78759 REVISION

D28386: fix(kded): watch config also when known config is applied

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY When a known config is applied the doApplyConfig with the Config wrapper override is called. In

D28217: Fix Formatter library CMake

romangg added inline comments. INLINE COMMENTS > romangg wrote in CMakeLists.txt:30 > Accidentally added QML and Quick? I removed experimentally the Qml and Quick package specifiers and it still compiled. REPOSITORY R111 KSysguard Library BRANCH cmake_fixes REVISION DETAIL

D28217: Fix Formatter library CMake

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Compiles again on Neon. INLINE COMMENTS > CMakeLists.txt:30 > > -find_package(Qt5 ${QT_MIN_VERSION} REQUIRED CONFIG COMPONENTS DBus Network > Widgets) > +find_package(Qt5

D28115: feat(kded): add a dbus method to lock current rotation

romangg added a comment. In D28115#632489 , @davidedmundson wrote: > How does mobile retrieve the current lockAutoRotate value? It could read it from the config file. But it would be better to add another dbus method for that.

D28115: feat(kded): add a dbus method to lock current rotation

romangg accepted this revision. romangg added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > config.cpp:103 > +} > +if(m_control->getAutoRotate(output) != value) { > +m_control->setAutoRotate(output, value); On push change to: `if

D28115: feat(kded): add a dbus method to lock current rotation

romangg requested changes to this revision. romangg added a comment. This revision now requires changes to proceed. Please call the functions `AutoRotate`. I failed to name it consistently in the code until now but let's go with AutoRotate from now on (and I will try to rename it where I

D28115: [RFC] feat(kded): add a dbus method to toggle auto-rotation

romangg added a comment. So I think of two things to consider: - How is the overall interaction? Do we want something in line with other systems? Then we should have a lock/unlock rotation workflow where the current rotation orientation is made permanent until the icon is tapped again.

D28106: fix: transfer tablet mode properties

This revision was automatically updated to reflect the committed changes. Closed by commit R110:6ba447e9e59d: fix: transfer tablet mode properties (authored by romangg). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28106?vs=77852=77874 REVISION

D28106: fix: transfer tablet mode properties

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY I forgot to copy over the tablet-mode-available and -engaged data from one config to the next

D28081: Populate Greeter process exit stderr

romangg added a comment. In D28081#628985 , @davidedmundson wrote: > Can we use categorised logging please. Yea, but I haven't seen any categorized logging in KScreenLocker so I opted for now with non-categorized logging as the rest of

D27675: feat: avoid duplicated text when assembling user-facing output names

romangg added a comment. In D27675#629182 , @dvratil wrote: > As you described, the system makes sense on X11 where you get something like `HDMI-1 (Sony GigaTV-12345)` so you see which device it is and what physical output it's connected to.

D10042: feat: parse EDID on the backend side

romangg added a comment. Thanks, so I'm talking about this line: [15:31:16.521] kscreen-console(422251:422251) unknown: Device ID: "xrandr-Eizo Nanao Corporation-DP-7-EV2736W/96211045" There it says xrandr, which should likely be not there. REPOSITORY R110 KScreen Library

D28081: Populate Greeter process exit stderr

romangg updated this revision to Diff 77784. romangg added a comment. else case REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28081?vs=5=77784 BRANCH debug REVISION DETAIL https://phabricator.kde.org/D28081 AFFECTED FILES

D28081: Populate Greeter process exit stderr

romangg added inline comments. INLINE COMMENTS > zzag wrote in ksldapp.cpp:256 > Shouldn't it be in an else branch? Yes, thanks! REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D28081 To: romangg, #plasma Cc: zzag, plasma-devel, Orage, LeGast00n,

D28081: Populate Greeter process exit stderr

romangg created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Give more info in debug output when and how the Greeter porcess exited and what counter-measures are triggered to unregular

D27675: feat: avoid duplicated text when assembling user-facing output names

romangg requested changes to this revision. romangg added a comment. This revision now requires changes to proceed. Ok, I see the issue. The question is if `Vendor Model` is not a bit stupid as a name for an output and if KWin/KWayland should not be a bit more intelligent about choosing a

D27677: feat: fix build after EDID changes in libkscreen

romangg added a comment. Is this now a bug fix or a feature? I would call it a refactor since there is no regression or prior bug and neither does it add a new feature. The feature was added in libkscreen. And please don't say `refactor: fix...` How about `refactor: incorporate prior

D10042: feat: parse EDID on the backend side

romangg added a comment. The idea to parse on the backend side is sound. Can you paste the output you get in a Wayland session? For me it shows the XWayland EDID of the outputs. INLINE COMMENTS > waylandbackend.cpp:81 > +auto device = output->outputDevice(); > +auto edid = new

D26945: fix(plasmoid): add smallSpacing to leftMargin

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Depends on if you use in the end arc. Then it's given by the Phab diff title. I changed it some more. See

D27675: feat: avoid duplicated text when assembling user-facing output names

romangg added a reviewer: romangg. romangg added a comment. I am currently working on some projects. But if you don't hear till Sunday from me about this, ping me. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D27675 To: dvratil, #plasma, romangg Cc: romangg,

D27674: feat(kcm): show resolution aspect ratio

romangg added a comment. Do you have an example? Name the product. I know it should be easy technically, but my question is if it makes sense. A mode is a combination of resolution and refresh rate. So I could imagine there are products that prefer higher refresh rate over resolution.

D27674: feat(kcm): show resolution aspect ratio

romangg added a comment. Do you have an example in the wild where the "default resolution" should be something else than the one with highest pixel count? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D27674 To: broulik, romangg, #vdg Cc: apol, plasma-devel,

D27675: feat: Avoid duplicated text when assembling user-facing output names

romangg added a comment. Can you give an example? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D27675 To: dvratil, #plasma Cc: romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D27674: feat(kcm): show resolution aspect ratio

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Nice tight implementation. INLINE COMMENTS > output_model.cpp:497 > +const QString text = i18nc("Width x height (aspect ratio)", "%1x%2 > (%3:%4)", > +

D27626: refactor: fix various compiler warnings

romangg added inline comments. INLINE COMMENTS > dvratil wrote in output_model.h:90 > Because in `output_model.cpp:224` we do `m_outputs.insert(i, Output(output, > pos))`, which can make use of move semantics. > > Making move operations `noexcept` is part of Cpp Core Guidelines >

D27626: refactor: fix various compiler warnings

romangg added inline comments. INLINE COMMENTS > output_model.h:90 > {} > +Output(Output &&) noexcept = default; > Output(KScreen::OutputPtr _ptr, const QPoint &_pos) Why to add and why noexcept? REPOSITORY R104 KScreen REVISION DETAIL

D27618: fix(kwayland): wait longer for connection timeout and retry

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Thanks. This m_isValid variable was really uselsess. ;) REPOSITORY R110 KScreen Library BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D27618 To: dvratil,

D27537: Fix simpleWrite test in kwaylandbackendtest

romangg added a comment. Thanks, but the commit message in wrong as the type must be `test` since this is a fix to an autotest. And the scope `autotest` does not exist. See https://cgit.kde.org/libkscreen.git/tree/CONTRIBUTING.md Also the header is not very expressive. A "fix" can be

D27537: Fix simpleWrite test in kwaylandbackendtest

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Please follow commit message guideline. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D27537 To: dvratil, #plasma, romangg Cc:

D27536: fix(kwayland): remove code with side-effects from Q_ASSERT

romangg added a comment. It would be nice if I get at least 24 hours to review patches in KScreen/libkscreen. Thanks for the patch. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D27536 To: dvratil, #plasma, davidedmundson, meven Cc: romangg, meven,

D27383: fix: reset doctor output color before exiting

This revision was automatically updated to reflect the committed changes. Closed by commit R110:274d94ed6453: fix: reset doctor output color before exiting (authored by z3ntu, committed by romangg). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE

D27383: fix: reset doctor output color before exiting

romangg added a comment. Yea, but sadly I have already committed it: https://cgit.kde.org/libkscreen.git/commit/?id=274d94ed645387b29386daa077b2cb6a3dafbeff So Luca, you need to write an additional one. ;) REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL

D27383: fix: reset doctor output color before exiting

romangg added a comment. True, thanks anyway. You can ask for commit rights by https://community.kde.org/Infrastructure/Get_a_Developer_Account REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D27383 To: z3ntu, davidedmundson Cc: romangg,

D27383: fix: reset doctor output color before exiting

romangg added a comment. Do you have commit rights? Otherwise I need your name and email for author information. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D27383 To: z3ntu, davidedmundson Cc: romangg, plasma-devel, Orage, LeGast00n,

D27383: kscreen-doctor: reset color before exiting

romangg added a comment. In D27383#611101 , @z3ntu wrote: > Of the four scopes (api, kwayland, qscreen & randr) I have no idea where to put this in. If you have a suggestion, I can update the commit message. Scopes are only optional.

D27383: kscreen-doctor: reset color before exiting

romangg added a comment. Please respect the Commit Message Guideline when pushing the change: https://cgit.kde.org/libkscreen.git/tree/CONTRIBUTING.md#n22 REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D27383 To: z3ntu, davidedmundson Cc:

D26658: fix(kwayland): move blocking tablet init before timer start

This revision was automatically updated to reflect the committed changes. Closed by commit R110:13b631eabb98: fix(kwayland): move blocking tablet init before timer start (authored by romangg). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE

D26681: [TabBox] Thumbnail Grid window switcher

romangg accepted this revision. romangg added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > Zren wrote in main.qml:183 > Uhg, I was using `width: parent.height` and `height: parent.height` but > changed it when cleaning it up. I must've not staged all the

D26658: WIP: fix(kwayland): stall tablet config change

romangg updated this revision to Diff 73630. romangg added a comment. - Init tablet before starting KWayland timer Further analysis showed that the issue is that for some reason the d-bus call to tablet mode properties is blocking for over one second. That in return leads to the

D26037: feat(kded): add orientation sensor

This revision was automatically updated to reflect the committed changes. Closed by commit R104:8032881459d1: feat(kded): add orientation sensor (authored by romangg). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26037?vs=73185=73619 REVISION DETAIL

D26038: feat(kcm): add option for auto rotation

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:039337cd3b1a: feat(kcm): add option for auto rotation (authored by romangg). Herald added a project: Plasma. Herald

D26681: [TabBox] Thumbnail Grid window switcher

romangg requested changes to this revision. romangg added a reviewer: Plasma. romangg added a comment. This revision now requires changes to proceed. Nice. Let's fix these few issues and get it merged before tomorrow. Other small issues can be fixed in beta phase. INLINE COMMENTS >

D26658: WIP: fix(kwayland): stall tablet config change

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY It seems only checking on no outputs initializing and signals being unblocked is not enough

D26037: feat(kded): add orientation sensor

romangg updated this revision to Diff 73185. romangg added a comment. - Fix seg fault on orientation sensor REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26037?vs=73148=73185 BRANCH orientation-sensor REVISION DETAIL

D26037: feat(kded): add orientation sensor

romangg updated this revision to Diff 73148. romangg marked 2 inline comments as done. romangg added a comment. - Use connectedToBackend getter - Replace DeviceOrientation REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26037?vs=73146=73148 BRANCH

D26037: feat(kded): add orientation sensor

romangg updated this revision to Diff 73146. romangg added a comment. Rebase on master. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26037?vs=72352=73146 BRANCH orientation-sensor REVISION DETAIL https://phabricator.kde.org/D26037 AFFECTED FILES

D26037: feat(kded): add orientation sensor

romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in orientation_sensor.cpp:29 > From what I can tell, we can call > > if (!sensor->connectToBackend()) { > m_available = false; > } > > in the constructor > > and then we have the option to call start/stop whenever. Yea, I

D26310: feat: use Control and logical size APIs for replicas

romangg added a comment. I missed to update the test plan. So for reference: this is at it landed unrelated to Wayland and instead altering the behavior on X11. This should make the saving and loading of replications there more robust. REPOSITORY R104 KScreen REVISION DETAIL

D26481: feat(kcm): control scale

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:a5c4e9906322: feat(kcm): control scale (authored by romangg). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D26281: feat: add auto rotate and tablet mode information

This revision was automatically updated to reflect the committed changes. Closed by commit R110:50969ab6cbb7: feat: add auto rotate and tablet mode information (authored by romangg). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26281?vs=72351=72981

  1   2   3   4   5   6   7   8   9   10   >