Re: Review Request 113139: Try to export include targets for Plasma as well

2013-10-07 Thread Stephen Kelly
/plasma/CMakeLists.txt http://git.reviewboard.kde.org/r/113139/#comment30269 The if-else shouldn't be needed. INSTALL_INTERFACE should already check if ${INCLUDE_INSTALL_DIR} is absolute. - Stephen Kelly On Oct. 7, 2013, 8:13 a.m., Ben Cooksley wrote

Re: Review Request 113139: Try to export include targets for Plasma as well

2013-10-07 Thread Stephen Kelly
as it seems camelcase headers are installed by KF5::plasma into include/KDE/Plasma/ Odd. I tried to add this dir, but seem to have hit a bug I'll look into. Patch looks good for now I think, thanks! - Stephen Kelly On Oct. 7, 2013, 8:13 a.m., Ben Cooksley wrote

Re: Review Request 113139: Try to export include targets for Plasma as well

2013-10-07 Thread Stephen Kelly
On Oct. 7, 2013, 9:35 a.m., Stephen Kelly wrote: src/plasma/CMakeLists.txt, line 173 http://git.reviewboard.kde.org/r/113139/diff/1/?file=199605#file199605line173 The if-else shouldn't be needed. INSTALL_INTERFACE should already check if ${INCLUDE_INSTALL_DIR} is absolute. Ben

Re: Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

2013-09-25 Thread Stephen Kelly
Sebastian Kügler wrote: CMake-gods, can you confirm the below? (It's inconsistent with my understanding, and how we've done it in the past months, I'd like to have a specialist opinion before going around and changing every single CMakeLists.txt in Plasma.) Running git log -S

Re: repository changes for plasma2/frameworks5

2013-01-28 Thread Stephen Kelly
Marco Martin wrote: Most important, what is the less messy git way to do it? As we discussed on IRC, it may be better to split plasma out into its own repo now already, like we did with nepomuk. As the frameworks branch has a 'use-by' date, I'd prefer not to import more things into it from

Re: Workflow Idea for 4.10

2012-03-17 Thread Stephen Kelly
Alexander Neundorf wrote: On Friday 16 March 2012, Kevin Ottens wrote: Hello, On Wednesday 14 March 2012 14:38:19 Aaron J. Seigo wrote: [...] this is what really piques my interest: merge based workflow. an integration branch would be fantastic. that branch should rebase

Plasma does not build without kdepimlibs

2011-09-14 Thread Stephen Kelly
Hi, 9edc8d34b3b0f9983f0eb014f8fbf4bcfcffc3f1 introduced a dependency in plasma on kdepimlibs for gpgme++. The cmake check in kdelibs for kdepimlibs claims it is optional, but the build fails later. The stuff that uses gpgme++ should be compiled conditionally based on whether kdepimlibs was

Re: QtQuick 2.0?

2011-05-04 Thread Stephen Kelly
FYI QtQuick 2 will not be compatible with QtQuick 1.x. Something to keep in mind, that there may be a migration step. context: http://thread.gmane.org/gmane.comp.lib.qt.qml/2499 Alan Alpert wrote: On Wed, 4 May 2011 03:39:22 ext Jason H wrote: I thought with modularization, that what is in

Re: QtQuick 2.0?

2011-05-04 Thread Stephen Kelly
FYI QtQuick 2 will not be compatible with QtQuick 1.x. Something to keep in mind, that there may be a migration step. context: http://thread.gmane.org/gmane.comp.lib.qt.qml/2499 Alan Alpert wrote: On Wed, 4 May 2011 03:39:22 ext Jason H wrote: I thought with modularization, that what is in

Re: Review Request: Notes widget: Working bold/italic/underline/strike out even when the note text is empty

2010-11-30 Thread Stephen Kelly
, visit: http://svn.reviewboard.kde.org/r/6005/ --- (Updated 2010-11-28 20:23:45) Review request for Plasma and Stephen Kelly. Summary --- Text format of the note can't be changed while the note is empty, so I add a space

Re: Review Request: Notes widget: Working bold/italic/underline/strike out even when the note text is empty

2010-11-30 Thread Stephen Kelly
to the bug report on the qt bug tracker. Stephen Kelly wrote: Just for clarity, I think it's similar to the bug I filed with Qt before, but maybe not the same. I think you should file a new Qt bug and link to that. Anne-Marie Mahfouf wrote: Stephen did you investigate further

Re: Review Request: Notes widget: Working bold/italic/underline/strike out even when the note text is empty

2010-11-29 Thread Stephen Kelly
: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6005/ --- (Updated 2010-11-28 20:23:45) Review request for Plasma and Stephen Kelly. Summary

Re: How to get Akonadi notes onto Plasma?

2009-11-02 Thread Stephen Kelly
Aaron J. Seigo wrote: On October 30, 2009, Stephen Kelly wrote: would prefer to only show the actual notes in the stack on click so they could be dragged elsewhere. Obviously the background svg of it should not be as it is, or the size it currently is. Additionally I need to give some

Re: How to get Akonadi notes onto Plasma?

2009-11-02 Thread Stephen Kelly
Marco Martin wrote: On Monday 02 November 2009, Stephen Kelly wrote: Aaron J. Seigo wrote: On October 30, 2009, Stephen Kelly wrote: would prefer to only show the actual notes in the stack on click so they could be dragged elsewhere. Obviously the background svg of it should

Re: How to get Akonadi notes onto Plasma?

2009-11-02 Thread Stephen Kelly
Sebastian Kügler wrote: On Monday 02 November 2009 15:08:31 Stephen Kelly wrote: Marco Martin wrote: Yeah, that sounds pretty good. This is the kind of thing I meant when I wrote about a master applet with satellites applets, which Aaron wrote would fail in some situations. I'm not certain

Re: How to get Akonadi notes onto Plasma?

2009-10-30 Thread Stephen Kelly
Stephen Kelly wrote: i think in this case, maybe start with the intended user experience. i'm not sure what you are actually envisioning for the user experience. e.g.: should notes appear automatically on your desktop / panel when they appear in Akonadi, so if i add a note in Kontact

Re: How to get Akonadi notes onto Plasma?

2009-10-23 Thread Stephen Kelly
Hi, busy day. Aaron J. Seigo wrote: On October 22, 2009, Stephen Kelly wrote: In Akonadi I just create an EntityTreeModel which has api for all of that stuff. If I can forward those calls to plasma somehow, that would be good, but I need a starting point. Do I create my model in a Applet

How to get Akonadi notes onto Plasma?

2009-10-22 Thread Stephen Kelly
Hi, I'm trying to get notes from Akonadi onto a plasma workspace. I've been reading some of the apidocs and I can't figure out if I need a data engine, whether I need one Plasma::Applet per note, whether I need a 'manager' plasmoid that manages all others, keeping them up to date, and

Re: 4.2: the binary compatible release

2008-10-21 Thread Stephen Kelly
Aaron J. Seigo wrote: for those wondering what binary compat means for us, in a nutshell: * we can't add new members to the public classes (the dptr makes that unecessary in the first place, of course =) Are you sure about this one? Techbase says you can:

Re: 4.2: the binary compatible release

2008-10-21 Thread Stephen Kelly
Aaron J. Seigo wrote: yes, functions or methods. not data members (which i usually shortcut to just members, versus methods ... probably what caused confusion; sorry.) You're right. I read methods instead of members. Sorry for the noise. Steve.

KJots on Plasma

2008-09-25 Thread Stephen Kelly
Hi, One of the things I wanted to do in the KDE 4.2 timeframe for KJots was to make a plasmoid for it. As time is running fast, I'm going to cheat and ask people who are already familiar with plasma for help on how it could work. For those who have never seen/used KJots, it is a simple note

Re: KJots on Plasma

2008-09-25 Thread Stephen Kelly
Aaron J. Seigo wrote: On Thursday 25 September 2008, Stephen Kelly wrote: The idea would be that the plasmoid would display either all of your kjots notes, or only a particular kjots book, or notes tagged with a particular cool! (i actually maintined kjots in kde3 and gave it its current