from:"TOM Harrison"

Re: Review Request 118180: slideshow BUG patch fix

2014-08-20 Thread TOM Harrison

: https://git.reviewboard.kde.org/r/118180/diff/ Testing --- Thanks, TOM Harrison ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison

://git.reviewboard.kde.org/r/118180/diff/ Testing --- Thanks, TOM Harrison ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison

/ Testing --- Thanks, TOM Harrison ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison

(updated) --- I will fix it soon. something wrong with the patch. Thanks, TOM Harrison ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison

(updated) --- Thanks, TOM Harrison ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison

://git.reviewboard.kde.org/r/118180/diff/ Testing --- Thanks, TOM Harrison ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison

/ Testing --- Thanks, TOM Harrison ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison

the diff are always error. I have upload successfully with the newest fixed patch - TOM Harrison On July 29, 2014, 3:24 p.m., TOM Harrison wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 118180: slideshow BUG patch fix

2014-07-21 Thread TOM Harrison

On 六月 5, 2014, 10:12 a.m., Christoph Feck wrote: Please add Plasma developers to the group of reviewers. Btw, you cannot give Ship It to yourself, others have to approve it. TOM Harrison wrote: that just a wrong click :) TOM Harrison wrote: thanks for reminding

Re: Review Request 118180: slideshow BUG patch fix

2014-07-21 Thread TOM Harrison

--- On 六月 5, 2014, 10:32 a.m., TOM Harrison wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180

Re: Review Request 118180: slideshow BUG patch fix

2014-07-21 Thread TOM Harrison

On 七月 21, 2014, 12:39 p.m., Martin Gräßlin wrote: TOM Harrison wrote: what kind of issue? tab and space different ? Sebastian Kügler wrote: Yes, don't use tabs at all for code indentation, use 4 spaces. It should look consistent with the surrounding code after that. OK, I