D25670: Synchronize decorations buttons order in GTK headerbars

trmdi added a comment. Excuse me, could you have a look to see if this bug relates to this patch or not? https://www.reddit.com/r/kde/comments/imnpny/firefox_global_menu_patch_removes_the_headerbar/ REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

D29466: [applets/appmenu] Add search to global application menu

trmdi added a comment. Can this be moved to krunner? In that case it can be used even when the user doesn't use global menu? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29466 To: cblack, #plasma, #vdg Cc: trmdi, nicolasfella, gikari, plasma-devel,

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

trmdi added a comment. Just a question, SierraBreezeEnhanced has a feature called "Unison hovering". Does this support it? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28623 To: gikari, #breeze, #plasma, cblack Cc: trmdi, ngraham, plasma-devel,

D29395: Refactor MediaController

trmdi added a comment. In D29395#662576 , @ngraham wrote: > Now the inner image has a greater top margin than bottom margin. Also, could the artist and album be allowed to become two-line strings before eliding, maybe? F8282138:

D29260: Clean up desktop config window size code and set a better default size

trmdi added a comment. In D29260#659172 , @ngraham wrote: > `GridUnit * 40` works out to be 720 px high with the default 10pt Noto Sans font, which is enough space to not interfere with the default 36px bottom panel. > > But there's no way

D29260: Clean up desktop config window size code and set a better default size

trmdi added a comment. Please keep in mind that not everyone uses a high res screen. 1366x768 is a very popular one, please don't make it too big on those screens. :( REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29260 To: ngraham, #vdg, #plasma Cc: trmdi,

D28985: [Kickoff] Disable tabBar's mouseArea when searching

trmdi added a comment. In D28985#652097 , @ngraham wrote: > Excellent! > > Please land on the `Plasma/5.18` branch and then merge to master. Let me know if you need a hand with that. Yes, please. I don't know how to do that.

D28985: [Kickoff] Disable tabBar's mouseArea when searching

trmdi created this revision. trmdi added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY When the root is in the "Search" state, we can safely disable it. BUG: 420282 REPOSITORY

D27998: [KCMs/Workspace] Add option for dndToMove

trmdi updated this revision to Diff 77644. trmdi added a comment. Nate's comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27998?vs=77643=77644 BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.kde.org/D27998

D27998: [KCMs/Workspace] Add option for dndToMove

trmdi added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:204 > I would make this label non-visible when `dndToMoveEnabler.checked` is false, > rather than changing its text. If there is a new stuff below this, when you make it visible, the below stuff will jump up. REPOSITORY

D27998: [KCMs/Workspace] Add option for dndToMove

trmdi added a comment. In D27998#627623 , @ngraham wrote: > Where? Being wrong in multiple places doesn't make it right. ;) On the left panel. REPOSITORY R119 Plasma Desktop BRANCH add-dndToMove (branched from master) REVISION

D27998: [KCMs/Workspace] Add option for dndToMove

trmdi updated this revision to Diff 77643. trmdi added a comment. Nate's comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27998?vs=77509=77643 BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.kde.org/D27998

D27998: [KCMs/Workspace] Add option for dndToMove

trmdi added a comment. In D27998#627605 , @ngraham wrote: > Right. > > @bugseforuns's objection is that you used the word "device" to mean "partition" in the UI. Both Dolphin and Qt use this word. REPOSITORY R119 Plasma Desktop

D27998: [KCMs/Workspace] Add option for dndToMove

trmdi added a comment. In D27998#627603 , @ngraham wrote: > What does? dnd from /dev/sda1 -> /dev/sda1 : move dnd from /dev/sda1 -> /dev/sda2 : show menu REPOSITORY R119 Plasma Desktop BRANCH add-dndToMove (branched from master)

D27998: [KCMs/Workspace] Add option for dndToMove

trmdi added a comment. Yes, it means "partition". REPOSITORY R119 Plasma Desktop BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.kde.org/D27998 To: trmdi, #vdg, #plasma, ngraham Cc: bugseforuns, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27998: Add workspace kcm option for dndToMove

trmdi added inline comments. INLINE COMMENTS > meven wrote in main.qml:150 > You can nowadays write `!kcm.globalsSettings.isDndToMoveImmutable` > That was added recently. D26368 Thanks, but maybe this need another patch. :) REPOSITORY R119 Plasma Desktop

D27998: Add workspace kcm option for dndToMove

trmdi updated this revision to Diff 77509. trmdi added a comment. Move to bottom, add hint REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27998?vs=77478=77509 BRANCH add-dndToMove (branched from master) REVISION DETAIL

D27998: Add workspace kcm option for dndToMove

trmdi created this revision. trmdi added reviewers: VDG, Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Add gui for the new `dndToMove` option. Depend: D27951

D27458: Set a better position for Krunner in wayland

trmdi closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27458 To: trmdi, #plasma, davidedmundson Cc: meven, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D27458: Set a better position for Krunner in wayland

trmdi updated this revision to Diff 76629. trmdi added a comment. Rename m_realVisible to m_requestedVisible REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27458?vs=76597=76629 BRANCH arcpatch-D27458 (branched from master) REVISION DETAIL

D27458: Set a better position for Krunner in wayland

trmdi updated this revision to Diff 76597. trmdi added a comment. Small fix. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27458?vs=76596=76597 BRANCH arcpatch-D27458 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27458

D27458: Set a better position for Krunner in wayland

trmdi updated this revision to Diff 76596. trmdi added a comment. Never show before position is set REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27458?vs=75883=76596 BRANCH arcpatch-D27458 (branched from master) REVISION DETAIL

D27458: Set a better position for Krunner in wayland

trmdi added a comment. In D27458#618437 , @davidedmundson wrote: > Idea is nice. > > > Does this not jitter on first load? Starting off in 0,0 then moving across? > We now have position async() but we're doing that after we've

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

trmdi added a comment. In D27329#611907 , @mvourlakos wrote: > In D27329#611906 , @trmdi wrote: > > > How about this? > > F8104781: image.png > > >

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

trmdi updated this revision to Diff 75959. trmdi added a comment. - Increase the height a bit more, the last effort. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27329?vs=75486=75959 BRANCH adjust-size-of-tooltip (branched from master)

D27458: Set a better position for Krunner in wayland

trmdi updated this revision to Diff 75883. trmdi added a comment. Improve code style REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27458?vs=75879=75883 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27458 AFFECTED FILES

D27458: Set a better position for Krunner in wayland

trmdi updated this revision to Diff 75879. trmdi added a comment. Use asyncCall REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27458?vs=75828=75879 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27458 AFFECTED FILES

D27458: Set a better position for Krunner in wayland

trmdi created this revision. trmdi added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY In wayland, QScreen::availableGeometry() returns QScreen::geometry(), we could get a

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

trmdi added a comment. How about this? F8104781: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27329 To: trmdi, #vdg, #plasma, ngraham Cc: filipf, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

trmdi added a comment. Hmm, I think the 1.5 ratio makes a nice shape, the thumbnail is also not too small. A tooltip has texts and a thumbnail, we needn't too focus in the thumbnail. F8098753: image.png REPOSITORY R119 Plasma Desktop REVISION

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

trmdi added a comment. We can increase the height a bit, but not sure which ratio is the best. Another thing is that, even with a bigger thumbnail, we could hardly see its content, so making it bigger doesn't make it more clear. In D27329#609831

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

trmdi updated this revision to Diff 75486. trmdi added a comment. - Increase the height a bit REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27329?vs=75484=75486 BRANCH adjust-size-of-tooltip (branched from master) REVISION DETAIL

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

trmdi created this revision. trmdi added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. TEST PLAN The size of tooltips are not changed between cases e.g. a normal window vs a window which is available

D27149: Scroll the truncated song/artist text when long hovering over it

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c8a7a3bd98a8: Scroll the truncated song/artist text when long hovering over it (authored by trmdi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27149: Scroll the truncated song/artist text when long hovering over it

trmdi updated this revision to Diff 75321. trmdi added a comment. - Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27149?vs=75287=75321 BRANCH add-tooltip-textWrapper (branched from master) REVISION DETAIL

D27262: Reduce blank space inside tooltip's header

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5be0b548b6ed: Reduce blank space inside tooltips header (authored by trmdi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27262?vs=75288=75320 REVISION

D27262: Reduce blank space inside tooltip's header

trmdi added a subscriber: ngraham. trmdi added a comment. Do you have any objection @ngraham ? REPOSITORY R119 Plasma Desktop BRANCH reduce-tooltip-blank-space (branched from master) REVISION DETAIL https://phabricator.kde.org/D27262 To: trmdi, #plasma, #vdg, ndavis Cc: ngraham,

D27262: Reduce blank space inside header

trmdi created this revision. trmdi added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Make the tooltip as compact as possible. This is also consistent with texts inside

D27149: Scroll the truncated song/artist text when long hovering over it

trmdi updated this revision to Diff 75287. trmdi added a comment. - Remove the redundant line REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27149?vs=75286=75287 BRANCH add-tooltip-textWrapper (branched from master) REVISION DETAIL

D27149: Scroll the truncated song/artist text when long hovering over it

trmdi updated this revision to Diff 75286. trmdi added a comment. - Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27149?vs=75026=75286 BRANCH add-tooltip-textWrapper (branched from master) REVISION DETAIL

D27219: Center placeholder texts in system tray popups

trmdi added a comment. Could you post screenshots of a same tab? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27219 To: ngraham, #vdg, #plasma Cc: trmdi, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27182: [applets/taskmanager] Clean up Tooltip code

trmdi added inline comments. INLINE COMMENTS > ngraham wrote in ToolTipInstance.qml:100 > Depends on the font; you can't necessarily count on that. Heading has `lineHeight: 1.2`, so there are 2 things for padding here right? Could we remove one? REPOSITORY R119 Plasma Desktop BRANCH

D27182: [applets/taskmanager] Clean up Tooltip code

trmdi added a comment. It's super big on my 1366x768 screen: Before: F8090526: image.png After: F8090521: image.png And the Before and After size are not the same. REPOSITORY R119 Plasma Desktop

D27149: Scroll the truncated song/artist text when long hovering over it

trmdi added a comment. Any other objection? REPOSITORY R119 Plasma Desktop BRANCH add-tooltip-textWrapper (branched from master) REVISION DETAIL https://phabricator.kde.org/D27149 To: trmdi, #plasma, #vdg, ndavis Cc: broulik, cblack, ndavis, plasma-devel, Orage, LeGast00n,

D27182: [applets/taskmanager] Clean up Tooltip code

trmdi added inline comments. INLINE COMMENTS > ngraham wrote in ToolTipInstance.qml:79 > If we do that, then the size of the preview/album art area can get very > short, which I don't think is desirable. I think it still looks acceptable, not tool short. This is the worst case: F8088588:

D27182: [applets/taskmanager] Clean up Tooltip code

trmdi added inline comments. INLINE COMMENTS > ToolTipInstance.qml:100 > +ColumnLayout { > +spacing: units.smallSpacing > + Could it be zero here? Because `Text` lines already has its own padding, isn't it? > ngraham wrote in ToolTipInstance.qml:79 > If we do that, then

D27182: [applets/taskmanager] Clean up Tooltip code

trmdi added inline comments. INLINE COMMENTS > ToolTipInstance.qml:79 > +// This number controls the overall size of the window tooltips > +Layout.maximumWidth: units.gridUnit * 17 > +Layout.minimumWidth: isWin ? Layout.maximumWidth : 0 How do you choose the number 17?

D27182: [applets/taskmanager] Clean up Tooltip code

trmdi added inline comments. INLINE COMMENTS > ToolTipInstance.qml:39 > > -spacing: units.smallSpacing > - Why do you remove all `spacing`? This increases lots of wasted space which is not good at least on small screens like 1366x768. > ToolTipInstance.qml:79 > +// This number

D27149: Scroll the truncated song/artist text when long hovering over it

trmdi updated this revision to Diff 75026. trmdi added a comment. - Address broulik's comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27149?vs=74981=75026 BRANCH add-tooltip-textWrapper (branched from master) REVISION DETAIL

D27149: Scroll the truncated song/artist text when long hovering over it

trmdi updated this revision to Diff 74981. trmdi added a comment. - Add license REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27149?vs=74972=74981 BRANCH add-tooltip-textWrapper (branched from master) REVISION DETAIL

D26514: Delay popup when dropping things into containments

This revision was automatically updated to reflect the committed changes. Closed by commit R119:36e918b09780: Delay popup when dropping things into containments (authored by trmdi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26514?vs=74264=74978

D27149: Scroll the truncated song/artist text when long hovering over it

trmdi created this revision. trmdi added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY - When the text is truncated, we could hover over it to read the full text TEST PLAN Everything

D26739: [applets/Task Manager] Refine tooltip highlight effect

trmdi added a comment. In D26739#602951 , @ngraham wrote: > Argh, now I can see it too: F8008546: weird margin.webm > > No idea what's causing this. The code seems conceptually right to me. Maybe

D27016: Update from Plasma's ToolTip

trmdi created this revision. trmdi added a reviewer: Latte Dock. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Add highlight effect when hovering over the tooltip's thumbnail REPOSITORY R878 Latte Dock

D26739: [applets/Task Manager] Refine tooltip highlight effect

trmdi added a comment. In D26739#602082 , @filipf wrote: > ^ I can't reproduce that, the patch works as intended for me. (we should investigate this though) > > One thing to just comment is that this is tailor-made for Breeze (the 1px

D26739: [applets/Task Manager] Refine tooltip highlight effect

trmdi added a comment. In D26739#601921 , @ngraham wrote: > In D26739#601762 , @trmdi wrote: > > > Not yet looked at the code carefully, but I feel the top margin and the bottom one of the thumbnail

D26739: [applets/Task Manager] Refine tooltip highlight effect

trmdi added a comment. Not yet looked at the code carefully, but I feel the top margin and the bottom one of the thumbnail are not identical. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26739 To: ngraham, #plasma, #vdg, filipf, ndavis Cc: trmdi, filipf,

D26739: [applets/Task Manager] Refine tooltip highlight effect

trmdi added a comment. In D26739#601666 , @ndavis wrote: > Actually, I just noticed a problem. When you hover over the bar, the thumbnail area gets highlighted, bit if you click on the bar, it doesn't bring the window to the front. Yes,

D26739: [applets/Task Manager] Refine tooltip highlight effect

trmdi added a comment. What happens when you hover the mouse on the control bar? Did you address it? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26739 To: ngraham, #plasma, #vdg, filipf, ndavis Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n,

D26760: Update from Plasma for ToolTipInstance.qml

This revision was automatically updated to reflect the committed changes. Closed by commit R878:77c170c8f7cb: Update from Plasma for ToolTipInstance.qml (authored by trmdi). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26760?vs=74260=74296 REVISION

D26760: Update from Plasma for ToolTipInstance.qml

trmdi added a comment. Thanks, but I want to wait for this patch: https://phabricator.kde.org/D26739 to be committed, then I will add it to this patch. It looks pretty nice. :) REPOSITORY R878 Latte Dock BRANCH update-ToolTipInstance-fromPlasma (branched from master) REVISION DETAIL

D26720: Cache single image wallpapers locally

trmdi added inline comments. INLINE COMMENTS > trmdi wrote in image.cpp:503 > `QDir::mkpath` is better: https://doc.qt.io/qt-5/qdir.html#mkpath Sorry, I meant QDir::mkpath is needed for KIO::CopyJob, not here, otherwise CopyJob will fail when the destination directory does not exist.

D26739: [applets/Task Manager] Refine tooltip highlight effect

trmdi added a comment. Pretty nice. But clicking on `playerControlsRow` (exclude buttons) does not behave the same way like clicking on the cover art, while the effect would make users think that they can click on the control row to open the window. REPOSITORY R119 Plasma Desktop

D26514: Delay popup for containments

trmdi updated this revision to Diff 74264. trmdi added a dependency: D26484: Add KIO::DropJobFlag to allow manually showing the menu. trmdi added a comment. - Show drop menu manually when dropping things into the desktop REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26760: Update from Plasma for ToolTipInstance.qml

trmdi added a comment. In D26760#599227 , @mvourlakos wrote: > @trmdi have you checked the previews still work OK after the patch? Yes, I tested it. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D26760 To:

D26760: Update from Plasma for ToolTipInstance.qml

trmdi updated this revision to Diff 74260. trmdi added a comment. - Address comment REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26760?vs=73935=74260 BRANCH update-ToolTipInstance-fromPlasma (branched from master) REVISION DETAIL

D26739: [applets/Task Manager] Refine tooltip highlight effect

trmdi added a comment. How about this? F7894214: vokoscreen-2020-01-20_23-10-29.mp4 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26739 To: ngraham, #plasma, #vdg, filipf Cc: trmdi, filipf, ndavis, plasma-devel,

D26739: [applets/Task Manager] Refine tooltip highlight effect

trmdi added a comment. Could you clarify before/after screenshots? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26739 To: ngraham, #plasma, #vdg, filipf Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26720: Cache single image wallpapers locally

trmdi added inline comments. INLINE COMMENTS > image.cpp:503 > +// check the cache > +} else if (QFile::exists(m_cachedWallpaperPath)) { > +m_wallpaperPath = m_cachedWallpaperPath; `QDir::mkpath` is better: https://doc.qt.io/qt-5/qdir.html#mkpath REPOSITORY R120

D26760: Update from Plasma for ToolTipInstance.qml

trmdi added inline comments. INLINE COMMENTS > ToolTipInstance.qml:175 > // round necessary, otherwise shadow mask for players has gap! > -height: Math.round(0.5 * width) + (!winTitle.visible? > winTitle.height : 0) > +height: Math.round(0.5 * width) +

D26760: Update from Plasma for ToolTipInstance.qml

trmdi updated this revision to Diff 73935. trmdi added a comment. - hasPlayer-tooltips shouldn't disappear when the mouse is inside the bottom margin of the tooltip REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26760?vs=73876=73935 BRANCH

D26760: Update from Plasma for ToolTipInstance.qml

trmdi updated this revision to Diff 73876. trmdi added a comment. - Add https://phabricator.kde.org/D11025 REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26760?vs=73861=73876 BRANCH update-ToolTipInstance-fromPlasma REVISION DETAIL

D26760: Update from Plasma for ToolTipInstance.qml

trmdi added a comment. In D26760#596760 , @mvourlakos wrote: > Is there any improvement, or it is just a code update? Some minor improvements: - https://phabricator.kde.org/D22230 - https://phabricator.kde.org/D21629 REPOSITORY

D26760: Update from Plasma

trmdi created this revision. trmdi added a reviewer: Latte Dock. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Just pull the update from Plasma REPOSITORY R878 Latte Dock BRANCH

D26525: Fix wallpaper destination path

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2212a9af156b: Fix wallpaper destination path (authored by trmdi). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26525?vs=73217=73640#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE

D26525: Fix wallpaper destination path

trmdi added a comment. Ping. Could I land this now? REPOSITORY R120 Plasma Workspace BRANCH fix-wallpaper (branched from master) REVISION DETAIL https://phabricator.kde.org/D26525 To: trmdi, #plasma, mart, ngraham Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26525: Fix wallpaper destination path

trmdi added a comment. @mart Are you ok with this now ? REPOSITORY R120 Plasma Workspace BRANCH fix-wallpaper (branched from master) REVISION DETAIL https://phabricator.kde.org/D26525 To: trmdi, #plasma, mart Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26525: Fix wallpaper destination path

trmdi updated this revision to Diff 73217. trmdi added a comment. - Switch from FileCopyJob to CopyJob to allow showing file overwrite dialog REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26525?vs=73115=73217 BRANCH fix-wallpaper (branched

D26525: Fix wallpaper destination path

trmdi added inline comments. INLINE COMMENTS > mart wrote in image.cpp:555 > I would prefer it to ask before owerwriting Do I need to modify this or just land it now? REPOSITORY R120 Plasma Workspace BRANCH fix-wallpaper REVISION DETAIL https://phabricator.kde.org/D26525 To: trmdi,

D26525: Fix wallpaper destination path

trmdi added inline comments. INLINE COMMENTS > mart wrote in image.cpp:554 > this is for first run when ~/.local/share/wallpapers isn't there yet? This is to check if the directory is available before copying, otherwise FileCopyJob would fail. REPOSITORY R120 Plasma Workspace REVISION

D26525: Fix wallpaper destination path

trmdi updated this revision to Diff 73115. trmdi added a comment. - Improve code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26525?vs=73070=73115 BRANCH fix-wallpaper REVISION DETAIL https://phabricator.kde.org/D26525 AFFECTED FILES

D26514: Delay popup for containments

trmdi updated this revision to Diff 73081. trmdi added a comment. - Sync with the dependency REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26514?vs=73080=73081 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26514 AFFECTED FILES

D26514: Delay popup for containments

trmdi updated this revision to Diff 73080. trmdi added a comment. - Sync with the dependency REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26514?vs=73029=73080 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26514 AFFECTED FILES

D26525: Fix wallpaper destination path

trmdi created this revision. trmdi added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY - Correct the destination path when downloading images. - Add the `KIO::Overwrite` for the file copy

D26514: Delay popup for containments

trmdi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Make use of the new parameter added in D26484 BUG: 415917 TEST PLAN Drop files into

D4574: [WIP]: unify file drop menu and containment

trmdi added a comment. This patch seems to cause this bug: https://bugs.kde.org/show_bug.cgi?id=415917 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4574 To: mart, #plasma, hein Cc: trmdi, hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26298: Add license to new files

This revision was automatically updated to reflect the committed changes. Closed by commit R120:78210e2780cf: Add license to new files (authored by trmdi). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26298?vs=72407=72408 REVISION DETAIL

D26298: Add license to new files

trmdi added a comment. In D26298#584838 , @ngraham wrote: > If you wrote this whole file yourself, you only need to add your own copyright. :) I wrote it with David's help so I would want to add him here. :) REPOSITORY R120 Plasma

D26298: Add license to new files

trmdi created this revision. trmdi added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Add license to strutmanager.* REPOSITORY R120 Plasma Workspace BRANCH master REVISION

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi added a comment. Thank you so much @davidedmundson! @mvourlakos: I think you can improve Latte now. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25807 To: trmdi, #plasma, mvourlakos, davidedmundson, mart, apol Cc: davidre, plasma-devel,

D25807: Allow to set the available screen rect/region from outside through dbus

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e8e360862fb7: Allow to set the available screen rect/region from outside through dbus (authored by trmdi). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 72387. trmdi added a comment. - Drop the test method REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25807?vs=72384=72387 BRANCH add-otherShellHelper (branched from master) REVISION DETAIL

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 72384. trmdi added a comment. - Use const reference for some parameters REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25807?vs=71980=72384 BRANCH add-otherShellHelper (branched from master) REVISION DETAIL

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi added inline comments. INLINE COMMENTS > davidedmundson wrote in strutmanager.h:25 > what's this about? This is just for easily testing using the qdbus command. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25807 To: trmdi, #plasma, mvourlakos,

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi added a comment. Ping! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25807 To: trmdi, #plasma, mvourlakos, davidedmundson, mart, apol Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D26266: Change remove action's icon to "edit-delete"

trmdi abandoned this revision. trmdi added a comment. In D26266#584135 , @mvourlakos wrote: > What is ConfigOverlay for plasma panels is using at its tooltip? Ah, I was wrong. "delete" should be the right one. Sorry.

D26266: Change remove action's icon to "edit-delete"

trmdi added a comment. But I've just found that Plasma panels use QIcon::fromTheme which load the icon from the icon theme, while PlasmaComponent.ToolButton loads icon from Plasma theme, that is not consistent in some cases. What do you think? REPOSITORY R878 Latte Dock BRANCH master

D26266: Change remove action's icon to "edit-delete"

trmdi created this revision. trmdi added reviewers: Latte Dock, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Follow Plasma codes

D26238: Improve context menu

This revision was automatically updated to reflect the committed changes. Closed by commit R878:fe5dbf9f2b96: Improve context menu (authored by trmdi). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26238?vs=72253=72255 REVISION DETAIL

D26238: Improve context menu

trmdi added a comment. In D26238#583556 , @mvourlakos wrote: > In D26238#583555 , @trmdi wrote: > > > In D26238#583551 , @mvourlakos wrote: > > > > >

  1   2   3   >